From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70054.outbound.protection.outlook.com [40.107.7.54]) by dpdk.org (Postfix) with ESMTP id EB44558C4 for ; Wed, 17 Oct 2018 01:28:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d5iou5HWk8kKcrWkx+Ru2RmlwWCNe83o9aDhGwFaB3I=; b=RmIAH7sQjfYozUZKSXE7Swu4YL+FlhkL09rn0e7KvHEFvPIxkOyamhsjekWd9kNiN68M9KnP1ikNOjaCjtBQs41NiNHTBT/Tgyueg+cGAVKVKuZ5yIWNX0GegpXuxo5zvFcGH+qSO4vXGWdataLDhnJ/eIxAAmisJCUOu3Rmo0U= Received: from DB7PR08MB3674.eurprd08.prod.outlook.com (20.177.120.156) by DB7PR08MB3482.eurprd08.prod.outlook.com (20.176.238.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.24; Tue, 16 Oct 2018 23:28:53 +0000 Received: from DB7PR08MB3674.eurprd08.prod.outlook.com ([fe80::9d3a:a6af:b4e5:bda1]) by DB7PR08MB3674.eurprd08.prod.outlook.com ([fe80::9d3a:a6af:b4e5:bda1%3]) with mapi id 15.20.1228.027; Tue, 16 Oct 2018 23:28:53 +0000 From: Honnappa Nagarahalli To: "Wang, Yipeng1" , "Richardson, Bruce" , "De Lara Guarch, Pablo" CC: "dev@dpdk.org" , Dharmik Thakkar , "Gavin Hu (Arm Technology China)" , nd , "Gobriel, Sameh" Thread-Topic: [PATCH v3 4/7] hash: add memory ordering to avoid race conditions Thread-Index: AQHUYfVdN2IJTatbZUOC3+ictwyaQaUcYh5AgARCkUA= Date: Tue, 16 Oct 2018 23:28:53 +0000 Message-ID: References: <1539325918-125438-1-git-send-email-honnappa.nagarahalli@arm.com> <1539325918-125438-5-git-send-email-honnappa.nagarahalli@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR08MB3482; 6:a25B07/x7Bge0c14vSl+9XQyHxufu+h/LH2fAR5MHZ1x6JyKt46nVCPmuZLC0VDVFf5Z+t9pvQWvJGxnY7CWzkLEeFJyY+tiCH9yvVQrDS5HKF++Ddd+F+IBPUMfR+BOoqw5bKaj02DXN+eP9PiEIpZqqfwLXAX8p0fO9trRZ/E/4XZKawMYraLK5f9bVl2fzUHClL3JWoCGypJFbQeWguC1KUdh3VudVMBnKhMFDEboY4aaMAFQaiSmk10uwr8d0MLeWAi1bpGh0ytB5u/H2+01PdiZSxu4tmua5azPUaRjMOB0IThEhk+zkfEIlSoBmZKledeu7PMgvQClWiAMM0LqPskrUoXo2hxcRcPcjov8NkZ5VHH/r54xVOB0A0ADnic0VR6Oqq84HWgEk/KfF87d1oA6OjEEaYPB4p7aTUJOBkmVh4GpJyq+jbPMbxfPgWfDRLtyZhBu/baGsvbn8w==; 5:TwVX8Ap8iUDeJe0OQqwo3qYTwUacVCaOPjpAuTwlQ+pb+CvssU/cH3TLjFJYThvh1DO+DOpslqm5lIvLYHa0r1fcztvzrULDWwhxsjfrZcM/7XWf2LB7jxqvv6M34HYneeWF7fK5qpQlddOt4aznufI2j7x9LsmUlq4rvi9NqMk=; 7:TGpyomqyK6Ea5pVa+OXrGEJpGSIOg6MqHwJSJt+9hJKlq7tbiKNmkFYOIcrbpJ2s3Tr7JmjA62UyOklG4NIQczswJWDpHCEhcKx9JX0MhYyu4QuJuw8uN352yf1ImiYmFDaNwlN6YKWU1URytRKZXO3LyiyLJvRL+AUOqyB3cs2Diz3uLCVtn41NfPA9NAnw57QbGeg6I2rmis2YLWBIJki5RBStA13k629QoBQPWOl+6m0KOzX7XAGtzBoIdCo6 x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-correlation-id: 6766c0c6-b180-450e-07b9-08d633bf2302 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:DB7PR08MB3482; x-ms-traffictypediagnostic: DB7PR08MB3482: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231355)(944501410)(52105095)(6055026)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(20161123560045)(201708071742011)(7699051); SRVR:DB7PR08MB3482; BCL:0; PCL:0; RULEID:; SRVR:DB7PR08MB3482; x-forefront-prvs: 0827D7ACB9 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(376002)(396003)(39860400002)(136003)(346002)(13464003)(189003)(199004)(14454004)(4326008)(7696005)(25786009)(6246003)(76176011)(68736007)(5660300001)(7736002)(26005)(102836004)(256004)(97736004)(3846002)(5250100002)(14444005)(6116002)(86362001)(66066001)(71200400001)(71190400001)(33656002)(6506007)(53936002)(106356001)(229853002)(2906002)(9686003)(55016002)(72206003)(8936002)(446003)(81166006)(8676002)(81156014)(105586002)(11346002)(186003)(54906003)(2900100001)(110136005)(99286004)(305945005)(316002)(478600001)(476003)(6436002)(74316002)(486006); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR08MB3482; H:DB7PR08MB3674.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: ZGhPaN+mNjNNGVN9kbZLj0huivOz8BG6Y4rCowvu8YfF1gqRIh2xvgQeFthU//1GgfmzKWp2hJ+i0tGWl7PzwTGePSYLeDcLO5B0ThVwpTPmfyC3Kvh6qTQm2FszM+2Bk3FCNMDrCmscj3fESpwtnft5OtoO0GlZKgPgPG0DFvB/KEkMS174yOcSevEAJm6XKs7fgUF9z7JguOr67KyXq5AdUIw42/l+1fSI3u1QVW5rnbIMhRMPUEXZtSzLWEs/pTNfFZIK9Mnm7NU01CLu0FbKzatiFdeWrVeX+KBAeWHubXbGIvM8MVBgELjve319474jVrHtnWHiONqEA8RvvAlklchKaQCM2p7+sxaVOJg= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6766c0c6-b180-450e-07b9-08d633bf2302 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Oct 2018 23:28:53.7408 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3482 Subject: Re: [dpdk-dev] [PATCH v3 4/7] hash: add memory ordering to avoid race conditions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2018 23:28:55 -0000 > When I applied this commit: > fatal: sha1 information is lacking or useless > (lib/librte_hash/rte_cuckoo_hash.c). > Please double check. I will verify the patches when I send out the next version. >=20 > >-----Original Message----- > >From: Honnappa Nagarahalli [mailto:honnappa.nagarahalli@arm.com] > >Sent: Thursday, October 11, 2018 11:32 PM > >To: Richardson, Bruce ; De Lara Guarch, > >Pablo > >Cc: dev@dpdk.org; Wang, Yipeng1 ; > >honnappa.nagarahalli@arm.com; dharmik.thakkar@arm.com; > >gavin.hu@arm.com; nd@arm.com > >Subject: [PATCH v3 4/7] hash: add memory ordering to avoid race > >conditions > > > >Only race condition that can occur is - using the key store element > >before the key write is completed. Hence, while inserting the element > >the release memory order is used. Any other race condition is caught by > >the key comparison. Memory orderings are added only where needed. > >For ex: reads in the writer's context do not need memory ordering as > >there is a single writer. > [Wang, Yipeng] > I remember we discussed that this commit itself does not fix any bug/issu= e, or > enabling feature, it is supposed to work with the following patches to en= able > lock-free read-write concurrency. You separated the commits for easier > review. >=20 > If you plan to merge these commits and change the commit message it would > be fine. Otherwise the current message title and content Is misleading. I= t > sounds like a bug fix but actually not. I think it is time to merge this commit. I will do it in the next version.