From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E00BA2EFC for ; Thu, 19 Sep 2019 16:55:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4C2B81F0B7; Thu, 19 Sep 2019 16:55:23 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20061.outbound.protection.outlook.com [40.107.2.61]) by dpdk.org (Postfix) with ESMTP id 391721F06B; Thu, 19 Sep 2019 16:55:21 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fjf8cHWWZYHOejX6yjoR9U1eXOWhbKLPgBMouuYGfqawqP1Tq292/U8wrFlUjrJfLZgyw8xKYne5sE+TxpjdcszLJ0ka9d4nsg525pyJys+knSCXVG6zcPW5wT/L38QCBDeHFKp5JnW9AZxVNi5J3e9t1KZquPxnikC7zSKOJnOK+J1K/Qm/qqZl+QytViFDdLAUEqckbU/Xd6sX9BNz3KDoqKmEMdm/yPKeSYm5vk7IdM2XJIGYVhNpi4K5SxpBHliN1fEZzgZACOeccY8Nym3dqRoSqQdbqHa9bo0yjjGXuve9lyzwzZZfDJG9JMVH5n/gJIxah15fLQIJzShBtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s3QUPBf2WgJ0s+yPEV99MOvAVBnpQHrY6SouA+m++oM=; b=R1rl3KsBf6Bu7947zv7ok5UFjGMSj+0KjtXzWCStt3J6+KD04akOLbsONLJSIPxC/oVcA3HMW7w0vRw6vfRsfg2xwT//Yw9QbS6dkSXfZr+1zIwXl6bywVj3LHq10GomajOvmhEcpVUsl949Cc9fPLsn8aE9jej+De2iCq2qTDpm41PInoijjD3rU+CxIVITmQj5+e1hpStxc+/LaBQpmWZFb5w4gddHl1ffQcplJhBt1bGgvheQ/90U+eZretJub2UMAZa8gyVySlr4bhWVTckFy03dBHFL1teqKHfOBIns6UzzTut1rxlNmQCCd56qwoj9C+6WTghIP8xEix3LnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s3QUPBf2WgJ0s+yPEV99MOvAVBnpQHrY6SouA+m++oM=; b=IlY+dHrltXQRZSS54Hqs5NkqDdRST8eqD+xz/NLsY4rELEngjIEdPYi2K4XgBwvML166BFC2nz3K6pnxCF3MZpPvHDJY3+fLM4eZ9voe3vt8YRtt02nGHbx2IvYFZuJ/aLM18Nnm6dRa7658Fk6tRASR3tNHY8APvEZvK+NaJqo= Received: from DB8PR04MB6635.eurprd04.prod.outlook.com (20.179.251.20) by DB8PR04MB6860.eurprd04.prod.outlook.com (52.133.240.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.17; Thu, 19 Sep 2019 14:55:20 +0000 Received: from DB8PR04MB6635.eurprd04.prod.outlook.com ([fe80::5078:877a:878f:52a]) by DB8PR04MB6635.eurprd04.prod.outlook.com ([fe80::5078:877a:878f:52a%6]) with mapi id 15.20.2263.023; Thu, 19 Sep 2019 14:55:20 +0000 From: Akhil Goyal To: Akhil Goyal , Thomas Monjalon CC: "stable@dpdk.org" , Bernard Iremonger , "dev@dpdk.org" , "konstantin.ananyev@intel.com" Thread-Topic: [dpdk-stable] [PATCH] examples/ipsec-secgw: fix unchecked return value Thread-Index: AQHVTRvgA5nvrYdIUEGA1JKX4Yiki6bvsG8AgAEpeACAAcNnkIBAvOjg Date: Thu, 19 Sep 2019 14:55:20 +0000 Message-ID: References: <1565181012-19553-1-git-send-email-bernard.iremonger@intel.com> <4252912.OkXEp6FMEK@xps> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.70] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d0f52e71-ba52-4bbb-ef29-08d73d11647e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600167)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:DB8PR04MB6860; x-ms-traffictypediagnostic: DB8PR04MB6860:|DB8PR04MB6860: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 016572D96D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(396003)(136003)(376002)(39860400002)(366004)(189003)(199004)(110136005)(54906003)(81156014)(7696005)(81166006)(478600001)(305945005)(71200400001)(14454004)(71190400001)(33656002)(9686003)(6246003)(7736002)(316002)(6506007)(229853002)(6116002)(25786009)(186003)(76176011)(2906002)(55016002)(486006)(44832011)(74316002)(3846002)(26005)(102836004)(6436002)(99286004)(64756008)(5660300002)(66446008)(66556008)(66476007)(8676002)(476003)(446003)(66066001)(4744005)(8936002)(4326008)(256004)(11346002)(76116006)(66946007)(52536014)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB8PR04MB6860; H:DB8PR04MB6635.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: uMk0JuaX0rpyh9ebGaX4f0C7J4BdcyPPiGnZEX01F8PwoXNDBJIRH0poAbJSysXokUreRzsH8kStR7B45VImN2oxujdF+Q1mB8DsmHQm0UaLfzGJ2tcA5ukC4LtZmn6em8UMdycLkFlZh1v1FcIQsu6yRggbM5i0hcwhFGMIpt1oTd9sQm4I242jMA2VGXH/hPIjlyJizl/JcJUgw/yDJ9PSkhFZ8i8j6cFkdC1EyX6GLB8a/XG06cF8+brc6DnwX54Ur/wKlHi9mdMVMuyy/ZXykqMFyy9Qh4VxT/SuAllTV3IoLdC4IWsPUebMJ0qY4AqNlC39fYz6/ycp0KPvQnPPC0iGpSPEFhz4TmZl5vys0Dw278Vv0Tnh8GGWanlRZtHWhubLxrr4nRT9cCEJ0OmvZ3/Sow5c4Odpkfr+VYM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0f52e71-ba52-4bbb-ef29-08d73d11647e X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Sep 2019 14:55:20.4604 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rIwPnBSPbKsbzyuKu0gtQhiGszLCI/Xhw3ZpDXkeNMi/M0obW0Hg07wsLRSJ+TDmeL0s8FxC8QhVHlVaUcdz4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6860 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/ipsec-secgw: fix unchecked return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > > > > 07/08/2019 15:39, Akhil Goyal: > > > > > > > > > > > Check the return value of the rte_eth_dev_rss_hash_conf_get > function. > > > > > > > > Coverity issue: 344970 > > > > Fixes: 3a690d5a65e2 ("examples/ipsec-secgw: fix first packet with i= nline > > crypto") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Bernard Iremonger > > > > --- > > > Acked-by: Akhil Goyal > > > > > > Thomas, > > > Could you please take this patch directly to master. > > > > It doesn't look critical at all. > > Why do you want this in DPDK 19.08 without enough time for proper > validation > > testing? > Yes this one is not a critical fix. We can defer it to next release. Applied to dpdk-next-crypto Thanks.