From: Akhil Goyal <akhil.goyal@nxp.com>
To: Thomas Monjalon <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "roy.fan.zhang@intel.com" <roy.fan.zhang@intel.com>,
"pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Declan Doherty <declan.doherty@intel.com>,
Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-dev] [PATCH] drivers/crypto: fix build with make
Date: Fri, 28 Feb 2020 12:24:16 +0000 [thread overview]
Message-ID: <DB8PR04MB66357F2193FEA8FE3A99B7F2E6E80@DB8PR04MB6635.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200227223326.507857-1-thomas@monjalon.net>
Hi Thomas,
>
> In the check for the version of intel-ipsec-mb library,
> there is a backslash in front of the #include.
> It is not clear why this backslash is for.
> It is not clear why there was no error so far.
>
> In an up-to-date ArchLinux, these errors were seen:
>
> syntax error near unexpected token `|'
> `grep -e "IMB_VERSION_STR" \#include <intel-ipsec-mb.h> | cut -d'"' -f2'
> syntax error near unexpected token `|'
> `grep -e "IMB_VERSION_NUM" \#include <intel-ipsec-mb.h> | cut -d' ' -f3'
>
> The makefiles are fixed by removing the backslash.
>
> Fixes: 3067c8ce77ac ("crypto/aesni_mb: fix build with custom dependency path")
> Fixes: 457b8e372975 ("crypto/aesni_gcm: check dependency version with make")
> Fixes: bf6eb2c22fd1 ("crypto/kasumi: use IPsec library")
> Fixes: 7c87e2d7b359 ("crypto/snow3g: use IPsec library")
> Fixes: 61f7c988e39e ("crypto/zuc: use IPsec library")
> Cc: stable@dpdk.org
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
I see that CI is still failing after removing that backslash.
I believe the issue is not because of backslash. It is something else.
Regards,
Akhil
next prev parent reply other threads:[~2020-02-28 12:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 22:33 Thomas Monjalon
2020-02-28 12:24 ` Akhil Goyal [this message]
2020-02-28 12:41 ` Thomas Monjalon
2020-02-28 12:56 ` Thomas Monjalon
2020-02-28 13:25 ` [dpdk-dev] [PATCH v2] drivers/crypto: fix build with make 4.3 Thomas Monjalon
2020-03-12 8:05 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB8PR04MB66357F2193FEA8FE3A99B7F2E6E80@DB8PR04MB6635.eurprd04.prod.outlook.com \
--to=akhil.goyal@nxp.com \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=roy.fan.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).