* [dpdk-dev] [PATCH] app/compress-perf: fix floating point exception
@ 2019-08-06 10:37 Adam Dybkowski
2019-09-09 14:03 ` Trybula, ArturX
2019-09-19 14:52 ` Akhil Goyal
0 siblings, 2 replies; 3+ messages in thread
From: Adam Dybkowski @ 2019-08-06 10:37 UTC (permalink / raw)
To: dev, fiona.trahe, pablo.de.lara.guarch; +Cc: Adam Dybkowski
This patch fixes the floating point exception that happened
when the number of cores to be used during the benchmark
was zero. After the fix such situation is detected, the error
message is printed and the benchmark application exits.
Fixes: 424dd6c8c1a8 ("app/compress-perf: add weak functions for multicore test")
Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
---
app/test-compress-perf/main.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/app/test-compress-perf/main.c b/app/test-compress-perf/main.c
index e7ac412e6..6f095b548 100644
--- a/app/test-compress-perf/main.c
+++ b/app/test-compress-perf/main.c
@@ -127,9 +127,13 @@ comp_perf_initialize_compressdev(struct comp_test_data *test_data,
* if there are more available than cores.
*/
if (enabled_cdev_count > nb_lcores) {
+ if (nb_lcores == 0) {
+ RTE_LOG(ERR, USER1, "Cannot run with 0 cores! Increase the number of cores\n");
+ return -EINVAL;
+ }
enabled_cdev_count = nb_lcores;
RTE_LOG(INFO, USER1,
- " There's more available devices than cores!"
+ "There's more available devices than cores!"
" The number of devices has been aligned to %d cores\n",
nb_lcores);
}
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] app/compress-perf: fix floating point exception
2019-08-06 10:37 [dpdk-dev] [PATCH] app/compress-perf: fix floating point exception Adam Dybkowski
@ 2019-09-09 14:03 ` Trybula, ArturX
2019-09-19 14:52 ` Akhil Goyal
1 sibling, 0 replies; 3+ messages in thread
From: Trybula, ArturX @ 2019-09-09 14:03 UTC (permalink / raw)
To: dev; +Cc: Dybkowski, AdamX
This patch fixes the floating point exception that happened when the number of cores to be used during the benchmark was zero. After the fix such situation is detected, the error message is printed and the benchmark application exits.
Fixes: 424dd6c8c1a8 ("app/compress-perf: add weak functions for multicore test")
Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
Acked-by: Artur Trybula <arturx.trybula@intel.com>
---
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] app/compress-perf: fix floating point exception
2019-08-06 10:37 [dpdk-dev] [PATCH] app/compress-perf: fix floating point exception Adam Dybkowski
2019-09-09 14:03 ` Trybula, ArturX
@ 2019-09-19 14:52 ` Akhil Goyal
1 sibling, 0 replies; 3+ messages in thread
From: Akhil Goyal @ 2019-09-19 14:52 UTC (permalink / raw)
To: Adam Dybkowski, dev, fiona.trahe, pablo.de.lara.guarch
>
> This patch fixes the floating point exception that happened
> when the number of cores to be used during the benchmark
> was zero. After the fix such situation is detected, the error
> message is printed and the benchmark application exits.
>
> Fixes: 424dd6c8c1a8 ("app/compress-perf: add weak functions for multicore
> test")
>
> Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> ---
Applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-19 14:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-06 10:37 [dpdk-dev] [PATCH] app/compress-perf: fix floating point exception Adam Dybkowski
2019-09-09 14:03 ` Trybula, ArturX
2019-09-19 14:52 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).