* [PATCH] doc: add limitation in using segment-sz in crypto-perf
@ 2025-05-16 12:10 Akhil Goyal
2025-05-16 14:41 ` Anoob Joseph
0 siblings, 1 reply; 3+ messages in thread
From: Akhil Goyal @ 2025-05-16 12:10 UTC (permalink / raw)
To: dev; +Cc: suanmingm, anoobj, kai.ji, hemant.agrawal, brian.dooley, Akhil Goyal
When segment-sz is given as parameter,
use buffer-sz in descending order.
The reason is, same scatter gather buffer list is being used
for all packet sizes which is initialized once in the beginning.
Now if a small packet case is run first,
mbuf SG list will be trimmed to a smaller number of SG and
rest of the SGs are lost resulting in segfault.
Buffers cannot be re-initialized as that will come in datapath and
will be costly.
So to workaround this, if segment-sz is passed as argument,
use values in buffer-sz in descending order.
Signed-off-by: Akhil Goyal <gakhil@marvell.com>
---
doc/guides/tools/cryptoperf.rst | 1 +
1 file changed, 1 insertion(+)
diff --git a/doc/guides/tools/cryptoperf.rst b/doc/guides/tools/cryptoperf.rst
index e53e2d0ebf..a3d35f6a50 100644
--- a/doc/guides/tools/cryptoperf.rst
+++ b/doc/guides/tools/cryptoperf.rst
@@ -139,6 +139,7 @@ The following are the application command-line options:
* ``--segment-sz <n>``
Set the size of the segment to use, for Scatter Gather List testing.
+ Use list of values in buffer-sz in descending order if segment-sz is used.
By default, it is set to the size of the maximum buffer size, including the digest size,
so a single segment is created.
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] doc: add limitation in using segment-sz in crypto-perf
2025-05-16 12:10 [PATCH] doc: add limitation in using segment-sz in crypto-perf Akhil Goyal
@ 2025-05-16 14:41 ` Anoob Joseph
2025-05-19 6:03 ` Hemant Agrawal
0 siblings, 1 reply; 3+ messages in thread
From: Anoob Joseph @ 2025-05-16 14:41 UTC (permalink / raw)
To: Akhil Goyal, dev
Cc: suanmingm, kai.ji, hemant.agrawal, brian.dooley, Akhil Goyal
> Subject: [PATCH] doc: add limitation in using segment-sz in crypto-perf
>
> When segment-sz is given as parameter,
> use buffer-sz in descending order.
> The reason is, same scatter gather buffer list is being used for all packet sizes
> which is initialized once in the beginning.
> Now if a small packet case is run first, mbuf SG list will be trimmed to a smaller
> number of SG and rest of the SGs are lost resulting in segfault.
> Buffers cannot be re-initialized as that will come in datapath and will be costly.
> So to workaround this, if segment-sz is passed as argument, use values in
> buffer-sz in descending order.
>
> Signed-off-by: Akhil Goyal <gakhil@marvell.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] doc: add limitation in using segment-sz in crypto-perf
2025-05-16 14:41 ` Anoob Joseph
@ 2025-05-19 6:03 ` Hemant Agrawal
0 siblings, 0 replies; 3+ messages in thread
From: Hemant Agrawal @ 2025-05-19 6:03 UTC (permalink / raw)
To: Anoob Joseph, Akhil Goyal, dev
Cc: suanmingm, kai.ji, brian.dooley, Akhil Goyal
> -----Original Message-----
> From: Anoob Joseph <anoobj@marvell.com>
> Sent: 16 May 2025 20:11
> To: Akhil Goyal <gakhil@marvell.com>; dev@dpdk.org
> Cc: suanmingm@nvidia.com; kai.ji@intel.com; Hemant Agrawal
> <hemant.agrawal@nxp.com>; brian.dooley@intel.com; Akhil Goyal
> <gakhil@marvell.com>
> Subject: RE: [PATCH] doc: add limitation in using segment-sz in crypto-perf
> Importance: High
>
> > Subject: [PATCH] doc: add limitation in using segment-sz in
> > crypto-perf
> >
> > When segment-sz is given as parameter, use buffer-sz in descending
> > order.
> > The reason is, same scatter gather buffer list is being used for all
> > packet sizes which is initialized once in the beginning.
> > Now if a small packet case is run first, mbuf SG list will be trimmed
> > to a smaller number of SG and rest of the SGs are lost resulting in segfault.
> > Buffers cannot be re-initialized as that will come in datapath and will be
> costly.
> > So to workaround this, if segment-sz is passed as argument, use values
> > in buffer-sz in descending order.
> >
> > Signed-off-by: Akhil Goyal <gakhil@marvell.com>
>
> Acked-by: Anoob Joseph <anoobj@marvell.com>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-19 6:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-16 12:10 [PATCH] doc: add limitation in using segment-sz in crypto-perf Akhil Goyal
2025-05-16 14:41 ` Anoob Joseph
2025-05-19 6:03 ` Hemant Agrawal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).