From: Kathleen Capella <Kathleen.Capella@arm.com>
To: "thomas@monjalon.net" <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: fix TX burst queue drain edge case
Date: Fri, 26 Mar 2021 16:27:47 +0000 [thread overview]
Message-ID: <DBAPR08MB57523DD9D6AE11E9FEC0DF1687619@DBAPR08MB5752.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <6914149.Zb7rk1ssy2@thomas>
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, March 24, 2021 1:16 PM
> To: Kathleen Capella <Kathleen.Capella@arm.com>
> Cc: dev@dpdk.org; nd <nd@arm.com>; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>
> Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: fix TX burst queue drain edge
> case
>
> 23/02/2021 19:23, Kathleen Capella:
> > Initialize prev_tsc to cur_tsc. This avoids running the TX queue drain
> > in the first iteration of the packet processing loop.
>
> Is it really a fix? What was broken?
> Isn't it an optimization?
It could be considered an optimization since effectively it prevents entering the if statement on the
first iteration of the loop. I will remove the "fixes" line and reword the subject line.
>
> > Fixes: af75078fece3 ("first public release")
>
> If it's really a fix, we should probably backport it, so
> Cc: stable@dpdk.org
[Kathleen Capella]
It is not really a significant problem to be fixed in previous releases so it does not need to be backported.
>
> > Signed-off-by: Kathleen Capella <kathleen.capella@arm.com>
> > Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
>
>
next prev parent reply other threads:[~2021-03-26 16:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 18:23 Kathleen Capella
2021-03-24 17:15 ` Thomas Monjalon
2021-03-26 16:27 ` Kathleen Capella [this message]
2021-04-08 21:35 ` [dpdk-dev] [PATCH v2] examples/l3fwd: skip TX queue drain on first iteration Kathleen Capella
2021-04-20 1:12 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBAPR08MB57523DD9D6AE11E9FEC0DF1687619@DBAPR08MB5752.eurprd08.prod.outlook.com \
--to=kathleen.capella@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).