From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7AFABA0C42; Fri, 26 Mar 2021 17:27:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C33F40686; Fri, 26 Mar 2021 17:27:59 +0100 (CET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130040.outbound.protection.outlook.com [40.107.13.40]) by mails.dpdk.org (Postfix) with ESMTP id 88FC040685 for ; Fri, 26 Mar 2021 17:27:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZLDEtSwkHGCqzBhLiVF/6jw7fPEftdgIVwcb3PbF1WA=; b=uBonnmkuyC0I+TOPZM0QAQqlzrTsvzbvBoI4XZxz5kq2SixvlOMdJeTegLHMYqVIkL5T/ddFy6KvV1L0l/6m3HkzcuC/bDNHu9Qf02HI3M8psKtAeVmqzyX3W0e64BtpvKVEl3xlTDJwmSGC/Ms3ieB5R9UdIs9lfRjCyoww1Qo= Received: from AM5PR0402CA0018.eurprd04.prod.outlook.com (2603:10a6:203:90::28) by DB6PR0801MB1654.eurprd08.prod.outlook.com (2603:10a6:4:3a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.29; Fri, 26 Mar 2021 16:27:56 +0000 Received: from AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:90:cafe::d9) by AM5PR0402CA0018.outlook.office365.com (2603:10a6:203:90::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25 via Frontend Transport; Fri, 26 Mar 2021 16:27:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT040.mail.protection.outlook.com (10.152.17.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25 via Frontend Transport; Fri, 26 Mar 2021 16:27:55 +0000 Received: ("Tessian outbound f15357ab733e:v89"); Fri, 26 Mar 2021 16:27:54 +0000 X-CR-MTA-TID: 64aa7808 Received: from 8cde0927693a.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 965BC747-CE85-4A11-A65F-7A0B8D8F3BB7.1; Fri, 26 Mar 2021 16:27:48 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8cde0927693a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 26 Mar 2021 16:27:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k6iYqkXEa2/Bpcs5SrK3oFRF758gQ1olij8MPc15Q57oJUCZo6EZ+aPENiuE2sQY7bH9MyYKABBdUnQOOupXPvSDQN14jojX4c29UTH/QvtGz6gmDp9gQt/GVIaXQQkPrIBbL5JMwEWvqu8SAN0Rnroz+7XLnaCwHAY91vrytX/hH4yQH9EDJTxCNV3TqTHSbAkcJShPWEg7ruFhiK7qW2ksnNnyv55P4z7EZ8r1rQymlVAX1vrhaynKs+NaDVjrT7ZheP3CmuZd/IR0ZBKwJ2jtu/hr8bAVoG4wTiAd6pRvytiKQn0EXzVnIm69ddfG+inN58W7FdW27HgvaLotUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZLDEtSwkHGCqzBhLiVF/6jw7fPEftdgIVwcb3PbF1WA=; b=Tixva/4/pZlthAloueOzBNFpWmjeYJAy59rfBzuui2HIaFpENshFT4tTHbZ4yZY9jn6uIYmWMTE/H7DVD7q8MVBrJ30HDZ19nKP9GEz40V0IhA1mCln8rXAW2GZQEBNFxsPX53LU3YPrUmaBg7BczTtGm4IUNDHkYTrQOE6tw6xMZM8VQVopxomS+yhjcn205/aovYjVLmUfzQFMZ65M3wpZ4Die6vtQD4KST/nck30rxpZj0J/U7o0MWMDeK834hMK/D3WpjsGUdI07VYN8umO9qv6i281sPkxPwtp8om7hTg7+jkyJJsf6Y3s8FHxv8Ofgk5XqCpDcfdCeIhQCPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZLDEtSwkHGCqzBhLiVF/6jw7fPEftdgIVwcb3PbF1WA=; b=uBonnmkuyC0I+TOPZM0QAQqlzrTsvzbvBoI4XZxz5kq2SixvlOMdJeTegLHMYqVIkL5T/ddFy6KvV1L0l/6m3HkzcuC/bDNHu9Qf02HI3M8psKtAeVmqzyX3W0e64BtpvKVEl3xlTDJwmSGC/Ms3ieB5R9UdIs9lfRjCyoww1Qo= Received: from DBAPR08MB5752.eurprd08.prod.outlook.com (2603:10a6:10:1ac::21) by DB9PR08MB6569.eurprd08.prod.outlook.com (2603:10a6:10:261::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.24; Fri, 26 Mar 2021 16:27:47 +0000 Received: from DBAPR08MB5752.eurprd08.prod.outlook.com ([fe80::4102:e0d0:7df0:362]) by DBAPR08MB5752.eurprd08.prod.outlook.com ([fe80::4102:e0d0:7df0:362%7]) with mapi id 15.20.3977.025; Fri, 26 Mar 2021 16:27:47 +0000 From: Kathleen Capella To: "thomas@monjalon.net" CC: "dev@dpdk.org" , nd , Honnappa Nagarahalli Thread-Topic: [dpdk-dev] [PATCH] examples/l3fwd: fix TX burst queue drain edge case Thread-Index: AQHXChFtFe3gooVZi0a2+mK1mZNd0KqTjnsAgAHdbLA= Date: Fri, 26 Mar 2021 16:27:47 +0000 Message-ID: References: <20210223182300.29817-1-kathleen.capella@arm.com> <6914149.Zb7rk1ssy2@thomas> In-Reply-To: <6914149.Zb7rk1ssy2@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: BCBCE9D31AF75540984D2747178DA07A.0 x-checkrecipientchecked: true Authentication-Results-Original: monjalon.net; dkim=none (message not signed) header.d=none; monjalon.net; dmarc=none action=none header.from=arm.com; x-originating-ip: [64.121.153.90] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 422ad683-c949-4fd1-8a85-08d8f0741c60 x-ms-traffictypediagnostic: DB9PR08MB6569:|DB6PR0801MB1654: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: BqF/QAh+mqZA5i6KOjTtD/AxYuzOD2G6bj52qrdQE39dUROGFiJeP1DKJYyYPhtQXNz6ViRqcXuvqH9NOkEg4kSW30UDXKphrJcekPvezqJP1KTmXXgSuMr3hGxDaZovo7eDOn5VMwIrwGO1WhxYH7AJ/yIgZwsPYNaWd49f3ptifz5DluhzCKavA/9pSYAcs80+oinTuWyrnqhTISxUyxw/MYqeXgAsZioCSLuHZjucvUr69u9+s5epFQbvFl0WPaL2JSnqKeEP47iztraYpN+n9BE+sIlrS4t7DeFhQsQdc29u9lhZoaatTKx1I7beHxM0Pg/gqNXlpU+kt44TSIVkgwIFKW/LMp8FQt9LAFXKrCQmDh4j8DqYpr3rVqrTIrnMN/Glt4OnIRq2tNWorps1yXPfRoQH2XhhSxVQL97pHK4xUbiCdqQPIdnSig2wZmuXmPMfBNt3MLTqTVy6JYVxulfYRDxW6Wczu6sdFc9B2/Y7Xzccdb1/rTaPSMFXQ+McAQr86+0nNHzVC0lYmOCKEzSoKjQ6LY8hN5LTlReInw3180BYwo7x5B6rvvn973fQYTEqZzvx/s0al05T38dLxS4XZJqX6k9xPiSTDE3v9NDr+FjlnaUQZEBOklXLbQ6AR7M7r8VY2OZ1NawCEFRb9k5vHZesukrawL2lgcI= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5752.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(376002)(136003)(396003)(366004)(346002)(83380400001)(8676002)(4326008)(8936002)(55016002)(186003)(9686003)(71200400001)(26005)(54906003)(66556008)(66476007)(52536014)(66946007)(86362001)(7696005)(5660300002)(64756008)(53546011)(38100700001)(316002)(33656002)(2906002)(66446008)(478600001)(6506007)(6916009)(76116006); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?7PBYcQiEb8gWiiD+xRrNteawXcbFc6ODDkW/nJlyFhjJsaB77PoHDlf3MpJM?= =?us-ascii?Q?xkMzw5nZZJgNHxdnSL0B3EZEszp2zRhYUtu0oXBpQ5uy864Q9GB1eIYekw2i?= =?us-ascii?Q?D3Vm+WC8WX7A5MxhmAYicERJkqPRFWBfQk1zPf+PngeHi0iy28zbkHlCuRg3?= =?us-ascii?Q?LwZ7FC55MFNZOMrJfiaeWFuhQKZl9gxxSqkWGg8MgPk5IGWYK/6vA4fUDqIO?= =?us-ascii?Q?4RERvjNNYuWy7Cr7S1//72puOLH4dMFHhoTzxALUsFLHBYUP3E2DQ0QSLP/X?= =?us-ascii?Q?+71pPGxYCTxERl/vk+O+tWA2atc4gsKvbKROQ/HHyB9vpWZH/b/CrWBirJxY?= =?us-ascii?Q?+CC+Wv9N4UfdbVE7sn4icUrdwPUvKY8j6nB7lKYb0r0WFZcVG7CTaz30gvau?= =?us-ascii?Q?piTtjxwaP0W3tLRUXChyQId3ZyAsTc8TMeQ6RqNTaq6W3/FgrBRw1IaUSw6T?= =?us-ascii?Q?k0J0zbV/ALMD+A/cEnnAnhD97I8JoUF9mJh+9bd4ZgtHLY9ZKjmw//epTDJE?= =?us-ascii?Q?1INX8aj3U0Fs6KXxyufsNUmnbZUCkP6YDAYIYqt6+xvPos3DUrfvi/sBUoFM?= =?us-ascii?Q?sIouETzqueFYNGpmj1IrWGhL1lbUA0LsQ4QDO+yZC45vvxo92veZeP4YS9yU?= =?us-ascii?Q?1MfYtM9jt5zXeFQkAqtJRpWuFgBFlQNnV/X+UnExgpPFgXgnuyKVIsDSO0/4?= =?us-ascii?Q?44qZXTLQl3bHrlB8+JcarPdafhStNQz8GqJMPhtsEtkP9XevTp7uLsYHp4bR?= =?us-ascii?Q?e2aowQ2uVySr6CQepp/T4EZxLlNVKhffXIBNme3Rur1KZ6hHVg4r1pDVO7SB?= =?us-ascii?Q?vLHVFy86fe7t4nA0aTzkh9GGPGalYG1z/5nQ9v39VcLF/b+FjPoX560JtV6u?= =?us-ascii?Q?NXzGH+wIi1a/FCAkwYu7UAv4I26GVC4ciGlckHeaOhSq0t9G/Mr22NAmmowu?= =?us-ascii?Q?Z+o8qI4B21Zz0t903j9RUH6sE+j3LfeV+bGnP6PFvM02SmffX16gCN8rNFSP?= =?us-ascii?Q?zuk6kHGt1gIz0y6l2nGGg/GTFkl/gSITLGwXXDPUu4A48WzRD3SDWr6Sroum?= =?us-ascii?Q?GEoAwsI2aGN7dJQZZCl3omHnnyKY6krNueQyRT0mkcoUWhCkCaTulc/J6Glm?= =?us-ascii?Q?/NhueJEiEqfDU539w/FsB+89fFHC2PsK7K+RN0IN20D963shJoEavFWNhCS3?= =?us-ascii?Q?HKM1B8m/Xm3WfXJ91IhznAG1YixsD5mavSJKz5BQUKmj0yptmOuAMNrqQlfX?= =?us-ascii?Q?jT8w12LLLmwogoca0xO/5V6R8IgqwsolADi1MMOTu4p6gBofssTI2vfIAqLV?= =?us-ascii?Q?8L6NNLb/Qrgfw0rQcEkQzixR?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6569 Original-Authentication-Results: monjalon.net; dkim=none (message not signed) header.d=none; monjalon.net; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: a806bbe9-9870-4c94-bcc7-08d8f0741774 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uIZSXFK1fvCE2zmWQH+LZ1mcGfg9PLD0JrEP1rjj8/LAxKs3BgwmZhgG2pknEUPQrZxjlkpUkJ24FVs5aNBgMn1rLquhbuWwPTFHJgYy18k5FO8/vGxhqZDgTOzz84IENt7KYeMn6G4lN1dofxC9+TqyXzv6PMgO+EV6zvZb6GgnTFUR4YbTgK64jDnSYQPoYEBbPEnpC0E0Cu3AFaHGWBcXC+UnlCpJvek2ogAWuQPdyrrpFL7YHgX0YFJ7BAirLxfoH0qvoPNNNCCsYGcMDMJAvbx1zeDZO2GBV04r5RZo3lFHnHfvWKu+6QPvY7Cd8a7KI5GUiDmZ8f1mNAZGrDpaQwl9nnclsdZEU8Gh5UHQlBrjpYYhvZ5SAfZAWAY1Yg+MJySEeckM194/rXZtEqtogGpX/6UdNCI2ZpfvbnuVUAG3XfiezjKq0FkaFX2S/O+GYjEpRYjxYP0VE3YUdIr+fryLFrnFhSH1ZdhREzOw/idR1FdhTZGN+rwY3g1YazvoNdG5BiAVRpwEvjJsA7sWtjTn9KsOe8f9xwKC/JeigWjK9je5hBAcKHNrw9ssbU12UOSVHUDJR225+Iv1O8/NBPpyXHs/XqUM7q72tBQrmBySZaen1S4ipr/CZXDMQfI37D6hBIPkb8LTShDnLQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(39860400002)(136003)(346002)(396003)(376002)(36840700001)(46966006)(86362001)(82310400003)(2906002)(81166007)(82740400003)(7696005)(53546011)(6506007)(54906003)(70586007)(478600001)(70206006)(316002)(356005)(8676002)(5660300002)(36860700001)(52536014)(8936002)(83380400001)(6862004)(9686003)(186003)(4326008)(336012)(26005)(55016002)(33656002)(47076005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2021 16:27:55.5277 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 422ad683-c949-4fd1-8a85-08d8f0741c60 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1654 Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: fix TX burst queue drain edge case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday, March 24, 2021 1:16 PM > To: Kathleen Capella > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > > Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: fix TX burst queue drain = edge > case >=20 > 23/02/2021 19:23, Kathleen Capella: > > Initialize prev_tsc to cur_tsc. This avoids running the TX queue drain > > in the first iteration of the packet processing loop. >=20 > Is it really a fix? What was broken? > Isn't it an optimization? It could be considered an optimization since effectively it prevents enteri= ng the if statement on the first iteration of the loop. I will remove the "fixes" line and reword the = subject line. >=20 > > Fixes: af75078fece3 ("first public release") >=20 > If it's really a fix, we should probably backport it, so > Cc: stable@dpdk.org [Kathleen Capella]=20 It is not really a significant problem to be fixed in previous releases so = it does not need to be backported. >=20 > > Signed-off-by: Kathleen Capella > > Reviewed-by: Honnappa Nagarahalli >=20 >=20