* [dpdk-dev] [PATCH v2] app/testpmd: remove unused struct member
@ 2021-02-09 15:40 Kathleen Capella
2021-02-19 17:25 ` Kathleen Capella
2021-02-22 18:20 ` Ferruh Yigit
0 siblings, 2 replies; 4+ messages in thread
From: Kathleen Capella @ 2021-02-09 15:40 UTC (permalink / raw)
To: Wenzhuo Lu, Xiaoyun Li, Bernard Iremonger
Cc: honnappa.nagarahalli, kathleen.capella, thomas, nd, dev
The tx_queue member of the fwd_lcore struct is unused as it is already
part of the fwd_stream structure. Deleting helps improve code readability.
Signed-off-by: Kathleen Capella <kathleen.capella@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
---
app/test-pmd/testpmd.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
index 5f2316210..f805f1b4d 100644
--- a/app/test-pmd/testpmd.h
+++ b/app/test-pmd/testpmd.h
@@ -247,7 +247,6 @@ struct fwd_lcore {
streamid_t stream_idx; /**< index of 1st stream in "fwd_streams" */
streamid_t stream_nb; /**< number of streams in "fwd_streams" */
lcoreid_t cpuid_idx; /**< index of logical core in CPU id table */
- queueid_t tx_queue; /**< TX queue to send forwarded packets */
volatile char stopped; /**< stop forwarding when set */
};
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH v2] app/testpmd: remove unused struct member
2021-02-09 15:40 [dpdk-dev] [PATCH v2] app/testpmd: remove unused struct member Kathleen Capella
@ 2021-02-19 17:25 ` Kathleen Capella
2021-02-19 18:50 ` Ferruh Yigit
2021-02-22 18:20 ` Ferruh Yigit
1 sibling, 1 reply; 4+ messages in thread
From: Kathleen Capella @ 2021-02-19 17:25 UTC (permalink / raw)
To: Kathleen Capella, Wenzhuo Lu, Xiaoyun Li, Bernard Iremonger
Cc: Honnappa Nagarahalli, thomas, nd, dev
The iol-testing warning on this patch seems to be unrelated to the patch.
On February 9, 2021 10:40 AM, Kathleen Capella wrote
> The tx_queue member of the fwd_lcore struct is unused as it is already part of the fwd_stream
> structure. Deleting helps improve code readability.
> Signed-off-by: Kathleen Capella <kathleen.capella@arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> app/test-pmd/testpmd.h | 1 -
> 1 file changed, 1 deletion(-)
> diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index 5f2316210..f805f1b4d 100644
> --- a/app/test-pmd/testpmd.h
> +++ b/app/test-pmd/testpmd.h
> @@ -247,7 +247,6 @@ struct fwd_lcore {
> streamid_t stream_idx; /**< index of 1st stream in "fwd_streams" */
> streamid_t stream_nb; /**< number of streams in "fwd_streams" */
> lcoreid_t cpuid_idx; /**< index of logical core in CPU id table */
> - queueid_t tx_queue; /**< TX queue to send forwarded packets */
> volatile char stopped; /**< stop forwarding when set */
> };
> --
> 2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH v2] app/testpmd: remove unused struct member
2021-02-19 17:25 ` Kathleen Capella
@ 2021-02-19 18:50 ` Ferruh Yigit
0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2021-02-19 18:50 UTC (permalink / raw)
To: Kathleen Capella, Wenzhuo Lu, Xiaoyun Li, Bernard Iremonger
Cc: Honnappa Nagarahalli, thomas, nd, dev
On 2/19/2021 5:25 PM, Kathleen Capella wrote:
> The iol-testing warning on this patch seems to be unrelated to the patch.
>
Yep, it looks unrelated, spdk build is failing, I tried to trigger build again,
please check after some time if status changes.
> On February 9, 2021 10:40 AM, Kathleen Capella wrote
>> The tx_queue member of the fwd_lcore struct is unused as it is already part of the fwd_stream
>> structure. Deleting helps improve code readability.
>
>> Signed-off-by: Kathleen Capella <kathleen.capella@arm.com>
>> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
>> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>> ---
>> app/test-pmd/testpmd.h | 1 -
>> 1 file changed, 1 deletion(-)
>
>> diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index 5f2316210..f805f1b4d 100644
>> --- a/app/test-pmd/testpmd.h
>> +++ b/app/test-pmd/testpmd.h
>> @@ -247,7 +247,6 @@ struct fwd_lcore {
>> streamid_t stream_idx; /**< index of 1st stream in "fwd_streams" */
>> streamid_t stream_nb; /**< number of streams in "fwd_streams" */
>> lcoreid_t cpuid_idx; /**< index of logical core in CPU id table */
>> - queueid_t tx_queue; /**< TX queue to send forwarded packets */
>> volatile char stopped; /**< stop forwarding when set */
>> };
>
>> --
>> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH v2] app/testpmd: remove unused struct member
2021-02-09 15:40 [dpdk-dev] [PATCH v2] app/testpmd: remove unused struct member Kathleen Capella
2021-02-19 17:25 ` Kathleen Capella
@ 2021-02-22 18:20 ` Ferruh Yigit
1 sibling, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2021-02-22 18:20 UTC (permalink / raw)
To: Kathleen Capella, Wenzhuo Lu, Xiaoyun Li, Bernard Iremonger
Cc: honnappa.nagarahalli, thomas, nd, dev
On 2/9/2021 3:40 PM, Kathleen Capella wrote:
> The tx_queue member of the fwd_lcore struct is unused as it is already
> part of the fwd_stream structure. Deleting helps improve code readability.
>
> Signed-off-by: Kathleen Capella <kathleen.capella@arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-22 18:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-09 15:40 [dpdk-dev] [PATCH v2] app/testpmd: remove unused struct member Kathleen Capella
2021-02-19 17:25 ` Kathleen Capella
2021-02-19 18:50 ` Ferruh Yigit
2021-02-22 18:20 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).