From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0A75A04C0; Tue, 29 Sep 2020 07:24:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CF7281C296; Tue, 29 Sep 2020 07:24:24 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2056.outbound.protection.outlook.com [40.107.21.56]) by dpdk.org (Postfix) with ESMTP id BB75C1C241; Tue, 29 Sep 2020 07:24:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wwaWno+D0rVfG42kb/ykaK+9/w9rNGoA2T9z5GTQreU=; b=N0hq7qi27wdAkJKOs8Nse9nysQkNCaynV34/XFC75Tvv66liZQ0JoVlFFYJRubYhCNNvGnpScUZqgscfOnuhGovX1HCjiBmE2ZGRNZbgRPPXWaEIT/4jfvwE4Be+E+ctVsG5HGNihzL7daG5JHMHSul8in/2FksuQAbaimVOST4= Received: from AM5PR0601CA0032.eurprd06.prod.outlook.com (2603:10a6:203:68::18) by PR3PR08MB5676.eurprd08.prod.outlook.com (2603:10a6:102:82::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.20; Tue, 29 Sep 2020 05:24:19 +0000 Received: from AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:68:cafe::f3) by AM5PR0601CA0032.outlook.office365.com (2603:10a6:203:68::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.22 via Frontend Transport; Tue, 29 Sep 2020 05:24:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT060.mail.protection.outlook.com (10.152.16.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.21 via Frontend Transport; Tue, 29 Sep 2020 05:24:19 +0000 Received: ("Tessian outbound bac899b43a54:v64"); Tue, 29 Sep 2020 05:24:19 +0000 X-CR-MTA-TID: 64aa7808 Received: from 8fb1d3439076.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B08152B8-2657-4306-B18D-B601F5AC97E2.1; Tue, 29 Sep 2020 05:24:14 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8fb1d3439076.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 29 Sep 2020 05:24:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G7V970rVN5CmP+CWSP5My4xqsFNcec0uvJEypKPVZdq7XwzGiYk36hktzdM0iYXsCHAFGo+xKIaza+A9XqYHhkzbF3VVVCinK61hSMrEcj9bSfpMdc03UV+aJ4XYgCQHVdux1UFSqyBIxVqFxUWTIpEAdTMt1l87qdlA+7TADBByySSkxwSvi+KUQPlK4BRkGYH0U2JEimBvh0HHI3Qpik9jBKEouUDM7VmR2kwy7g482ksH/ZkYmDpM8bWfHRtf1EZ9bNN8wxlfnPTc3B9twXaBUkE3wOm3LgjMbT6fp2QA/Dh/NtX3j0zEVx2BYHsf83w1BybaM4k7yhCAhdf8oQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wwaWno+D0rVfG42kb/ykaK+9/w9rNGoA2T9z5GTQreU=; b=CxA+cT36VDoiiJxAxY8FCqHC5DkzvQ4LhEKpujMfftoeHHQWUDeO4L2QhEqX5SH9UeBIwWn60StI5NklzFHIIyFHxTCO46wQnE4ekvXdMoS/ZdQDel8u1MN49zICYu2IRlwShDTHV+0F4a/8HFdtA0FDXmFWwoWk8FvUAkbHibEBgfNesYkOi6iiu+CxoW2ktYULj7VdK4FfHoM2eSCDK+F5Z16SPB5CCCBwUJMnX58GdSImNWnzLnhMVuvVoMBtcJK8TsRgonSzdqM2/+7gL54zyVAA3/NRTO38eOLKUqzhPAkWL6nY11br6jfC9mGl4lSDG8vQMlsiVGRiycf3Cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wwaWno+D0rVfG42kb/ykaK+9/w9rNGoA2T9z5GTQreU=; b=N0hq7qi27wdAkJKOs8Nse9nysQkNCaynV34/XFC75Tvv66liZQ0JoVlFFYJRubYhCNNvGnpScUZqgscfOnuhGovX1HCjiBmE2ZGRNZbgRPPXWaEIT/4jfvwE4Be+E+ctVsG5HGNihzL7daG5JHMHSul8in/2FksuQAbaimVOST4= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB7PR08MB3339.eurprd08.prod.outlook.com (2603:10a6:5:1c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.22; Tue, 29 Sep 2020 05:24:12 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d%4]) with mapi id 15.20.3412.029; Tue, 29 Sep 2020 05:24:12 +0000 From: Honnappa Nagarahalli To: Stephen Hemminger CC: "dev@dpdk.org" , Phil Yang , "jgrajcia@cisco.com" , "ferruh.yigit@intel.com" , nd , "stable@dpdk.org" , Honnappa Nagarahalli , nd Thread-Topic: [dpdk-dev] [PATCH v2 1/8] net/memif: do not update local copy of tail in tx function Thread-Index: AQHWldmOGCbgkpUl/U+/jdHuIoKgi6l/Fa2g Date: Tue, 29 Sep 2020 05:24:12 +0000 Message-ID: References: <20200921192254.20560-1-honnappa.nagarahalli@arm.com> <20200928190334.40624-1-honnappa.nagarahalli@arm.com> <20200928135353.774a805f@hermes.local> In-Reply-To: <20200928135353.774a805f@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: BDD3F0A7797662419D3BF994BA4D09BD.0 x-checkrecipientchecked: true Authentication-Results-Original: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.110.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: cb5845cd-eea8-4e75-5bfb-08d86437ea71 x-ms-traffictypediagnostic: DB7PR08MB3339:|PR3PR08MB5676: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:6790;OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1gI3FB/Rj1nrINNfFdd6BU4lKY0NzpqPBmHWMyw8dmOfwloeZYzo4SQ6ftjhWx0xZGL1dd2GqiIAvFhz0i+Xl2/iVno+epFv5iyBXFVqWjzQYPnxQQ1PgIJfp++dNRyWsNvpJPtyTpJIolPbDwivqZ1ZvOh9DL6BA6SgRmNqPp4lv5Yk2QUVtP4jQDVJb77IsWDkFMJehMh1bnRY65fJ5d8nvIGmwf0xxfuKfqMzdLOh/RoldzE5GAWqpS6ZTekE15t3FEIFaPAOr2081J/MzVONQbcE7W0ec1XFXEzimfglsexLXfguhAYli+h6QbubiRTa3vnzyGv/cS0jAeMLBkJSwC8HGy5JM3MfJcTJuRH/NFohPkeUyTjWjz8xiwLp X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(346002)(376002)(396003)(39860400002)(316002)(186003)(8936002)(6506007)(52536014)(478600001)(26005)(4744005)(7696005)(76116006)(66946007)(5660300002)(4326008)(9686003)(6916009)(55016002)(8676002)(54906003)(33656002)(2906002)(15650500001)(83380400001)(86362001)(71200400001)(66446008)(64756008)(66476007)(66556008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: tB9NaUs510cgSlc/rbPFOTX6P2I58f0E1OdQaJFSVaXcgjI/+Nu150dsW1mMqBPxWV/LuNzCo2KwFG0gxTB/BXo9FYe1z/EkYskEK44DTj7I539bYTXzVKJ/bmJTWIeYDNHM7SrC/crnOyd2BBgG6LBjE+8XiX0F0XdTlpETjL7SqSm/h5WZ/6fy1sZRz8unzw9EYY9GuDk20pXyvBDcJWpZn/eCLGsTyoRTChu7teunnbjKkAs745D1jQj6p5Ky6UDDRGo57VoRkNPvzu7esU2B43E0Vnd9NWNnvSGiI1VdOf57u1YA9n6cU3s0Qvg4L+Iq1H+PpuIgoXrSQEiXw84DiqXSF4YxahrtpJ6capNOXH0t1mNer8kSCf38CVcw/cc+o+Jpe73YQO7l3FqiquTHNW+W4Y5QOiwm4bqUTeTsrXdnz2eJ7jfqH+BepoCnHUHruLv9ZonnhOkD76O4x5KupUzL0DBVzRDJpGyUAk1mu0kfbxRdJHnPHQoz8Sq2T214ahEPt7NUYC9R7TpGUwpZh/Gst4E9VdVC30AUyOQXUINin0tzACHkD2beeR5fPAd3wumVCK8+aJ/4r3hChHyY8ccLlyZN0lJSuoksTBJEHU028REg176U6gyugrhybpScyd2Ra8N+d/XlN5Pp4g== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3339 Original-Authentication-Results: networkplumber.org; dkim=none (message not signed) header.d=none; networkplumber.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 5741f174-2130-48fc-c94a-08d86437e669 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gAFSyWeC4Mp20jpM3S/FQCoYRFthwK5cvkS1bu5/syxK7usl3BvMkIAH/PR9h+Wl+JLzd1db/qCkqagqA+y8PWhJYWTwvJBgeyIPAv1uZBUrWgUi+eY5bg23ujNkot+uymR+9JNeBF+NBpZbg/nUbVWrfOyXTEnB6HP6YvMmZgMil9hXBDpztbVNn+bFL8T3blXpHF2gayHfVE5WPXkHEMpjf84u9yf9d7k2XcPoLZZ36OiisxJkFE+jh0r0m0SiXTbwqa4tSj5B0lA5qQJz/y35YvbYiDD1uD89Q3W7nX813Lw8TG7JNycW1Zd1/CirupY7aMzixYP0xj3Qq1Ah964e6aHuKL3anXGN1pcki81H9yAxI/rmKWaKjKM4l6Gbhkw4wPg+BbpE0x/NVWFXeoxPLdiolmz0UHTm3KA1qk1zIX9JHG3fIfgyH/VaBkcu X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(396003)(376002)(136003)(346002)(39860400002)(46966005)(186003)(6862004)(86362001)(55016002)(82740400003)(52536014)(7696005)(8676002)(33656002)(4326008)(450100002)(8936002)(47076004)(36906005)(316002)(83380400001)(54906003)(81166007)(356005)(5660300002)(15650500001)(478600001)(6506007)(336012)(70586007)(2906002)(70206006)(26005)(9686003)(82310400003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2020 05:24:19.1413 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cb5845cd-eea8-4e75-5bfb-08d86437ea71 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5676 Subject: Re: [dpdk-dev] [PATCH v2 1/8] net/memif: do not update local copy of tail in tx function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > On Mon, 28 Sep 2020 14:03:27 -0500 > Honnappa Nagarahalli wrote: >=20 > > In the case of S2M queues, the receiver synchronizes with the sender > > (i.e. informs of the packets it has received) using ring->tail. > > Hence, the sender does not need to update last_tail. > > > > In the case of M2S queues, the receiver uses last_tail to keep track > > of the descriptors it has received. The sender is not required to > > update the last_tail. Updating the last_tail makes it a shared > > variable between the transmitter and receiver affecting the > > performance. > > > > Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD") > > Cc: jgrajcia@cisco.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Honnappa Nagarahalli > > Reviewed-by: Phil Yang > > Reviewed-by: Ruifeng Wang >=20 > This patch series will conflict with the pending master/slave patchset. > Please let the master/slave renaming go in first. +1, review can go on.