DPDK patches and discussions
 help / color / mirror / Atom feed
From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: Cian Ferriter <cian.ferriter@intel.com>,
	Konstantin Ananyev <konstantin.ananyev@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>, nd <nd@arm.com>,
	nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH] ring: fix comment for __rte_ring_move_cons_head()
Date: Tue, 24 Aug 2021 19:32:35 +0000	[thread overview]
Message-ID: <DBAPR08MB58140C5D5A8DD12424C8EBEF98C59@DBAPR08MB5814.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20210823172844.72394-1-cian.ferriter@intel.com>

<snip>

> 
> Change "enqueue" to "dequeue" because the __rte_ring_move_cons_head()
> function is updating the consumer head for dequeue.
> 
> Fixes: 0dfc98c507b1 ("ring: separate out head index manipulation")
> Cc: bruce.richardson@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Cian Ferriter <cian.ferriter@intel.com>
LGTM
Acked-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

> ---
>  lib/ring/rte_ring_c11_pvt.h     | 2 +-
>  lib/ring/rte_ring_generic_pvt.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/ring/rte_ring_c11_pvt.h b/lib/ring/rte_ring_c11_pvt.h index
> 37e0b2afd6..f895950df4 100644
> --- a/lib/ring/rte_ring_c11_pvt.h
> +++ b/lib/ring/rte_ring_c11_pvt.h
> @@ -111,7 +111,7 @@ __rte_ring_move_prod_head(struct rte_ring *r,
> unsigned int is_sp,
>   * @param is_sc
>   *   Indicates whether multi-consumer path is needed or not
>   * @param n
> - *   The number of elements we will want to enqueue, i.e. how far should the
> + *   The number of elements we will want to dequeue, i.e. how far should the
>   *   head be moved
>   * @param behavior
>   *   RTE_RING_QUEUE_FIXED:    Dequeue a fixed number of items from a ring
> diff --git a/lib/ring/rte_ring_generic_pvt.h b/lib/ring/rte_ring_generic_pvt.h
> index c95ad7e12c..5acb6e59be 100644
> --- a/lib/ring/rte_ring_generic_pvt.h
> +++ b/lib/ring/rte_ring_generic_pvt.h
> @@ -106,7 +106,7 @@ __rte_ring_move_prod_head(struct rte_ring *r,
> unsigned int is_sp,
>   * @param is_sc
>   *   Indicates whether multi-consumer path is needed or not
>   * @param n
> - *   The number of elements we will want to enqueue, i.e. how far should the
> + *   The number of elements we will want to dequeue, i.e. how far should the
>   *   head be moved
>   * @param behavior
>   *   RTE_RING_QUEUE_FIXED:    Dequeue a fixed number of items from a ring
> --
> 2.32.0


  reply	other threads:[~2021-08-24 19:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-23 17:28 Cian Ferriter
2021-08-24 19:32 ` Honnappa Nagarahalli [this message]
2021-10-01 12:47   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DBAPR08MB58140C5D5A8DD12424C8EBEF98C59@DBAPR08MB5814.eurprd08.prod.outlook.com \
    --to=honnappa.nagarahalli@arm.com \
    --cc=bruce.richardson@intel.com \
    --cc=cian.ferriter@intel.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=nd@arm.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).