From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E72D8A0C45; Tue, 24 Aug 2021 21:32:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A20D5406A3; Tue, 24 Aug 2021 21:32:51 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80082.outbound.protection.outlook.com [40.107.8.82]) by mails.dpdk.org (Postfix) with ESMTP id 25AD140687; Tue, 24 Aug 2021 21:32:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JhP2fU8fwh3FSCypkL/wotZcPFGtAuyTcJuPEVCbpeE=; b=FRajGa/XVjzljiyV5Gir1ScRZwUmJ4RM/rbUxAYAu4RgqjMWbWiuq3uRmoFghsETgQGp8KLM2jC/vF2ShKTiQs/CnfkOLOwQsxdptalndYEW28vbjpRP+IPXezCd3C57HKJtIRZYK35i6OzVh5ga8dmFEqRoPxpW7i0Y53ynzrY= Received: from DU2PR04CA0357.eurprd04.prod.outlook.com (2603:10a6:10:2b4::32) by AM0PR08MB2996.eurprd08.prod.outlook.com (2603:10a6:208:5b::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.22; Tue, 24 Aug 2021 19:32:43 +0000 Received: from DB5EUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b4:cafe::3d) by DU2PR04CA0357.outlook.office365.com (2603:10a6:10:2b4::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19 via Frontend Transport; Tue, 24 Aug 2021 19:32:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT044.mail.protection.outlook.com (10.152.21.167) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17 via Frontend Transport; Tue, 24 Aug 2021 19:32:43 +0000 Received: ("Tessian outbound 1a0c40aa17d8:v103"); Tue, 24 Aug 2021 19:32:43 +0000 X-CR-MTA-TID: 64aa7808 Received: from dd2ed612bf38.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 31A5DD38-EF56-4B70-9466-582FE739E50B.1; Tue, 24 Aug 2021 19:32:37 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dd2ed612bf38.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 24 Aug 2021 19:32:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VCaAMhU+mSUn0WxRsBYjnxnVcjQusaotJQiLqfmZgP6KMvtHMYRiAdFfiGeHqwUGsFM+QxbyfXgpQ/A49dv3EMhHOLsYxE5k3+LxHFzWkwqT5tBk0jVGZAGK/7JtD7owXJsCk7VxdDpAEPhhT3kOhfmvWHqsh9QFrDMO7bZqadWd6h/kVG9pSR0hCnrpm8ajJCePRuwShS/cGfHbmaLI/6aw8S9k5+j8cDkEx6bJn0wLCXLTWgPeEouD0aCTAjTNsNKzxiQhh8jWlWuLpRPvS4w0aW3v/CDsPXb2Rd4Jnj+5KTQwvpEspNyU+mRrW55wOr/j32QZEl0Yl6lRSre05w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JhP2fU8fwh3FSCypkL/wotZcPFGtAuyTcJuPEVCbpeE=; b=QwNpgRgyn3hHA/jTCAyqRP+D+HB/dbNxGrDrvLXSKwHhe37FXmoLTGYMAjaBAw0eBkDYx3XUR2kVHFrDWDwu45ySA+WlYqRmzgO85ussu+R+zqcbP2O11lEKJS8WhdzpZpGM01EFriBZMUf7eAXcsJw2732c/S50Xn0WK6hBENxXWPVjRhAqyVExVCZ9G2f9ewvXtnkYVJW8LM+pSnd1k+NLYEfHBeYKIwXy7hNlL6+iy1ob/wt38Fi0h+71Chrea9Sc+P9aPCMAvdg+sULMVGJ9+6klDgMUvRM1l1k7FInAa4yrBfqZxWsnLT18f021Z/HumFw5NMcpFjK2uNGBiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JhP2fU8fwh3FSCypkL/wotZcPFGtAuyTcJuPEVCbpeE=; b=FRajGa/XVjzljiyV5Gir1ScRZwUmJ4RM/rbUxAYAu4RgqjMWbWiuq3uRmoFghsETgQGp8KLM2jC/vF2ShKTiQs/CnfkOLOwQsxdptalndYEW28vbjpRP+IPXezCd3C57HKJtIRZYK35i6OzVh5ga8dmFEqRoPxpW7i0Y53ynzrY= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DBBPR08MB6202.eurprd08.prod.outlook.com (2603:10a6:10:209::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19; Tue, 24 Aug 2021 19:32:36 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::ac8f:622:c2d4:9e6d]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::ac8f:622:c2d4:9e6d%9]) with mapi id 15.20.4436.025; Tue, 24 Aug 2021 19:32:35 +0000 From: Honnappa Nagarahalli To: Cian Ferriter , Konstantin Ananyev CC: "dev@dpdk.org" , "bruce.richardson@intel.com" , "stable@dpdk.org" , nd , nd Thread-Topic: [PATCH] ring: fix comment for __rte_ring_move_cons_head() Thread-Index: AQHXmERPYVdcrA+dnk6MNRavEYPFe6uDCtmw Date: Tue, 24 Aug 2021 19:32:35 +0000 Message-ID: References: <20210823172844.72394-1-cian.ferriter@intel.com> In-Reply-To: <20210823172844.72394-1-cian.ferriter@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 7218D232AE40A747AA4B971CA877F8ED.0 x-checkrecipientchecked: true Authentication-Results-Original: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: bc7f73bf-6de4-4c0a-5e09-08d96735f178 x-ms-traffictypediagnostic: DBBPR08MB6202:|AM0PR08MB2996: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:5516;OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: oRiM3boGudnrvpjUPnOnXCbfOqb0tpmTYeCEylJUjAnprc09I++/mGM8M31qiEjmycXWlDT5O9kVua8wEFbe7ojR/Bq7Y/7QjRFf1CuOv81Q+cDIvhJwZZlrxe//eAgLm4kA7DisLQL21A6wkZ2z2YHdLLxytXP1gW/ZHw8pLA0Iy/228GdecfWMQ5zWKkXEnYh0mnEv9jTuI0XhZiAZRJs2CBFfZq1I0FYerQzFsdvML81VeBc8HCSLVLA+SFU+HHPAvByHzjM2+6UEZer32vEDRwjvhCObQqZmKayyZF8VlnbyFbp0Wu5T+bxyaJb4LrPcJIP3cfRkp0/ku5U91O3DnQ8ZclTKXHlrEmFgU1l0skqzCAXmPtgla3yoc1h/mZwPSHI/WiOunObq+fDvMLY6q8KWntqgYoxI2Dw022rHFX02N2XCljDjpU4LgoowH6UCsYap0QcFnoyTtuuwfdtjjWw5HrRzmxP1eHSXIsvGXrIMw0BoRs5IUEoFO24vrR1yP7frQqWQW+MYOfobw0oCPl+AZg3ahmqeAZ4AeQN24cl86YsbgLHdJpxoOuvL4pudvv5zQyVTtj7PBA7CrJVUQtCN/lz7Nhsw9F0UKp6XQzpkRzHQ3x8Mvl6iNTZtOZYyXDIgUVL7poyMTOIDhI/EUR+QBT12ztHV8coeTCQUXiLK0HaNIKYvJU5MytTqQkwm8InF33MpuwormJhzNg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(39850400004)(396003)(366004)(346002)(136003)(83380400001)(76116006)(316002)(9686003)(86362001)(4326008)(52536014)(186003)(38070700005)(478600001)(55016002)(33656002)(6506007)(26005)(2906002)(71200400001)(38100700002)(8676002)(66476007)(7696005)(66946007)(5660300002)(66556008)(110136005)(64756008)(8936002)(66446008)(54906003)(122000001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PC80fUtBJUyGwaB3ImCqK7/s9ps4I7tMA5wBJ8VkAWf7cmT5aIbVJV2p/5By?= =?us-ascii?Q?4ujq81h5gkDKSw8fXLO0u7Vvc0G9KC+wBXnVbU2NDnu97g15uFqVEgw6tEBj?= =?us-ascii?Q?packxMJplmFKky/+hk9yOrXavGZctdm0VOieCda+/niLTNHrosXNoIs+jYd3?= =?us-ascii?Q?EB0RDXckV5BLHFtnhQXYmwohmxY2fvjnYKNCha54XOkrNapVMJzyr8VEwzet?= =?us-ascii?Q?juHUNYwTAnFWRZ4mKD40HRtE08uxgBOWO66m4PSy7tS2ZWRIfc5XGOep9+Dh?= =?us-ascii?Q?pz9sv5ksh1vfEq1pJehmfSSuzRVc3gXbHk+cWyNxt6FT8yPbwX2vOlKdS/sl?= =?us-ascii?Q?Hvtp2jIPWPrmoa0eXiFwpIdEKqQ3GVusKARdX3/8l+n3Q+dw9bgfiWJBgK9p?= =?us-ascii?Q?8kLUe0Iimw9L/q1Ylhn8efc34GB7tWv6hYzf4fYtM84ik+D006nVZP4sXXFq?= =?us-ascii?Q?ormEQIYTIDpwoCTKB791dif+dRUMeDmBhZK1OOnwujslPV+H3f1Mh5WFmYXZ?= =?us-ascii?Q?VCE0DtLdWoh3F5OyCxiwoEuBlrbCoHn0aSgVZeY8knPtV1jArCdkHUGOAVpn?= =?us-ascii?Q?G6HviC7rKITRx3igIGvVOtLOMr6WO0SwQ4QLDSpKIar/H0aG+MgvvBV2cF0I?= =?us-ascii?Q?Gtli0q5XOGho0henycYEWK09bdJx+Pi/8me39yBzHXCEqle0fAZrzJnCOmlo?= =?us-ascii?Q?nN1l9EpycD007OXCoc1nZ6LI1kRKAG3H2MRKbdIo8Sf7jVHUYVtw7l20mMNF?= =?us-ascii?Q?8OxTTA10p8BDJ0c9j3DUiiJxbJ5ZyhY3DXqBbDM0Ozg5xs6eu7F4a4eYAtt/?= =?us-ascii?Q?D0hkGOPDx5UloODe3x2IAg32myhxyJK3OYk/Q+dglMZDfod/1PrK43AoueNt?= =?us-ascii?Q?jTyGEepvOEaoo9DodMTSo40C8Fv+NxsGSBmDFG1RsQ1U3MDp3VRpNlRdmpMB?= =?us-ascii?Q?Ufk+qJZoLFULWQ8HEr+0CZjRKhyt9B/DsLRcfAcCDGDaxiyn1/hkST/WqDiU?= =?us-ascii?Q?w3DrPh0gjG+etw6Id91M8UEeQj9uBGZgCWJ88s6AV6ABax37N8AxxnbJdXxs?= =?us-ascii?Q?h16jdMRIzWTi0aRpYQi7Scu4DWN7IoXdrEgP6XtM16DmmXCJBamYvhphWs3I?= =?us-ascii?Q?mCKzPaxU6J+d4kVCONw8Y8HrbTsEpxdSoqctC0PTWD/BTY2V3m2H/YZqOase?= =?us-ascii?Q?dQhpdA/+xS2eEHSW5toHHSKWf0kakFZFYhav18YPUNBLuZiVrywWZB/LgPX/?= =?us-ascii?Q?HxnrJ8puwonFHkhd6nqed78Ftle56kdeFZyHpD9PtVKfxuEGDHkAA+gvzPKV?= =?us-ascii?Q?1npXR9Fr1JMKyUaw/KT7wW/V?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6202 Original-Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: ca4ef06b-97b6-4a95-7ffb-08d96735ed19 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fRrQqCgZKfPwqHJujQu6tb/dCgHl4Em6EI+Wcq9PdMXSw4BAh/q5lPY5TuX945I9XhJbeEaAg1uuZrcFr5y8rrFM/60ck3/XjI0PsLCNdjva1GXgVGdTmXJogNYDEEwacaVC/e4dsshqEsxG2D5Nh3TENl/qF1dkK/gWrB/R+NNmmgwlS0KAAxQtTJZrcJLJXRe9ZJ7RtbGVL/KjH9tUtFIFo9DwXVTeotpmwGp5FYKjhYxJ0mPXX6s6+cE2qH/RajfdbTyz6qi198K45fohrt0VHo9Hm7JQM4p2COkhteHDDFSKBLT9//s32A6HmmzScoBuU1dLt9igwkanvtdJSLwLzOXcWLZkHXtlxyxju9b+rOcKpwK6mUsc+kUOoh2gdBago0/KdVQpkj5joT3Nzns7sF7mtv9/hLcPcwmrtWZBkIiUBDSdFNEleAbFDn0sUIaq9V/2rvYOJSxhAw2ip52ek4OD+dsLfw4ZEDEiQh2AMLWDqWQK0s+Ywg/E7+m1YIUqN5wztZzawHCBkoidtLoYXR3Fn3Y9U54InAGh5u1eMdVDTKl36afl1sv/Rth8mgK+DI0RpeGjG8JGcQnDSpNhs+BlJuBJg5iLd5PGRD6irSQKUynF/ihUcLonalZRJhbUQ7gkwVg7ptjgw+RH96hVaw67tGxdz3PumtJ6iU0Rb8r9rfL/aHRhi9Ui666rLiELOowrb/x5i5474JvFYg== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(346002)(376002)(39850400004)(396003)(136003)(36840700001)(46966006)(81166007)(86362001)(54906003)(82740400003)(9686003)(316002)(55016002)(110136005)(336012)(478600001)(356005)(7696005)(52536014)(83380400001)(36860700001)(4326008)(82310400003)(33656002)(5660300002)(450100002)(70206006)(8676002)(70586007)(47076005)(26005)(186003)(8936002)(2906002)(6506007); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2021 19:32:43.1461 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bc7f73bf-6de4-4c0a-5e09-08d96735f178 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB2996 Subject: Re: [dpdk-dev] [PATCH] ring: fix comment for __rte_ring_move_cons_head() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Change "enqueue" to "dequeue" because the __rte_ring_move_cons_head() > function is updating the consumer head for dequeue. >=20 > Fixes: 0dfc98c507b1 ("ring: separate out head index manipulation") > Cc: bruce.richardson@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Cian Ferriter LGTM Acked-by: Honnappa Nagarahalli > --- > lib/ring/rte_ring_c11_pvt.h | 2 +- > lib/ring/rte_ring_generic_pvt.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/ring/rte_ring_c11_pvt.h b/lib/ring/rte_ring_c11_pvt.h in= dex > 37e0b2afd6..f895950df4 100644 > --- a/lib/ring/rte_ring_c11_pvt.h > +++ b/lib/ring/rte_ring_c11_pvt.h > @@ -111,7 +111,7 @@ __rte_ring_move_prod_head(struct rte_ring *r, > unsigned int is_sp, > * @param is_sc > * Indicates whether multi-consumer path is needed or not > * @param n > - * The number of elements we will want to enqueue, i.e. how far should= the > + * The number of elements we will want to dequeue, i.e. how far should= the > * head be moved > * @param behavior > * RTE_RING_QUEUE_FIXED: Dequeue a fixed number of items from a rin= g > diff --git a/lib/ring/rte_ring_generic_pvt.h b/lib/ring/rte_ring_generic_= pvt.h > index c95ad7e12c..5acb6e59be 100644 > --- a/lib/ring/rte_ring_generic_pvt.h > +++ b/lib/ring/rte_ring_generic_pvt.h > @@ -106,7 +106,7 @@ __rte_ring_move_prod_head(struct rte_ring *r, > unsigned int is_sp, > * @param is_sc > * Indicates whether multi-consumer path is needed or not > * @param n > - * The number of elements we will want to enqueue, i.e. how far should= the > + * The number of elements we will want to dequeue, i.e. how far should= the > * head be moved > * @param behavior > * RTE_RING_QUEUE_FIXED: Dequeue a fixed number of items from a rin= g > -- > 2.32.0