From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1569641CC1; Fri, 17 Feb 2023 16:28:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE93740EE3; Fri, 17 Feb 2023 16:28:47 +0100 (CET) Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2063.outbound.protection.outlook.com [40.107.249.63]) by mails.dpdk.org (Postfix) with ESMTP id DDF4640EE1 for ; Fri, 17 Feb 2023 16:28:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FA/ryM3saCmkN0TwFigDXCh2A1a+37LxJbRVvs5gNDI=; b=6y2pOegwP6auttEHc/hV+nEBAGroXmxD8XNr8nbETPg6QGwwwYnM8k2ZIgY5/EHN7yux1B6H229Sy6A8Y1f4kG9zor+QZTtVN81XQNJWLGETZJUFNf9USjzhOTF7O3behpsU7tU8cITUSWPhfDXksJiLTukfcZ8W6/MfBPRAXek= Received: from DB6PR07CA0204.eurprd07.prod.outlook.com (2603:10a6:6:42::34) by VE1PR08MB5744.eurprd08.prod.outlook.com (2603:10a6:800:1af::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.13; Fri, 17 Feb 2023 15:28:42 +0000 Received: from DBAEUR03FT054.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:42:cafe::da) by DB6PR07CA0204.outlook.office365.com (2603:10a6:6:42::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.12 via Frontend Transport; Fri, 17 Feb 2023 15:28:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT054.mail.protection.outlook.com (100.127.142.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.15 via Frontend Transport; Fri, 17 Feb 2023 15:28:42 +0000 Received: ("Tessian outbound 6e565e48ed4a:v132"); Fri, 17 Feb 2023 15:28:41 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 3cd8357330332438 X-CR-MTA-TID: 64aa7808 Received: from 9991732d1e03.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C26E6A63-92F2-48DC-9BB5-220D47B1524B.1; Fri, 17 Feb 2023 15:28:30 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9991732d1e03.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 17 Feb 2023 15:28:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jyoWR6pXbrkh5q5gR3n9ibHef6aP6ApZF8RW81P2Nik7d9wTfFm/AGNkOAbkhBS82pM8gcI6FW3q6hOrp8yYaplcgl4HNFu1asvLNa5fsFz+AgENVLnSy6iw3GsoFuqLihUUlrxlXBcaTgTE775JFDno9BEfG3LJxGBPCLj/lwVyFPAgWVlICrO0yL+tmAA+8C9wtGSExs3erzuoP1Mj1YBTYJZGF8bdVAcY5tybRxJoh6StposJsoJjn5YFPf1m2eyoRsNUzuavdOkWJ/ashlWFd9hlVF/0Ett+ZfO4DUU/ttDrrdbVrn4CIdg1VEWo/NehcAncbWKiQywXIP3BUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FA/ryM3saCmkN0TwFigDXCh2A1a+37LxJbRVvs5gNDI=; b=GfulGcZ4BjaJ/pGweMyl3xAFAQvAomFkcPaA6NEVOysWt2N3Oj7e4AvUpEKLfGDuN/orNv0RJnJKuOcvT9Uj37iowyNZYKhWKsbrmp7dOY7WVBy/lM041aKMCtAHIHQ3nQbzhULaGRYdsEHCNXdOaED+GiiNkv1FyxBwA1tA5BV4yp+oszlWKRSFsgBJEPH2jf7kA9ugQgZLJDInEqrcNtSSnGzME/DU32Ed+Cf9P4H6UsnIaZLvGhYasPLseByOKmzsohXdPLoJ4zFialCOBudyY6XFZAnoXF5dICOdQ9LdrZ1GT63g95CxMinaRrVcewUWL6CucQeCsvI+CQyQXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FA/ryM3saCmkN0TwFigDXCh2A1a+37LxJbRVvs5gNDI=; b=6y2pOegwP6auttEHc/hV+nEBAGroXmxD8XNr8nbETPg6QGwwwYnM8k2ZIgY5/EHN7yux1B6H229Sy6A8Y1f4kG9zor+QZTtVN81XQNJWLGETZJUFNf9USjzhOTF7O3behpsU7tU8cITUSWPhfDXksJiLTukfcZ8W6/MfBPRAXek= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by AS8PR08MB8780.eurprd08.prod.outlook.com (2603:10a6:20b:5bd::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.14; Fri, 17 Feb 2023 15:28:27 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::910e:e35f:b1eb:ae9]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::910e:e35f:b1eb:ae9%4]) with mapi id 15.20.6111.013; Fri, 17 Feb 2023 15:28:27 +0000 From: Honnappa Nagarahalli To: Junfeng Guo , "qi.z.zhang@intel.com" , "jingjing.wu@intel.com" , "ferruh.yigit@amd.com" , "beilei.xing@intel.com" CC: "dev@dpdk.org" , "xiaoyun.li@intel.com" , "helin.zhang@intel.com" , Rushil Gupta , Jordan Kimbrough , Jeroen de Borst , nd , Honnappa Nagarahalli , nd Subject: RE: [RFC v3 07/10] net/gve: support basic stats for DQO Thread-Topic: [RFC v3 07/10] net/gve: support basic stats for DQO Thread-Index: AQHZQqMP1F5V6b1xi0KGpKYXtWWZpK7TQ3yA Date: Fri, 17 Feb 2023 15:28:27 +0000 Message-ID: References: <20230130062642.3337239-1-junfeng.guo@intel.com> <20230217073228.340815-1-junfeng.guo@intel.com> <20230217073228.340815-8-junfeng.guo@intel.com> In-Reply-To: <20230217073228.340815-8-junfeng.guo@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: F96F4FEF87B45C48AF670CB0C0DF8CE1.0 Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: DBAPR08MB5814:EE_|AS8PR08MB8780:EE_|DBAEUR03FT054:EE_|VE1PR08MB5744:EE_ X-MS-Office365-Filtering-Correlation-Id: 215eb53a-2e19-430a-4f8e-08db10fba691 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: IMDD7hDvk4bHC3I6dFrhonY5w0oMcxKGGyMKTms8xe4L9680tUM9Vp5P6zKP+rkMnafuRDYLrLUQnHvLlKXT2j9KqFSjlZSSnfmJt6ahmmQP59ZKgjd2UV1mszJzukerW6+W7V9zN91GU4lgusIbCpQEn6sLnphGCd1JAMFv/Llebul71AzUOgBxjAJWo3WRc9iptGQ6bws5ynM2/gS3QCUZoPbHA0zg66DM58cSzVoAGSb5eO2okzePtnaSLvTmR48vZ7efeu2bLYS8CzfUERR40yRhCm24mOosTzeEHKTo8B12SS3MAO9hp7MqNC+wFjvUTnH1JzetgoJvI5MtU6dLaZI8HMZ0+efFcHy4JSqytkzBd7cShG7ROsOW0Y+Jmd3ZOvmfmKkXFCK3OwVhbcI+1PIeGHBbvK4xzunCs75slCt1Ux900DsEc4p0mno/SBe5ErLK+MvkEtdQQDMAbGXlOjCo4HyacGYUhtHNcYSXYku4mBHCUI4AOqXHTbJld6WQFE7QskrfHyROcbe2uZlnFJsNcvmUxTBD2/hHJ4jCqMmoJ7TIMT/u5bisXjG0+s64Q3M3zOynBs1r/JR7bHkPnF2CBh/LgA/+qfpfauoy+y0usswrDPJFFFqJYsqiBKg683UT1qvmwM6f8Z1t36GdOzAsV8jHUQNbjUEZBQJon0QnNQ7IQJEbG+yjt6UvmDgvQ7LntkxX1HN/ipPtcQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(39860400002)(366004)(346002)(376002)(396003)(136003)(451199018)(86362001)(38100700002)(122000001)(38070700005)(4326008)(33656002)(5660300002)(7416002)(55016003)(64756008)(8936002)(2906002)(66476007)(66946007)(8676002)(66446008)(52536014)(6506007)(66556008)(76116006)(41300700001)(9686003)(26005)(186003)(53546011)(316002)(83380400001)(54906003)(71200400001)(7696005)(478600001)(110136005); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8780 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0706a0c2-ac54-4934-ef2d-08db10fb9df0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vBW5sXpGNCzMTcf9x3zHuFfRU1uVv6UBxyIrRcIxSe5uUCSVIiJydbYHZ16G0ytvR2GYIIceerlFodaLV5r+/jAsq41lluZ0DVj/eEpf34646k/kws1Wty/vkWk9WFio0IpYYPOdRkQUARcTRk4gl5DF018dZi617OROoChfh4q8pt/t91qgpnHPNsF2oPpt/GGItu9M+WEDhnlrAmaYzN0FwoCSPTJcv0vAdKrAjVByhkXYrzuoy9G72yo1/OgzRFZhMA7bI/ECAQR1SMfj8RVfbHunisPmyqx8V+ak4btsFufO4EDJg7nxjkxXyW5toh79qJ4db7Cn/km/6oN2FqivCCW4vBNc8zTa3Wy1FnkICVXSiALAAUsjS2iYXAI0mdtk1IxHCBbTOkUOLhD4mj+a+2oddALA7BOHv1BOkZEVX4oP1cxK9MaX2Pjzma+rVpdefQSlvmWz4TCy1Rm9hI3YJ2oC1GBfoGBwRlIKz+VUwbMc2VF1EZi1oWoAh4MnOZuL4OkYbYJklAschptcUacp0wUc7MDDej38zhKZhQoKn/os3lRTWpodcU9KyxSrBOtRPyDMRet1MQ4PpbY35e/AOyjE4jca5nTNR7VtdSzfKh6/IyMQGgGJZHTjyadi71xEGma2Jz6yyfAlivAy+xSkgh70KK8pmgLjq46gwbO9/uftKe0m7ha/Tblk/FvONw8A/20/+hvLY4pUWzE+iQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230025)(4636009)(376002)(39850400004)(396003)(136003)(346002)(451199018)(36840700001)(40470700004)(46966006)(82740400003)(8676002)(70586007)(41300700001)(70206006)(33656002)(52536014)(110136005)(86362001)(54906003)(8936002)(55016003)(40480700001)(4326008)(5660300002)(356005)(478600001)(82310400005)(316002)(83380400001)(81166007)(36860700001)(40460700003)(7696005)(47076005)(26005)(9686003)(53546011)(6506007)(336012)(186003)(2906002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 15:28:42.0433 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 215eb53a-2e19-430a-4f8e-08db10fba691 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5744 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Junfeng Guo > Sent: Friday, February 17, 2023 1:32 AM > To: qi.z.zhang@intel.com; jingjing.wu@intel.com; ferruh.yigit@amd.com; > beilei.xing@intel.com > Cc: dev@dpdk.org; xiaoyun.li@intel.com; helin.zhang@intel.com; Junfeng > Guo ; Rushil Gupta ; Jordan > Kimbrough ; Jeroen de Borst > Subject: [RFC v3 07/10] net/gve: support basic stats for DQO >=20 > Add basic stats support for DQO. >=20 > Signed-off-by: Junfeng Guo > Signed-off-by: Rushil Gupta > Signed-off-by: Jordan Kimbrough > Signed-off-by: Jeroen de Borst > --- > drivers/net/gve/gve_ethdev.c | 2 ++ > drivers/net/gve/gve_rx_dqo.c | 12 +++++++++++- > drivers/net/gve/gve_tx_dqo.c | 6 ++++++ > 3 files changed, 19 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c > index 1c9d272c2b..2541738da1 100644 > --- a/drivers/net/gve/gve_ethdev.c > +++ b/drivers/net/gve/gve_ethdev.c > @@ -481,6 +481,8 @@ static const struct eth_dev_ops > gve_eth_dev_ops_dqo =3D { > .rx_queue_release =3D gve_rx_queue_release_dqo, > .tx_queue_release =3D gve_tx_queue_release_dqo, > .link_update =3D gve_link_update, > + .stats_get =3D gve_dev_stats_get, > + .stats_reset =3D gve_dev_stats_reset, ^^^^^^^^^^^^^^^^^^ I do no= t see this function in this patch > .mtu_set =3D gve_dev_mtu_set, > }; >=20 > diff --git a/drivers/net/gve/gve_rx_dqo.c b/drivers/net/gve/gve_rx_dqo.c > index a281b237a4..2a540b1ba5 100644 > --- a/drivers/net/gve/gve_rx_dqo.c > +++ b/drivers/net/gve/gve_rx_dqo.c > @@ -37,6 +37,7 @@ gve_rx_refill_dqo(struct gve_rx_queue *rxq) > next_avail =3D 0; > rxq->nb_rx_hold -=3D delta; > } else { > + rxq->no_mbufs +=3D nb_desc - next_avail; > dev =3D &rte_eth_devices[rxq->port_id]; > dev->data->rx_mbuf_alloc_failed +=3D nb_desc - > next_avail; > PMD_DRV_LOG(DEBUG, "RX mbuf alloc failed > port_id=3D%u queue_id=3D%u", @@ -57,6 +58,7 @@ gve_rx_refill_dqo(struct > gve_rx_queue *rxq) > next_avail +=3D nb_refill; > rxq->nb_rx_hold -=3D nb_refill; > } else { > + rxq->no_mbufs +=3D nb_desc - next_avail; > dev =3D &rte_eth_devices[rxq->port_id]; > dev->data->rx_mbuf_alloc_failed +=3D nb_desc - > next_avail; > PMD_DRV_LOG(DEBUG, "RX mbuf alloc failed > port_id=3D%u queue_id=3D%u", @@ -80,7 +82,9 @@ gve_rx_burst_dqo(void > *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) > uint16_t pkt_len; > uint16_t rx_id; > uint16_t nb_rx; > + uint64_t bytes; >=20 > + bytes =3D 0; > nb_rx =3D 0; > rxq =3D rx_queue; > rx_id =3D rxq->rx_tail; > @@ -94,8 +98,10 @@ gve_rx_burst_dqo(void *rx_queue, struct rte_mbuf > **rx_pkts, uint16_t nb_pkts) > if (rx_desc->generation !=3D rxq->cur_gen_bit) > break; >=20 > - if (unlikely(rx_desc->rx_error)) > + if (unlikely(rx_desc->rx_error)) { > + rxq->errors++; > continue; > + } >=20 > pkt_len =3D rx_desc->packet_len; >=20 > @@ -120,6 +126,7 @@ gve_rx_burst_dqo(void *rx_queue, struct rte_mbuf > **rx_pkts, uint16_t nb_pkts) > rxm->hash.rss =3D rte_be_to_cpu_32(rx_desc->hash); >=20 > rx_pkts[nb_rx++] =3D rxm; > + bytes +=3D pkt_len; > } >=20 > if (nb_rx > 0) { > @@ -128,6 +135,9 @@ gve_rx_burst_dqo(void *rx_queue, struct rte_mbuf > **rx_pkts, uint16_t nb_pkts) > rxq->next_avail =3D rx_id_bufq; >=20 > gve_rx_refill_dqo(rxq); > + > + rxq->packets +=3D nb_rx; > + rxq->bytes +=3D bytes; > } >=20 > return nb_rx; > diff --git a/drivers/net/gve/gve_tx_dqo.c b/drivers/net/gve/gve_tx_dqo.c > index af43ff870a..450cf71a6b 100644 > --- a/drivers/net/gve/gve_tx_dqo.c > +++ b/drivers/net/gve/gve_tx_dqo.c > @@ -80,10 +80,12 @@ gve_tx_burst_dqo(void *tx_queue, struct rte_mbuf > **tx_pkts, uint16_t nb_pkts) > uint16_t nb_used; > uint16_t tx_id; > uint16_t sw_id; > + uint64_t bytes; >=20 > sw_ring =3D txq->sw_ring; > txr =3D txq->tx_ring; >=20 > + bytes =3D 0; > mask =3D txq->nb_tx_desc - 1; > sw_mask =3D txq->sw_size - 1; > tx_id =3D txq->tx_tail; > @@ -118,6 +120,7 @@ gve_tx_burst_dqo(void *tx_queue, struct rte_mbuf > **tx_pkts, uint16_t nb_pkts) > tx_id =3D (tx_id + 1) & mask; > sw_id =3D (sw_id + 1) & sw_mask; >=20 > + bytes +=3D tx_pkt->pkt_len; > tx_pkt =3D tx_pkt->next; > } while (tx_pkt); >=20 > @@ -141,6 +144,9 @@ gve_tx_burst_dqo(void *tx_queue, struct rte_mbuf > **tx_pkts, uint16_t nb_pkts) > rte_write32(tx_id, txq->qtx_tail); > txq->tx_tail =3D tx_id; > txq->sw_tail =3D sw_id; > + > + txq->packets +=3D nb_tx; > + txq->bytes +=3D bytes; > } >=20 > return nb_tx; > -- > 2.34.1