From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93AD4A0A0C; Thu, 1 Jul 2021 00:41:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 16E6840141; Thu, 1 Jul 2021 00:41:18 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2048.outbound.protection.outlook.com [40.107.20.48]) by mails.dpdk.org (Postfix) with ESMTP id 2FC5C40040; Thu, 1 Jul 2021 00:41:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x+vRPw3P0k8PBVUIGtLFx4/cPWjG3OAX/gRtGtiRFwg=; b=1LBgHgAyYB1zo7KGiGH/RJEZ2grmhqSjHDk4xiZMj4a10WMIHxJHpTfid5vLKfFznbJenWcPDDROZkBd9GTLPB3yKSRglsjfPWBNmBAATo66qhvkKsOlt0xy4ZFngo8WY+yrJZ4FASpQP01lFA4WBauOUXJIHoNu9xK4ZCS/Eqc= Received: from AM5PR0502CA0014.eurprd05.prod.outlook.com (2603:10a6:203:91::24) by AM5PR0802MB2611.eurprd08.prod.outlook.com (2603:10a6:203:a2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.20; Wed, 30 Jun 2021 22:41:15 +0000 Received: from AM5EUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:91:cafe::85) by AM5PR0502CA0014.outlook.office365.com (2603:10a6:203:91::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Wed, 30 Jun 2021 22:41:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT028.mail.protection.outlook.com (10.152.16.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Wed, 30 Jun 2021 22:41:14 +0000 Received: ("Tessian outbound 5d90d3e3ebc7:v97"); Wed, 30 Jun 2021 22:41:14 +0000 X-CR-MTA-TID: 64aa7808 Received: from aebf50808cf3.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4DA3FDCB-2A57-4C49-A64A-11CBB39CC30A.1; Wed, 30 Jun 2021 22:41:05 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id aebf50808cf3.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 30 Jun 2021 22:41:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OZpLWMlXKhGzxMfq26KjOz6YOUJ1m0SIn6O5jSKkqo5k/sLaoJCYRciSUaUB5fl4u9J02ZdospwTK/pRcve8NZsd52wSSayEMyVZA2m/aIgSN7WjfkJMYCG0HvgdQpHkdOOjFOuJkVpLLwTSE6ao/AmR28bnj9XuycgAfqUaxumtch9zTJY245tv6yVEwq+OKKsltJr0k/LudOvqQpHUsTvmf3NyDvy1nb35dzM8cuS/aG44hA4qIsseKrFM+8jrEkeij6cqgkFPsZHY2PTjVENXl3FXk0uK42txsDqmP5vmckTM0v6bIW442TbOc3upRINByTnOIvterDBmBJ5BCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x+vRPw3P0k8PBVUIGtLFx4/cPWjG3OAX/gRtGtiRFwg=; b=UNlMb59iYK0xiOkpvtg1jogVAwK+ZVzbjuuDazT9otClreAA0d6+sRQXxibyppEq/MbEcAJiCV9oqO5mahNbfLTC6pwMp9OPhpgb854qktF6LMEgBHHGHZvZJ5cL6/0moTpLCy7YunLV37Nh/kYeTqU8PBOWs6qJ/NIuodiW9/grjghoWDR0g3faKpPC8RvMECYPlnaZtWotWsYP/RFB40lwYqObsZ8vjy7mkLVCRPepsJ894mG55RqabVLiPemqHl2BcPyj2GNMPgPspgOfWX1jfc3LuOF2OPkdXt9ncq2UWwgldk8HXJ5QUfFCdJhefkhyKE5RzNf4PRgo6XNp7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x+vRPw3P0k8PBVUIGtLFx4/cPWjG3OAX/gRtGtiRFwg=; b=1LBgHgAyYB1zo7KGiGH/RJEZ2grmhqSjHDk4xiZMj4a10WMIHxJHpTfid5vLKfFznbJenWcPDDROZkBd9GTLPB3yKSRglsjfPWBNmBAATo66qhvkKsOlt0xy4ZFngo8WY+yrJZ4FASpQP01lFA4WBauOUXJIHoNu9xK4ZCS/Eqc= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB8PR08MB5097.eurprd08.prod.outlook.com (2603:10a6:10:38::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.20; Wed, 30 Jun 2021 22:41:00 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::f15f:821c:74c5:2482]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::f15f:821c:74c5:2482%2]) with mapi id 15.20.4287.023; Wed, 30 Jun 2021 22:41:00 +0000 From: Honnappa Nagarahalli To: Tyler Retzlaff CC: "thomas@monjalon.net" , Joyce Kong , "dev@dpdk.org" , "david.marchand@redhat.com" , "stephen@networkplumber.org" , "olivier.matz@6wind.com" , "andrew.rybchenko@oktetlabs.ru" , "harry.van.haaren@intel.com" , Ruifeng Wang , nd , "techboard@dpdk.org" , nd Thread-Topic: [dpdk-dev] [PATCH v2 0/8] use GCC's C11 atomic builtins for test Thread-Index: AQHXYlsX55q9L1IEsEyhls7s9yhriasYVEyAgACD8ECACJcSgIAJ3QFwgAGwv4CAAAHDMIAAC3EAgAALihCAABkigIAACLxg Date: Wed, 30 Jun 2021 22:41:00 +0000 Message-ID: References: <20210604094624.31308-1-joyce.kong@arm.com> <20210617152155.GD29777@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <7557795.l8Y19qOmnl@thomas> <20210630185107.GA14701@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20210630193822.GA21590@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20210630214937.GA15829@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20210630214937.GA15829@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: E5A19A79BCD3B64A9A2C753CA556ABC9.0 x-checkrecipientchecked: true Authentication-Results-Original: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [70.113.13.105] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 39433d3d-328d-4599-7df3-08d93c182ae8 x-ms-traffictypediagnostic: DB8PR08MB5097:|AM5PR0802MB2611: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: v+4D+eswrwBmjQHEDEqT/EtmU4UeZIM4K3cMYu1ABEV4HtPJS4cYqp7eovxBahKQua/rgIZ36rYFLNQYdlGIry4FXCaI2lDPjj5lSW2e1W/Qo4fRTbnRbemkGdNdaEzFgNKjLCJUi8UW0MgHrFHVmHx365pjt2Xsa/czoY9POFSckvccF1tsj1Fmk7Gg2UCOq3IIvrbTyaWEPYTJC/onVO6ORQpb/NuqXDc3bOyCmbrCbn8ECmFtUxNJ5v+jxfcyOUpMXNDS80g9OVJqps5YGCaz73AE2m7j/zagh3DFGEIFK+DvMKw4TwVR1h0qlBvYzDet8pGV3iXi4MM/oa0TQ//XGtpwp5QvHD9boznXWRdPPJBemjf0mlfg7vPyV7yyk17N4NNSzT/qtb2xcf8Srd5fYqyJQzjlK3+WZIQwTWzyCfgAXxi8F41+VNLz6PP9z0vspj6XI4IWdqNdXXavVZ4eFlnG60RigRvhas+Pzg3hQ2q+0oAlzv1u32qD59RcvznlarjCYs/aFN9YrsSwIetvawW16VkBBDGhelRzo6VhVIiibfl4Gjhck+Hp6yFBNmLuuhWuY9pm2i6x3coW67Rgk+y43w/IyKl7Zoy/sgUBi5s0vGugsiMOkF5cxQt/ahs+2ZJ9UAr68oDwY0VUsiiSFALJR8s9UNIMCZQuYqUe3f6WqFP5p1MlMU0MPjKv3NF9Xei1UwSNpLNVyHmh1pYIIEg3GykvEkzpH11610PNGTF5HxMGY+FzNhG29Waf03JC1bzeMWfqXN2a8e4QyA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39850400004)(136003)(376002)(366004)(346002)(396003)(966005)(33656002)(8936002)(83380400001)(5660300002)(122000001)(64756008)(66446008)(66556008)(6506007)(478600001)(66476007)(38100700002)(66946007)(71200400001)(76116006)(86362001)(6916009)(54906003)(7696005)(2906002)(8676002)(4326008)(26005)(55016002)(9686003)(52536014)(186003)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3xUaOOmfjuMq1y8ijf9+6Zt2mnjj/qGFhF5lyAg09Ob4TQziP8lIeoH9KS5D?= =?us-ascii?Q?SrmWdU4C0gpMZsMViKa1NyXiyr59m5pFo/46oL3AWhd5BjKd8M1C6r5Px4Yg?= =?us-ascii?Q?czOTxM5OffwbMJ7zuy00tZYQ4RxC892SATazyXYniWhcIonES//lwhjn3WsH?= =?us-ascii?Q?efVery7Cd2zFX3coHeMHykfZh1xsSIubJKa/6yKcEyRXlVaTdswEFLZwHIsA?= =?us-ascii?Q?twjSzJEpOvmEuaM95kvRYJGZ0xl44Glgxm5yDzQBjTaHlgTiI9ZFNQmhLv4S?= =?us-ascii?Q?R6mx1GiQWxtvGS+OJ8XjytCRbKLrNOvsRKTdsGAgr+cEwYj3tzK1MheLhFdP?= =?us-ascii?Q?m6AYCUFVgk+uyYg0CxAkfa+Z1Jd44WWx5FfEwusQBUsxSb2Tv9e5fbpLs6YG?= =?us-ascii?Q?GrNSJTOb7L74UwQJXpuK3HTVS+bkTpoaWHxBnFZM9yxWf5CLAT6jOFC9KInX?= =?us-ascii?Q?1/udQZt9LQ7QXWcDXrDut4jftt8TNUCuXwSP6wGLq4gf3etccf23+fpiNvwx?= =?us-ascii?Q?7bTiNBicI33PVUcTgMekMoYF748hspDT6rUNY8MlbWGY2WEY0mZztzK11oRl?= =?us-ascii?Q?/aWpBDq1lCQgmlvqcK1sNortDkbYU3gVjMqnXbl+WGKUKIx9HoELart3iL9h?= =?us-ascii?Q?GkQ5j+vzt49or5XqKaN3ipR6xXCIMzi1tiSZpKu2ybOTZpEmmar6+My+nhSx?= =?us-ascii?Q?qW3rs0j2KyywHHCOqUAGmhWA9daN5AE4dGZwmSh5GTcjCPki2Aj3w5gMhCtx?= =?us-ascii?Q?HovyxzP957RzpzqRftMTOUEPHNRwHvUQCIto47UV6J68Ya1+5yBqc69KgB/Q?= =?us-ascii?Q?jOU/EQjujIGUuIcYKE2bnPyw+lbHZXsCwJWip/BhufpnHomBYAseMeqU52lB?= =?us-ascii?Q?Gtoo9U2jKFvZczB0AP3fRn4oeYt+HPol6AKDKBf890QZJfja9rSNz5CA6qqo?= =?us-ascii?Q?pu9IvKs8G+0GBQePsw4gtnh5t+XfoLkxgOljiwXTzHOQzHpoBZv/0rKCZ2rD?= =?us-ascii?Q?Msx7RIjh5UP5XCeB51ft/m84Z42QkbjuD+ad7hd3fg0U7qUxPc/Q4+M9uKyh?= =?us-ascii?Q?GYVdF0ARt1fyJBId/rMo72gsBpPl1sClo81jR9xqcUOMFyHwMCoRFqBOEarQ?= =?us-ascii?Q?VWDCvWX27QJf7VMjV3Am8aVTVAWsAlPHI2c82ItiNDMPCGFu3+CrnuC/USqo?= =?us-ascii?Q?6VCzlM6vSe+PoeqTAdE6f17fdq9QW4NyzsiHtpgRPrDpmHCjXuHzoB8JGa41?= =?us-ascii?Q?WclFbCnzmWcJ8ljpwyfVnBL0NC82nZPJp3hbY+jdn6vSa4N/mfbL5Ng4lKtt?= =?us-ascii?Q?y5a6gRTholRjncJfD/LpdJ30?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5097 Original-Authentication-Results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: c6c02029-41ba-4d79-b74c-08d93c1822ae X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X57hbjq1zwbjuNi1arQdPx9AAzEAvwRjyMJKSHvntoXdzFtpA9yNe/C4dV+96hmmcXxKczywAkQF/+DmWDGw6g6jOIqD6cGosknwj2+TRLAvnL5/vJq1JNph4zuMrHwYQz2Mbco8CYqn5o42C2yEyBiEbtv1hV2NSst6U+8hYTRVGgNxVv2jmnpcMxXw1fDDbN6SG3A0ClTlNcB/fGbesR6v5u9UHUJa1NDnP4j/TG6tMIcgqM9xuzhSTKY/tehCmrqgtDQTxjV+qP6KkrM4H/4TlMwatlC58+u2KY6sBU95EpAf0dZbVMp5rMBHgB9ZsitgPabx3qyqOhGEC6t9NTFuQpfuYDgi9qgVTCx41v+hjsS7p+mi03TNC4X91S99p2ey+a1HrqgrqExcbIHpmZfDmjV0JJ/dRsmcNk6oK2bR7gbBxmJ9BsewfSZ+feRwIcEOrhTwIkkFKvfN7z4VSDWEI+MaPMD+YLkQJLtamg1Jshf9Gsb6WLVUGdg9DAvbJpiehalxCNh+3k/a/1HfB0D+hRau+3CMYa7Li3UnEzwhTjymtRgibIAUcoE03HUNiJgdCPEcPOy9u9OMmCyM1k2gWZ9LBelJSpxrrpTD76V/pjg/ytNEDQDAK4hP7FV4+4dIhmWum3zEVwNEFLi3CGUy1TdC0QIfs0RKs9++I83d6LyUNijWuPrKslvD3N7v6xpQrhyc2ljHjLnl2uYiGGCuiy4gs+XXpK1XK63V4G+82kyqWz99TRniPbM920c2hp9uwb5jOiDIoL9TUAk+F6k6ayMVdjAS2ezpjZhVNV+UZl8RwnHTdWQ41oUTAc0qeffCfAbtdxBT9p6BPuF/ow== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(39850400004)(376002)(346002)(136003)(396003)(36840700001)(46966006)(186003)(83380400001)(86362001)(336012)(5660300002)(8676002)(54906003)(52536014)(33656002)(82740400003)(6506007)(55016002)(81166007)(26005)(9686003)(356005)(82310400003)(36860700001)(6862004)(316002)(70586007)(478600001)(450100002)(4326008)(47076005)(2906002)(966005)(7696005)(70206006)(8936002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2021 22:41:14.5527 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 39433d3d-328d-4599-7df3-08d93c182ae8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2611 Subject: Re: [dpdk-dev] [PATCH v2 0/8] use GCC's C11 atomic builtins for test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > > > > > > > As I mentioned earlier in this thread, GCC supports 2 types of > > > > atomics. "Use GCC atomic builtins" does not help distinguish > > > > between them. In "GCC's C11 atomic builtins" - "C11" indicates > > > > which atomics we are using, "atomic builtins" indicates that we > > > > are NOT using APIs from stdatomic.h > > > > > > if you need a term to distinguish the two sets of atomics in gcc you > > > can qualify it with "Memory Model Aware" which is straight from the g= cc > manual. > > "Memory model aware" sounds too generic. The same page [1] also makes > it clear that the built-in functions match the requirements for the C11 > memory model. >=20 > allow me to put your interpretation of the manual that you linked side by= side > with what the manual text actually says verbatim. >=20 > your text from above > "built-in functions match the requirements for the C11 memory model." >=20 > the actual text from your link > "built-in functions approximately match the requirements for the C++11 > memory model." >=20 > * you've chosen to drop approximately from the wording to try and make > your argument. I am not sure how this makes a difference to our arguments. For ex: there a= re no other built in functions that "exactly" match the C++11 memory model = supported by GCC. >=20 > * you've also chosen to substitute C11 in place of C++11. again > presumably for the same reason. >=20 > in fact the entire page does not mention C11 even once, it also goes on t= o > highlight a specific deviation from C++11 with this excerpt "because of a > deficiency in C++11's semantics for memory_order_consume" I do not have a problem to call it C++11. IMO, calling it "GCC's C++11 ..."= will address this deviation and the approximation. >=20 > > There are also several patches merged in the past which do not use the = term > "memory model aware". I would prefer to be consistent. >=20 > i prefer the history represent the change. that previous submitters and > reviewers lacked precision is not my concern nor is consistency a reason = to > continue documenting history incorrectly. Ok. As I mentioned, it is just my preference. >=20 > i'm waiting to ack the change, it's up to you. you've already spent more = time > arguing than it would have taken to submit a v2 correcting the problem. I am not arguing for the sake of arguing. You are trying to correct few mis= takes here (I truly appreciate that) and I am trying to explain my POV and = making corrections as needed. I am sure we will conclude soon. >=20 > > > > [1] https://gcc.gnu.org/onlinedocs/gcc/_005f_005fatomic-Builtins.html