From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9FF1A0547; Fri, 10 Sep 2021 01:38:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A45C4067E; Fri, 10 Sep 2021 01:38:12 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50082.outbound.protection.outlook.com [40.107.5.82]) by mails.dpdk.org (Postfix) with ESMTP id 2BF734003F; Fri, 10 Sep 2021 01:38:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZOWYqn3KQAq8tNz0OQs4PkZPvbCbJt+RqCgCpOuHbq4=; b=hUtoTPRpo8EJEzgcKsTGCdHENoETjCOSU9Wg6Y/24zDbhgUX+KOfRcumuWs1IT4r7KoF4cDXnKNHrxUszVgS0GrgqY8KUvMqh0HtbNGZQBklaoGrfEUHwOVe/c6JU/Z6oRlwiosTvd10hvgK3/RFq5kE6NT1xPB2xfM6HeHWOOU= Received: from AM0PR02CA0101.eurprd02.prod.outlook.com (2603:10a6:208:154::42) by DB7PR08MB3163.eurprd08.prod.outlook.com (2603:10a6:5:1e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Thu, 9 Sep 2021 23:37:58 +0000 Received: from VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:154:cafe::6e) by AM0PR02CA0101.outlook.office365.com (2603:10a6:208:154::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Thu, 9 Sep 2021 23:37:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT043.mail.protection.outlook.com (10.152.19.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Thu, 9 Sep 2021 23:37:57 +0000 Received: ("Tessian outbound f1898412aff1:v103"); Thu, 09 Sep 2021 23:37:57 +0000 X-CR-MTA-TID: 64aa7808 Received: from a84d7ae4fd0a.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C84E5980-7ADE-4E20-94C8-B3F660376F20.1; Thu, 09 Sep 2021 23:37:51 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a84d7ae4fd0a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 09 Sep 2021 23:37:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GWHvXxNFzzpwKPJ6T8GYzZA8siVDkCmvWwqegks9pk2oUnS+PbHkCKCVOpUEw8sI2TciPS8D5KRITDHh1fwwqMmkx1wY4e4+k7oYudT0KHRm5ERjjBngrXLFQV0CMz2/llAgfVtsQZeuejN19XNXmd5mW7NW6u7kS56KgLTPBS0S4TwZ563uXragvq1sISGeYw8WmEtUrKYIxTORZNBBTwZi0EeTdcphasQCHdwSyb04CC3oASb3rr2gkI/8B8KJV3rhGP3VQ2OMJypqbH0vUmCqFXQswzy0OuRK+FtXUjIb0BvzO2CUsNh186uzK2xgfQ/0itCuVmw+Mk9thLdRkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ZOWYqn3KQAq8tNz0OQs4PkZPvbCbJt+RqCgCpOuHbq4=; b=aENCHOpatiiBwkbADLqmsqSxi7BicxsBcfSXF3UkFEcK7OdQ/Vww1MsxudBnvPnhtSc7BkL9IMh1CzueI5BF8O2uWviqSLOKI6X3nrAMpGzs/iTswUq3IiXry1TvaUj5iP0kQh6NQnne7GI5cdvSZn+ECtcGvrt9rdbqD/SOnSfBqJTHyVBAVSiTudybo/IuntYu3tov8nlt23RORLirA+AKuJ9rlr202zfNQxPi6gYE+2lkuni0dPXvVvavqumMC3eW3epbIzZQQDOqneTpZGbMz6K7s1IECA2Qb7k4YkP9PpSyKFzZjzeg39zA2v72NRdnW7cbwYpAVRsWJXq9vw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZOWYqn3KQAq8tNz0OQs4PkZPvbCbJt+RqCgCpOuHbq4=; b=hUtoTPRpo8EJEzgcKsTGCdHENoETjCOSU9Wg6Y/24zDbhgUX+KOfRcumuWs1IT4r7KoF4cDXnKNHrxUszVgS0GrgqY8KUvMqh0HtbNGZQBklaoGrfEUHwOVe/c6JU/Z6oRlwiosTvd10hvgK3/RFq5kE6NT1xPB2xfM6HeHWOOU= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB9PR08MB7037.eurprd08.prod.outlook.com (2603:10a6:10:2cd::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Thu, 9 Sep 2021 23:37:49 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::8187:ccbc:30d:3464]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::8187:ccbc:30d:3464%6]) with mapi id 15.20.4500.015; Thu, 9 Sep 2021 23:37:49 +0000 From: Honnappa Nagarahalli To: Honnappa Nagarahalli , "dev@dpdk.org" , "konstantin.ananyev@intel.com" , "david.marchand@redhat.com" , Feifei Wang , "techboard@dpdk.org" CC: Ruifeng Wang , nd , "Feifei Wang (Arm Technology China)" , nd Thread-Topic: [PATCH v2 4/6] eal: update rte_eal_wait_lcore definition Thread-Index: AQHXpdBi37b9e7fPmUm2fUIpL+ghFqucWt+w Date: Thu, 9 Sep 2021 23:37:48 +0000 Message-ID: References: <20210224212018.17576-1-honnappa.nagarahalli@arm.com> <20210909231312.2572006-1-honnappa.nagarahalli@arm.com> <20210909231312.2572006-5-honnappa.nagarahalli@arm.com> In-Reply-To: <20210909231312.2572006-5-honnappa.nagarahalli@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 5358F2C13F4AF84F8F3084DB6FBA3651.0 x-checkrecipientchecked: true Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: b1d1eb30-bb24-4b3f-ee6a-08d973eadae4 x-ms-traffictypediagnostic: DB9PR08MB7037:|DB7PR08MB3163: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: luP/bmC2AbT5BMewqbFBMVHZ2v7M7dwgjiJJYCvzjASjZHJXHBuUidpHRA1h/5RTAnePLMhmjKXnSO9FmVLrbSvyqqXQTsJMt+GxO9zBXjag++CjuhlKp2Aw1Mm9c3sadp3dr46fIRFkax9afeWqe33+Q/Uz8PW8qTDnQHTY8PtPLwf776uagOiiQ2E458nzj7GpoMhjqnbTCsGfn9jpPbS+qtsyk7rQL5fit5MiyRIN2ZB1dMfeZe9VkNW8iVLOnQqRLngKyE1IeLbvuP0RFheyZekdgx9K5gSl3Ufs4hOUuMExHsBTkDK1eTTOG1qWZ/eVhR/8aeDkdve3fCtCgjLZ8EIfXc5UWQ9KyY14LFbk70t1z1fmnQhymH8cnJGuDUKyQta2SqBfiky8C6RYoPw/YNE5pX3cAwx6tI5t059vcFqPHqte2xlxWUP2U0w6XOuXd+0LgupHMcw+HXykt2a+v1FsUQS+w2GRoKE+lYw2BaMhsertyrR66JJQbSzF06DjKQXrg7PmyrRbUKFJNaS4lY06B0bDZOvMeoFC1n0xi6oe94pWZjFs8VG4zpvOGdGEgKWC/OTAQllXyjpM25KGibJRBItMfTLbcrOlZjIHsGVnXzxXFesgHt55lnaiaO+MpADU9nJdAPeI1QHt9RA/rpxJt1JeCMMAn4doGw+qyn4XgrncHXgHRWjbmu1iZds6EMU2b9yKXf7qkwnMrQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(396003)(39860400002)(366004)(136003)(376002)(7696005)(86362001)(26005)(186003)(76116006)(71200400001)(122000001)(83380400001)(8936002)(2906002)(38070700005)(6506007)(15650500001)(52536014)(53546011)(66476007)(38100700002)(9686003)(478600001)(4326008)(54906003)(66556008)(8676002)(64756008)(66946007)(33656002)(66446008)(316002)(55016002)(110136005)(5660300002); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7037 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 7e6406af-057b-4c3a-7742-08d973ead574 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: chiYTGMlY5wF315Ba5IPQF0ahzsAMxxWMvOiSf4+A+Gbm5pDtW1fSD8L/iK+iltMJW7xd8X0ul+irrb1QQCumtVA6/o11IsG/4FI5k+VGy8xzHWk/7Xn2ZX0RWgoHwr3FkGMd5Uplaq97en+GdzdXa3D2yOaYGZ0KH6POSpAZhXwt6MCRCD0ilZZg5CuXR30KXGScPnRDA9Ez45DXE4kEYRmudKaTlapvxEhNwo5rH0Tn68jqdDcm3etulj00qthQ7+Dzp04ZjMFj0JddMutq0Jp/efXAUJQwpUTTWw8BfsbY6pa+RIdRoXa+jm7GfDPjF1e8EZYc7r0ajzoNVxcBi9albEONO2mLUphJOtgmXsEVqDH0LYW/+mb63dT8SQsmFoZlCsOj/X8tKc9+D2Yn0LP3+YB8VO1Y+CFY/qcStVrl+T8ZKjqT3plcQNXMFDdC8rGIgf9FmWqjxHMU1U9Lp/UFSXSHO/kdGV/kiQfRBXHT6aB6CjvUWZrH1lRb5r7XTfbY46bw2U0BxvUQCd8B0R5RRCvhE6+LCbdkxnu7PHPI3uaaLxbDFPZdNC/rL/Dh3R4b3uagBnm7MqdzonjTLsmk4KeKuv4bz0XCPaAlkv6k+hlpGmQ6hqkMOIByo+7FoXfCHueBktKG3r5bR4UlBf9t/WThEDcjXj7+ZMP2U/ntcbs+5tFV63b/A7AsPEI7wX8SmXiAEzPRz09B6aGUw== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(39860400002)(346002)(136003)(376002)(396003)(46966006)(36840700001)(53546011)(478600001)(186003)(47076005)(36860700001)(26005)(33656002)(6506007)(83380400001)(7696005)(52536014)(356005)(110136005)(81166007)(5660300002)(2906002)(54906003)(8936002)(15650500001)(8676002)(316002)(4326008)(70586007)(336012)(82310400003)(450100002)(9686003)(86362001)(70206006)(82740400003)(55016002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2021 23:37:57.9994 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b1d1eb30-bb24-4b3f-ee6a-08d973eadae4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3163 Subject: Re: [dpdk-dev] [PATCH v2 4/6] eal: update rte_eal_wait_lcore definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" + Techboard. This is the API (not ABI as I mentioned) compatibility breakage that I ment= ioned during the last Techboard meeting. The removal of the FINISHED state itself was announced. This is a change re= lated to that. However, the specific API change was not called out in the d= eprecation notice. > -----Original Message----- > From: Honnappa Nagarahalli > Sent: Thursday, September 9, 2021 6:13 PM > To: dev@dpdk.org; Honnappa Nagarahalli > ; konstantin.ananyev@intel.com; > david.marchand@redhat.com; Feifei Wang > Cc: Ruifeng Wang ; nd ; Feifei > Wang (Arm Technology China) > Subject: [PATCH v2 4/6] eal: update rte_eal_wait_lcore definition >=20 > Since the FINISHED state is removed, the API rte_eal_wait_lcore is update= d to > always return the status of the last function that ran in the worker core= . >=20 > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Feifei Wang > --- > lib/eal/common/eal_common_launch.c | 6 ++---- > lib/eal/include/rte_launch.h | 12 +++++------- > 2 files changed, 7 insertions(+), 11 deletions(-) >=20 > diff --git a/lib/eal/common/eal_common_launch.c > b/lib/eal/common/eal_common_launch.c > index 78fd940267..4bc842417a 100644 > --- a/lib/eal/common/eal_common_launch.c > +++ b/lib/eal/common/eal_common_launch.c > @@ -23,10 +23,8 @@ > int > rte_eal_wait_lcore(unsigned worker_id) > { > - if (lcore_config[worker_id].state =3D=3D WAIT) > - return 0; > - > - while (lcore_config[worker_id].state !=3D WAIT) > + while (__atomic_load_n(&lcore_config[worker_id].state, > + __ATOMIC_ACQUIRE) !=3D WAIT) > rte_pause(); >=20 > rte_rmb(); > diff --git a/lib/eal/include/rte_launch.h b/lib/eal/include/rte_launch.h = index > ed0bb4762a..f2d386e6e2 100644 > --- a/lib/eal/include/rte_launch.h > +++ b/lib/eal/include/rte_launch.h > @@ -119,18 +119,16 @@ enum rte_lcore_state_t > rte_eal_get_lcore_state(unsigned int worker_id); > * > * To be executed on the MAIN lcore only. > * > - * If the worker lcore identified by the worker_id is in a FINISHED stat= e, > - * switch to the WAIT state. If the lcore is in RUNNING state, wait unti= l > - * the lcore finishes its job and moves to the FINISHED state. > + * If the lcore identified by the worker_id is in RUNNING state, wait > + until > + * the lcore finishes its job and moves to the WAIT state. > * > * @param worker_id > * The identifier of the lcore. > * @return > - * - 0: If the lcore identified by the worker_id is in a WAIT state. > + * - 0: If the remote launch function was never called on the lcore > + * identified by the worker_id. > * - The value that was returned by the previous remote launch > - * function call if the lcore identified by the worker_id was in a > - * FINISHED or RUNNING state. In this case, it changes the state > - * of the lcore to WAIT. > + * function call. > */ > int rte_eal_wait_lcore(unsigned worker_id); >=20 > -- > 2.25.1