From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3EF7E430BA; Mon, 21 Aug 2023 06:40:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BCA1D40EE3; Mon, 21 Aug 2023 06:40:30 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2081.outbound.protection.outlook.com [40.107.20.81]) by mails.dpdk.org (Postfix) with ESMTP id B64FB40A7D for ; Mon, 21 Aug 2023 06:40:28 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nxo5gyLjn8dNuYRnUQfCtobTkylQIcTxWtwHLwOexiH8OO4drQtJ9Ct/6Z1YJn6diqyhADyKB1CQUntUQ3ynCMOMfRW3D4QYJExWoQeRkCqLf5rRhWL8SHerhx3cIxByv4d1VS5GZVmTj9XCGwoVQzZZzmRSenNK9N9xkqHxqGnpxcR9p9G5HvrAW7gW4SHOIIlEASJen9r8PGDJWY42Qvf31S5/ynvjhi0GszKxXqTlf/LTWc/zq9TJfsF34vPG36NoSJ/3igGZwsIsxvVQfC1k0EUHrxf1SOtaCDf/4AJHCWXl+8pBYncuPmaKF4FB9nlNaJKWth1C2IkN9eIA3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KZLccpwqw0gauCtmHJlfizMq18v6hSt7I0hmz7LvwfY=; b=Lw5BIrFFeU0/0Ebggl7k0+YEwoY6vLh0hX7KeZ8QWcxCgtdwGPRj0w+pShxbfnFsaYc0AK2o2ko0+R0ENvEgskWtDtszZ1WEUvfjP/12qtWLjlxo5lHypZeUGPlIOW0HkN6Z2aw3EzpHwbZF3XQskw7rVvj5PeeRg4HEekJum/yG5xMW8oSJMt6oaY+Iavbf749tLrZguw1uS6aKjD0A6dZr4gUuAXN2GfSWVJO3/YJyuVF8Z4u7xyikGZRI6IbvqNTUitWlJEFZsBItEkvTOFGkvhMozWk9qjrpHSVFnq5Wd466730Vg7NRp6Z7NkCk/55gnCRan2M7VGASetnd9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KZLccpwqw0gauCtmHJlfizMq18v6hSt7I0hmz7LvwfY=; b=q6MnaQ9t4rdwINQGc7qVe3gMISixD4BYS9PV7NmrwYvN6BUK7eNUmZLo9moJJjVwelvKKG6RBp5S6Ub6OLpAoOVFi77TdVVh64IIJQhhb74n+ielIWbKs+jIW+nxJaSoxyoJQHaqEBifji9/1SR79Hq0/JfQgQCh4R0pGJ/jl8M= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by AS8PR08MB9044.eurprd08.prod.outlook.com (2603:10a6:20b:5c0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.24; Mon, 21 Aug 2023 04:40:26 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::b3a3:eb56:481f:99c2]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::b3a3:eb56:481f:99c2%4]) with mapi id 15.20.6699.022; Mon, 21 Aug 2023 04:40:26 +0000 From: Honnappa Nagarahalli To: =?iso-8859-1?Q?Morten_Br=F8rup?= , "dev@dpdk.org" CC: "konstantin.v.ananyev@yandex.ru" , Wathsala Wathawana Vithanage , nd , nd Subject: RE: Ring library optimization idea Thread-Topic: Ring library optimization idea Thread-Index: AdnTSADDofJIeE2PSx6EnyX+/hQSngAiil6Q Date: Mon, 21 Aug 2023 04:40:25 +0000 Message-ID: References: <98CBD80474FA8B44BF855DF32C47DC35D87B21@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87B21@smartserver.smartshare.dk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: B5DA6EB6358AB04EACE10AEDD7BBC014.0 x-checkrecipientchecked: true authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DBAPR08MB5814:EE_|AS8PR08MB9044:EE_ x-ms-office365-filtering-correlation-id: 243206a7-c281-44d0-859d-08dba200bd26 nodisclaimer: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 51JHO17B6jpDFfKeZTPrPLOuF1LA5OhTbdc1OTvnrttuanshd7oUlebN8psN8/vkYHdy+4vhhu1y+pomkPsj3YPbzuSFWvxColJihvCPmaSSXaxPiaTD91rKKG1R2jLlfuvlQYKXP1sLOQpToHKEByOS4uFQCBLCgej5Xu3KxLSsYbGwp5z2Ei9s0VrGnIF+gK5AmTwRdkKnVLgCu0zhZqpk6UtQDlCuZx86mKuq85ieXTt98ra9//U6piRYlXOtinhdFNkiYuzNyel1BbjBsRyoL9IPKF+PxvBW5Sfmhr2vfnQAjSbxezznbpa/kcV0BqwcULB7Noj7CxiN/GpHTBqIRHtNBNHaIPsjzzL1pi4XYzkpZrBCrZZ5yfjO02c1y2tbx0mM6E8mPR/spR2DKNiqUB7CYlEsbiu5iJ7iBWqXz6ml5zTdvXuM0UhRTL0xyURtNO2fKg3Dl2/wZ5cJEQKnJZT6UP6IcqwccFLwA/v9yGH06uTNR4JWoYRx5ZQbTg3YjULsf5y+D9rcTzDXjqubveklQy7ZFAi5Ir5stFQylxTzWuzUtza5fHyn/8XgGvZhVhcZDj9dmxpSGhzP597n8FoP8gkuXr8mkmeK9s5gHoJYm5oeurud+AjETEuskeypTzwa4o7skgOj+NXNmQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(136003)(376002)(346002)(366004)(39860400002)(186009)(1800799009)(451199024)(66446008)(66476007)(64756008)(54906003)(76116006)(66556008)(66946007)(316002)(9686003)(110136005)(8676002)(8936002)(4326008)(41300700001)(122000001)(478600001)(71200400001)(55016003)(38070700005)(7696005)(38100700002)(53546011)(6506007)(66574015)(2906002)(3480700007)(83380400001)(86362001)(5660300002)(33656002)(26005)(52536014)(23180200003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?ArshRRo0L3X7LM6Q1ET+bKhBVr68Qiv7PsPIc5zficp3VyyQigOrqYVfgU?= =?iso-8859-1?Q?fD4hq5NHl9H0wy2tjhCq03R/VrYSXhGqgfLVmeXT6Zcyjpb1YX0RnR7l8R?= =?iso-8859-1?Q?trwOoeSfBDtdyx1Divf01/GoE4towPvrmK6gIvkye2eKDWSp/iCt7dm85p?= =?iso-8859-1?Q?oTxE2r24X+PJlmwlE1wZsWfThWlQuFoY4Bq9IY+ArRmWlTSn4vSOfJesaH?= =?iso-8859-1?Q?4KGCgxfLTvK30h4SgmXn+vzaVb4DhluV3/DZBA5x5lMRfXMuHTIR4ViVDO?= =?iso-8859-1?Q?sJWKhhaMZOvLcY3ad3JwN7/lRILSXvGdyzMjDhthQuqgSEX2XwlyvsTsBu?= =?iso-8859-1?Q?jVT//2EDlxoIQ4GrFhc62vYwGf9QW+7gMTvqQfaZ4t8D581VlsRDV1jDHZ?= =?iso-8859-1?Q?PBTNgpA4UpgUavwzVLE2gy2hHwWI3FpIPgTeGyHECpmMSUNWFwQvD2EcAf?= =?iso-8859-1?Q?DsJQIi0IbulpjN/Tcb882Mr6ws+leGsPlXJBEDfbc2OyPQYIaEiukNTv+7?= =?iso-8859-1?Q?1P685WxfLZI6O8AdOfgHz6QMxby2BqiO59Yr10MCZxee8q/MibfpLqBmDF?= =?iso-8859-1?Q?hdu6iw6ZG8srsl9eVsivfjtgxWioTcmFZtlwrjmU0xBoScUl6az/dxNeya?= =?iso-8859-1?Q?bFan7CgSgxz7GHYwF9VsvjODLibDTf6+YX+QKl6iZvR3Z8aOaTyIDjm4d2?= =?iso-8859-1?Q?CYHusPH5sD/V1KGxv4X5f2NrWr2fqBj0NQjurKAZHBPhcIcH84pOb6UVWm?= =?iso-8859-1?Q?uHflzltUL+Tjx8zXHV0IFZdwdsUMPKLr0NssaHCXoDSHmQRduSatRbBIzI?= =?iso-8859-1?Q?rZt5R5Hf9xTG08qapiZ8ZwLQIBT50R+9yeYQ/4O978uxKjegE1IWXT5ai0?= =?iso-8859-1?Q?W8/yh77OzmvMwE7Et2qinnbMN4HDRamKb2MJOQiPtAARZTm5rWXnzWTbCC?= =?iso-8859-1?Q?pzjyp1wR9LSadHtpq+iNs2hqof3VS+u5eHTzNyvfjlMHgzQ1NAyP6k7vww?= =?iso-8859-1?Q?fkNXs0pqArPjk3i4/5Bx2Ds6OdK4BcFG2WwCP3qQe+k2DJgx+P8FgTAWYo?= =?iso-8859-1?Q?8IV7RlzeyyLSqKYPeMU9/c2IaCLj6du9dOsxIMXrr5sgT5f3aDap4pq4vx?= =?iso-8859-1?Q?YSpDhAtM7f0kGpCz7MrhWZHOWPVbKoxXBpq9AILi4uJhQgICL6ziD0MdaW?= =?iso-8859-1?Q?AyShrvh4ApGWR+uE/nw0H+A7nWbfQqKk/rkLcTr/f8AH+hP2EG7wqG7Al7?= =?iso-8859-1?Q?5rUP4G+4Y4T2gVjhvDn9d3P9wxNWubA6VqAWFLP4qTihQ2CrTHsr2VDSpu?= =?iso-8859-1?Q?sMQNW4am+aih6mSg73SESmKA/48X0fyWO5sVzeww5yoYdKAFSQ4jEudEvc?= =?iso-8859-1?Q?fmn0LHyDnf7VoypMiHtL9UT5IUo4SdvXxvtFoUZlSQJgZl7TSLHUsmtTn6?= =?iso-8859-1?Q?uKRpckfEY19aIy7MaDGhNiM7TH0wVMWTmZiDLx9m7zcci2gCF/YmFH+4Sg?= =?iso-8859-1?Q?1vPF1HvWiWg1r38og/+6Vfsxp+GbLrqdTtm14aHG/Y+Mh1q2mf8v7cmsEA?= =?iso-8859-1?Q?ixtkHoTTwJsEqoFhkWlsX+eiPFzuEeSKhxlq3GJFYemH85PyjRAOQIuqAz?= =?iso-8859-1?Q?A7v81UyQ7BdJn+WbdmpUezL7XqGx1JAa8oVUkF85ZoOmkQWJV6gx9RCw?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DBAPR08MB5814.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 243206a7-c281-44d0-859d-08dba200bd26 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Aug 2023 04:40:25.9958 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WoG1Ywf64tLzqm3+nFGkDn+FggqrjRsmAVZ1xKYUFfDZYj23KoIYxK2SB5QOBLBkoMdUJ0y2CKkvrFPlCn7w1yXjhtWKcUWGoSq381uSPAc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9044 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Morten Br=F8rup > Sent: Sunday, August 20, 2023 4:24 AM > To: dev@dpdk.org > Cc: Honnappa Nagarahalli ; > konstantin.v.ananyev@yandex.ru > Subject: Ring library optimization idea >=20 > Most of the fast path ring library functions access the two cache lines c= ontaining > respectively the r->prod and r->cons structures. >=20 > Some of the fast path functions also have to fetch r->capacity and r->mas= k, > which reside in another cache line. >=20 > What do you think about adding shadow variables of r->capacity and r->mas= k > to the same cache line as r->prod, to improve ring library performance (b= y > avoiding having to read a third cache line) when under CPU cache pressure= ? Agree with the idea. I am not sure about the performance as these are read-= only data. IMO, we should not worry about it as it saves one cache line (bu= t we do not need to measure the performance). They will occupy 12B, but I d= o not see how we will occupy the entire 64B of the cacheline in the near fu= ture. Also, the shadow variables need to be part of both r->prod and r->cons. >=20 > -Morten