From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1158A00C3; Thu, 21 Apr 2022 04:35:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 43090410FA; Thu, 21 Apr 2022 04:35:40 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2066.outbound.protection.outlook.com [40.107.21.66]) by mails.dpdk.org (Postfix) with ESMTP id 23952410E1 for ; Thu, 21 Apr 2022 04:35:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EefyVDd6dpl2gUjSzEI12ha3+/Cah9JbLgfiy2ORwGc=; b=ohqGT4S6CBGv4yAwCEdcnHU5XLSlYmriLbkApkzsMtn4bCh7MFbkkSSOY6/0cOJoPZTsujhr2Pui+GwbtX6am1L8LdHGuTYGTRJv0ZPc+KapP+EL4B4LDEcfcxQPjJwWa8qeO8acfOH+dgwo/vfnOoG8FzE3Plmi6qFUaZs0ofE= Received: from AM5PR1001CA0027.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:2::40) by DBBPR08MB4920.eurprd08.prod.outlook.com (2603:10a6:10:d8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 21 Apr 2022 02:35:35 +0000 Received: from AM5EUR03FT020.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:2:cafe::f4) by AM5PR1001CA0027.outlook.office365.com (2603:10a6:206:2::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13 via Frontend Transport; Thu, 21 Apr 2022 02:35:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT020.mail.protection.outlook.com (10.152.16.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14 via Frontend Transport; Thu, 21 Apr 2022 02:35:34 +0000 Received: ("Tessian outbound 78191104f1b7:v118"); Thu, 21 Apr 2022 02:35:34 +0000 X-CR-MTA-TID: 64aa7808 Received: from 843f3c128f14.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AE629C98-80E8-4255-B022-F2B686323CC1.1; Thu, 21 Apr 2022 02:35:28 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 843f3c128f14.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 21 Apr 2022 02:35:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cea7Z1WwJkdpcgUbOZ2GveO3RvhgdiV/xB7hZ1IyX7wP4h3s7rUjr820bBplFZ3NzBcvCJMUSchOL4HyKF1F27xf2Wxw72r76GduirGY2erjJPThGNcs0QjeIC03FHtFH7V/121bjiU18e1nEafavGzFIFqrgSeXAftvTX2l7uFOAGiDdd3c85ztrjBltDDWzLcqg7+rx/ni5sDYGLFVKRlevXu7CKb9kHTKZvebY+vSGbzKhpd08ICTdPzgbcc0XeD2Gmf1/QarOqRlqXMGI+VxoW9RREfTBKxmRqIolWfEN0zYYDvYVyi3rEOlazhlfv9+qGGyX0oyt35gts3V2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EefyVDd6dpl2gUjSzEI12ha3+/Cah9JbLgfiy2ORwGc=; b=Eu9GRTLti9gu9NtUBw8uwLQXIbycuTkudIRjj+93Ot9sNUUE88dz0JEi/uPpIhwdbFxiJLz3fBYE1tG/q8RpgOCOZhCimNCFD91ypgOdQXolTqCi0TkxzOCp5FLVIMAWH5VNLS9RPOPE3Trh9bfmQn+DfzcUxVXJpMCgTmG+GLel8LYoQDQEg0qGBCquhv3AVZqWz20iJGa+0UpO7k3rzTTPltXE/c050Q421h1tCQcktlO02QWcrAb9Jimd5dlUbtQ7NRzYTUwd4jbK9qGAddHkSjsNSP4kJpy2nKu6t1t3Y60tkpWZv1MWYL61KUTllir2jXvtUAyqOEyOV+MoYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EefyVDd6dpl2gUjSzEI12ha3+/Cah9JbLgfiy2ORwGc=; b=ohqGT4S6CBGv4yAwCEdcnHU5XLSlYmriLbkApkzsMtn4bCh7MFbkkSSOY6/0cOJoPZTsujhr2Pui+GwbtX6am1L8LdHGuTYGTRJv0ZPc+KapP+EL4B4LDEcfcxQPjJwWa8qeO8acfOH+dgwo/vfnOoG8FzE3Plmi6qFUaZs0ofE= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by HE1PR08MB2665.eurprd08.prod.outlook.com (2603:10a6:7:39::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Thu, 21 Apr 2022 02:35:15 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7516:547a:f52e:2be7]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7516:547a:f52e:2be7%3]) with mapi id 15.20.5186.014; Thu, 21 Apr 2022 02:35:15 +0000 From: Honnappa Nagarahalli To: =?iso-8859-1?Q?Morten_Br=F8rup?= , Feifei Wang CC: "dev@dpdk.org" , nd , Ruifeng Wang , nd Subject: RE: [PATCH v1 5/5] examples/l3fwd: enable direct rearm mode Thread-Topic: [PATCH v1 5/5] examples/l3fwd: enable direct rearm mode Thread-Index: AQHYVI8Os3vmCXi1HEGk+2Bx5G4N06z4lK6AgAEIHHA= Date: Thu, 21 Apr 2022 02:35:15 +0000 Message-ID: References: <20220420081650.2043183-1-feifei.wang2@arm.com> <20220420081650.2043183-6-feifei.wang2@arm.com> <98CBD80474FA8B44BF855DF32C47DC35D86FE4@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D86FE4@smartserver.smartshare.dk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 0C939642E9E4A44E9BAFAE72C4C4469D.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 58a07e73-1796-4012-6450-08da233f9cec x-ms-traffictypediagnostic: HE1PR08MB2665:EE_|AM5EUR03FT020:EE_|DBBPR08MB4920:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: zDJdZTfST3ipT2sE+NKLIXViifOMmePDe9FjVMeeCtFEDnI5W0x1jrpxGkljxaoJqp1/YQSBN5smSREt34YXiMa+IeC/mNMsB1w6YGGNFl4mYtwb9KpViwi5MMILfcty7Jeqdjkks/qhEwIBibgRMexcJTJILBKWBnaGCbmX1Lyepn4/AZRh8Ck+SgJLOOqqXpwyKVqRK6i6w3x4FuQOckTDpmsoiIqsGajqTN/TQ/Y7IZE7MX+ZfVC7mhT/BPc+ogRmiAYEs3drG/TPGq/sBqGKIpKCg6B4b7HYoYTo2hM4k8NbweJkkhzf0JlZO7J6CyxS78gJiWBZUfsCyOLz7qVqMxmfPY2zOOPqTguNKzOZq/Pyq+7WehmKCJZymV8PNeZxqDCEFwsowejIna/5lv2rxtp/FHZ9PsOcZgdAWmJafQ0cbsTbrrzgonPsgcgdg4KQx4yf8vL1ORr6omgijGnGGzjXGevIQGzsE8pEjbhXokpLqbptPd9fRPWNi8XdKvItzX+W/IqYqwkkDU3Br0ingZHjecnSYENXOoKz5DVxbIJxiDufemeMx8kJb5QgVUkInhMagENPru6rSWVDRfDtEm8HcJUrG96X+NBj0uzFGgRobzIFCh+5sEzUaDE5aPGDBWeTAE5CQ5+FxKvYJmRFZoJHZM7gRBsdjZlqgcU8HmS4tRadX4c2GS+hQnv1XSZpeI65km0WWPEI2koU3w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(54906003)(86362001)(9686003)(71200400001)(38070700005)(110136005)(26005)(2906002)(52536014)(38100700002)(5660300002)(8936002)(122000001)(33656002)(186003)(55016003)(6506007)(7696005)(66556008)(83380400001)(64756008)(6636002)(316002)(4326008)(8676002)(66446008)(508600001)(76116006)(66476007)(66946007); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2665 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT020.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1d523735-5263-4596-bcce-08da233f9167 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: psec/RNhJJbOCcqzpGfdAhkClXWz2O+OJ4Ek0LEkafl9o6QZbA9LNB8KIR5tReR7x/3+81KgjzQAPKSgslmyyAaF7EwrBSe5gLaT2+viPiNfHKB0xvCCpAfygKv5IF27WacE70rPGIt4ssszG4OH7Be3p5tBehxgbQsU/qYBpod+0wfxnM/GSpXPClzfI87iGBlfl7x3PmoosAG2UuCBVJsPb+iH8yzaHAh7QHtwSgFxlDlv4Z64HG9PIuGXgfwAXhnfFIshAMtgVFRkDpY00D53ApYMjN0DosCQ1kIovXyW6IG6zMYqi58akuh0XnqprK3mZwEO+TBdS9yGEavoqxLo7vgZ/oF5jQYKuQTKToHI2mmaD+l4nqtmNLQe+kAYuL20gUx+cWqwTpn/5zuoFnpghryTDeXpuiUk/WElAuhhTKvTg1lldZYIB8FdXI6lrXAKMktCXNP3cIUdlSvzmjRIjEFHk+h7AFC9MIaQi0L4XkbM1UFSUErCLxbmM9XhCK3q3aRveaifXLbZnW6RjM5iDkZRhl6ckkrlps/6jSJHTU6wVo7UU4jE2QQyQ/h2/aUkjYR109gzdrDcZ7P76rVdxziiLmpjgLsOdopfwRn3Ixg4F5bMaH6S/dTXM3hgQjgwMo8FwAmbrq9HtYteq4wUOto3u6Q0RGLnRpo42NzGUNvJIXkYbyomAAUSKFEX X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(186003)(40460700003)(55016003)(47076005)(82310400005)(336012)(2906002)(36860700001)(83380400001)(33656002)(81166007)(8936002)(70586007)(6636002)(70206006)(52536014)(508600001)(5660300002)(110136005)(54906003)(7696005)(356005)(316002)(86362001)(9686003)(26005)(4326008)(8676002)(6506007); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 02:35:34.8371 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 58a07e73-1796-4012-6450-08da233f9cec X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT020.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4920 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >=20 > > From: Feifei Wang [mailto:feifei.wang2@arm.com] > > Sent: Wednesday, 20 April 2022 10.17 > > > > Enable direct rearm mode. The mapping is decided in the data plane > > based on the first packet received. >=20 > I usually don't care much about l3fwd, but putting configuration changes = in the > fast path is just wrong! I would say it depends. In this case the cycles consumed by the API are ver= y less and configuration data is very small and is already in the cache as = PMD has accessed the same data structure.=20 If the configuration needs more cycles than a typical (depending on the app= lication) data plane packet processing needs or brings in enormous amount o= f data in to the cache, it should not be done on the data plane. >=20 > Also, l3fwd is often used for benchmarking, and this small piece of code = in the > fast path will affect benchmark results (although only very little). We do not see any impact on the performance numbers. The reason for putting= in the data plane was it covers wider use case in this L3fwd application. = If the app were to be simple, the configuration could be done from the cont= rol plane. Unfortunately, the performance of L3fwd application matters. >=20 > Please move it out of the fast path.