From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D800A04DD; Wed, 28 Oct 2020 16:22:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 82BBBCC40; Wed, 28 Oct 2020 16:22:19 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150050.outbound.protection.outlook.com [40.107.15.50]) by dpdk.org (Postfix) with ESMTP id EA38ECBDB; Wed, 28 Oct 2020 16:22:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W2VXNUEggSeHCD0saP6dBSaYB1U/KajzWAX1mfRlfGc=; b=jicQLAyggyiovDGVd0QFMtE1I3uyvqOI4HE2kfWnm39X39A2EKxZ+fk/2Bsjxf6vTd5zNe26FhPOCbfnmi/udve4252p7JiicFzqc2PEyHB6hNPSoYmv62Q7qYdf5yteBgMtlR0lH/vdZcJ5nTke7Z8Nq5azvPooSkTIJMOZ3rs= Received: from DB7PR05CA0030.eurprd05.prod.outlook.com (2603:10a6:10:36::43) by VE1PR08MB5808.eurprd08.prod.outlook.com (2603:10a6:800:1a1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.25; Wed, 28 Oct 2020 15:22:14 +0000 Received: from DB5EUR03FT012.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:36:cafe::5c) by DB7PR05CA0030.outlook.office365.com (2603:10a6:10:36::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.19 via Frontend Transport; Wed, 28 Oct 2020 15:22:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT012.mail.protection.outlook.com (10.152.20.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3520.15 via Frontend Transport; Wed, 28 Oct 2020 15:22:14 +0000 Received: ("Tessian outbound c189680f801b:v64"); Wed, 28 Oct 2020 15:22:14 +0000 X-CR-MTA-TID: 64aa7808 Received: from 75ccf6d43748.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9ECB9200-4490-4382-A81A-840721A92ACD.1; Wed, 28 Oct 2020 15:22:09 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 75ccf6d43748.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 28 Oct 2020 15:22:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SKFLhg73USnrcruickyBeBYpkKSqCcKlpxkPm098DE1xXBWUw2VpIhAPCs+FP0rdnN548riQ1Ab9bcoNgEpynPHttMxafrAd5ef38LKz0QJ8Co9eCfIsB9Psxex4+aWpig7iws1zuygZZ0yU3JjU20HSIlZyuVXMwzkUBmRBQVW5OQ0gkFdM7LxctPIrXMyTBAgV+qDhJy7yuSIevSnn0id9D55BK1hC4104iBVNbRjPE4Ye4MS77/aOnt6CVBPCHCZdMSbZui1R2+S0Wal3Lwp6IsH2logMUyfzQC/dFGW+XCtHWwUYayl8nCj5Ha6quCmsgo86vXTTV/pJC43hHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W2VXNUEggSeHCD0saP6dBSaYB1U/KajzWAX1mfRlfGc=; b=V/5XMWTaSryvtZFPfxG+tXNOhE0zabsPc9JdsJ8cHBlbVsYww4rg4lkiWjsUsdRwH64gf5AkyObFRB1WKaLV3h0kRV+h0D1davQMPBsca69Y1xhTxi/Otyws9ZpFfjF/Da/zTpDIiTCaawTbqKCQM+9F1vlpqfL8RNKivDWYqgNWK3VkKMaSxOEfZx6CqV6VbJLjD0Y2wuSQS6B90rHAVBmIAhvFO/2RJq8JosgSVO38wKkqI5C2qbn4/uPqvC5M1Ld8d7LlyaSl2bYiRAg76USj96c7eponu/X6LoBdegWGS+WbqcZ/nvqsSVGoJ6m/6c1Jkhd3lodoyPzZs3x6Hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W2VXNUEggSeHCD0saP6dBSaYB1U/KajzWAX1mfRlfGc=; b=jicQLAyggyiovDGVd0QFMtE1I3uyvqOI4HE2kfWnm39X39A2EKxZ+fk/2Bsjxf6vTd5zNe26FhPOCbfnmi/udve4252p7JiicFzqc2PEyHB6hNPSoYmv62Q7qYdf5yteBgMtlR0lH/vdZcJ5nTke7Z8Nq5azvPooSkTIJMOZ3rs= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB6PR0801MB1704.eurprd08.prod.outlook.com (2603:10a6:4:38::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.25; Wed, 28 Oct 2020 15:22:06 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d%4]) with mapi id 15.20.3499.018; Wed, 28 Oct 2020 15:22:06 +0000 From: Honnappa Nagarahalli To: Bruce Richardson , "Akhil.goyal@nxp.com" , Ray Kinsella CC: "Ananyev, Konstantin" , "Gujjar, Abhinandan S" , "dev@dpdk.org" , "Doherty, Declan" , "techboard@dpdk.org" , "Vangati, Narender" , "jerinj@marvell.com" , nd Thread-Topic: [dpdk-techboard] [v4 1/3] cryptodev: support enqueue callback functions Thread-Index: AQHWq8kd4RFxjf8yaUCycrmrnmomOKmrxnKAgADoggCAAEzPgIAAGfCAgAAL9QCAAAG3IA== Date: Wed, 28 Oct 2020 15:22:06 +0000 Message-ID: References: <1603619090-118652-1-git-send-email-abhinandan.gujjar@intel.com> <1603619090-118652-2-git-send-email-abhinandan.gujjar@intel.com> <20201028151130.GD1634@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20201028151130.GD1634@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 7FE7519DE00313409D3EA056C47ACD84.0 x-checkrecipientchecked: true Authentication-Results-Original: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [107.77.219.18] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 2b31b7d3-211b-4606-dd1a-08d87b553fa3 x-ms-traffictypediagnostic: DB6PR0801MB1704:|VE1PR08MB5808: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: hEyF0fndt9Cbq+0JFX4BXX34lj+f6PNF7Ta6fz0BhjJySzW0YsNkrR3p6JuSWKvJ92WGsvMc1OeFoG7iqNgBdxXhU7UDvzHHrovK7j5jsjXdV3sXQATc+C95EEbQPEAe4w8Ztg6IFFdP3eJyr4S/O3nunTg9KkkC1+n9jZPusdsc2Ok0MnGMRD9Xdm28CBstxxwY4YXmbF/k1ijDGMoyiepTgncfTPwh5wt1xNbjeu+230IvzyCBoWi3q1LO5NiLQRJxfUmcj5OSW4S0J/wgT5pujYU7NfGlr4l0MXEmFsc2sneCEm0c8UeDh9Jv8KB06bc4aasX+b5fAQs6pvkpjg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(136003)(39860400002)(366004)(376002)(33656002)(83380400001)(7416002)(316002)(71200400001)(52536014)(4326008)(2906002)(5660300002)(86362001)(9686003)(478600001)(8936002)(6506007)(110136005)(66476007)(64756008)(55016002)(186003)(76116006)(66556008)(7696005)(66946007)(66446008)(54906003)(26005)(8676002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: hEKIOmH2zPhvem7bbK10CMpQmwNu+PcF7FvYVkR6e8LX7dmxt1FLtZY+tjqwh6L9CbJ3ALfraUkmw818tLhS6ePq6981u7rU4eydl6lLuvYX/anRssLVISrj8mW9YPWgTIJ5ljHMvc7NbFJPj1z6mQk2xK3JplafqkmbUKrb+i6b+qmARXyiplKj94EGU+DUEWfdS1U0aQK9GnX/DPsxqcge5aGCfTJcEu5heiKC4STbp383KSbmnqcEXILk3N2tLua5ShFL5lABSGpqRdow5n8TJpHPMpTLL47BorDXAmJRtqqjikFceAzQ7H40x+cOLxcvsUAYlq5L65gsxcetfT5HKWYRIbosckHNhRCEudOZ7E8sV+ESoOSpN2BsKzwT9os7L37jQGVvrN6SJGNn73xjcQ/Kr07AdKdymhzLKxmxUElOETdfPsPcx82PAH8jYOuxfnJXUyRaZ6LXqmrjFM0Qxk2OPTi1rGeExRWrLQo9AmQXXkwhjiagmDeN9Eq0H1PA1os2SSSGlR3EHJxvqLMA42TpL9rhmVo34CTS4nOXmQDdJ841MoYsjMIAggB64uoO3UKQG/4Z3BJcBg56965z6nKkV0pibBMO+gRK4aA0OLiB5ZMPt0FUbvTEJnpllE3mHuLot6SjN9MiPqHAGA== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1704 Original-Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: aeef0ee2-b81f-417d-afce-08d87b553b07 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yCz49ByiFGmKJd3AxK3jcl/nCMF4iSAZDbCD58yvHMdDb283Yj+8vQCoR4bJCNinm7iSrKmrUDKaxRbHgs3pzy85pvYDATsKsJlQbeOzJT2sB2tvM62L0M7skwIrfgK0uhZJZN7UvNL98clp00kpqnL41JNkZDdCTSiJKTLux+KWUAMlxH/SedR186n9Ii4PLWBStFm97YGtMvYSwpOeb6jY9qu+vyqpaqzNXxIQjnwO9wxJLIxXxuQITzjfHRaxbZkvDxl7xY5TJJTwJfYDT9AuM1mWKEBz+uZF2I8bN5vjR9KVdOFzd+pitcSwjpT1yuSlz5xeBijcw4+zEO131pgUucmPUMPAHSi6kM+fkT+Yew3WGijpdTwaUkqacdIi/EJPbtT4bm/mQ4TpOc6/Pw== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(346002)(39850400004)(396003)(136003)(376002)(46966005)(70586007)(47076004)(82740400003)(26005)(70206006)(2906002)(186003)(55016002)(83380400001)(316002)(9686003)(7696005)(478600001)(33656002)(52536014)(336012)(54906003)(356005)(5660300002)(82310400003)(6506007)(450100002)(4326008)(81166007)(8936002)(110136005)(86362001)(8676002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2020 15:22:14.2975 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2b31b7d3-211b-4606-dd1a-08d87b553fa3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5808 Subject: Re: [dpdk-dev] [dpdk-techboard] [v4 1/3] cryptodev: support enqueue callback functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" + Ray for ABI >=20 > On Wed, Oct 28, 2020 at 02:28:43PM +0000, Akhil Goyal wrote: > > > > Hi Konstantin, > > > > > > > Hi Tech board members, > > > > > > > > > > I have a doubt about the ABI breakage in below addition of field. > > > > > Could you please comment. > > > > > > > > > > > /** The data structure associated with each crypto device. */ > > > > > > struct rte_cryptodev { > > > > > > dequeue_pkt_burst_t dequeue_burst; @@ -867,6 +922,10 > @@ > > > > > > struct rte_cryptodev { > > > > > > __extension__ > > > > > > uint8_t attached : 1; > > > > > > /**< Flag indicating the device is attached */ > > > > > > + > > > > > > + struct rte_cryptodev_enq_cb_rcu *enq_cbs; > > > > > > + /**< User application callback for pre enqueue processing */ > > > > > > + > > > > > > } __rte_cache_aligned; > > > > > > > > > > Here rte_cryptodevs is defined in stable API list in map file > > > > > which is a pointer To all rte_cryptodev and the above change is > > > > > changing the size of the > > > structure. > > > > > > While this patch adds new fields into rte_cryptodev structure, it > > > doesn't change the size of it. > > > struct rte_cryptodev is cache line aligned, so it's current size: > > > 128B for 64-bit systems, and 64B(/128B) for 32-bit systems. > > > So for 64-bit we have 47B implicitly reserved, and for 32-bit we > > > have 19B reserved. > > > That's enough to add two pointers without changing size of this struc= t. > > > > > > > The structure is cache aligned, and if the cache line size in 32Byte > > and the compilation is done on 64bit machine, then we will be left > > with 15Bytes which is not sufficient for 2 pointers. > > Do we have such systems? Am I missing something? > > >=20 > I don't think we support any such systems, so unless someone can point ou= t > a specific case where we need to support 32-byte CLs, I'd tend towards > ignoring this as a non-issue. Agree. I have not come across 32B cache line. >=20 > > The reason I brought this into techboard is to have a consensus on > > such change As rte_cryptodev is a very popular and stable structure. > > Any changes to it may Have impacts which one person cannot judge all us= e > cases. > > >=20 > Haven't been tracking this discussion much, but from what I read here, th= is > doesn't look like an ABI break and should be ok. If we are filling the holes in the cache line with new fields, it should no= t be an ABI break. >=20 > Regards, > /Bruce