* Re: [dpdk-dev] [PATCH] config/arm: add support for Marvell CN10K
2021-03-31 17:23 [dpdk-dev] [PATCH] config/arm: add support for Marvell CN10K Nithin Dabilpuram
@ 2021-03-31 17:33 ` Jerin Jacob
2021-04-01 1:20 ` Honnappa Nagarahalli
2021-04-01 10:03 ` [dpdk-dev] [PATCH v2] " Nithin Dabilpuram
2021-04-19 20:39 ` pbhagavatula
2 siblings, 1 reply; 9+ messages in thread
From: Jerin Jacob @ 2021-03-31 17:33 UTC (permalink / raw)
To: Nithin Dabilpuram
Cc: dpdk-dev, Jan Viktorin, Ruifeng Wang, Honnappa Nagarahalli,
Jerin Jacob, Sunil Kumar Kori, Satha Koteswara Rao Kottidi,
Pavan Nikhilesh, Kiran Kumar K, Satheesh Paul,
Ashwin Sekhar Thalakalath Kottilveetil
On Wed, Mar 31, 2021 at 10:53 PM Nithin Dabilpuram
<ndabilpuram@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Add config support to cross compile for Marvell CN10K SoC.
> Marvell CN10K SoC is based on ARM Neoverse N2 cores.
cores->core
>
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
With the above change:
Acked-by: Jerin Jacob <jerinj@marvell.com>
> ---
> config/arm/arm64_cn10k_linux_gcc | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
> create mode 100644 config/arm/arm64_cn10k_linux_gcc
>
> diff --git a/config/arm/arm64_cn10k_linux_gcc b/config/arm/arm64_cn10k_linux_gcc
> new file mode 100644
> index 0000000..4f8e7cb
> --- /dev/null
> +++ b/config/arm/arm64_cn10k_linux_gcc
> @@ -0,0 +1,20 @@
> +[binaries]
> +c = 'aarch64-linux-gnu-gcc'
> +cpp = 'aarch64-linux-gnu-cpp'
> +ar = 'aarch64-linux-gnu-gcc-ar'
> +strip = 'aarch64-linux-gnu-strip'
> +pkgconfig = 'aarch64-linux-gnu-pkg-config'
> +pcap-config = ''
> +
> +[host_machine]
> +system = 'linux'
> +cpu_family = 'aarch64'
> +cpu = 'armv8.6-a'
> +endian = 'little'
> +
> +[properties]
> +implementer_id = '0x41'
> +part_number = '0xd49'
> +max_lcores = 36
> +max_numa_nodes = 1
> +numa = false
> --
> 2.8.4
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH] config/arm: add support for Marvell CN10K
2021-03-31 17:33 ` Jerin Jacob
@ 2021-04-01 1:20 ` Honnappa Nagarahalli
2021-04-01 10:09 ` Nithin Dabilpuram
0 siblings, 1 reply; 9+ messages in thread
From: Honnappa Nagarahalli @ 2021-04-01 1:20 UTC (permalink / raw)
To: Jerin Jacob, Nithin Dabilpuram
Cc: dpdk-dev, Jan Viktorin, Ruifeng Wang, jerinj, Sunil Kumar Kori,
Satha Koteswara Rao Kottidi, Pavan Nikhilesh, Kiran Kumar K,
Satheesh Paul, Ashwin Sekhar Thalakalath Kottilveetil, nd,
Honnappa Nagarahalli, thomas, nd
<snip>
> Subject: Re: [dpdk-dev] [PATCH] config/arm: add support for Marvell CN10K
>
> On Wed, Mar 31, 2021 at 10:53 PM Nithin Dabilpuram
> <ndabilpuram@marvell.com> wrote:
> >
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > Add config support to cross compile for Marvell CN10K SoC.
> > Marvell CN10K SoC is based on ARM Neoverse N2 cores.
>
> cores->core
>
> >
> > Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> With the above change:
> Acked-by: Jerin Jacob <jerinj@marvell.com>
I prefer this patch to be based on top of [1].
[1] http://patches.dpdk.org/project/dpdk/patch/1617186371-18699-2-git-send-email-juraj.linkes@pantheon.tech/
>
>
> > ---
> > config/arm/arm64_cn10k_linux_gcc | 20 ++++++++++++++++++++
> > 1 file changed, 20 insertions(+)
> > create mode 100644 config/arm/arm64_cn10k_linux_gcc
> >
> > diff --git a/config/arm/arm64_cn10k_linux_gcc
> > b/config/arm/arm64_cn10k_linux_gcc
> > new file mode 100644
> > index 0000000..4f8e7cb
> > --- /dev/null
> > +++ b/config/arm/arm64_cn10k_linux_gcc
> > @@ -0,0 +1,20 @@
> > +[binaries]
> > +c = 'aarch64-linux-gnu-gcc'
> > +cpp = 'aarch64-linux-gnu-cpp'
> > +ar = 'aarch64-linux-gnu-gcc-ar'
> > +strip = 'aarch64-linux-gnu-strip'
> > +pkgconfig = 'aarch64-linux-gnu-pkg-config'
> > +pcap-config = ''
> > +
> > +[host_machine]
> > +system = 'linux'
> > +cpu_family = 'aarch64'
> > +cpu = 'armv8.6-a'
> > +endian = 'little'
> > +
> > +[properties]
> > +implementer_id = '0x41'
> > +part_number = '0xd49'
> > +max_lcores = 36
> > +max_numa_nodes = 1
> > +numa = false
> > --
> > 2.8.4
> >
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH] config/arm: add support for Marvell CN10K
2021-04-01 1:20 ` Honnappa Nagarahalli
@ 2021-04-01 10:09 ` Nithin Dabilpuram
2021-04-01 10:14 ` Nithin Dabilpuram
0 siblings, 1 reply; 9+ messages in thread
From: Nithin Dabilpuram @ 2021-04-01 10:09 UTC (permalink / raw)
To: Honnappa Nagarahalli
Cc: Jerin Jacob, dpdk-dev, Jan Viktorin, Ruifeng Wang, jerinj,
Sunil Kumar Kori, Satha Koteswara Rao Kottidi, Pavan Nikhilesh,
Kiran Kumar K, Satheesh Paul,
Ashwin Sekhar Thalakalath Kottilveetil, nd, thomas
On Thu, Apr 01, 2021 at 01:20:44AM +0000, Honnappa Nagarahalli wrote:
> <snip>
>
> > Subject: Re: [dpdk-dev] [PATCH] config/arm: add support for Marvell CN10K
> >
> > On Wed, Mar 31, 2021 at 10:53 PM Nithin Dabilpuram
> > <ndabilpuram@marvell.com> wrote:
> > >
> > > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > >
> > > Add config support to cross compile for Marvell CN10K SoC.
> > > Marvell CN10K SoC is based on ARM Neoverse N2 cores.
> >
> > cores->core
> >
> > >
> > > Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > With the above change:
> > Acked-by: Jerin Jacob <jerinj@marvell.com>
> I prefer this patch to be based on top of [1].
>
> [1] http://patches.dpdk.org/project/dpdk/patch/1617186371-18699-2-git-send-email-juraj.linkes@pantheon.tech/
There is no conflicting change I believe for me to take care of. The change for
enable
>
> >
> >
> > > ---
> > > config/arm/arm64_cn10k_linux_gcc | 20 ++++++++++++++++++++
> > > 1 file changed, 20 insertions(+)
> > > create mode 100644 config/arm/arm64_cn10k_linux_gcc
> > >
> > > diff --git a/config/arm/arm64_cn10k_linux_gcc
> > > b/config/arm/arm64_cn10k_linux_gcc
> > > new file mode 100644
> > > index 0000000..4f8e7cb
> > > --- /dev/null
> > > +++ b/config/arm/arm64_cn10k_linux_gcc
> > > @@ -0,0 +1,20 @@
> > > +[binaries]
> > > +c = 'aarch64-linux-gnu-gcc'
> > > +cpp = 'aarch64-linux-gnu-cpp'
> > > +ar = 'aarch64-linux-gnu-gcc-ar'
> > > +strip = 'aarch64-linux-gnu-strip'
> > > +pkgconfig = 'aarch64-linux-gnu-pkg-config'
> > > +pcap-config = ''
> > > +
> > > +[host_machine]
> > > +system = 'linux'
> > > +cpu_family = 'aarch64'
> > > +cpu = 'armv8.6-a'
> > > +endian = 'little'
> > > +
> > > +[properties]
> > > +implementer_id = '0x41'
> > > +part_number = '0xd49'
> > > +max_lcores = 36
> > > +max_numa_nodes = 1
> > > +numa = false
> > > --
> > > 2.8.4
> > >
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH] config/arm: add support for Marvell CN10K
2021-04-01 10:09 ` Nithin Dabilpuram
@ 2021-04-01 10:14 ` Nithin Dabilpuram
2021-04-01 14:28 ` Honnappa Nagarahalli
0 siblings, 1 reply; 9+ messages in thread
From: Nithin Dabilpuram @ 2021-04-01 10:14 UTC (permalink / raw)
To: Honnappa Nagarahalli
Cc: Jerin Jacob, dpdk-dev, Jan Viktorin, Ruifeng Wang, jerinj,
Sunil Kumar Kori, Satha Koteswara Rao Kottidi, Pavan Nikhilesh,
Kiran Kumar K, Satheesh Paul,
Ashwin Sekhar Thalakalath Kottilveetil, nd, thomas
On Thu, Apr 01, 2021 at 03:39:01PM +0530, Nithin Dabilpuram wrote:
> On Thu, Apr 01, 2021 at 01:20:44AM +0000, Honnappa Nagarahalli wrote:
> > <snip>
> >
> > > Subject: Re: [dpdk-dev] [PATCH] config/arm: add support for Marvell CN10K
> > >
> > > On Wed, Mar 31, 2021 at 10:53 PM Nithin Dabilpuram
> > > <ndabilpuram@marvell.com> wrote:
> > > >
> > > > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > > >
> > > > Add config support to cross compile for Marvell CN10K SoC.
> > > > Marvell CN10K SoC is based on ARM Neoverse N2 cores.
> > >
> > > cores->core
> > >
> > > >
> > > > Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> > > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > >
> > > With the above change:
> > > Acked-by: Jerin Jacob <jerinj@marvell.com>
> > I prefer this patch to be based on top of [1].
> >
> > [1] http://patches.dpdk.org/project/dpdk/patch/1617186371-18699-2-git-send-email-juraj.linkes@pantheon.tech/
>
> There is no conflicting change I believe for me to take care of. The change for
> enable
Sorry, for incomplete message.
I think there is no conflicting change here. I hope my understanding is correct.
Since there is no dependency b/w the above patch and this one, I leave it to the maintainers
to decide the merge order.
>
> >
> > >
> > >
> > > > ---
> > > > config/arm/arm64_cn10k_linux_gcc | 20 ++++++++++++++++++++
> > > > 1 file changed, 20 insertions(+)
> > > > create mode 100644 config/arm/arm64_cn10k_linux_gcc
> > > >
> > > > diff --git a/config/arm/arm64_cn10k_linux_gcc
> > > > b/config/arm/arm64_cn10k_linux_gcc
> > > > new file mode 100644
> > > > index 0000000..4f8e7cb
> > > > --- /dev/null
> > > > +++ b/config/arm/arm64_cn10k_linux_gcc
> > > > @@ -0,0 +1,20 @@
> > > > +[binaries]
> > > > +c = 'aarch64-linux-gnu-gcc'
> > > > +cpp = 'aarch64-linux-gnu-cpp'
> > > > +ar = 'aarch64-linux-gnu-gcc-ar'
> > > > +strip = 'aarch64-linux-gnu-strip'
> > > > +pkgconfig = 'aarch64-linux-gnu-pkg-config'
> > > > +pcap-config = ''
> > > > +
> > > > +[host_machine]
> > > > +system = 'linux'
> > > > +cpu_family = 'aarch64'
> > > > +cpu = 'armv8.6-a'
> > > > +endian = 'little'
> > > > +
> > > > +[properties]
> > > > +implementer_id = '0x41'
> > > > +part_number = '0xd49'
> > > > +max_lcores = 36
> > > > +max_numa_nodes = 1
> > > > +numa = false
> > > > --
> > > > 2.8.4
> > > >
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH] config/arm: add support for Marvell CN10K
2021-04-01 10:14 ` Nithin Dabilpuram
@ 2021-04-01 14:28 ` Honnappa Nagarahalli
0 siblings, 0 replies; 9+ messages in thread
From: Honnappa Nagarahalli @ 2021-04-01 14:28 UTC (permalink / raw)
To: Nithin Dabilpuram
Cc: Jerin Jacob, dpdk-dev, Jan Viktorin, Ruifeng Wang, jerinj,
Sunil Kumar Kori, Satha Koteswara Rao Kottidi, Pavan Nikhilesh,
Kiran Kumar K, Satheesh Paul,
Ashwin Sekhar Thalakalath Kottilveetil, nd, thomas,
Honnappa Nagarahalli, nd
<snip>
> > > > Subject: Re: [dpdk-dev] [PATCH] config/arm: add support for
> > > > Marvell CN10K
> > > >
> > > > On Wed, Mar 31, 2021 at 10:53 PM Nithin Dabilpuram
> > > > <ndabilpuram@marvell.com> wrote:
> > > > >
> > > > > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > > > >
> > > > > Add config support to cross compile for Marvell CN10K SoC.
> > > > > Marvell CN10K SoC is based on ARM Neoverse N2 cores.
> > > >
> > > > cores->core
> > > >
> > > > >
> > > > > Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> > > > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > > >
> > > > With the above change:
> > > > Acked-by: Jerin Jacob <jerinj@marvell.com>
> > > I prefer this patch to be based on top of [1].
> > >
> > > [1]
> > > http://patches.dpdk.org/project/dpdk/patch/1617186371-18699-2-git-se
> > > nd-email-juraj.linkes@pantheon.tech/
> >
> > There is no conflicting change I believe for me to take care of. The
> > change for enable
>
> Sorry, for incomplete message.
>
> I think there is no conflicting change here. I hope my understanding is correct.
> Since there is no dependency b/w the above patch and this one, I leave it to
> the maintainers to decide the merge order.
Agree, there is no conflicting change. However, merging the above mentioned patch would require further enhancements to your patch. The above mentioned patch is pending since some time.
>
>
> >
> > >
> > > >
> > > >
> > > > > ---
> > > > > config/arm/arm64_cn10k_linux_gcc | 20 ++++++++++++++++++++
> > > > > 1 file changed, 20 insertions(+) create mode 100644
> > > > > config/arm/arm64_cn10k_linux_gcc
> > > > >
> > > > > diff --git a/config/arm/arm64_cn10k_linux_gcc
> > > > > b/config/arm/arm64_cn10k_linux_gcc
> > > > > new file mode 100644
> > > > > index 0000000..4f8e7cb
> > > > > --- /dev/null
> > > > > +++ b/config/arm/arm64_cn10k_linux_gcc
> > > > > @@ -0,0 +1,20 @@
> > > > > +[binaries]
> > > > > +c = 'aarch64-linux-gnu-gcc'
> > > > > +cpp = 'aarch64-linux-gnu-cpp'
> > > > > +ar = 'aarch64-linux-gnu-gcc-ar'
> > > > > +strip = 'aarch64-linux-gnu-strip'
> > > > > +pkgconfig = 'aarch64-linux-gnu-pkg-config'
> > > > > +pcap-config = ''
> > > > > +
> > > > > +[host_machine]
> > > > > +system = 'linux'
> > > > > +cpu_family = 'aarch64'
> > > > > +cpu = 'armv8.6-a'
> > > > > +endian = 'little'
> > > > > +
> > > > > +[properties]
> > > > > +implementer_id = '0x41'
> > > > > +part_number = '0xd49'
> > > > > +max_lcores = 36
> > > > > +max_numa_nodes = 1
> > > > > +numa = false
> > > > > --
> > > > > 2.8.4
> > > > >
^ permalink raw reply [flat|nested] 9+ messages in thread
* [dpdk-dev] [PATCH v2] config/arm: add support for Marvell CN10K
2021-03-31 17:23 [dpdk-dev] [PATCH] config/arm: add support for Marvell CN10K Nithin Dabilpuram
2021-03-31 17:33 ` Jerin Jacob
@ 2021-04-01 10:03 ` Nithin Dabilpuram
2021-04-19 20:39 ` pbhagavatula
2 siblings, 0 replies; 9+ messages in thread
From: Nithin Dabilpuram @ 2021-04-01 10:03 UTC (permalink / raw)
To: dev, Jan Viktorin, Ruifeng Wang, Honnappa Nagarahalli
Cc: jerinj, skori, skoteshwar, pbhagavatula, kirankumark, psatheesh,
asekhar, Nithin Dabilpuram
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
Add config support to cross compile for Marvell CN10K SoC.
Marvell CN10K SoC is based on ARM Neoverse N2 core.
Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
---
v2:
- Fix commit message.
config/arm/arm64_cn10k_linux_gcc | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
create mode 100644 config/arm/arm64_cn10k_linux_gcc
diff --git a/config/arm/arm64_cn10k_linux_gcc b/config/arm/arm64_cn10k_linux_gcc
new file mode 100644
index 0000000..4f8e7cb
--- /dev/null
+++ b/config/arm/arm64_cn10k_linux_gcc
@@ -0,0 +1,20 @@
+[binaries]
+c = 'aarch64-linux-gnu-gcc'
+cpp = 'aarch64-linux-gnu-cpp'
+ar = 'aarch64-linux-gnu-gcc-ar'
+strip = 'aarch64-linux-gnu-strip'
+pkgconfig = 'aarch64-linux-gnu-pkg-config'
+pcap-config = ''
+
+[host_machine]
+system = 'linux'
+cpu_family = 'aarch64'
+cpu = 'armv8.6-a'
+endian = 'little'
+
+[properties]
+implementer_id = '0x41'
+part_number = '0xd49'
+max_lcores = 36
+max_numa_nodes = 1
+numa = false
--
2.8.4
^ permalink raw reply [flat|nested] 9+ messages in thread
* [dpdk-dev] [PATCH v2] config/arm: add support for Marvell CN10K
2021-03-31 17:23 [dpdk-dev] [PATCH] config/arm: add support for Marvell CN10K Nithin Dabilpuram
2021-03-31 17:33 ` Jerin Jacob
2021-04-01 10:03 ` [dpdk-dev] [PATCH v2] " Nithin Dabilpuram
@ 2021-04-19 20:39 ` pbhagavatula
2021-04-20 22:29 ` Thomas Monjalon
2 siblings, 1 reply; 9+ messages in thread
From: pbhagavatula @ 2021-04-19 20:39 UTC (permalink / raw)
To: jerinj, Jan Viktorin, Ruifeng Wang, Bruce Richardson
Cc: dev, Pavan Nikhilesh, Nithin Dabilpuram
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
Add config support to cross compile for Marvell CN10K SoC.
Marvell CN10K SoC is based on ARM Neoverse N2 cores.
Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
---
v2 Changes:
- Rebase with ToT.
config/arm/arm64_cn10k_linux_gcc | 16 ++++++++++++++++
config/arm/meson.build | 12 ++++++++++++
2 files changed, 28 insertions(+)
create mode 100644 config/arm/arm64_cn10k_linux_gcc
diff --git a/config/arm/arm64_cn10k_linux_gcc b/config/arm/arm64_cn10k_linux_gcc
new file mode 100644
index 000000000..a3578c03a
--- /dev/null
+++ b/config/arm/arm64_cn10k_linux_gcc
@@ -0,0 +1,16 @@
+[binaries]
+c = 'aarch64-linux-gnu-gcc'
+cpp = 'aarch64-linux-gnu-cpp'
+ar = 'aarch64-linux-gnu-gcc-ar'
+strip = 'aarch64-linux-gnu-strip'
+pkgconfig = 'aarch64-linux-gnu-pkg-config'
+pcap-config = ''
+
+[host_machine]
+system = 'linux'
+cpu_family = 'aarch64'
+cpu = 'armv8.6-a'
+endian = 'little'
+
+[properties]
+platform = 'cn10k'
diff --git a/config/arm/meson.build b/config/arm/meson.build
index 86cdb9b53..3368cac85 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -316,10 +316,22 @@ soc_thunderxt88 = {
'part_number': '0xa1'
}
+soc_cn10k = {
+ 'description' : 'Marvell OCTEON 10',
+ 'implementer' : '0x41',
+ 'flags': [
+ ['RTE_MAX_LCORE', 24],
+ ['RTE_MAX_NUMA_NODES', 1]
+ ],
+ 'part_number': '0xd49',
+ 'numa': false
+}
+
socs = {
'generic': soc_generic,
'armada': soc_armada,
'bluefield': soc_bluefield,
+ 'cn10k' : soc_cn10k,
'dpaa': soc_dpaa,
'emag': soc_emag,
'graviton2': soc_graviton2,
--
2.17.1
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH v2] config/arm: add support for Marvell CN10K
2021-04-19 20:39 ` pbhagavatula
@ 2021-04-20 22:29 ` Thomas Monjalon
0 siblings, 0 replies; 9+ messages in thread
From: Thomas Monjalon @ 2021-04-20 22:29 UTC (permalink / raw)
To: Pavan Nikhilesh
Cc: jerinj, Jan Viktorin, Ruifeng Wang, Bruce Richardson, dev,
Nithin Dabilpuram
19/04/2021 22:39, pbhagavatula@marvell.com:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Add config support to cross compile for Marvell CN10K SoC.
> Marvell CN10K SoC is based on ARM Neoverse N2 cores.
>
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
> ---
> v2 Changes:
> - Rebase with ToT.
This is actually a v3.
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -316,10 +316,22 @@ soc_thunderxt88 = {
> 'part_number': '0xa1'
> }
>
> +soc_cn10k = {
Sorted alphabetically, and applied, thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread