From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DBF50436AC; Fri, 8 Dec 2023 19:26:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 61C7D402BF; Fri, 8 Dec 2023 19:26:11 +0100 (CET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2052.outbound.protection.outlook.com [40.107.6.52]) by mails.dpdk.org (Postfix) with ESMTP id 647F540144 for ; Fri, 8 Dec 2023 19:26:10 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ad0zdBcHbBAXQ3uBPEdjGe+vR04v9dYi0FVv8sKBvdY5doPLNkPyL38BaqlvCJ5xwWbBA+iUWdJN+061du9btTJgKUqejQBpCX0OI5nEw+CbszOMgwk04uNIGiiANrV8JQ49M6YRmN559/4qDy2shE06kkzgNmj3nUnhBUfmiEnPc7lvaV9KlI4GAcGhe0a/kDTHtvnCyTQl4C/YjStyFq116XBf02JeIatVVWqgTgmugFcqBUDnaVAIxo9ob+YSprlmhfaQNaX8v3bTWjcz1PY0D/EXFvLV8BrOihnGpxqut2Cbkr9rvkamnXvq5tjInjERFZLxQeBFtfLniqooDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DSeC09dGaUaDwRH6nWbpcx3Oc0DLFplwo9c6lgANpjc=; b=RC1M+Kb636c2NCJwUQi6guRcgv8Z/DMqXzohX+J/uZ55d05C4i5x4apb+LYx+/+VUXp5lD03hy1Nh/YGzMsisjr0HefmY0kGjeuNxSZ6JUs7MPkvHXxQ9hN71fagGSIMhqhU6/mAQzaTJK5mVOM3W3ys5dFSwSVGlxcaxhxxyAbP2vaukaeBDMZ1uX5094Xelcm/5UYP3zX4g4hz/J/tXJKbXBjjtUWNzadUSzsLwalomJ1X8GIfV9iVNm5kB6KtPMeiVNwBozpPMXKdEXvD0RTgs68hugiM8Y6auBjN1CCcBvjfIdBr+H+6VX1gzO1G/X6Cs1D41M5T2bkGFvj65g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DSeC09dGaUaDwRH6nWbpcx3Oc0DLFplwo9c6lgANpjc=; b=z4cz3iuY8adxlxln6XtWW95LT7JTavDoi1tWSK5ibVWNpRAf9iZBdnMWHrM0xJD6ZEFNlQ95MJy/m2BkRr8eEzE0Tz9czOsOiuF90lO8plNX8/bvT2zTUaGq4yRmamQMxxn5aUarP/FThhxC55t3Jqd/Te+FGQ9+TT/VP0wgPlc= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by AS8PR08MB7911.eurprd08.prod.outlook.com (2603:10a6:20b:509::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.34; Fri, 8 Dec 2023 18:26:08 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::6ee5:b854:81e:c23e]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::6ee5:b854:81e:c23e%7]) with mapi id 15.20.7068.028; Fri, 8 Dec 2023 18:26:08 +0000 From: Honnappa Nagarahalli To: David Marchand , "dev@dpdk.org" CC: "thomas@monjalon.net" , "ferruh.yigit@amd.com" , "bruce.richardson@intel.com" , "stephen@networkplumber.org" , "mb@smartsharesystems.com" , nd , nd Subject: RE: [RFC v2 09/14] rcu: introduce a logging helper Thread-Topic: [RFC v2 09/14] rcu: introduce a logging helper Thread-Index: AQHaKgQBFCRpFyKpQ0ms7dcphJkLyg== Date: Fri, 8 Dec 2023 18:26:08 +0000 Message-ID: References: <20231117131824.1977792-1-david.marchand@redhat.com> <20231208145950.2184940-1-david.marchand@redhat.com> <20231208145950.2184940-10-david.marchand@redhat.com> In-Reply-To: <20231208145950.2184940-10-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: FC79EA495E85FD4DAC97A313750022FC.0 x-checkrecipientchecked: true authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DBAPR08MB5814:EE_|AS8PR08MB7911:EE_ x-ms-office365-filtering-correlation-id: 1ca93356-7aa9-4511-fead-08dbf81b2597 x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr nodisclaimer: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GCqHZ5As6Wwwx1xYGbdliILwM2uhCtYyKxf0j5dS5JV2oAkT+TMqiXTStOGuLtvVjv07A0fJX8z2FBtd8eiYMHn1o9M9sXfP5OuODnBLIR6UuNXzecfdlJdjKWhMWhZc1OFUevBjTm3Kkmyj5MEkD+P1GolCyKR4V1/vG+ZvjR8nypBVjG5vHcGppbzoDKrrjPgpFkYp9AnWxlmeJC+TJ8YlzawpkEtav7izMHFjSrAY/bn+SYp/0JQ1UZEG29SxIliXzYSGLcaafVuNEFf7Z06M5BP+/iwtP7SQq1cIiX+TKNHA+OikjqNbNM0TOOBQrShzlVHV1Hsz2JLBoSgLuvTWz5Qh3GSuIijCdTPl4uXBZo09z0kiKhPfBbNxl6uam4A9l++YuMYSs/VDuMbP4D3WbTm02Yv1sdlMWgx+kts+EPyesy76N1bOyvPZCeVD1h19+M4eV3uIei3FpwjO2Ml0b0zZRoq51v64vYs33kzPtOTzDg7s0eXdLENhXu4hLMtL3P33lvQMCpk634Fy6Pmotl8JesKBV1PEGe5clLYx9kYbucpoX6lhVX9akaP927cttjx5zqPTKvcb9cULvh4G9md90J1lp7Vx5tnqSUcwswVG/NWNNsn4YuA8qraR x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(396003)(366004)(346002)(136003)(376002)(230922051799003)(186009)(64100799003)(1800799012)(451199024)(33656002)(2906002)(55016003)(64756008)(66556008)(52536014)(66446008)(54906003)(66476007)(316002)(110136005)(8676002)(38070700009)(4326008)(41300700001)(86362001)(8936002)(76116006)(66946007)(122000001)(38100700002)(5660300002)(83380400001)(478600001)(26005)(71200400001)(7696005)(9686003)(53546011)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lEwptPCQ3jgRVGaAdsPcJx+PeVz5leU6xMNFuDX6ePV1d3wurCQ7/vG9GC02?= =?us-ascii?Q?B5VImKVtoakSWjPcbvkmxxaDCfW77MaNY+Dy9YPwHXr+qI4l9+59AnUmxADg?= =?us-ascii?Q?VjK8ThmM9BLV5vlHU9PeoxtWW9/EuKqkBLJOMnrcOrTmwDY880oSrPfxi700?= =?us-ascii?Q?QoRcLuT+rq4czwzcmg1W6TmA8FMhHG44FYefwy/hU9SweGvsPZJeCbIQgHpE?= =?us-ascii?Q?PEBvLbjPdYj4y3bgSb3Ln6GqIpRcIWmJnXxgIA090nzg8403kE6AB+IwU8SF?= =?us-ascii?Q?GqCCCpiSlbkdXv+o7ioLevKV+CsoOGq5yUFxmJSzT/177k8brLdf7hTey8ph?= =?us-ascii?Q?JyiZpcclF6OhitvMlu1d9eU8E6SSI6wVFYG6QrWHmeiKcjPJFZzLg7dby1Td?= =?us-ascii?Q?F/KdK5tjOamy5hNCONCyQaINd/O5Qtj8oCKkHQtOaotb5NE5mzx2bG0tuYHu?= =?us-ascii?Q?QCldOVdIa/rJ6reuDg910RmonP+tcjfsxn01sqs6xEmDsva6fsD0WSsr43+A?= =?us-ascii?Q?BTjVFzYS+sTSGeYdjL/dKZbGCZFxpSCGE7bW9Fk375uAJnDermzaDarpZhvq?= =?us-ascii?Q?pkaaeGKaa8fTV8TfZ98FN+lIvyPl/hF2kVq++LTp/HaVaO5Fn+RYYiSbNdx3?= =?us-ascii?Q?ob0CkdZ/aJXZcPM2uupXq8PuvOM5yc1LDKVCLtkepAS49cBRjScVSD4kwom6?= =?us-ascii?Q?qdjCcmv+G8xmSsAOr9sc30Kwc1qkMEu0/paaFzuUOAXGhHQH2asYB7x/vTae?= =?us-ascii?Q?EM7pMn+ULKimOjhVjeOaP++uUDLaVWVCSPNClf3vwNaUK1gQhXTO7OdbwOIQ?= =?us-ascii?Q?DTFIVFFLR2Swv0Va7dFiwIwW9xGwvvCBK9vEAtC6C40O0kk4CyUXcMr+9Qat?= =?us-ascii?Q?bFnSRsihrtFShWgYd1me64vPer3MriT7S8Xm3p96uRwTFHiSsdTmEkCvW64J?= =?us-ascii?Q?7ucz3x5UMHwL1oxnGJFBiqwqKA7g82byW58k927SEg64TGa4tW4f75AH4ryy?= =?us-ascii?Q?UsWnXdogIvEddBi1jtCentKvWlKMfmx2cQHHbjirGZVKYtmBST3dDgl5z6BA?= =?us-ascii?Q?0VyvlGw1MJ08BLjFX9dJmtwja3RbmGv+ltmnT6llcM7/GjaD9oQNaJlxb09d?= =?us-ascii?Q?deRkvUZF/ryPkTnlgEEw85O3/MYASEbx+NEhSCypT/QAakHOMLXRFsCJTx6K?= =?us-ascii?Q?twu6eowCWu62wgT37gjIU8erRNrEq2ZbMJMdQjKeNphUgVaBrhdASrKP+C0R?= =?us-ascii?Q?NQ5AZAcbqQA6a93TnEiEaBFB66Of98abjRrDJ5eQlrKDtOIy6L8Q+eztsUrl?= =?us-ascii?Q?vw84f+s1mghAzCmmPSUUiUTc0Am7qcO2yABK9tZyWcbPVPm4oiirBHIXqtTd?= =?us-ascii?Q?gsRL0iQSEdSrdQMRNMlsQtGX32lAgH5UAvZVzpSmubJZrg7nanpVjEW2ZXl2?= =?us-ascii?Q?o/6gxlf+4BSpQVyxiEs0wnGXP6iN/rSKN7922VmcIoekULgRQvXhDDpNZxfd?= =?us-ascii?Q?LWAXHNRhn12Vafc29nuNFQgCg8pDtGLJ05U+spqwCinG1ii0yxmR+p/Q1kCx?= =?us-ascii?Q?qL3x9SWcCu6ndr9dSJ9r9LrpM2drydjD9sjlvJ7ryY5EKUy6uvkXH+9O1n+y?= =?us-ascii?Q?Yg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DBAPR08MB5814.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ca93356-7aa9-4511-fead-08dbf81b2597 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Dec 2023 18:26:08.0997 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jimqtNY8NVRoka3Vmqh6wzqEc1vqi+vmHWlVpoIRox26uN5aPgWcI8zHaGUBVW3hTqbq/UzLQClD7kXvFNt3Dw93yN8aJUKZUNpHOM4l84k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7911 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: David Marchand > Sent: Friday, December 8, 2023 9:00 AM > To: dev@dpdk.org > Cc: thomas@monjalon.net; ferruh.yigit@amd.com; > bruce.richardson@intel.com; stephen@networkplumber.org; > mb@smartsharesystems.com; Honnappa Nagarahalli > > Subject: [RFC v2 09/14] rcu: introduce a logging helper >=20 > Signed-off-by: David Marchand Thank you, looks good Reviewed-by: Honnappa Nagarahalli > --- > lib/rcu/rte_rcu_qsbr.c | 62 ++++++++++++++++-------------------------- > lib/rcu/rte_rcu_qsbr.h | 1 + > 2 files changed, 24 insertions(+), 39 deletions(-) >=20 > diff --git a/lib/rcu/rte_rcu_qsbr.c b/lib/rcu/rte_rcu_qsbr.c index > 41a44be4b9..5b6530788a 100644 > --- a/lib/rcu/rte_rcu_qsbr.c > +++ b/lib/rcu/rte_rcu_qsbr.c > @@ -19,6 +19,9 @@ > #include "rte_rcu_qsbr.h" > #include "rcu_qsbr_pvt.h" >=20 > +#define RCU_LOG(level, fmt, args...) \ > + RTE_LOG(level, RCU, "%s(): " fmt "\n", __func__, ## args) > + > /* Get the memory size of QSBR variable */ size_t > rte_rcu_qsbr_get_memsize(uint32_t max_threads) @@ -26,9 +29,7 @@ > rte_rcu_qsbr_get_memsize(uint32_t max_threads) > size_t sz; >=20 > if (max_threads =3D=3D 0) { > - rte_log(RTE_LOG_ERR, rte_rcu_log_type, > - "%s(): Invalid max_threads %u\n", > - __func__, max_threads); > + RCU_LOG(ERR, "Invalid max_threads %u", max_threads); > rte_errno =3D EINVAL; >=20 > return 1; > @@ -52,8 +53,7 @@ rte_rcu_qsbr_init(struct rte_rcu_qsbr *v, uint32_t > max_threads) > size_t sz; >=20 > if (v =3D=3D NULL) { > - rte_log(RTE_LOG_ERR, rte_rcu_log_type, > - "%s(): Invalid input parameter\n", __func__); > + RCU_LOG(ERR, "Invalid input parameter"); > rte_errno =3D EINVAL; >=20 > return 1; > @@ -85,8 +85,7 @@ rte_rcu_qsbr_thread_register(struct rte_rcu_qsbr *v, > unsigned int thread_id) > uint64_t old_bmap, new_bmap; >=20 > if (v =3D=3D NULL || thread_id >=3D v->max_threads) { > - rte_log(RTE_LOG_ERR, rte_rcu_log_type, > - "%s(): Invalid input parameter\n", __func__); > + RCU_LOG(ERR, "Invalid input parameter"); > rte_errno =3D EINVAL; >=20 > return 1; > @@ -137,8 +136,7 @@ rte_rcu_qsbr_thread_unregister(struct rte_rcu_qsbr > *v, unsigned int thread_id) > uint64_t old_bmap, new_bmap; >=20 > if (v =3D=3D NULL || thread_id >=3D v->max_threads) { > - rte_log(RTE_LOG_ERR, rte_rcu_log_type, > - "%s(): Invalid input parameter\n", __func__); > + RCU_LOG(ERR, "Invalid input parameter"); > rte_errno =3D EINVAL; >=20 > return 1; > @@ -211,8 +209,7 @@ rte_rcu_qsbr_dump(FILE *f, struct rte_rcu_qsbr *v) > uint32_t i, t, id; >=20 > if (v =3D=3D NULL || f =3D=3D NULL) { > - rte_log(RTE_LOG_ERR, rte_rcu_log_type, > - "%s(): Invalid input parameter\n", __func__); > + RCU_LOG(ERR, "Invalid input parameter"); > rte_errno =3D EINVAL; >=20 > return 1; > @@ -282,8 +279,7 @@ rte_rcu_qsbr_dq_create(const struct > rte_rcu_qsbr_dq_parameters *params) > params->v =3D=3D NULL || params->name =3D=3D NULL || > params->size =3D=3D 0 || params->esize =3D=3D 0 || > (params->esize % 4 !=3D 0)) { > - rte_log(RTE_LOG_ERR, rte_rcu_log_type, > - "%s(): Invalid input parameter\n", __func__); > + RCU_LOG(ERR, "Invalid input parameter"); > rte_errno =3D EINVAL; >=20 > return NULL; > @@ -293,9 +289,10 @@ rte_rcu_qsbr_dq_create(const struct > rte_rcu_qsbr_dq_parameters *params) > */ > if ((params->trigger_reclaim_limit <=3D params->size) && > (params->max_reclaim_size =3D=3D 0)) { > - rte_log(RTE_LOG_ERR, rte_rcu_log_type, > - "%s(): Invalid input parameter, size =3D %u, > trigger_reclaim_limit =3D %u, max_reclaim_size =3D %u\n", > - __func__, params->size, params- > >trigger_reclaim_limit, > + RCU_LOG(ERR, > + "Invalid input parameter, size =3D %u, > trigger_reclaim_limit =3D %u, " > + "max_reclaim_size =3D %u", > + params->size, params->trigger_reclaim_limit, > params->max_reclaim_size); > rte_errno =3D EINVAL; >=20 > @@ -328,8 +325,7 @@ rte_rcu_qsbr_dq_create(const struct > rte_rcu_qsbr_dq_parameters *params) > __RTE_QSBR_TOKEN_SIZE + params->esize, > qs_fifo_size, SOCKET_ID_ANY, flags); > if (dq->r =3D=3D NULL) { > - rte_log(RTE_LOG_ERR, rte_rcu_log_type, > - "%s(): defer queue create failed\n", __func__); > + RCU_LOG(ERR, "defer queue create failed"); > rte_free(dq); > return NULL; > } > @@ -354,8 +350,7 @@ int rte_rcu_qsbr_dq_enqueue(struct rte_rcu_qsbr_dq > *dq, void *e) > uint32_t cur_size; >=20 > if (dq =3D=3D NULL || e =3D=3D NULL) { > - rte_log(RTE_LOG_ERR, rte_rcu_log_type, > - "%s(): Invalid input parameter\n", __func__); > + RCU_LOG(ERR, "Invalid input parameter"); > rte_errno =3D EINVAL; >=20 > return 1; > @@ -372,8 +367,7 @@ int rte_rcu_qsbr_dq_enqueue(struct rte_rcu_qsbr_dq > *dq, void *e) > */ > cur_size =3D rte_ring_count(dq->r); > if (cur_size > dq->trigger_reclaim_limit) { > - rte_log(RTE_LOG_INFO, rte_rcu_log_type, > - "%s(): Triggering reclamation\n", __func__); > + RCU_LOG(INFO, "Triggering reclamation"); > rte_rcu_qsbr_dq_reclaim(dq, dq->max_reclaim_size, > NULL, NULL, NULL); > } > @@ -391,23 +385,18 @@ int rte_rcu_qsbr_dq_enqueue(struct > rte_rcu_qsbr_dq *dq, void *e) > * Enqueue uses the configured flags when the DQ was created. > */ > if (rte_ring_enqueue_elem(dq->r, data, dq->esize) !=3D 0) { > - rte_log(RTE_LOG_ERR, rte_rcu_log_type, > - "%s(): Enqueue failed\n", __func__); > + RCU_LOG(ERR, "Enqueue failed"); > /* Note that the token generated above is not used. > * Other than wasting tokens, it should not cause any > * other issues. > */ > - rte_log(RTE_LOG_INFO, rte_rcu_log_type, > - "%s(): Skipped enqueuing token =3D %" PRIu64 "\n", > - __func__, dq_elem->token); > + RCU_LOG(INFO, "Skipped enqueuing token =3D %" PRIu64, > dq_elem->token); >=20 > rte_errno =3D ENOSPC; > return 1; > } >=20 > - rte_log(RTE_LOG_INFO, rte_rcu_log_type, > - "%s(): Enqueued token =3D %" PRIu64 "\n", > - __func__, dq_elem->token); > + RCU_LOG(INFO, "Enqueued token =3D %" PRIu64, dq_elem->token); >=20 > return 0; > } > @@ -422,8 +411,7 @@ rte_rcu_qsbr_dq_reclaim(struct rte_rcu_qsbr_dq *dq, > unsigned int n, > __rte_rcu_qsbr_dq_elem_t *dq_elem; >=20 > if (dq =3D=3D NULL || n =3D=3D 0) { > - rte_log(RTE_LOG_ERR, rte_rcu_log_type, > - "%s(): Invalid input parameter\n", __func__); > + RCU_LOG(ERR, "Invalid input parameter"); > rte_errno =3D EINVAL; >=20 > return 1; > @@ -445,17 +433,14 @@ rte_rcu_qsbr_dq_reclaim(struct rte_rcu_qsbr_dq > *dq, unsigned int n, > } > rte_ring_dequeue_elem_finish(dq->r, 1); >=20 > - rte_log(RTE_LOG_INFO, rte_rcu_log_type, > - "%s(): Reclaimed token =3D %" PRIu64 "\n", > - __func__, dq_elem->token); > + RCU_LOG(INFO, "Reclaimed token =3D %" PRIu64, dq_elem- > >token); >=20 > dq->free_fn(dq->p, dq_elem->elem, 1); >=20 > cnt++; > } >=20 > - rte_log(RTE_LOG_INFO, rte_rcu_log_type, > - "%s(): Reclaimed %u resources\n", __func__, cnt); > + RCU_LOG(INFO, "Reclaimed %u resources", cnt); >=20 > if (freed !=3D NULL) > *freed =3D cnt; > @@ -472,8 +457,7 @@ rte_rcu_qsbr_dq_delete(struct rte_rcu_qsbr_dq *dq) > unsigned int pending; >=20 > if (dq =3D=3D NULL) { > - rte_log(RTE_LOG_DEBUG, rte_rcu_log_type, > - "%s(): Invalid input parameter\n", __func__); > + RCU_LOG(DEBUG, "Invalid input parameter"); >=20 > return 0; > } > diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h index > 6b908e7ee0..0dca8310c0 100644 > --- a/lib/rcu/rte_rcu_qsbr.h > +++ b/lib/rcu/rte_rcu_qsbr.h > @@ -36,6 +36,7 @@ extern "C" { > #include >=20 > extern int rte_rcu_log_type; > +#define RTE_LOGTYPE_RCU rte_rcu_log_type >=20 > #if RTE_LOG_DP_LEVEL >=3D RTE_LOG_DEBUG > #define __RTE_RCU_DP_LOG(level, fmt, args...) \ > -- > 2.43.0