From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D341A04C9; Mon, 14 Sep 2020 06:28:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6FB62E07; Mon, 14 Sep 2020 06:28:22 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130073.outbound.protection.outlook.com [40.107.13.73]) by dpdk.org (Postfix) with ESMTP id 0E4F2160; Mon, 14 Sep 2020 06:28:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fj6qsLYhTrwbzD5bQ+Vkpm2UVEkA26LXXC/WiN3WxCg=; b=Nody0N0gdA3rrojT1jWclNTrTiigHNfPqrxQHQdqWlJ4FuPhJMyo6iPI2u4YyOKKXqLXAkjFqrBdCaGENnj7p0/khfucdAiHrLkfzqDBnk91jdIj1gjv2sJtoYTo8i1dtPSCW4Rb3n78U1VrOoNyv34eU717Liy3czzu1EvrMTo= Received: from AM5PR0101CA0007.eurprd01.prod.exchangelabs.com (2603:10a6:206:16::20) by HE1PR0801MB1753.eurprd08.prod.outlook.com (2603:10a6:3:88::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Mon, 14 Sep 2020 04:28:19 +0000 Received: from AM5EUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:16:cafe::fb) by AM5PR0101CA0007.outlook.office365.com (2603:10a6:206:16::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16 via Frontend Transport; Mon, 14 Sep 2020 04:28:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT046.mail.protection.outlook.com (10.152.16.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16 via Frontend Transport; Mon, 14 Sep 2020 04:28:18 +0000 Received: ("Tessian outbound 34b830c8a0ef:v64"); Mon, 14 Sep 2020 04:28:18 +0000 X-CR-MTA-TID: 64aa7808 Received: from 0629e94f2730.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FFD8DB04-C835-442E-9C0E-CDAD851E47AE.1; Mon, 14 Sep 2020 04:28:12 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0629e94f2730.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 14 Sep 2020 04:28:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LFuoRGQFKN2VsSyKVMs6S0NwluZmnvUAgiyW0QvKBk0vr38Y6dmSg0amTcFvKClQGZQr31yKyFtWo3K9T/+k+5jfI0pXLRwiwgn+Vyx9K2UF/lISpwXykPSrc6XKvw0OK5WBXysu3jQK80er6/VbDtBWPXuEQvbeaa5nbBIvH8uIDTu78ZaOHJyDZn/z9Nqn2Rks5vt0felSYtGI25cgCOoTij2X7+69zY47170RdZpONRhQ55hdp2+R1Hh8mYJcrrnS4A6nL943wFNxCQYoO5MsjTQebqAw0DoOywiO4n42HX1oxhTy8ouq3oFvr6cfWeF6AXXoZv4j2RWZ0ZfUNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fj6qsLYhTrwbzD5bQ+Vkpm2UVEkA26LXXC/WiN3WxCg=; b=KW+JStEO0rIKJL+U9ZNs2S4po4/Q0Stl6u19ipSinCIKG6reX/PW7dscnYgJDn2gmem7bxRVn0CPa8NQ9z0BqIC9rQqveZOIM7u/ow/HkJQukuHLF//8b5s1+z66okJRj/OfedqR6aAsxwPAxhrxXssEhBflsxUM97HM6QbvuL3iHiFz3A5NfnqBpMxPmtDW+jm4jhkBX035tF7dXGjucsMntcJyWweQfVAZ6WqRRSHTpbSAsgunnLXSfPo/1HfX90gkDHHR3YxsybrlXIir786TOOukYDuy5niUBJRri4T2omQ5ZueL0maXbe9pm/n13ng4hm1vttel28QW7OFplA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fj6qsLYhTrwbzD5bQ+Vkpm2UVEkA26LXXC/WiN3WxCg=; b=Nody0N0gdA3rrojT1jWclNTrTiigHNfPqrxQHQdqWlJ4FuPhJMyo6iPI2u4YyOKKXqLXAkjFqrBdCaGENnj7p0/khfucdAiHrLkfzqDBnk91jdIj1gjv2sJtoYTo8i1dtPSCW4Rb3n78U1VrOoNyv34eU717Liy3czzu1EvrMTo= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB7PR08MB3882.eurprd08.prod.outlook.com (2603:10a6:10:7d::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Mon, 14 Sep 2020 04:28:10 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::408a:40fb:7402:c805]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::408a:40fb:7402:c805%6]) with mapi id 15.20.3370.019; Mon, 14 Sep 2020 04:28:10 +0000 From: Honnappa Nagarahalli To: Feifei Wang , Konstantin Ananyev , Olivier Matz , Gavin Hu CC: "dev@dpdk.org" , nd , Feifei Wang , "stable@dpdk.org" , Honnappa Nagarahalli , nd Thread-Topic: [PATCH v3 2/6] test/ring: fix wrong parameter passed to the enqueue APIs Thread-Index: AQHWiFYzhLw4yYva406yeusrp3jxBqlnjgtg Date: Mon, 14 Sep 2020 04:28:09 +0000 Message-ID: References: <20200729063105.11299-1-feifei.wang2@arm.com> <20200911161002.19816-1-feifei.wang2@arm.com> <20200911161002.19816-3-feifei.wang2@arm.com> In-Reply-To: <20200911161002.19816-3-feifei.wang2@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 1D2B96CA8FE93641B677104AE9138D2B.0 x-checkrecipientchecked: true Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.110.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 9d21c14e-dfe1-47c4-0eae-08d858669b37 x-ms-traffictypediagnostic: DB7PR08MB3882:|HE1PR0801MB1753: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:6430;OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: cXxF5wGFwqnMiCKdIy28z8OjWICdTIR+ak/znNN8aSBhdYt38jGGe2zNPBlqo42Y1Enz9haXpoacd5o2b3VDBT7N3z3J8YS/vlpxa25ek7XTqc+PHuVOuxhIUMgIiEmn8U0yABIsP6+zph+/FcFU7p3pQ+HTB0EITJ7C5mcfvO9tdVsPeejam1zii1hWA41rLpBP2/vAtZEptTRxvl8okJmeJYubkaMlFCRuH/0I3uZy2iYiIGI19y6ktJmZQMl8gOMpOt/qM1Bh+kde0fQvguTprxIcOH8eZ7FQ8K6XXv6oKmaryPWTO+1R3y7uVn45 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(366004)(39850400004)(376002)(346002)(26005)(186003)(6506007)(2906002)(7696005)(316002)(9686003)(55016002)(8676002)(4326008)(8936002)(86362001)(71200400001)(5660300002)(110136005)(6636002)(54906003)(478600001)(66476007)(66556008)(33656002)(52536014)(66446008)(76116006)(83380400001)(64756008)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: YGkQCPrsYTyKggeFMOoGqwXuEI2FnhCHuqGEUTGmmT1bTo5SLwHW5eFjYQJE+mkqyGqq+xSfOMVFhiDIcXux62aalvpIScHv9mUHEbHAc2Th6l0q/c4IkuK/YCzoc53UBshnUZ0Ud2a0jAYF5dRuUs1jW5/ahuy0voA6c5UTw+yCHgh554vkK37ZnnQ0MzJo/BjzKEmiYUTXeCZWPgXbl2EkntQdT7nrNVTP+2tIWhfx4gL2OjbWuTqzrw7AcM3vEVoFIMeO6eb+LESGBjL0Ljdt3flRDwL8UGgfrJE0mROvXwWlcg7ojCwgnJumRei8L4Hz9dQbfBL/EbFRdk94BADiRlgVIA9XJx3g2xvhRtgD1hYFbrFP1t8RRbCQ/bBcR87W2IgnqHDlBKDoEV3uM6+74bhdeVyl6OGudB5yeE/Pjpvjz2QX95S8KOOw5Km/xj40JS4NYMxNuR7QHZRHEznTejTcn8AgnkHnnxrD5mbPVyk+Ye8yBinoEJ+lkVQ1yIGk/gzseXG3/RvGZW+7CX62MeIk77/gpjyyoNh9ASC3W0hl1T2QiTOrhEgnLOijnqE5z2hsbPMEiDZi1POSMAKEshpF2K5dYz9evs4okMqvP6cDE7XEfM/2rGEP17w+nFiPAWKDEaNMidWqvSJBTw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3882 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: ca26f852-44db-4747-3165-08d858669611 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pUtxlivE3Xmy5Dfcn0AfjZ3HkzZsLZw2ra5vmOlnmwxFYHZoXezXUq/h3afn2FwNg2KPPnuv1hOrPO+TFhke4+BmOTNTE4yN9So1XIWnhQl/48r1k0f1xr9QmvZFUfRZ9UAGYHocQq42b+R08keU0Jppvb333Afb6W9iH0a9A8msrB8x5c5H5MQiSwdw3HVDi0RzbwpWGtXYHx9wCgas0FeI4MDPvZoMw2XpOVKGENv9yHrD11ZpD2dWf+oRez38xtekMa951YiR2vNwi/xDZgLZw4It1ZFW4YZGGcbSBjyHF9Ph83DQfOkzq0Q9YakCLeAIMKcv3FPyvuX/V4AYsIyGQf2BLUQTMUwdx7cGefVV3LErQEw5kJW7S3VNxQERuuKclmwUgkM3yDNpUf0msw== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(346002)(376002)(136003)(39850400004)(396003)(46966005)(4326008)(336012)(26005)(70206006)(6506007)(186003)(7696005)(82740400003)(52536014)(70586007)(36906005)(356005)(81166007)(478600001)(54906003)(110136005)(83380400001)(316002)(6636002)(5660300002)(2906002)(82310400003)(8676002)(450100002)(8936002)(33656002)(9686003)(55016002)(86362001)(47076004); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2020 04:28:18.5992 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9d21c14e-dfe1-47c4-0eae-08d858669b37 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1753 Subject: Re: [dpdk-dev] [PATCH v3 2/6] test/ring: fix wrong parameter passed to the enqueue APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > When enqueue one element to ring in the performance test, a pointer shoul= d > be passed to rte_ring_[sp|mp]enqueue APIs, not the pointer to a table of > void *pointers. >=20 > Fixes: a9fe152363e2 ("test/ring: add custom element size functional tests= ") > Cc: honnappa.nagarahalli@arm.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Feifei Wang > Reviewed-by: Ruifeng Wang > Reviewed-by: Phil Yang Reviewed-by: Honnappa Nagarahalli > --- > app/test/test_ring.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/app/test/test_ring.h b/app/test/test_ring.h index > aa6ae67ca..d4b15af7c 100644 > --- a/app/test/test_ring.h > +++ b/app/test/test_ring.h > @@ -50,11 +50,11 @@ test_ring_enqueue(struct rte_ring *r, void **obj, int > esize, unsigned int n, > if ((esize) =3D=3D -1) > switch (api_type) { > case (TEST_RING_THREAD_DEF | TEST_RING_ELEM_SINGLE): > - return rte_ring_enqueue(r, obj); > + return rte_ring_enqueue(r, *obj); > case (TEST_RING_THREAD_SPSC | TEST_RING_ELEM_SINGLE): > - return rte_ring_sp_enqueue(r, obj); > + return rte_ring_sp_enqueue(r, *obj); > case (TEST_RING_THREAD_MPMC | TEST_RING_ELEM_SINGLE): > - return rte_ring_mp_enqueue(r, obj); > + return rte_ring_mp_enqueue(r, *obj); > case (TEST_RING_THREAD_DEF | TEST_RING_ELEM_BULK): > return rte_ring_enqueue_bulk(r, obj, n, NULL); > case (TEST_RING_THREAD_SPSC | TEST_RING_ELEM_BULK): > -- > 2.17.1