From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DEC3DA0C55; Thu, 14 Oct 2021 02:19:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 507C440042; Thu, 14 Oct 2021 02:19:38 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60064.outbound.protection.outlook.com [40.107.6.64]) by mails.dpdk.org (Postfix) with ESMTP id DDC5940041 for ; Thu, 14 Oct 2021 02:19:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LZc4PWHHHYYQ5FTeTO+Aon8cAOHIMqDfnzLneWnZa5w=; b=iB6oAdZI5zRDEKQjWo1gmsZVOs1hqgzXUPa0Ww/m9QugZNDZdhiwOpc85mV2IlKMvg1j8yeLaj2EgxEBSNWGfrPpnPW5vryGBmVb7jyA5GrZlD1Gyk5bd48WYCDGhs/uLfb34sq0Yp9Gfcr2Fxu2FbyyaiRstugL9XPg08JzXw4= Received: from AS9PR06CA0220.eurprd06.prod.outlook.com (2603:10a6:20b:45e::23) by PAXPR08MB7232.eurprd08.prod.outlook.com (2603:10a6:102:1dc::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Thu, 14 Oct 2021 00:19:35 +0000 Received: from AM5EUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45e:cafe::72) by AS9PR06CA0220.outlook.office365.com (2603:10a6:20b:45e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend Transport; Thu, 14 Oct 2021 00:19:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT022.mail.protection.outlook.com (10.152.16.79) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend Transport; Thu, 14 Oct 2021 00:19:35 +0000 Received: ("Tessian outbound f1898412aff1:v103"); Thu, 14 Oct 2021 00:19:35 +0000 X-CR-MTA-TID: 64aa7808 Received: from d649fb435e2f.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6DD49981-6BDA-4E35-9B38-3FB79F6B9A1D.1; Thu, 14 Oct 2021 00:19:29 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d649fb435e2f.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 14 Oct 2021 00:19:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LOCst4RdLaUJ9mKvJvEpCQc9UJg00PZhQwMhRjeKz2K5849bQxh+DnJ6JdmyAergTsLidcp0WeE5Iqrl4/619jl2roy1sL1M1UaGWEP+D62pNYxRdAAE3aZYrVY/rhAl8pmGDEe2sHsBxUq4gIsm71Vvp4/F2s/Q855nv5o0gEc6RRpv5KB7vt51QaUfiz4H9UwlfgEODB0cQ1V9NSSxXIzDawLMwkbOqUQV2lsEXu7irVYCsQCHbJBvXmwWoiUH2Q/FfCAWejhxxy22Uka93IGBnd24/jOyhLpYxfVFajGdkbaBoPWwYGUaTcp8LEujy6UaaVS7MDulQb3wbT1a3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LZc4PWHHHYYQ5FTeTO+Aon8cAOHIMqDfnzLneWnZa5w=; b=WCO0x1GZPYhqB1YT6eq7AiRR8kvycCrAhmGNdEIL/oInXdfZim+nenhPPUl8CaFUL63Qh+HzJNCrzpjPaUACnTumlJnF+wFPPFB7hhqDPtV9/HZ97k/pK8Jb2dEJkwBTpacyteTxPYLeWCSKkYj/plbhfRRZ8M1+LFR3u45TTp1xWKdy6eakfXbT76EJOW99h+m3rWn7GDCStmaShwHQ4LcC8DYDvJg70zFWlltoQ/SWokw6lq70HTHceyfa5seDn9aJUQp38Fn6Gn16iQAtBrVg95HzhdmNuRt6OyeN7d7hmqaTP9pVv0f4wEE1txj9HnGkcr/kGqOd8hk2XkjbuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LZc4PWHHHYYQ5FTeTO+Aon8cAOHIMqDfnzLneWnZa5w=; b=iB6oAdZI5zRDEKQjWo1gmsZVOs1hqgzXUPa0Ww/m9QugZNDZdhiwOpc85mV2IlKMvg1j8yeLaj2EgxEBSNWGfrPpnPW5vryGBmVb7jyA5GrZlD1Gyk5bd48WYCDGhs/uLfb34sq0Yp9Gfcr2Fxu2FbyyaiRstugL9XPg08JzXw4= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB6PR08MB2775.eurprd08.prod.outlook.com (2603:10a6:6:17::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Thu, 14 Oct 2021 00:19:27 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::8501:86ca:a393:17b7]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::8501:86ca:a393:17b7%9]) with mapi id 15.20.4587.026; Thu, 14 Oct 2021 00:19:27 +0000 From: Honnappa Nagarahalli To: Stephen Hemminger CC: "dev@dpdk.org" , "mdr@ashroe.eu" , "yipeng1.wang@intel.com" , Dharmik Thakkar , nd , Vladimir Medvedkin , nd Thread-Topic: [dpdk-dev] [PATCH] hash: promote APIs to stable Thread-Index: AQHXwIOP5NyStr3t40OHKFHUBfYlBqvRn/MA Date: Thu, 14 Oct 2021 00:19:27 +0000 Message-ID: References: <20211013213858.16200-1-honnappa.nagarahalli@arm.com> <20211013154158.280d5db8@hermes.local> In-Reply-To: <20211013154158.280d5db8@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: E7086038BE10DA41A78C3C8A44975DFE.0 x-checkrecipientchecked: true Authentication-Results-Original: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 9b2ce1a4-39cd-45bb-37ca-08d98ea84db8 x-ms-traffictypediagnostic: DB6PR08MB2775:|PAXPR08MB7232: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:7219;OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 2hBwMyWJHq2hive45GbGXWZ4eQTqGW7TPahGUm3HoSvBdVoR+dr6uCsGKPvKOjupZYggPIy3QsPtSTM4NzJo0qG0U6B8DBK6qb2a/Ib6SUMYWES36GfnOVUQOM/SX2eychuc98YvrNGUqiku4W3PrTbVkdZWAAeQZzDanxvDPK5D5MM1kD4GX5CtdchaRiY1wSzYR6n/kU7vSHLEd7PLYa41UZxf/ABWM8N79u5TYxUUOVgkT/kaqoDmeWPYz19N52VdjGfDxHJTTlqzKQwe8/Zzc9EL3+aiGFYj2759M/pumSWY2EXjMkSB6IuyXpr6DB3YXS6P1XnbPZ/mcAgRFYE24RG2aNy7dg7k0/MkkPtCKQkAEHS7XcyRYodGL2j553TsrxbIOg65AuMM5+GUHLK40q/izToF5jiTeK/JTK0zUqjkvHtQWO0AXq3dahxzpeoM4R8JCY+wzTXUfxCbm4vjdTGk91vVxDVLHqFeN7lAPCgQ2FxuBrw3HW3Ee64dlnSwHa9PKqvXkfZPFX+Q6skK8PKurzl9K+olYlqVAcItDdoXoSsuSXUijzaoiGlDd2DofxeXlIOJdjA6h8zjwk87hsHERRqtlU/ZMlyJpSjbrQYfg78rHM06FgmCC07GsrmBRPVQU9ndW0COv4xrdZDUhXTUkITkV+IaIvZLnIu5lEe/S4aJYz37QwoNYaGESVDV0DEvmJUH9TtHclWAtA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6506007)(64756008)(55016002)(66476007)(38100700002)(2906002)(71200400001)(66446008)(4326008)(83380400001)(66556008)(66946007)(7696005)(52536014)(8676002)(5660300002)(122000001)(4744005)(33656002)(186003)(316002)(8936002)(26005)(6916009)(508600001)(38070700005)(54906003)(9686003)(76116006)(86362001); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2775 Original-Authentication-Results: networkplumber.org; dkim=none (message not signed) header.d=none; networkplumber.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 24f497af-3cea-441b-d57c-08d98ea848e2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fnqfwo1biKwJyvf+XvL3Ut0P1l9oxFl2IWjvpOwFNAXLSgux9Igv7IGRWW8qPZBzXnBsq80H/I0k7TVeLZTJ5KxqHeEuB8JTzwMW6DB6aRsZgvp29Z+lyRG+w13av6o1FQjDjJ95sd5hci9ktpkquyTLkO6hwzXQ+EJN6KD6z7UzemafwFa3x21fKiHbbXhlQ+ONiut9mQJaCzGQhyd6IoKrx4MJGiGUTDVrc7NON4snueKgnV1uBwHCOjPTSBcWEATwAUq5gsC6nAE32nQaElR9Jqbv3e6qhm1rEf0KSpoAT8VHjIBysTUQ3nAET+aamNPs4HCtxdCWKHBV2JaUPY6pXQbDUkU1x36l0GwuljNQqtGgye1dDqm1WcUPAv3N8gXdHngmAq+rzfKYkXAXAha4oH1dOiJwNNV8PgVACai1ZelekCj8BxcK97af2t6wAOdvXqzFR7Ay9thQxtT8JwpKAFlOe4Y+vJhelDS5F2+CEuGwLcZHQyyVkR9H4WfFioKtSg4vfRMYW8oFxMC2+TOe4vHPL7DrJ+2EuA5/l4U6ngWu84JPg3O7Ml0kcWZsspedl9WACYK2LTWZ+osFGM8SHY/3hRVko1IhOjekrEeBaUhNF8yrzs7sv0wtTuV3Smy5g2znHjuG+zZPhaROpmMe6vDF7pf464n5x9wpEyPPH5Npe46FSUM5ezPgLYs2ex14Qrs4FcPs5EsybX2t6Q== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(6862004)(52536014)(356005)(336012)(8676002)(81166007)(4326008)(5660300002)(47076005)(82310400003)(186003)(8936002)(54906003)(316002)(6506007)(33656002)(4744005)(83380400001)(86362001)(26005)(9686003)(36860700001)(55016002)(7696005)(70586007)(508600001)(2906002)(70206006); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 00:19:35.8564 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9b2ce1a4-39cd-45bb-37ca-08d98ea84db8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7232 Subject: Re: [dpdk-dev] [PATCH] hash: promote APIs to stable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > On Wed, 13 Oct 2021 16:38:58 -0500 > Honnappa Nagarahalli wrote: >=20 > > --- a/lib/hash/rte_hash.h > > +++ b/lib/hash/rte_hash.h > > @@ -430,7 +430,6 @@ rte_hash_get_key_with_position(const struct > rte_hash *h, const int32_t position, > > * - 0 if freed successfully > > * - -EINVAL if the parameters are invalid. > > */ > > -__rte_experimental > > int > > rte_hash_free_key_with_position(const struct rte_hash *h, > > const int32_t position); >=20 >=20 > Need to remove @warning EXPERIMENTAL in comment. Agreed >=20 >=20 > What about all the other experimental functions in here? > It looks like all of them should be promoted. I just changed the symbol that was reported by the tool. rte_thash_*** were added on 4/19/2021. Vladimir, are you ok with promoting = them? Yipeng, if you are fine, I can promote rte_hash_lookup_with_hash_bulk, rte_= hash_lookup_with_hash_bulk_data and rte_hash_max_key_id. These are around m= ore than a year.