From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5BA54A0527; Mon, 9 Nov 2020 18:24:54 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A22CB697B; Mon, 9 Nov 2020 18:24:52 +0100 (CET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80071.outbound.protection.outlook.com [40.107.8.71]) by dpdk.org (Postfix) with ESMTP id 2A5566889 for ; Mon, 9 Nov 2020 18:24:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bNSj7kHvqxPhueQiGicAwBJJlgxaSZYQztmhDIsl9lo=; b=wOa4DW3l1m0vEfdc7B5JNDnGefQVEU2b14pUvX0UBkCg31TyhCk59+qSu6DWU1NiU2i5kfLeolnvWY48jNsFhh747TEXmQ6b1MS6q37yhoL8eunADX5mW/ri+joJfdTIc/VPYzC1jx204c77AcrG9hbIlmVV8RNz8MOrW/QvFj8= Received: from AM6P191CA0077.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::18) by PA4PR08MB6238.eurprd08.prod.outlook.com (2603:10a6:102:e8::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Mon, 9 Nov 2020 17:24:47 +0000 Received: from AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8a:cafe::d9) by AM6P191CA0077.outlook.office365.com (2603:10a6:209:8a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21 via Frontend Transport; Mon, 9 Nov 2020 17:24:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT043.mail.protection.outlook.com (10.152.17.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.17 via Frontend Transport; Mon, 9 Nov 2020 17:24:47 +0000 Received: ("Tessian outbound 814be617737e:v71"); Mon, 09 Nov 2020 17:24:47 +0000 X-CR-MTA-TID: 64aa7808 Received: from acf714c38f4c.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E201E68C-9DE2-4784-B82D-5B4A2F202CF2.1; Mon, 09 Nov 2020 17:24:42 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id acf714c38f4c.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 09 Nov 2020 17:24:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PvWAFSvAZRQct8+8xfQrrhTE2BslbORBzc9RubMxZ+nbDbzi6GQ1Iim9sq0i2lQaW+diYM+H4/LZDU5cQnr/kenSeLgj+K6xZkAXFkk2FdHbN595ZpRVjf7jsLaT6/2p9lX6u5yjB0nj0ytXjHAOn/jqkPuplzSZHrk2jWIhl8Aqfg7dlfSQXvXlrjg5Dq6X8tLhYpBL2dvtVLR+6vVwB/NgVXpF+V0lRdxLMw1sZzy2xxt/ewaasdKkYaGeSpgBwMQtxd+vmBnr0AnZESFTvowQhSxDVz+v56+TD5wnaGdUkiRGkYdJxuJuGNez/vAakUXLlJx+SvM8hnNzlldRCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bNSj7kHvqxPhueQiGicAwBJJlgxaSZYQztmhDIsl9lo=; b=erjFWkmhzjYGbFvHgtMEq1GjsL1fbXDT89OrARy9G+YHkeBawrRrwOXDCzHcKXXT8H+o1cqW4dGNG3P7zE59DhmxZN3x7BAylN0JTlOXk8rBHoJ+eKPiZFTnuDPffqJ72mAxuOH99w6VBD2ZuDUT3pm2Cc7ZyNAG5SS/d1l46JYVyrIfdZG0GCPt9XXOWWawsEYccr2UZPA2enVc26Cj6hO6yKyRCbamiutMtfZNvOCHc9POunLeomJdGv/LV655YIP1Zvasul6uuBHJ0NxDkwvPCii1VQORLLrham34JyCghsxKsk0Ejk3e9tcN4R64JCNBRLtw6TgTmFywN/o8Ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bNSj7kHvqxPhueQiGicAwBJJlgxaSZYQztmhDIsl9lo=; b=wOa4DW3l1m0vEfdc7B5JNDnGefQVEU2b14pUvX0UBkCg31TyhCk59+qSu6DWU1NiU2i5kfLeolnvWY48jNsFhh747TEXmQ6b1MS6q37yhoL8eunADX5mW/ri+joJfdTIc/VPYzC1jx204c77AcrG9hbIlmVV8RNz8MOrW/QvFj8= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB7PR08MB4587.eurprd08.prod.outlook.com (2603:10a6:10:30::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Mon, 9 Nov 2020 17:24:20 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d%4]) with mapi id 15.20.3541.025; Mon, 9 Nov 2020 17:24:20 +0000 From: Honnappa Nagarahalli To: "Walsh, Conor" , "Ananyev, Konstantin" CC: "dev@dpdk.org" , "Chen, LingliX" , nd , Honnappa Nagarahalli , nd Thread-Topic: [PATCH v1] app/test: zcd needs to be initialised to fix gcc compile error Thread-Index: AQHWsszTRxk6cC6E8kGHmDv39SBl8am4TxpAgAezxQCAAAUUMIAABuCAgAAEwTA= Date: Mon, 9 Nov 2020 17:24:20 +0000 Message-ID: References: <20201104170306.1688771-1-conor.walsh@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: D3D0137B3824874C930FB43FABE7D2A4.0 x-checkrecipientchecked: true Authentication-Results-Original: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [107.77.222.108] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: fe18ac92-d1e9-49af-2fd1-08d884d45b59 x-ms-traffictypediagnostic: DB7PR08MB4587:|PA4PR08MB6238: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ADONr5KRItzsHfQyPyU9kx3WNG3xhgtjpwR2+Q8PpUdIqggRKCrbKR9fofEL/bUn33n5z2/v9XIgY1cbxHxtc26BFlCePwDn/uZxW/BtAXzOUXoGozKYXyJH1hAEgTanJnghfodRC3+mSQe7spVmrHlICiIY0r/dyTZPWFyG8Oo4110WiKxrgN/VIYkH9scVR81pj7WKdg5TvbMV4ggVsLpGnMyWfKxHuVGslOIg/IPiuuz0Mb1XUrzL6tfbnr6nYNdPI0beUuwguq2I6sZbEIKyqAVpYA5oRZ59D0+DObWPubUJB2zVjyOjNoruyWnB X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39860400002)(346002)(376002)(366004)(136003)(54906003)(52536014)(66946007)(71200400001)(33656002)(86362001)(55016002)(76116006)(8936002)(8676002)(9686003)(66556008)(478600001)(7696005)(83380400001)(6506007)(5660300002)(186003)(4326008)(66476007)(64756008)(26005)(2906002)(66446008)(316002)(110136005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: aisibOQUuRnHmifmoFgGMLBViItagOlzKKrPnGU7mNXDmRArgIa+YdNDZQcrQNvpau/0qH7hmu8uu3z9D2WhhrMM0f5wNsAVNYWhGwQzvOf35ZNxf7mYkNXQHwLXMsAuVDFX8YVxKJI7XZxthw3MujfzFk9KU/RHJOd/57j9aERUxUBqHkLg+HmbJJCrrw32tuBJQ2xl4G+ZhChswylTsuJOHmCZdz/iAQy+n1vhF9AooqQFXd8rYoOSlnKYPXCAk8AqQ80wVuRTJyYZUSLTbOiFGE3vlQn1PWm1ZMLltUEUooH4bkaypjpyV/pr57snC54v7v5EPiEie2E7qfxLk7z6Zd00ca+NAc623ghlahspV0Yl2hOwedGiJGx9t5u327YJ7dPf0WAeOsJVUn3RB5HMKl50SzuXB1Vunj3tJLwfgOt4Ek+JmGNiV+5IB38quiAPaR5lkeFB1f3c15LWhnwm1kkLbGv33mIxtpZZ6vYbTcr90yfSeOId5lhoXPFZpRxkkHKSSBnk8EinwufSeDZIPoisQqdA+rr4w4Zf0kk2fYZ7/UYRhzoQDRn7JJrj5i1lmelr6gyBfGQtdvlH5iPhTcFB16+E+pq5g9c7EUfj3jSwYfnqqFOdnCq1VRezsyGfe8ahUbhS4vkyaSH+KA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB4587 Original-Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 6fd48ce5-e746-434b-74c6-08d884d44b86 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PF72GiZ3UZ2scKNPTTTA4vZBIC7U8nzuwB8BKvxMKPZIeAxfXcwk/F/hClm98Lr3lcoc+yIEjyRF2BZz2seh4/ymepsv23bMImnPiKXaXr5EdB+k9YnJRQfszmTk3pcOqvssJmPV80grdJWH+UcGv/R4rN37K1YVAxi0vzhoyeJRjYO8nRNYy6ZOYoQnPmS6YvfBxmhjmnm68tCqr3qMqi20ifC9xZj7c9Y6mRhj2Ncy4MM4SKS4PMN5MZcPmtcvomOaMJrned4i9HlXo+0pj/ud33bULHTb2Dwuj4wDatTJ8t2NKYata5iOFOoZIliNT1hX7KeG0eEJwQPDFh9s2MpBwXelF+w8KCkuO97KkjU7cdrvGwCZzFhO9+zqBjoNyWBxUHpWYBhAEhwDSlEOxg== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(136003)(376002)(396003)(39860400002)(346002)(46966005)(36906005)(2906002)(33656002)(70206006)(70586007)(5660300002)(316002)(82310400003)(86362001)(52536014)(54906003)(110136005)(478600001)(186003)(81166007)(4326008)(26005)(83380400001)(8936002)(7696005)(47076004)(356005)(8676002)(336012)(55016002)(6506007)(82740400003)(9686003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2020 17:24:47.2880 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fe18ac92-d1e9-49af-2fd1-08d884d45b59 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6238 Subject: Re: [dpdk-dev] [PATCH v1] app/test: zcd needs to be initialised to fix gcc compile error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > > > Hi Honnappa, > > > > > > Sorry about the delayed reply. > > No problem, thank you. > > > > > The build error trace is below, the build command used was: CC=3Dgcc > > > meson > > -- > > > optimization=3D1 --werror build1; ninja -C build1 I am not sure how I > > > could fix this issue without initialising zcd. > > > > > > In file included from ../app/test/test_ring_mt_peek_stress_zc.c:5: > > > ../app/test/test_ring_stress_impl.h: In function 'test_worker': > > > ../app/test/test_ring.h:82:3: error: 'zcd.n1' may be used > > > uninitialized in this function [-Werror=3Dmaybe-uninitialized] > > > test_ring_mem_copy(zcd->ptr2, src, > > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > esize, num - zcd->n1); > > > ~~~~~~~~~~~~~~~~~~~~~ > > > ../app/test/test_ring_mt_peek_stress_zc.c:32:26: note: 'zcd.n1' was > > declared > > > here > > > struct rte_ring_zc_data zcd; > > > ^~~ > > > In file included from ../app/test/test_ring_mt_peek_stress_zc.c:5: > > > ../app/test/test_ring.h:67:2: error: '*((void *)&zcd+8)' may be used > > > uninitialized in this function [-Werror=3Dmaybe-uninitialized] > > > memcpy(dst, src, sz); > > > ^~~~~~~~~~~~~~~~~~~~ > > > ../app/test/test_ring_mt_peek_stress_zc.c:32:26: note: '*((void > > *)&zcd+8)' > > > was declared here > > I remember seeing a similar error in test_ring_st_peek_stress_zc.c. > > In the file test_ring_mt_peek_stress_zc.c, after the call to > > enqueue/dequeue API calls, we have: > > "n =3D (m =3D=3D n) ? n : 0;" > > > > This is present as the code was copied from existing code. I do not > > see why this line is required. Can you please try to remove this line > > and see if it works? >=20 > I commented out all occurrences of that line in test_ring_mt_peek_stess_z= c.c > and the build is still failing. > Trace at end of email. Thanks for checking the suggestion. Can you provide your setup details? OS = and gcc version would be good. I would like to try it. >=20 > [2339/2407] Compiling C object app/test/dpdk- > test.p/test_ring_mt_peek_stress_zc.c.o > FAILED: app/test/dpdk-test.p/test_ring_mt_peek_stress_zc.c.o > gcc -Iapp/test/dpdk-test.p -Iapp/test -I../app/test -Ilib/librte_acl - > I../lib/librte_acl -I. -I.. -Iconfig -I../config -Ilib/librte_eal/include= - > I../lib/librte_eal/include -Ilib/librte_eal/linux/include - > I../lib/librte_eal/linux/include -Ilib/librte_eal/x86/include - > I../lib/librte_eal/x86/include -Ilib/librte_eal/common - > I../lib/librte_eal/common -Ilib/librte_eal -I../lib/librte_eal -Ilib/libr= te_kvargs - > I../lib/librte_kvargs -Ilib/librte_metrics -I../lib/librte_metrics - > Ilib/librte_telemetry -I../lib/librte_telemetry -Idrivers/bus/pci - > I../drivers/bus/pci -I../drivers/bus/pci/linux -Ilib/librte_pci -I../lib/= librte_pci - > Idrivers/bus/vdev -I../drivers/bus/vdev -Ilib/librte_bitratestats - > I../lib/librte_bitratestats -Ilib/librte_ethdev -I../lib/librte_ethdev - > Ilib/librte_net -I../lib/librte_net -Ilib/librte_mbuf -I../lib/librte_mbu= f - > Ilib/librte_mempool -I../lib/librte_mempool -Ilib/librte_ring -I../lib/li= brte_ring > -Ilib/librte_meter -I../lib/librte_meter -Ilib/librte_bpf -I../lib/librte= _bpf - > Ilib/librte_cfgfile -I../lib/librte_cfgfile -Ilib/librte_cmdline -I../lib= /librte_cmdline > -Ilib/librte_cryptodev -I../lib/librte_cryptodev -Ilib/librte_distributor= - > I../lib/librte_distributor -Ilib/librte_efd -I../lib/librte_efd -Ilib/lib= rte_hash - > I../lib/librte_hash -Ilib/librte_rcu -I../lib/librte_rcu -Ilib/librte_eve= ntdev - > I../lib/librte_eventdev -Ilib/librte_timer -I../lib/librte_timer -Ilib/li= brte_fib - > I../lib/librte_fib -Ilib/librte_rib -I../lib/librte_rib -Ilib/librte_flow= _classify - > I../lib/librte_flow_classify -Ilib/librte_table -I../lib/librte_table -Il= ib/librte_port > -I../lib/librte_port -Ilib/librte_sched -I../lib/librte_sched -Ilib/librt= e_ip_frag - > I../lib/librte_ip_frag -Ilib/librte_kni -I../lib/librte_kni -Ilib/librte_= lpm - > I../lib/librte_lpm -Ilib/librte_graph -I../lib/librte_graph -Ilib/librte_= ipsec - > I../lib/librte_ipsec -Ilib/librte_security -I../lib/librte_security - > Ilib/librte_latencystats -I../lib/librte_latencystats -Ilib/librte_member= - > I../lib/librte_member -Ilib/librte_node -I../lib/librte_node -Ilib/librte= _pipeline > -I../lib/librte_pipeline -Ilib/librte_rawdev -I../lib/librte_rawdev - > Ilib/librte_reorder -I../lib/librte_reorder -Ilib/librte_stack -I../lib/l= ibrte_stack - > Idrivers/mempool/ring -I../drivers/mempool/ring -Idrivers/mempool/stack - > I../drivers/mempool/stack -Idrivers/event/skeleton - > I../drivers/event/skeleton -Idrivers/net/bonding -I../drivers/net/bonding= - > Idrivers/net/ring -I../drivers/net/ring -Ilib/librte_power -I../lib/librt= e_power - > Ilib/librte_pdump -I../lib/librte_pdump -Idrivers/crypto/scheduler - > I../drivers/crypto/scheduler -fdiagnostics-color=3Dalways -pipe - > D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Werror -O1 -include > rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat-nonliteral - > Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested- > externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict- > prototypes -Wundef -Wwrite-strings -Wno-packed-not-aligned -Wno-missing- > field-initializers -march=3Dnative -mno-avx512f -DALLOW_EXPERIMENTAL_API = - > Wno-format-truncation -D_GNU_SOURCE -fno-strict-aliasing - > DALLOW_INTERNAL_API -MD -MQ app/test/dpdk- > test.p/test_ring_mt_peek_stress_zc.c.o -MF app/test/dpdk- > test.p/test_ring_mt_peek_stress_zc.c.o.d -o app/test/dpdk- > test.p/test_ring_mt_peek_stress_zc.c.o -c > ../app/test/test_ring_mt_peek_stress_zc.c > ../app/test/test_ring_mt_peek_stress_zc.c: In function > '_st_ring_dequeue_bulk': > ../app/test/test_ring_mt_peek_stress_zc.c:13:11: error: variable 'm' set = but > not used [-Werror=3Dunused-but-set-variable] > uint32_t m; > ^ > ../app/test/test_ring_mt_peek_stress_zc.c: In function > '_st_ring_enqueue_bulk': > ../app/test/test_ring_mt_peek_stress_zc.c:31:11: error: variable 'm' set = but > not used [-Werror=3Dunused-but-set-variable] > uint32_t m; > ^ I am not sure why you are seeing the above error.