From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79988A0C42; Mon, 10 May 2021 19:21:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2BAF240140; Mon, 10 May 2021 19:21:14 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50052.outbound.protection.outlook.com [40.107.5.52]) by mails.dpdk.org (Postfix) with ESMTP id 1CB864003E for ; Mon, 10 May 2021 19:21:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l5lZSgm1faiRUP6933G7j79DoxAuhrvDT6XfvjO6lXM=; b=29vZtl/6nTryShs761pfKpcwJ9Xc6T04qRLMRp/RKz69ye6CxS3ETRLfCl/I9/c3uW6Bu2gdS7JYlKmdGBoLs/di9KqKIkABsGeRuobapmW+KzXfmiAKwlojh6M53Rb+j5BStzKgN7sbYouqB7MkDNREQg9AAhhWv0I3P+nkWx4= Received: from AM6PR0202CA0065.eurprd02.prod.outlook.com (2603:10a6:20b:3a::42) by AM0PR08MB4305.eurprd08.prod.outlook.com (2603:10a6:208:140::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Mon, 10 May 2021 17:21:09 +0000 Received: from AM5EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:3a:cafe::a4) by AM6PR0202CA0065.outlook.office365.com (2603:10a6:20b:3a::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 17:21:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT005.mail.protection.outlook.com (10.152.16.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 17:21:09 +0000 Received: ("Tessian outbound 8ca198b738d3:v91"); Mon, 10 May 2021 17:21:08 +0000 X-CR-MTA-TID: 64aa7808 Received: from 1b19a510a18d.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E21E0142-39D3-4BE8-AC14-217A51C7474A.1; Mon, 10 May 2021 17:20:59 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1b19a510a18d.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 10 May 2021 17:20:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aX8ar5VbPoq4Q/urt0RfC2/29c7rYYbcJLWNp5HJvqh60tFlLYUc8MDDGuHuOmuV00jDJCfsScPI+oCvF0uEmSXbJR0hAnf7wC8Cew0WeKH42eJsmLlEry6epB2m0CIPGDFiY6Rr9Yqsn8X5XnxKnoacZi7HaZ2RRYk1iLwtA4m2FC+2IvyKlZllxhEl1sp3leKToqOkg7GIF9QLDe3+PPIk/iykCEN16J4vna7jm1yYWOnG+qAtEvvi7NwnLgyO4UvSzvVmFiht9JEvMerQBerq+fShsqEJDx5mhjnHlOrjqe7OqoinQfVKPk4rgZKdCs/w87slZ46WJAWAi2UTSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l5lZSgm1faiRUP6933G7j79DoxAuhrvDT6XfvjO6lXM=; b=L+Y5swhWO465Oua4g33aig7JRN2+zr8Z8Ik6Lm2SdYokIRWQF6GghT4lgq29GktebXnRipnfPhy8MivjjYLq0i5aaXwOQVnXC3Kci6VHXh4nrKTerWh2aIqW42Ky92Bv95VpYI/FngVhr0UuJcAFpbC3l2aBCtrv1lDlSIQp+1MmiUZriXsfA138U3k2FL9gczCyAnhxuiy8zaJC/77zyngIru3nFB4rm2+LMIxV4U6lKZLLAXl2VYFmG2rzNiVmXdgdOWOrY8Dkuh7GvUVy/A3yCOZnrnTh7CSnqrJd3jWL7ZriWwIZQ8yDMuR1FWp4UUwaqNokQj+r5JSmWQeJow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l5lZSgm1faiRUP6933G7j79DoxAuhrvDT6XfvjO6lXM=; b=29vZtl/6nTryShs761pfKpcwJ9Xc6T04qRLMRp/RKz69ye6CxS3ETRLfCl/I9/c3uW6Bu2gdS7JYlKmdGBoLs/di9KqKIkABsGeRuobapmW+KzXfmiAKwlojh6M53Rb+j5BStzKgN7sbYouqB7MkDNREQg9AAhhWv0I3P+nkWx4= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB6PR08MB2647.eurprd08.prod.outlook.com (2603:10a6:6:22::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.27; Mon, 10 May 2021 17:20:55 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::2994:a01e:2de:f94e]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::2994:a01e:2de:f94e%7]) with mapi id 15.20.4108.031; Mon, 10 May 2021 17:20:54 +0000 From: Honnappa Nagarahalli To: Pavan Nikhilesh Bhagavatula , "thomas@monjalon.net" CC: "jerinj@marvell.com" , "juraj.linkes@pantheon.tech" , Jan Viktorin , Ruifeng Wang , Bruce Richardson , "dev@dpdk.org" , nd , Honnappa Nagarahalli , nd Thread-Topic: [EXT] Re: [dpdk-dev] [PATCH] config/arm: add ability to express arch extensions Thread-Index: AQHXRZ5HCyGToccUz0un7dD4aCCk46rc8jcAgAADhEA= Date: Mon, 10 May 2021 17:20:54 +0000 Message-ID: References: <20210505121423.850-1-pbhagavatula@marvell.com> <1699304.vFISr3HHSL@thomas> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 7F10159CDE904941978975DB8806CBEB.0 x-checkrecipientchecked: true Authentication-Results-Original: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [70.113.13.105] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: e0664eeb-88ec-4521-4114-08d913d800a5 x-ms-traffictypediagnostic: DB6PR08MB2647:|AM0PR08MB4305: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:6108;OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: /0kgXbVcgTmlEYAHM2ulHTiZBwJwqBsHLzMv/7T6vPTa5Q9GegCsND9XZm6+b75VXhNhls4ySoJH3cfD4AHOwjyDTOIpnbmzhsTYPpqs2SY1eBtt7yeZ0Oj3DHh3CWZhk9yPHIVyKqORs44aTsWKRQDuEu+BbuS9nQ+jq/MCoaeNAgoPPUKsV5pT0ZwTgC5Z6tFPEsV68Bit7zfUSGxnQpKrsEjpaFGyffg8DKpETGhBlWqNYOP5Svk09/OKTTzJw4KpoxPoBxU2bD6bVrKcd0dcrAaMKYMyYkASX5TeZzh2rbRdO4ioUedcRKc0Aob+40BmWhQdKJefidnkqlTmNmsTMkmVmX5f+SPHdH06i+rYsTTN61xnvxWPprY1Ia2+pHh/3rSrTvjrMjU5S+mI7gLvIKGy1wvrrII3/GM8WqFs8u5aUngybj2Nz1+zxhbQ3N40yyq8zcIF6fgI5VzpM5BgHwtfSMnYJK2W4KmxrwC5I2hTJKso7rABrHzgCTboIYrhgJZYc1plFgMfqq5rh1ms5CmcGzlUFpAF87iBbVlmEPRMqsAC0/tHpcMkliypK75MRBa0SlURgOBHEYaf0GCOfaUIpsKeMaMFuKxSaS3IsdL+IMBvGcoLIDIjZ/atsMVPwVDIMU4To7LHaM0UiM2LBD0l3Amm847ImO9c7zufARN8eAwh77YdM3luSUOP X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(396003)(346002)(376002)(136003)(26005)(316002)(52536014)(6506007)(71200400001)(86362001)(2906002)(83380400001)(5660300002)(55016002)(4326008)(478600001)(8676002)(38100700002)(122000001)(966005)(66946007)(76116006)(110136005)(54906003)(7696005)(64756008)(186003)(66556008)(33656002)(9686003)(66476007)(8936002)(66446008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?O6lGKMZWjR7je/kxHSlfSKBds8IVrxamg5supJVF98FdZ+d5mYLtDwgUvOFL?= =?us-ascii?Q?omTbbYxgW1duexCFgpSrLBZcix31bMW1OF01bybgGkR9HnyDJDTTiV6H2cUj?= =?us-ascii?Q?xdNpUM3ETl7J62eEXRqBDOqZJLazT7baFDvceSouozzWqIbez0AR1RU/PUz2?= =?us-ascii?Q?Kg38L5dgdnTWjJILYrw+aEo16UJH9vVBUKbKNWJhcXxALjTHoAsHyJs0BVk8?= =?us-ascii?Q?vudaLGaDQHo+t8X5jG+pWqcxcpmOIDtjV9+6W8BFfnmEzWswpKMcVmAi8m97?= =?us-ascii?Q?X1pvyJs5YTjRjFoA34vO3BJoPrQS20P10y3ogoRLlzjSvCmtCVVoJ64LZdCh?= =?us-ascii?Q?xDdBRSn54CWcQGSk+71F88yamCmZXMdRWiRIFD9CbsXWZrwD7OlEzVXgq3Iq?= =?us-ascii?Q?3goF+gNyypjuZ5VonhrQZvr3FWqGkdbS5z7irV54vLs4QXPkHh73+jqqGDcF?= =?us-ascii?Q?TsflWKbjlbk7pTU1rmOspJqxOqhXlyW7YPf5joKg51DbQsyPZcrELzAwgekm?= =?us-ascii?Q?0JHt2oWsSyEWaI0dIWwZI8tA/1WiE+cxDV0C3tylWGccA/lGzRnMHzB/Dm6x?= =?us-ascii?Q?352QeSL7krx+T2Aj2cEk/5VxG5R1nZeEvjyEWUdn3+Wpl59RIBzlDb3FKAbr?= =?us-ascii?Q?G6eBXSLhBMAILiYnvUqVvTC9QXN3WSP7MT/aI5IzlvdldNKbwK4INmgLMyaV?= =?us-ascii?Q?lWEMR/xN4PPpGkyhNAxAWpKr0xnOWtTA9EH6iI5PqXZv6st1zXy4g340QJje?= =?us-ascii?Q?3h6C80Dvqvrbt74+VJhxD1Zjdil1F50F/E+winfW4H2JKFaJh39UITPaWjuP?= =?us-ascii?Q?r+xY0iPA5yQV1qBqtTcctcalLz2ujOX+khcSjm2mW3LmHe2hNM1HJ1T2STLH?= =?us-ascii?Q?jeH92axZp+3vjixvaeglOx9lZMuYXwFn5N9gitQtVNPMvj5cQe/uHrugfJO4?= =?us-ascii?Q?4FLB8a7gXc7Gs/Z43DUy1sHgIB6Qc7Ho7gFfhJ+CMpon3FVtHxA5iAzO0d4d?= =?us-ascii?Q?7PrZAirMECEnKNiWfR43bc54Fj5QcTR5uCpe6dqpt1umKD6BG9uhbS7DUDSQ?= =?us-ascii?Q?PRqRZBr1uHokzvY7gwXvmYOT5+3hlZyTqJMw1rFYflBvSYNo9ztt2oMSW4oG?= =?us-ascii?Q?TTOYrTRHWAogm1CCHYs/QFMD02dSFND19E+kQ/T+1xKZAGYodkXRcStHy51h?= =?us-ascii?Q?HFCSG4JV9RFbi1dNBMLKofBiNuR0Ig55rl6pbF3/QjbO+bUSVHKuI5k9HkMX?= =?us-ascii?Q?ZYhXYkR/j3XFBmnhOfg6Wba1jubBBT6mob4seJSEM919Fm1B1/JS7vgogmL/?= =?us-ascii?Q?Y8jlz58GFNn3JLjFO4YOL9S2?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2647 Original-Authentication-Results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: ea4bb128-6a00-44e3-3915-08d913d7f7f1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /gXiBKWX+3Tc59oJr1Qr/updnn/YPiGbdE6benLrvTWnj7R1GMDr75igiVSWhNjXYAddNJLhPck9mJd97qsXhGH/0iJWRaC/HR7+N1G0Sz2yvhyqakXRg3Is3i9WVn0HnNxVOwGEJz+7hg3ukE/jJ38XPn81NflC947iuQwTd0h1wDxk1GJuM9EZ8DGujCLG5EV9iSKw5WpMldiMZEFMTQ+EMDEU6sM6gGHW2KqG68dhsYVAq6DmE44YnQY/RmLtHZYsxV9mxk7CQxwmNqpTUncd7NwxctAKtQwb6cUJBvSMB2jsx8P4OZ8n6KuQpacZWSYID/OuX43H9rlOSa1eFgZ4O7jhhiPIy7kPaPAE4BdjyqnfxB0A3dQ0+wzblwNEtvEic2l1L/8BuQyDLxI+ugC2NJnVAatliwPo/J8BsCNbAvo8PYimtrBy7QerCqV/dy3ZIDAcpm/39TS0ecc46S6+BOlAMFn7tDBBrtiV3YxYm/y+ZzJ3aKhI1Y/OT8QFMHIXFrRqnv3wSsGuwcW7FgsDpYeHzH7/7eiPHyt1cj5llWBX+EwPfKEneh0ABrXrMIn3jb+OphDYJs1gvWo9KlcMaqgxlfVv+70c1vsYG2KkbfUSUuALcR+re1tBJrkCyp/wGkEAigWrjKKtgH4GFCVNJYJhL4JW3M5SP7q3npHm7nWoYQiHGIV+1CpD29tPC8LwXv2UInns5wxMfgFj4tI7F9OHJ7KTWPtct2Z8luA= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(396003)(346002)(376002)(39860400002)(136003)(36840700001)(46966006)(186003)(52536014)(82310400003)(6506007)(2906002)(86362001)(36860700001)(33656002)(47076005)(9686003)(55016002)(966005)(478600001)(336012)(7696005)(26005)(8936002)(54906003)(81166007)(356005)(83380400001)(82740400003)(5660300002)(4326008)(110136005)(70206006)(316002)(8676002)(70586007); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2021 17:21:09.3769 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e0664eeb-88ec-4521-4114-08d913d800a5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4305 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] config/arm: add ability to express arch extensions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > >05/05/2021 14:14, pbhagavatula@marvell.com: > >> From: Pavan Nikhilesh > >> > >> The ARM architecture allows SoCs to have extensions in addition to > >> base profiles such as Large System Extension (LSE), CRC etc. > >> > >> Add ability to declare SoC specific extensions. > >> > >> Signed-off-by: Pavan Nikhilesh > > > >I don't know what it is fixing. It is an optimization? > >Is it candidate for next release? >=20 > Its more of an enhancement, the default n2 march flag doesn't describe > anything about the extensions that a specific SoC has. > In case of OCTEON 10 SoC it has support for LSE and CRC in additional to = the > basic n2 profile. > This patch allows SoC to add extensions to the -march flag. > Default n2 march : -march=3Darmv8.5-a+crypto+sve2 > OCTEON 10 march : -march=3Darmv8.5-a+crypto+sve2+lse+crc >=20 > Including extensions in march helps compiler generate better code. > Example adding '+lse' tells the compiler to inline C11 atomics rather tha= n > having a run time jump >=20 > https://gcc.godbolt.org/z/8hPv87dbr Can you compile the code with armv8.5-a instead of armv8-a? I see that LSE = instructions are used. https://gcc.godbolt.org/z/18MYhY7xv >=20 > I don't think this is limited to OCTEON 10 other SoC should also add thei= r > extensions to march. >=20 > > > >> --- > >> > >> More details about ARM extensions > >> https://urldefense.proofpoint.com/v2/url?u=3Dhttps- > >3A__developer.arm.com_documentation_102378_0200&d=3DDwICAg&c > >=3DnKjWec2b6R0mOyPaz7xtfQ&r=3D1cjuAHrGh745jHNmj2fD85sUMIJ2IPIDs > >IJzo6FN6Z0&m=3DyCt4te5_7VJvaJT5OXrOpFXH3UBOUqRDlHZuSVEUZHM > >&s=3DDquFBMwxMpjxWcM2Qw1c2t_ak-j6DN4rz8ce_I43RJk&e=3D > >> > >> config/arm/meson.build | 8 ++++++++ > >> 1 file changed, 8 insertions(+) > >> > >> diff --git a/config/arm/meson.build b/config/arm/meson.build index > >> 22cd81319..8aa961e5b 100644 > >> --- a/config/arm/meson.build > >> +++ b/config/arm/meson.build > >> @@ -230,6 +230,7 @@ soc_cn10k =3D { > >> ['RTE_MAX_LCORE', 24], > >> ['RTE_MAX_NUMA_NODES', 1] > >> ], > >> + 'extensions' : ['lse', 'crc'], > >> 'part_number': '0xd49', > >> 'numa': false > >> } > >> @@ -387,6 +388,7 @@ else > >> endif > >> > >> soc_flags =3D [] > >> + soc_extensions =3D [] > >> if soc_config.has_key('not_supported') > >> error('SoC @0@ not supported.'.format(soc)) > >> elif soc_config !=3D {} > >> @@ -394,6 +396,7 @@ else > >> implementer_config =3D implementers[implementer_id] > >> part_number =3D soc_config['part_number'] > >> soc_flags =3D soc_config.get('flags', []) > >> + soc_extensions =3D soc_config.get('extensions', []) > >> if not soc_config.get('numa', true) > >> has_libnuma =3D 0 > >> endif > >> @@ -431,6 +434,11 @@ else > >> # apply supported machine args > >> machine_args =3D [] # Clear previous machine args > >> foreach flag: part_number_config['machine_args'] > >> + if flag.startswith('-march') and soc_extensions.length() !=3D > >> + 0 > > > >Why condition on start with -march? >=20 > There are some implementer flags which don't have -march to add extension= s > to. >=20 > > > >> + foreach ex: soc_extensions > >> + flag +=3D '+' + ex > >> + endforeach > >> + endif > > > >