From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DF5741B83; Mon, 30 Jan 2023 19:27:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4935140DF6; Mon, 30 Jan 2023 19:27:31 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2040.outbound.protection.outlook.com [40.107.14.40]) by mails.dpdk.org (Postfix) with ESMTP id 0A01D40C35 for ; Mon, 30 Jan 2023 19:27:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nXHwppdx/HCb7owk6/oGddiR/NLe8FCnvmIdz0j15FI=; b=9x+Z/a3KOt96VWe7clD/T5fYRrhi1OoHbtG/FVR7eYGp9aMvAxqj7ALlt8Yw8QWJ/9GxthpO0vouAuhXlNmKmig8EJvBZvQpWQtPbTrXhE8qnOrojAyZq71GKYbUv8TK10Iih9sZibd1OmU03uLjIkouSfpgY/ot76FlIAXAVtk= Received: from DU2PR04CA0175.eurprd04.prod.outlook.com (2603:10a6:10:2b0::30) by DB4PR08MB9333.eurprd08.prod.outlook.com (2603:10a6:10:3f6::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.33; Mon, 30 Jan 2023 18:27:25 +0000 Received: from DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b0:cafe::71) by DU2PR04CA0175.outlook.office365.com (2603:10a6:10:2b0::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36 via Frontend Transport; Mon, 30 Jan 2023 18:27:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT023.mail.protection.outlook.com (100.127.142.253) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.21 via Frontend Transport; Mon, 30 Jan 2023 18:27:25 +0000 Received: ("Tessian outbound 43b0faad5a68:v132"); Mon, 30 Jan 2023 18:27:25 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 190d41aab1f1c0b3 X-CR-MTA-TID: 64aa7808 Received: from 1166cea96639.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 759D3C25-C51E-4715-90E9-4F80D7ED7690.1; Mon, 30 Jan 2023 18:27:19 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1166cea96639.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 30 Jan 2023 18:27:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RnwDEefkiwvxa6zWjp/BYySvPI446Pl5wxnhLkDz1fn7DTTKVSvpmVNCMwWNq15kq5C0aYbqQyOQH9BruLPzBrlEtOROmUxx/swHiy7hwgiT+ig0A26h7Nab9aEgNBqXuXK9QGWJEl7r2IuWoGC/XnakGR7k7CUXZ9jIoR1jdncY+RzpkfeqE8ek51X2QrLQplsWDsxSWc+87cIEiT2oeNa67s9gVX1C+qW1KEE0UW9LmRDoeTztejVPeJ/32ZWBX5ixpVQAIM7DBycvSUCxhwbJzQNYxb7LE5Vnzmr01ZiPskhxqKVMTP9yjmQyp+B4dc2OqArt0p0HJ5IqGBkp5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nXHwppdx/HCb7owk6/oGddiR/NLe8FCnvmIdz0j15FI=; b=U9KrPALvUlDwpRdTdJFY32ulJfs0/48fvjAhbZ7gO58jvcM3DgcKBhm8h4qWzycaCLO3gqhvBkaUCapOIFkTpgl0uatB46wUoy+I+timOae1scwEBFeiaeR5cW8y4waozgI2NSUyXzHqYQQP6smSHqAxGcH5+ncG0gWgmBTwg6BQ+wMM/MTlp6ayGSVEoGdDm1/H3EzfZgcA/ogwWrR83QJt/7cIfLScCr79eQNV//Kb62hQnAc+8yjP2j/MW+w8T7XnbQRWJDrIOdOMsc5r054QQsWgQLrywmyxHqlD8jGpQlJDYFrnIYD51q4fSYWoTI/h+SKuVzBhn07sFU0QnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nXHwppdx/HCb7owk6/oGddiR/NLe8FCnvmIdz0j15FI=; b=9x+Z/a3KOt96VWe7clD/T5fYRrhi1OoHbtG/FVR7eYGp9aMvAxqj7ALlt8Yw8QWJ/9GxthpO0vouAuhXlNmKmig8EJvBZvQpWQtPbTrXhE8qnOrojAyZq71GKYbUv8TK10Iih9sZibd1OmU03uLjIkouSfpgY/ot76FlIAXAVtk= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by PA4PR08MB6143.eurprd08.prod.outlook.com (2603:10a6:102:ed::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36; Mon, 30 Jan 2023 18:27:16 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::f8c8:b4b6:c041:ac9d]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::f8c8:b4b6:c041:ac9d%7]) with mapi id 15.20.6043.036; Mon, 30 Jan 2023 18:27:16 +0000 From: Honnappa Nagarahalli To: Junfeng Guo , "qi.z.zhang@intel.com" , "jingjing.wu@intel.com" , "ferruh.yigit@amd.com" , "beilei.xing@intel.com" CC: "dev@dpdk.org" , "xiaoyun.li@intel.com" , "helin.zhang@intel.com" , Rushil Gupta , Jordan Kimbrough , Jeroen de Borst , nd , nd Subject: RE: [RFC v2 7/9] net/gve: support basic stats for DQO Thread-Topic: [RFC v2 7/9] net/gve: support basic stats for DQO Thread-Index: AQHZNHS/ZhejyEBm/USpSQ8pd0XCgq63Rolg Date: Mon, 30 Jan 2023 18:27:16 +0000 Message-ID: References: <20230118025347.1567078-1-junfeng.guo@intel.com> <20230130062642.3337239-1-junfeng.guo@intel.com> <20230130062642.3337239-8-junfeng.guo@intel.com> In-Reply-To: <20230130062642.3337239-8-junfeng.guo@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 41F9DB85FE52484D9DC447AE4306BE5A.0 Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: DBAPR08MB5814:EE_|PA4PR08MB6143:EE_|DBAEUR03FT023:EE_|DB4PR08MB9333:EE_ X-MS-Office365-Filtering-Correlation-Id: 6e86509c-a22d-469b-d76b-08db02efa2f2 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9air4bYbJxBYsXJSc+IiuI6KlRX14NXxPfq5hTF1xbC2WFw381tFcihh5i3GBjqHhlYXkGdkjiLI0nKKa/vLbSty63grdEt66IQM73Lak7akQvvxe9+ZAmTgo3pW9eboPcfOml8A1SAD1OUev5X9XTFYsieyldQfezVADI+MXZ0wXY35dwGe71W77j9SHktXgShHDVxoXDhp5O+dZB7Xkohh6f5cHmXri4KlgEFTcnBDoogXvPsqPaNeWBWp4PAC145mayKfuArfnahZH3F/pQrLikDe3Ldi/D7TfXDA2sypbgiSckSRTHcvXPQ/cHK4/+fvj6lHfwflilH1vGIVG5QWfFCX5ZTWnJDi1jorU+zOpkrzMRmf2ZjDg7jV1n5x7JrKg3S4kJNTqzjGQqGJ7cmMdqFengcTaJbifLqSCPZj+2A/bXvE1xRqD0MJoCVQ7CkABVn89X2Wc/l7AGW7/0wc+KUN78uKVKvKtRW73m0UCfw3yAbxEXsAIrPUcycG2jusdG5iDSzz+1RZ94+ukTeQp5/51rpCwBevMxLD00EXoxD4uaC8cHbDiRiAohgQgd3abi2WnXFkhvgYPbBoNS5DKmPRLmqrs0rxihuCPn/r/zVEADt595XM3vpED/izXf9mvfom1AQ3UD+TCfhf4IoxQgy0ynyo4jJp4KuhBP009eXqBa4vDFPvht+9IykLF0ZIyN/rsFBvbC/V8ejA6Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(136003)(346002)(39860400002)(396003)(366004)(376002)(451199018)(110136005)(54906003)(66946007)(316002)(64756008)(8676002)(4326008)(76116006)(66446008)(66476007)(66556008)(8936002)(41300700001)(52536014)(5660300002)(122000001)(86362001)(33656002)(38100700002)(38070700005)(71200400001)(186003)(9686003)(53546011)(6506007)(26005)(7416002)(55016003)(2906002)(478600001)(7696005)(83380400001); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6143 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2268c628-4484-46db-201e-08db02ef9d83 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: g74lk/jMqLNFf7YPit6mUXJ5JLQJYhAHasMJtg7hh5licDaAy3R/+Ym6YXl5KAGE94CscyyPH+I6LW7/TlYJ4raiuIZZ816mTbbGe3GUbakaE3UkvzhHS/vzb7HmWgTtZsGIFzPmHAwCDGhK6jUsCI5bYI49mti34Y8ZIshBvTkz1eerJO5WCfzpA/e4LNvy2bfuiBXJwsE5mRLqLkOYrJJEgxZbQWwD2NZKD5IAeacJLnjHYmhyISaJpq2NYe6VIKBB4Wd2bpkqR/NPN1FFGSSbztATua2SRo44YGj8wHhJPHPRbIc430foN1tNsT6IRSXXU96H3Azrbu8M746NWfhsUnuHT/TS8hEdUCrJEQMCIHrtUxv8DDctAHe9K7soP3mFwn1NhiqV7T0ji05tcrEhJ+RALoyHr7DHYvQhXMNK7ZEN3sOoU+RttfxtoDcRw1rl8tFoeErST/JMtpaPIxxx3xSTd4oGYjAo6Bl/uJzi9147XIcpUCiKeXBm69eU3+4zCzo7MARBQJePCFLQ8d+vuteoy4ViXbjN63eAVhWpwprmBlpHo4ZC1XeqWLYzmoXEr8iel1I4lNh8tg+lCMT/NdSdiZac66hP6OF3JvYbkbOP9pjelNT7rUoSmKeZQUe2tXZtIATEStCxvxOIAtZJgD7VlHIifGW9eXYVLZJZcTkWIjsppPzIdtwj2m8NFA/faw9XLhlINxQrhQ3zjg== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230025)(4636009)(376002)(346002)(396003)(136003)(39860400002)(451199018)(40470700004)(36840700001)(46966006)(110136005)(5660300002)(54906003)(41300700001)(316002)(7696005)(2906002)(8936002)(52536014)(70206006)(70586007)(4326008)(478600001)(6506007)(186003)(9686003)(26005)(53546011)(8676002)(47076005)(336012)(83380400001)(82310400005)(55016003)(40480700001)(356005)(33656002)(40460700003)(86362001)(81166007)(36860700001)(82740400003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2023 18:27:25.7164 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6e86509c-a22d-469b-d76b-08db02efa2f2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB9333 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Few comments inline > -----Original Message----- > From: Junfeng Guo > Sent: Monday, January 30, 2023 12:27 AM > To: qi.z.zhang@intel.com; jingjing.wu@intel.com; ferruh.yigit@amd.com; > beilei.xing@intel.com > Cc: dev@dpdk.org; xiaoyun.li@intel.com; helin.zhang@intel.com; Junfeng Gu= o > ; Rushil Gupta ; Jordan > Kimbrough ; Jeroen de Borst > Subject: [RFC v2 7/9] net/gve: support basic stats for DQO >=20 > Add basic stats support for DQO. >=20 > Signed-off-by: Junfeng Guo > Signed-off-by: Rushil Gupta > Signed-off-by: Jordan Kimbrough > Signed-off-by: Jeroen de Borst > --- > drivers/net/gve/gve_ethdev.c | 60 ++++++++++++++++++++++++++++++++++++ > drivers/net/gve/gve_ethdev.h | 11 +++++++ drivers/net/gve/gve_rx_dqo.c = | 12 > +++++++- drivers/net/gve/gve_tx_dqo.c | 6 ++++ > 4 files changed, 88 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c = index > 89e3f09c37..fae00305f9 100644 > --- a/drivers/net/gve/gve_ethdev.c > +++ b/drivers/net/gve/gve_ethdev.c > @@ -369,6 +369,64 @@ gve_dev_info_get(struct rte_eth_dev *dev, struct > rte_eth_dev_info *dev_info) > return 0; > } >=20 > +static int > +gve_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > +{ > + uint16_t i; > + > + for (i =3D 0; i < dev->data->nb_tx_queues; i++) { > + struct gve_tx_queue *txq =3D dev->data->tx_queues[i]; > + if (txq =3D=3D NULL) > + continue; > + > + stats->opackets +=3D txq->packets; > + stats->obytes +=3D txq->bytes; > + stats->oerrors +=3D txq->errors; > + } > + > + for (i =3D 0; i < dev->data->nb_rx_queues; i++) { > + struct gve_rx_queue *rxq =3D dev->data->rx_queues[i]; > + if (rxq =3D=3D NULL) > + continue; > + > + stats->ipackets +=3D rxq->packets; > + stats->ibytes +=3D rxq->bytes; > + stats->ierrors +=3D rxq->errors; > + stats->rx_nombuf +=3D rxq->no_mbufs; > + } > + > + return 0; > +} > + > +static int > +gve_dev_stats_reset(struct rte_eth_dev *dev) { > + uint16_t i; > + > + for (i =3D 0; i < dev->data->nb_tx_queues; i++) { > + struct gve_tx_queue *txq =3D dev->data->tx_queues[i]; > + if (txq =3D=3D NULL) > + continue; > + > + txq->packets =3D 0; > + txq->bytes =3D 0; > + txq->errors =3D 0; Do these (similar ones elsewhere) need to be atomic operations? These stati= stics are being accessed from PMD and the control plane threads. > + } > + > + for (i =3D 0; i < dev->data->nb_rx_queues; i++) { > + struct gve_rx_queue *rxq =3D dev->data->rx_queues[i]; > + if (rxq =3D=3D NULL) > + continue; > + > + rxq->packets =3D 0; > + rxq->bytes =3D 0; > + rxq->errors =3D 0; > + rxq->no_mbufs =3D 0; > + } > + > + return 0; > +} > + > static int > gve_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) { @@ -407,6 +465= ,8 > @@ static const struct eth_dev_ops gve_eth_dev_ops =3D { > .rx_queue_release =3D gve_rx_queue_release, > .tx_queue_release =3D gve_tx_queue_release, > .link_update =3D gve_link_update, > + .stats_get =3D gve_dev_stats_get, > + .stats_reset =3D gve_dev_stats_reset, > .mtu_set =3D gve_dev_mtu_set, > }; >=20 > diff --git a/drivers/net/gve/gve_ethdev.h b/drivers/net/gve/gve_ethdev.h = index > d434f9babe..2e0f96499d 100644 > --- a/drivers/net/gve/gve_ethdev.h > +++ b/drivers/net/gve/gve_ethdev.h > @@ -105,6 +105,11 @@ struct gve_tx_queue { > struct gve_queue_page_list *qpl; > struct gve_tx_iovec *iov_ring; >=20 > + /* stats items */ > + uint64_t packets; > + uint64_t bytes; > + uint64_t errors; > + > uint16_t port_id; > uint16_t queue_id; >=20 > @@ -156,6 +161,12 @@ struct gve_rx_queue { > /* only valid for GQI_QPL queue format */ > struct gve_queue_page_list *qpl; >=20 > + /* stats items */ > + uint64_t packets; > + uint64_t bytes; > + uint64_t errors; > + uint64_t no_mbufs; > + > struct gve_priv *hw; > const struct rte_memzone *qres_mz; > struct gve_queue_resources *qres; > diff --git a/drivers/net/gve/gve_rx_dqo.c b/drivers/net/gve/gve_rx_dqo.c = index > 244517ce5d..41ead5bd98 100644 > --- a/drivers/net/gve/gve_rx_dqo.c > +++ b/drivers/net/gve/gve_rx_dqo.c > @@ -37,6 +37,7 @@ gve_rx_refill_dqo(struct gve_rx_queue *rxq) > next_avail =3D 0; > rxq->nb_rx_hold -=3D delta; > } else { > + rxq->no_mbufs +=3D nb_desc - next_avail; > dev =3D &rte_eth_devices[rxq->port_id]; > dev->data->rx_mbuf_alloc_failed +=3D nb_desc - > next_avail; > PMD_DRV_LOG(DEBUG, "RX mbuf alloc failed > port_id=3D%u queue_id=3D%u", @@ -57,6 +58,7 @@ gve_rx_refill_dqo(struct > gve_rx_queue *rxq) > next_avail +=3D nb_refill; > rxq->nb_rx_hold -=3D nb_refill; > } else { > + rxq->no_mbufs +=3D nb_desc - next_avail; > dev =3D &rte_eth_devices[rxq->port_id]; > dev->data->rx_mbuf_alloc_failed +=3D nb_desc - > next_avail; > PMD_DRV_LOG(DEBUG, "RX mbuf alloc failed > port_id=3D%u queue_id=3D%u", @@ -80,7 +82,9 @@ gve_rx_burst_dqo(void > *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) > uint16_t pkt_len; > uint16_t rx_id; > uint16_t nb_rx; > + uint64_t bytes; >=20 > + bytes =3D 0; > nb_rx =3D 0; > rxq =3D rx_queue; > rx_id =3D rxq->rx_tail; > @@ -94,8 +98,10 @@ gve_rx_burst_dqo(void *rx_queue, struct rte_mbuf > **rx_pkts, uint16_t nb_pkts) > if (rx_desc->generation !=3D rxq->cur_gen_bit) > break; >=20 > - if (unlikely(rx_desc->rx_error)) > + if (unlikely(rx_desc->rx_error)) { > + rxq->errors++; > continue; > + } >=20 > pkt_len =3D rx_desc->packet_len; >=20 > @@ -120,6 +126,7 @@ gve_rx_burst_dqo(void *rx_queue, struct rte_mbuf > **rx_pkts, uint16_t nb_pkts) > rxm->hash.rss =3D rte_be_to_cpu_32(rx_desc->hash); >=20 > rx_pkts[nb_rx++] =3D rxm; > + bytes +=3D pkt_len; > } >=20 > if (nb_rx > 0) { > @@ -128,6 +135,9 @@ gve_rx_burst_dqo(void *rx_queue, struct rte_mbuf > **rx_pkts, uint16_t nb_pkts) > rxq->next_avail =3D rx_id_bufq; >=20 > gve_rx_refill_dqo(rxq); > + > + rxq->packets +=3D nb_rx; > + rxq->bytes +=3D bytes; Similarly here, these should be atomic operations. > } >=20 > return nb_rx; > diff --git a/drivers/net/gve/gve_tx_dqo.c b/drivers/net/gve/gve_tx_dqo.c = index > 3583c82246..9c1361c894 100644 > --- a/drivers/net/gve/gve_tx_dqo.c > +++ b/drivers/net/gve/gve_tx_dqo.c > @@ -80,10 +80,12 @@ gve_tx_burst_dqo(void *tx_queue, struct rte_mbuf > **tx_pkts, uint16_t nb_pkts) > uint16_t nb_used; > uint16_t tx_id; > uint16_t sw_id; > + uint64_t bytes; >=20 > sw_ring =3D txq->sw_ring; > txr =3D txq->tx_ring; >=20 > + bytes =3D 0; > mask =3D txq->nb_tx_desc - 1; > sw_mask =3D txq->sw_size - 1; > tx_id =3D txq->tx_tail; > @@ -118,6 +120,7 @@ gve_tx_burst_dqo(void *tx_queue, struct rte_mbuf > **tx_pkts, uint16_t nb_pkts) > tx_id =3D (tx_id + 1) & mask; > sw_id =3D (sw_id + 1) & sw_mask; >=20 > + bytes +=3D tx_pkt->pkt_len; > tx_pkt =3D tx_pkt->next; > } while (tx_pkt); >=20 > @@ -141,6 +144,9 @@ gve_tx_burst_dqo(void *tx_queue, struct rte_mbuf > **tx_pkts, uint16_t nb_pkts) > rte_write32(tx_id, txq->qtx_tail); > txq->tx_tail =3D tx_id; > txq->sw_tail =3D sw_id; > + > + txq->packets +=3D nb_tx; > + txq->bytes +=3D bytes; > } >=20 > return nb_tx; > -- > 2.34.1