From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 20FAA439BC; Wed, 24 Jan 2024 23:57:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0D606410FB; Wed, 24 Jan 2024 23:57:47 +0100 (CET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2040.outbound.protection.outlook.com [40.107.8.40]) by mails.dpdk.org (Postfix) with ESMTP id E38EF40EE7 for ; Wed, 24 Jan 2024 23:57:44 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iOUyW6CxIA2aOJxR61LhZhzrabCgCIxbXcHXNzOX/68C8SEQBbZmL+WpaczRCY8uIxeoJlkqI1c8ugD6ti3O1XjJxttxIwj+JdzKtW+9m59C/ToShg8MyfZ6QYcEvvwtoVzqT78BhW828eijTImdLXvuOpt4FMPqcakxCAUkmk9SaM0KsJoZ9Y3TjnYEernzE1qv1F+2qJ8ak25B3lcDNWksWnjm0sMQO/nnTzkVmSz+Vr25w/jsjI35l0Xkwd/FmfV1Ue/5FRjXK8cPP02uzRR1uhfG/NFR19rYtNEDYfGcgm57dytjuC/oLFA/YphO0qfxus1d8zhDg3/pTrEQQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C8MqU25l92Hw4tift4R1+xomIz/61YojTn7V3j4MS8c=; b=n/bUd3YxFAF2LIvdq4X7BEbIu7GAjXLzSDcrWoYh9I2eO+Tpy/Nf50utlzP3CeLrAaDkl24sLt8a2BEPQRs/hVRo2eS9kYP3CW1OiX13KYYkocMrSz9YnctWnuD1T7f3y3mUtKMjh8OLAmkqn6HXzc9whQulrB/JftWZ0aYzD+AuVbX5nbHTFui9RXYs9JLGv+8CqMT92i7A42lbL0oCoKFo7RTGyp9E2zB+H7k4MOl+937il3dqpHWD7Q2vZ4aBfVvsltbgmg2Ot4b3xrkexwYVwRRLNkoKw5w6TaPowraMOtuwKf/DHqmZ9lzQkRCMjYgbYqR50/KS5Rb4OnO/4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C8MqU25l92Hw4tift4R1+xomIz/61YojTn7V3j4MS8c=; b=g+8bRDIJyVl3L+VUFNvSwW2yFWFBMM4W/53R5+uv3m7lD5rYtKp9xyCaigOWi/84IUZmwrV/jOPXpGG/qrbgghfVZL3bOuzaIhAS6m7DV1RVjGmvyqNb5za0htI6O9zqNpQv9yIkwnSzPUtRRAO22UEXEV8y6m/BV8LvCH9qAOw= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DU0PR08MB8397.eurprd08.prod.outlook.com (2603:10a6:10:407::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.22; Wed, 24 Jan 2024 22:57:43 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::6ee5:b854:81e:c23e]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::6ee5:b854:81e:c23e%7]) with mapi id 15.20.7228.022; Wed, 24 Jan 2024 22:57:43 +0000 From: Honnappa Nagarahalli To: Tyler Retzlaff , "dev@dpdk.org" CC: Bruce Richardson , Sameh Gobriel , Vladimir Medvedkin , Yipeng Wang , Stephen Hemminger , nd , nd Subject: RE: [PATCH 1/2] hash: replace zero length array with flex array Thread-Topic: [PATCH 1/2] hash: replace zero length array with flex array Thread-Index: AQHaTxMqVEuvkSCgakasQGQmrihgkbDpk0Ig Date: Wed, 24 Jan 2024 22:57:43 +0000 Message-ID: References: <1706134657-17446-1-git-send-email-roretzla@linux.microsoft.com> <1706134657-17446-2-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1706134657-17446-2-git-send-email-roretzla@linux.microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 4E3BA3FEA437B94FAEFA89873A4BF9C2.0 x-checkrecipientchecked: true authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DBAPR08MB5814:EE_|DU0PR08MB8397:EE_ x-ms-office365-filtering-correlation-id: e602fda2-aaa3-48ef-2f0b-08dc1d2fdfa0 nodisclaimer: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tAnlXZ+S+MHP9RrzjeG5+RO4vFaDl4ddrsgbz/aFcF7vQvYovKvIrEdpI+I9z9iO+GlI1+2VqPJG6U/B2sJcbYUELIVO/AfXlbpeDPL+fQv0OJrZ03aYp4yPO1XDuX5GI7c2HjKoB5S1HN+WQnApC1Fk/iC52ti3SJEk6f0Jkti25+tZ9sJJ6h2n6mSEr/CxwVG41Bo2NbN6bvh3+j1Z0ltnQG6fz3tEfMLeyMr0rZ1oru+xmiSWGpRKYRw07Suci84XESOYkZCvKPzPtcUp7SJoj6QxSP1LrdC/xiHmadNkz9TRCBLLdJG0K/C/UCiAzSb3oOV8OSknsM7Ze+uB+0gDciD8ynB3F9tNn3RJIBocTVFKmgqZ1U3GQ4nmqiSiiJrmba3tTLr0El6S2nW95H0aKib/rjht0Lboo5L4Fl+XDx4kYPs9FOR2bqmMIa8ha9E1z9EzCzeqBw0Pk3hkQpLyhST2d0rv6Ge9kIZhpTJdyY36a6E5D/FCmU7VWDRNAoyFGqr741cebfOXb7FRbpmmQ90Sbl67nv7+JUpJg9ZDe0MjrqF5ULJcD55mXNS8N5tVR7GpAJytjEqW2KoN9RiqeX6deYNiMjgU2vV6/i8fG0DOPmwbzADpNHDx4MV7 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(396003)(136003)(346002)(39860400002)(376002)(230922051799003)(64100799003)(1800799012)(186009)(451199024)(7696005)(6506007)(54906003)(9686003)(53546011)(76116006)(64756008)(316002)(66946007)(55016003)(110136005)(38100700002)(8676002)(4326008)(478600001)(52536014)(8936002)(2906002)(5660300002)(71200400001)(66556008)(66476007)(66446008)(122000001)(83380400001)(38070700009)(41300700001)(86362001)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wSHNOCrmo0hWrnjAGpkxWsnr7Fqat7kW3JzcxlXtYfuGkntwd3R3m1N5ufcp?= =?us-ascii?Q?1ZXoCBRkvZkGrPeFXky5K3KuuNrX2Hp2lWdJfKCPTHyU3h0rW0FydvODMuph?= =?us-ascii?Q?or+n3BTtPnVKst2uEbpIaFT+ex4O3Sd57i+KXGD7AJkMAfGU1oJOmstYEKqA?= =?us-ascii?Q?44PyZokndvkMqb4KhfIg8oFdh8WhPMd2tYKe7vgRwDAi2VDn3iCITtcD/Qrw?= =?us-ascii?Q?v+rFV11U8/o04M6aJzvIPPn1/JAYXVlHuQsSNEGYN9/h7mwFzk6bw71IOlFa?= =?us-ascii?Q?iDEd49xDQLxO0NVVGhEzE1UanlqceZF2oIaYcU5t+dJ8tIDsXR79Xbc0NLL8?= =?us-ascii?Q?qPr09Nmw8/HxHJV114f456/Dfi5WnkOVsWuq9gBB+WQgv+1GL8Q0dOCkH3lI?= =?us-ascii?Q?emH49s/p+TEMHD3F1m0R78FJACVGWczMs94dCzA/lCjoPPqNzyXG8NhrhG1e?= =?us-ascii?Q?MnoxZxrS9ejSHjC4nEyWqKJ7gf+t09dJYLQgx+Rz57QpfFEplHyh40qpijc1?= =?us-ascii?Q?O2bELtf5/Ktyk6+voO6T97KB9xgFxt5VXrQttPjU0TIkel9JJ8IThHVqk8pk?= =?us-ascii?Q?LLIKPGXeepdJL61XiDvOQJsbeJzHgJG/WWPl+CBndhsPPAaAEGh3c2W4SO8f?= =?us-ascii?Q?eVFGC96QWM05Oe0d8Jwtp95WhVKhfujKD7GuZP9QDPhQDjcZG6BFi5YODraW?= =?us-ascii?Q?q59HIX1ABriKgksg/RfnYMkIqx9EQr9tZBRmIbetFU7KByCx9v+x0CVxaCC/?= =?us-ascii?Q?8JWTpYFaFF84bZAe9kIpeLy+Xx7jTuBaRpWYunHIKMOmOUY5EEz/v0lI4JMY?= =?us-ascii?Q?f+PAwPhGD7vLxGaFMq9fKMJgp5/tXHWLQ09XgY+eBqqM8uiLbJdutLDV+2uu?= =?us-ascii?Q?gI6Mq5dtOosopGuOKXr+AC2p6tAoB3gZN3ha9H+pArMgPh1S+SejnCAldIww?= =?us-ascii?Q?OTcrQEDd4YuYafj1T5f/3VWaNSuRP0KDArJo5Dpc2TKcR6EjJsTWcUR94kAO?= =?us-ascii?Q?Y+Mev6/1kswzNj3JqsLnyvg2wZ7PZqwgS9dypyrbXla8Ep3U9rIyAIPtejhO?= =?us-ascii?Q?5kk2SCI0owjft2dP7dluDQ4L+YOyWRh8bIEjeM8HBmb6nTqoT+MPCWOfEOo7?= =?us-ascii?Q?r/ERG8mQODDQfQqq4f0/5BK4J4IZceOfXZHYzD8QX5r9xf3bUSbvTnvd9rM8?= =?us-ascii?Q?ZCBNDiMR3+t+sK6Xw7+Q7Jjuj9sQoWkZ82ywd7jmkAOWHButN2lbl+e3QHtT?= =?us-ascii?Q?ja1cAlJIvNeeZjr2FnjkXsjwpOPQZ1rX197PA1Fh78rUvjU/Wvrw1ehRVINC?= =?us-ascii?Q?MdwVhJ5izQ9lzxSndq/MCmntSWSwejJ52ugFvJkc6hCRruaSO/RC3EOnsmcM?= =?us-ascii?Q?yMcZfubWAYqqYXxbX5VzM4A7E1FGXT7uzYuaZg7eMrZxKurFLFpb1e7MnI3T?= =?us-ascii?Q?PDOmo4wPAeMpAjJgCs/86T+OJKH720fs8rKeE8TVcYGgoHmIwy8qnMNXKXOu?= =?us-ascii?Q?sHZrwscm+onlAg8chvSX6h+N4pwMohadjuUihREd09Tgj0KT7gOny8W0OmGE?= =?us-ascii?Q?0W+9+RzwZ3RI0ts32XI00mCM4qhVIf82/Vz4g0HOKxsh3JYpQlbdIPXWnQUL?= =?us-ascii?Q?m1BxQ2lpEhgTfgnzSIz9EReRxWPq0/8EH/czVixohoSaSNup0wXtpNKEJDMW?= =?us-ascii?Q?acPs8Q=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DBAPR08MB5814.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e602fda2-aaa3-48ef-2f0b-08dc1d2fdfa0 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2024 22:57:43.1738 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SkSE2cKHSSOZakzVJciKF2vzl2hk083sai5yOvNLpSsHwaN6orNf0daK8yuJYtobkezIhAQb/2rsHUguntLkyAjVqngxJ1Z8NBlh+BQJA2w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8397 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Tyler Retzlaff > Sent: Wednesday, January 24, 2024 4:18 PM > To: dev@dpdk.org > Cc: Bruce Richardson ; Honnappa Nagarahalli > ; Sameh Gobriel > ; Vladimir Medvedkin > ; Yipeng Wang ; > Stephen Hemminger ; Tyler Retzlaff > > Subject: [PATCH 1/2] hash: replace zero length array with flex array >=20 > Zero length arrays are GNU extension. Replace with standard flex array. >=20 > Signed-off-by: Tyler Retzlaff Reviewed-by: Honnappa Nagarahalli > --- > lib/hash/rte_thash.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c index e8de071..1= 982051 > 100644 > --- a/lib/hash/rte_thash.c > +++ b/lib/hash/rte_thash.c > @@ -80,7 +80,7 @@ struct rte_thash_subtuple_helper { > uint32_t tuple_offset; /** < Offset in bits of the subtuple */ > uint32_t tuple_len; /** < Length in bits of the subtuple */ > uint32_t lsb_msk; /** < (1 << reta_sz_log) - 1 */ > - __extension__ uint32_t compl_table[0] __rte_cache_aligned; > + uint32_t compl_table[] __rte_cache_aligned; > /** < Complementary table */ > }; >=20 > @@ -93,7 +93,7 @@ struct rte_thash_ctx { > uint32_t flags; > uint64_t *matrices; > /**< matrices used with rte_thash_gfni implementation */ > - uint8_t hash_key[0]; > + uint8_t hash_key[]; > }; >=20 > int > -- > 1.8.3.1