Re: [dpdk-dev] [PATCH] ring: fix size of name array in ring structure

[Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>]

This patch has a CI failure in DTS in test_scatter_mbuf_2048 for Fortville_Spirit NIC. I am not sure how this change is related to the failure. The log is as follows:

TestScatter: Test Case test_scatter_mbuf_2048 Result FAILED: 'packet receive error'

Has anyone seen this error? Is this a known issue?

Thanks,
Honnappa

> -----Original Message-----
> From: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Sent: Thursday, October 14, 2021 3:56 PM
> To: dev@dpdk.org; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; andrew.rybchenko@oktetlabs.ru;
> konstantin.ananyev@intel.com
> Cc: nd <nd@arm.com>; zoltan.kiss@schaman.hu
> Subject: [PATCH] ring: fix size of name array in ring structure
> 
> Use correct define for the name array size. The change breaks ABI and hence
> cannot be backported to stable branches.
> 
> Fixes: 38c9817ee1d8 ("mempool: adjust name size in related data types")
> Cc: zoltan.kiss@schaman.hu
> 
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> ---
>  lib/ring/rte_ring_core.h | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/lib/ring/rte_ring_core.h b/lib/ring/rte_ring_core.h index
> 31f7200fa9..46ad584f9c 100644
> --- a/lib/ring/rte_ring_core.h
> +++ b/lib/ring/rte_ring_core.h
> @@ -118,12 +118,7 @@ struct rte_ring_hts_headtail {
>   * a problem.
>   */
>  struct rte_ring {
> -	/*
> -	 * Note: this field kept the RTE_MEMZONE_NAMESIZE size due to ABI
> -	 * compatibility requirements, it could be changed to
> RTE_RING_NAMESIZE
> -	 * next time the ABI changes
> -	 */
> -	char name[RTE_MEMZONE_NAMESIZE] __rte_cache_aligned;
> +	char name[RTE_RING_NAMESIZE] __rte_cache_aligned;
>  	/**< Name of the ring. */
>  	int flags;               /**< Flags supplied at creation. */
>  	const struct rte_memzone *memzone;
> --
> 2.25.1