From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7CAB439CA; Fri, 26 Jan 2024 02:37:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 779CB402A7; Fri, 26 Jan 2024 02:37:17 +0100 (CET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2043.outbound.protection.outlook.com [40.107.7.43]) by mails.dpdk.org (Postfix) with ESMTP id 12E0040289 for ; Fri, 26 Jan 2024 02:37:16 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l+ZsMLPHxEoo9X4PPKBabv9xS5XhB6W28d6s/7SmSUme8IwQUB0ysgyEiuRw7XOQkoLVb3/S7fAieISAbfa3yxg9KVQhV1LWdFUCMmGCigagMGMg9ES4CicI4TARz/RqVio8MC6jbKa0Q4O+gqOXy/+X9UW+QEkZcXidTBjTtI19WqRcruPCDbYW0aOG3TLV9v/vWJ6JxFr/OLKdl0IKY4Uxz40u4kz4rkbhFMz8J29gV8/SdKNz8ozG0yJe49zL1UrcUCWiFFe34QVf4XtQHblHYurrr5DTis3UxIt+V7VVlIeutaZeJA6R+litZlwu6DVCwfxPrYaodnVsu+R+1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9qd8JkBL+xdzKc/IF5L6V4HMgV9gvFRPq94E8+aWces=; b=oaBm12PX/flp3/twlitWpsJfpiRUhCvKWmSC/49jtlWUxcf++2lC0NJOPm31F+xbredlTlCrQejOAQiFc2GuXj4mQiuWApNVW2u3KO3Xe8ZTpTOrJ8trNnmzpFiSv0iS3ICKEcIqhFXjGUMf1cOIwPxkjtLAEmbtaOIgkVuLqNLJSbYldPUb85wO2jgttVyDe83LvF/A688jOM5zabIXCGAEU6nlg05OxWwuZpfzRFf1n90rwYSqsb1CBEE54EUPzaXR/2BfxjB2Ux9UvYkxOi8LjZ65PLyIogUQST+rJfgJUQmSsUMNZ3KILALQ5aE+XuOggKy+l1wtptGMbX+TOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9qd8JkBL+xdzKc/IF5L6V4HMgV9gvFRPq94E8+aWces=; b=MZ3X6NUorlNrPs4TwHVoZuqrs9xFOpVVeYpJ/bfVZvV9yw3k39ZAO5+sCrqc3mN4bkxdu3dliL4HOfgMM/IjcQhrIyxi+2u1Zm2Crhxftyons+LLzOKiK37MpWhVxjyxK/l2sgAfcGqelDXC4k0fwIbmJCN8OrEy1UeHVHLLc84= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by AS2PR08MB9392.eurprd08.prod.outlook.com (2603:10a6:20b:594::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.22; Fri, 26 Jan 2024 01:37:13 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::6ee5:b854:81e:c23e]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::6ee5:b854:81e:c23e%7]) with mapi id 15.20.7228.027; Fri, 26 Jan 2024 01:37:13 +0000 From: Honnappa Nagarahalli To: Tyler Retzlaff , =?iso-8859-1?Q?Morten_Br=F8rup?= CC: =?iso-8859-1?Q?Mattias_R=F6nnblom?= , "dev@dpdk.org" , Tyler Retzlaff , "konstantin.v.ananyev@yandex.ru" , nd , nd Subject: RE: rte_atomic_*_explicit Thread-Topic: rte_atomic_*_explicit Thread-Index: AQHaT7/eXgXr5SRW8ESN8ro8Zo8AvLDrFzKAgAAGqgCAADGzUA== Date: Fri, 26 Jan 2024 01:37:13 +0000 Message-ID: References: <0e268757-8368-456f-ba2f-10a1969c498f@lysator.liu.se> <98CBD80474FA8B44BF855DF32C47DC35E9F1A2@smartserver.smartshare.dk> <20240125223438.GA22922@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20240125223438.GA22922@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 0B8BECC05719654295602CEFC1BE4377.0 x-checkrecipientchecked: true authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DBAPR08MB5814:EE_|AS2PR08MB9392:EE_ x-ms-office365-filtering-correlation-id: a2b64756-283b-41f6-98c2-08dc1e0f5242 nodisclaimer: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PVUa0Tu8xNAyfvgukJURLPga3jF6FKdvZjBQKCprPVq3o2OM4y3BBhkl/kImiP3e8Zm1NA9yUucAdP1fK8510/JYiD7ioe5G28Cttfk16gs2cwNUINdPDq+RJmtepW9wHrIk+SZXWjzYQloSHK4UZqH1QOnq2DZZs9jqPngHbb1LvtUQkddhkgIbQllaagRtgiYUTwPg11a36oFyhLvOxNwdONZn6N931ZNdcdlOESWVVIUclp7oeNeDjdfzEvjQ5bf3/D3YMbehImt80sSm9q2pnZ4UaCuZgB+9funaP+aSZZP37K3XurmyO5PCap//1Tu0ywwVK3cRbBij0okFceaWSogvw5r+lCdQxPUiDuMLw2kGaBHhTYmibvqFb1PnTkX/wc/6AEZnUHrfmyLH98U2MyC8OOzRKgoQm09XVeve+G844L9l6h8m5pDM9d9jlbt19ZDgqfH/JYXMSYi/k3+Oqt2uCDGDon/NlVu9wDVsCjyxfMOd2yodMmgclYyB2d7s51VNZJihkICX4MMq1xC+NrAMy0KI1mNYsupQfjUoXTjszdv41hKXKc5mbOkX3PLCTqws6vGQXPdDv8vqAdTMkmeh0QwDpnPeXDaLR9Y= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(346002)(376002)(39860400002)(366004)(396003)(230922051799003)(451199024)(64100799003)(1800799012)(186009)(55016003)(66556008)(54906003)(66476007)(5660300002)(316002)(64756008)(66946007)(8676002)(4326008)(26005)(8936002)(66446008)(110136005)(76116006)(33656002)(9686003)(52536014)(83380400001)(2906002)(71200400001)(6506007)(478600001)(86362001)(41300700001)(966005)(38070700009)(38100700002)(7696005)(122000001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?0mqoLGhHCillqGuDThQ0RD7CJCZ+xTJjxo+3KAgWWdfRyWHSVgwPgqd3Z2?= =?iso-8859-1?Q?+B1zRdovSYRDlgmOpvPUB7+yO5caOOk1P06i4QRPVK+lCDn86zYXVQLbPa?= =?iso-8859-1?Q?/ykc4No94A5PCayKFlCyZsWZNFrJGeBrOteL5iSJcNtxsskbm4sl+KBkxD?= =?iso-8859-1?Q?XQMYWbWzJ+7ywHrW/iZj1Rv4/HEauhu2uBDPbMevEHrhB+vsBWksKU4si6?= =?iso-8859-1?Q?dW46a9jDpDijLQxEpjBHu3HWTrBxgsuU5LSPJOus8ulo7ZBh1yggCmDNwu?= =?iso-8859-1?Q?Zb8o9v41KVUKrwmPPMMu6eeaWsdfEgGQQJ6PscvpA+XrsZRu2kHds13SkV?= =?iso-8859-1?Q?IoryO3WlC6DUpjan02uVJwCPafVC154fMK3rGGii2Yth43uoiXQSIE/CY5?= =?iso-8859-1?Q?FWwKiDslxOGWy8CeV0a+OVPFEi0YPLEnsZFBcxXA7TVg2cIMgWLjrJiWLL?= =?iso-8859-1?Q?8jG/C26dE4zPpSXNkyWzhyn4aPDU/K2+ufv6HIy9R1dV0LN1tvYQz0iDG7?= =?iso-8859-1?Q?iWB+qCHN7Gs7F/bgkWGyFwKV+rtbPCYyXUcuMPvMc2PxHxOJ6IxnIXy1bT?= =?iso-8859-1?Q?72t1LmHlnXi8tDKhEGF2ii+j+zJttDZlEj8ZGXbIt6JNzakHhSJrtH3L+j?= =?iso-8859-1?Q?GrR+DyvVoIfVQR5u+iGKFLLs5C/kfDOFDPwLrSMh81TYuKcGwUFv6fh49X?= =?iso-8859-1?Q?BWcIgpF8Rt3DWchqnsoMkuAvwyX8bxbZ5rgsB2kmbBaYiklBv/InHEG04B?= =?iso-8859-1?Q?WrvH97a+WuICiZ+8bxOv8/AL1FPuWhFMZVk7akZwVrbDgqlCN0Avapolqw?= =?iso-8859-1?Q?dYx461R2xXebFMoEqyZR7lTMcS0HTHwJ9w5Nrb/9Vcgnlnz2v2sCtZIFUp?= =?iso-8859-1?Q?uGq6XwEF8iT93Q420yewkVOwSIGlpsWTkY3Ic6r+LffTNzaesv0PkenbbC?= =?iso-8859-1?Q?XCMg3oDFWW8zkfMcpCoutuHtVh+qzFZJROUi3OCtHv8TWxvkOf6UBIVLmu?= =?iso-8859-1?Q?unmmuEaYJmv6JKt+dg4coLXqaU0+Nvnk0fBPDL4TVPOjFiVMtt8YPVIWoL?= =?iso-8859-1?Q?o7jTbAYJRAbsDigJmwrQxYyh5XZt49W28D1MMPdQGFvysgAZEIjK+as+KG?= =?iso-8859-1?Q?qPbqMRo52Z3SuG2uF7IQGxmM1x5i5D8/jo4EcY6rk99amdAKVrMwJGHgKM?= =?iso-8859-1?Q?rzzqkOusjcVj52Pzz+00RwP3I2zK9R/v3jBnoHAEFkdtNlc1mqD5FXpXoN?= =?iso-8859-1?Q?I8Tw7Svzu0YNe0nrzEmFJ6CpIKYPHxKiI8m3vEasHGyfNMDcbSYzmeO81x?= =?iso-8859-1?Q?njAQJUPq2hKrv8V/6Laml2BOxuTiB14q0IhuBFlCj1PhfgKK9BxxfIGX6d?= =?iso-8859-1?Q?TKbHh7K4TLWBzLXqmF2zx/DxhcfCsLN4+bTGP50THtzLBOy/MfCZPmkbvD?= =?iso-8859-1?Q?HC9CZ701UPlXfDdlvbVbzbplsFYT1vvio8tad/E+ockbLlU7yTzPMQ1288?= =?iso-8859-1?Q?w8UTTRV9POThsroWh+SjpPOW0C2JWKa0ZgYfZ8wMuRQTEane2KZejjcwYI?= =?iso-8859-1?Q?WwlRYxAWmg6Tfb0CyNSBhZvA/4GZy6+EBTNhftJYGTwhJ1WRI3RVMUoA1P?= =?iso-8859-1?Q?niXwYp3mGSQvkLNnH5z/juCh2uUdDvjdpZM2xmneOyHbk4OG4r+QWxgg?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DBAPR08MB5814.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2b64756-283b-41f6-98c2-08dc1e0f5242 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jan 2024 01:37:13.2861 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ROZSC6wREiHGrAL4q+gM4BUftkuPS1v4i2gzE0QOYQ9q/fTlHBupcT7giCC6JCpPtpy0odEDwH3C6emDYyBy69LYZrUfs5636r1DiwEh81o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9392 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >=20 > On Thu, Jan 25, 2024 at 11:10:47PM +0100, Morten Br=EF=BF=BDrup wrote: > > > From: Mattias R=EF=BF=BDnnblom [mailto:hofors@lysator.liu.se] > > > Sent: Thursday, 25 January 2024 19.54 > > > > > > Why do rte_stdatomic.h functions have the suffix "_explicit"? > > > Especially > > > since there aren't any wrappers for the implicit variants. > > > > > > More to type, more to read. > > > > They have the "_explicit" suffix to make their names similar to those i= n > stdatomic.h. > > > > You might consider their existence somewhat temporary until C11 stdatom= ics > can be fully phased in, so there's another argument for similar names. (T= his > probably does not happen as long as compilers generate slower code for C1= 1 > stdatomics than with their atomic built-ins.) >=20 > yes, there was feedback at the time it was. >=20 > * we should *not* have non-explicit versions of the macros > * the atomic generic functions should be named to match C11 standard > with a rte_ prefix. This was mainly done to ensure that users think through the memory ordering= they want to use. This also matches with the compiler atomic built-ins. Wi= thout explicit, it is sequentially consistent memory order. >=20 > > > > > > > > When was this API introduced? Shouldn't it say "experimental" > > > somewhere? > > > > They were introduced as part of the migration to C11. > > I suppose they were not marked experimental because they replaced > something we didn't want anymore (the compiler built-ins for atomics, e.g= . > __atomic_load_n()). I don't recall if we discussed experimental marking o= r not. >=20 > i don't think we discussed it since they're wrapper macros. >=20 > > > > > > Reverse paper trail: > > https://git.dpdk.org/dpdk/log/lib/eal/include/rte_stdatomic.h > > https://patchwork.dpdk.org/project/dpdk/patch/1692738045-32363-2-git- > send-email-roretzla@linux.microsoft.com/ > > https://patchwork.dpdk.org/project/dpdk/patch/1692738045-32363-2-git- > send-email-roretzla@linux.microsoft.com/ > >