From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 20DD5A0A0C; Wed, 30 Jun 2021 21:06:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9DEB240141; Wed, 30 Jun 2021 21:06:57 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30040.outbound.protection.outlook.com [40.107.3.40]) by mails.dpdk.org (Postfix) with ESMTP id F083B40040; Wed, 30 Jun 2021 21:06:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FNuY204uS0Ji1x8vtZVQz0MuNSyG0QcR35vODw/2hc4=; b=27a5sLm8ZeyiOsLOYxQnsidbBN/dcD6Mn41yTyJ4TrNyMKn57v84rx4oAXDrwd7/iac3PcI3xMvB2DkysOFMdP34cfSAUQXwRlMBocqGWRzaPCx4ukY+RNBVa2AmfLF0wdoqRGFhfqYzA9onlh7Sxa+mwxbEyW25C6Bzq1Av1dc= Received: from AM6P191CA0016.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::29) by DB7PR08MB2988.eurprd08.prod.outlook.com (2603:10a6:5:18::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.21; Wed, 30 Jun 2021 19:06:45 +0000 Received: from VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8b:cafe::80) by AM6P191CA0016.outlook.office365.com (2603:10a6:209:8b::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23 via Frontend Transport; Wed, 30 Jun 2021 19:06:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT013.mail.protection.outlook.com (10.152.19.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Wed, 30 Jun 2021 19:06:45 +0000 Received: ("Tessian outbound 3362253f4878:v97"); Wed, 30 Jun 2021 19:06:44 +0000 X-CR-MTA-TID: 64aa7808 Received: from 2c154ae1678b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 85F0BFAD-10CC-40E2-900A-09AAB79AD1CC.1; Wed, 30 Jun 2021 19:06:36 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2c154ae1678b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 30 Jun 2021 19:06:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TRUZT/l4t2z/7L3kQ49G2jp7w5JEhdGjs3arIlF8AnAGzCNMP/Mh/WMDBx7T+g+EY+MCCs3Bs8k7PJMgXdZ6imX8xbiz/d14s1BA7obbGDVQyrpo4alT1Vw+emBgVnpu+g/pAyP45plp+T2iaYmroLdI5EJEYZDiDv7P42MagVKRDw/p07yk3PmIkKM2WC94MjlPEUACb8pmj2EmFl19ZBSHoy5xPeGWyaCxUbiZNxMuELqEB2IEA3VxfcknAJFUvkOegnfph3kBodDdZoyC78exX4xH/3IZluAi2JQTEj5HQHJHS7vhp2AgDYRlwePpWFNY+VemxRn4rlSiA6rrEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FNuY204uS0Ji1x8vtZVQz0MuNSyG0QcR35vODw/2hc4=; b=ZPBEuGy92rJfEXcLq6r+hFGkntVeX+nVkhxd4JzHF03Bt7eANEus23xGuuPZ8QkVqreFku6kIOmthihHpQsq3wZPN8+U6/lDP7QSVcyFE39EGXZFHJrenLMkeHDANKjKEo24OWfQg7R/pk7TOvW8sXmqdQdzdYcTHpoc2Yebm5isHHTU9ldlrjyeTAPjpRr/2zFhpQ6ibUpebeSnjWMUYacurpHOHR7vO0AbpZx+Pt1qdbLV5kf5Ywo/5nSkbTbNMTyqa4K+rH+7ArmjkbEBafTeLHVcMk2ckoFIXIhmP0c/lgPlO8VvBHtj7F03mqeJU1AGoB53Tiheojnh+uDc3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FNuY204uS0Ji1x8vtZVQz0MuNSyG0QcR35vODw/2hc4=; b=27a5sLm8ZeyiOsLOYxQnsidbBN/dcD6Mn41yTyJ4TrNyMKn57v84rx4oAXDrwd7/iac3PcI3xMvB2DkysOFMdP34cfSAUQXwRlMBocqGWRzaPCx4ukY+RNBVa2AmfLF0wdoqRGFhfqYzA9onlh7Sxa+mwxbEyW25C6Bzq1Av1dc= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB6PR0801MB1958.eurprd08.prod.outlook.com (2603:10a6:4:73::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Wed, 30 Jun 2021 19:06:31 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::f15f:821c:74c5:2482]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::f15f:821c:74c5:2482%2]) with mapi id 15.20.4287.023; Wed, 30 Jun 2021 19:06:31 +0000 From: Honnappa Nagarahalli To: Tyler Retzlaff CC: "thomas@monjalon.net" , Joyce Kong , "dev@dpdk.org" , "david.marchand@redhat.com" , "stephen@networkplumber.org" , "olivier.matz@6wind.com" , "andrew.rybchenko@oktetlabs.ru" , "harry.van.haaren@intel.com" , Ruifeng Wang , nd , "techboard@dpdk.org" , nd Thread-Topic: [dpdk-dev] [PATCH v2 0/8] use GCC's C11 atomic builtins for test Thread-Index: AQHXYlsX55q9L1IEsEyhls7s9yhriasYVEyAgACD8ECACJcSgIAJ3QFwgAGwv4CAAAHDMA== Date: Wed, 30 Jun 2021 19:06:31 +0000 Message-ID: References: <20210604094624.31308-1-joyce.kong@arm.com> <20210617152155.GD29777@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <7557795.l8Y19qOmnl@thomas> <20210630185107.GA14701@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20210630185107.GA14701@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 4135BD7029B760408BB80937029FF55A.0 x-checkrecipientchecked: true Authentication-Results-Original: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [70.113.13.105] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 922d7c63-70ec-49fc-5a66-08d93bfa342e x-ms-traffictypediagnostic: DB6PR0801MB1958:|DB7PR08MB2988: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3qQ18ki1CYGKvaEzh8bZMsvGsugSnPUrLV0e/l207arOQPppVVwDmlZmJ+XqoewTt0x05Lg2bzaG0f1cbb49GPNz22ckQnSfnvrDgrfjIVrswZsMIf4DPi+ESS2qcJiBg0N2LAov8CPYLR6iNYd/Zcx2H9aM73wGGTzZ6LOThuuU6HFzlVLbZ8lN0ZhWLqP+9vUndgUjkyv9hhKW/rpeuac7H7mkGfvc0wcIUoKU3YPglUCPkhV8OnZ3IK0AEKie6FpWHJDjUapVXHfG6UGnL8ZxMDfR35xb26MBr9QXSZ4QqJn0rNvamjnLYpeV2rygBQV0fN1OfuQCUU0eEEfCj6rDGbWlK7NJn9jW9X5WOu88xSo90Nkixi44DpZgnmWJxXEAVXbLYlvb7E8PolWQ9CyOLNyFVUtjJJTX8GMm79ifArxpJkCfQPg5OES5LjKQAXyPD/cxL80+wEF6xExocnDI2Y9o2FzuOtCtGi884PNcKhb6sl4dJUnA5wreCK5dWnfuo9FihHP7tQr2NhzmIN/nM0Ev4wjMiqowsgbWhTQu20RtTDtm25+ylIIKV8PQUgQSWjT2+0PsLOb8B4w+7gB48HYto/ZS0W5JE4P8QqLQRctz3M4ofX4T85yCXaGRZYsinklusSi0Fw1ZUt6XDgrfq4oqwX9a/Vf57I12/i1g/Owcfi+XGG6J/un+fWaalh+gPc1z1wFMqU3XPTn7XQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39850400004)(346002)(136003)(366004)(396003)(376002)(83380400001)(33656002)(9686003)(55016002)(71200400001)(6916009)(4326008)(478600001)(66946007)(86362001)(122000001)(66446008)(64756008)(66556008)(66476007)(38100700002)(26005)(2906002)(6506007)(186003)(52536014)(8676002)(5660300002)(54906003)(8936002)(7696005)(316002)(76116006)(21314003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1INTRbNHfzwV+RwBQXzw3bGdzaIS3zhHz/uuO3t8p1V1KQ8RZTnwmhwUxIgj?= =?us-ascii?Q?ho0+WUNufzYkUBz3vVsLbBDKmEx5BQKcOlAjyQhpnymUuaGPASdYcaMxOtse?= =?us-ascii?Q?/fSWEg29leDOVKoSKv+xNY4Y15a6b4pje7o2rtSW9MyYSFp3Sv4XyD9iLRZY?= =?us-ascii?Q?D4Mg1S/RNW99huDgfyysszg+lRVNUZD3acHGXmNEU4Uj9YycWj8dtiT1yxwq?= =?us-ascii?Q?fReEMydS115WdE+0qeoxzc68pE4LVFewMgb1WjW/E+3Q7gSDk4hEHwk0RDo3?= =?us-ascii?Q?I+n1hSPXjXXrK97w+WO+mc/igmeYHEsfCVzD04FSqxUYT2cfto3AH0pCa4hD?= =?us-ascii?Q?iW5BeCQ9BRfqaCaLkxDjYZ+pdRoCPEzG5HgB/+HvLTMyzGiAW36GPQ0+YoWU?= =?us-ascii?Q?koxMxZ4UB/4buPexMzQ5EV27Xgv2hprE8qkryBerII3QZdgkRjRFFpI/voAc?= =?us-ascii?Q?8Ko947J6tkBNypsAiHpKWWsMV+0o0dwnbnOhgl/8L2KK3Msa3/nI2EZCxzCy?= =?us-ascii?Q?lnr93kN2lCV3wvGE9r9CBT+739BFPoAzarsU9RPH/2Top10+reV1ZP5bO7ey?= =?us-ascii?Q?CN6rz5o3UukJl54fAce9DymFFfER1u3ckF2TtjyF+IC2scXTlvZTtkeuDIKV?= =?us-ascii?Q?GYeHHAB4HF8Irw5QWiphaZcANXW9OqYFclwKJh7p14X/U3sG6D69jJOt0vIC?= =?us-ascii?Q?+9LXz/GZ0K+JJ83WZelzdruKPkyOjpYqoycaaVHyf5hc0/4aQqiFRO7lzBG8?= =?us-ascii?Q?qqm2i6skWPqnKQFwhfcBfta+xqPbIMAEKWVBbd8u3pckJNzTxv5fboVvlSUv?= =?us-ascii?Q?v/hmx7OtJQSrnWP1mKLIqLXDyai0eIW22/tdGZjFhiQhgwmMNNwiYGc2as/+?= =?us-ascii?Q?eONGECT0/66WM83iohwSwWxfH4FBDDF5968E1yF4Ke1Grytv1958fmJKrgd+?= =?us-ascii?Q?p1XCHXKKHSDGCNhVUAZal7nxa5RF8pDiu6bqtqh4/NKucIwnJJOa//s4R3VY?= =?us-ascii?Q?3s5X8QuUDR+csEmpS8Axp96ZDrBvNEMU155cYTqZIkt6tsxIq70TpY91UUum?= =?us-ascii?Q?D+hXVFAiMKxtImV+cns14Ze0QhduThB5wTKYaNJ7/Ass8zQTonUZjqat/04i?= =?us-ascii?Q?98eL894+fgmvgHROExVgvCcaP+t8P85Xsc5I/IP3Com5JZRSEf2Hy10xvH8q?= =?us-ascii?Q?sKKIdhCkNzWCuUC5AsR6RzZffyMtqMoVKodwYYNWzVDQwCNOqlQA7man3G17?= =?us-ascii?Q?Qcu236Zxwwxs+gNgmemnJjApblxq8vtmByuwrC3eQUlhAE5eWGIGLCetL+ZO?= =?us-ascii?Q?ldIumhj0KvU1qt5RDipdzEUZ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1958 Original-Authentication-Results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 26e970ec-c6f4-4b03-2c82-08d93bfa2c39 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BacbWnXa7bQPbu6mUPZ6yiezg0INR9levF+lMyQNdBhhEz4eg0aN1B7krJ/SMhtiZgi0yNBr5zEhLRjq8oQv2H4pE6snLE4/skuzQPSnTzpc+x6LW2okGpTdl71YziIsg/jWnJzhlOt1Ry7MmtI6GQToOV+GCVg1waNpyb4j3S3dETrIKoc24k7CIF4O8xVl1HslBkzMkC1+l1yvN3JvWdhtH/Vq3vZz4XhZQn0/cYZ+NIiE1+A2ZHiUuMkm8Tg7Smdpm41BmPsIaoTvL0Z5CZZYUipSI6nePltUXkOTDDOJF6idyEZRcKMjAXxpTNet/yq6885ESj2IDtrt7TeTyts8jFSGbiSUM04teDNQGD2uPQPUTa+R6zLEn6bjTc5PKtYrkBgOUUMoOt1aRgSsvBE7700uoimmAdui3weBSiOpBAtM/7wI1qSmeA0NqHQWUuQrLCkZ6heEzVXeUOIdOfzmpt6IgjzsREiOFE8SXPHOmneyjqOoZFOXa/wn87a6356x5BpXqxVhxyNN8HKKsRdei6HtdhdQdUVMIJZEmBaTKbay1SsjAF1IMm0t0v59TxTt9Fx42IlAjj1tMCEWOFCYZD68LiplXdGHJDkiBd6jf1rV+pJr9gVDPHWapgR3IJDxF52jDSHjLtBsG2ziTgvkED3yGbsk8u3Z5HjIiVF1/51VSWx4N0yOy9/0WW5D2nl5+Jwf5At7c5jPwPGyruPg+o4YIQOEWB/ytZDzpfk= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(396003)(136003)(346002)(376002)(39850400004)(46966006)(36840700001)(82310400003)(4326008)(336012)(356005)(6862004)(5660300002)(186003)(81166007)(26005)(316002)(54906003)(55016002)(9686003)(82740400003)(478600001)(83380400001)(70206006)(70586007)(86362001)(8936002)(33656002)(2906002)(6506007)(8676002)(7696005)(47076005)(450100002)(52536014)(36860700001)(21314003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2021 19:06:45.1312 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 922d7c63-70ec-49fc-5a66-08d93bfa342e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB2988 Subject: Re: [dpdk-dev] [PATCH v2 0/8] use GCC's C11 atomic builtins for test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > > > 18/06/2021 01:26, Honnappa Nagarahalli: > > > > > On Tue, Jun 15, 2021 at 09:54:51PM -0500, Joyce Kong wrote: > > > > > > Since C11 memory model is adopted in DPDK now[1], use GCC's > > > > > > atomic builtins in test cases. > > > > > > > > > > as previously discussed these atomics are not "C11" they are > > > > > direct use of gcc builtins. please don't incorporate C11 into > > > > > the title of the patches or commit messages since it isn't. > > > > > > > > GCC supports 2 types of built-in atomics, __atomic_xxx[1] and > > > > __sync_xxx [2]. > > > > We need a way to distinguish between them. > > > > We are using "C11" as [1] says they match C++11 memory model. > > > > > > I agree it would be more correct to mention "compiler builtin" > > > as it is not strictly the C11 API. > > The log already mentions "GCC's C11 atomic builtins". I think that is c= orrect > enough and represents the change correctly. >=20 > it's misleading and does not attract the correct reviewers particularly d= ue to > prominence in the commit/mail subject. >=20 > please change it to "Use GCC atomic builtins" which describes clearly the > actual change without ambiguity. using "C11" implies the patch is adding > code that uses C11 stdatomic.h and it doesn't. As I mentioned earlier in this thread, GCC supports 2 types of atomics. "Us= e GCC atomic builtins" does not help distinguish between them. In "GCC's C1= 1 atomic builtins" - "C11" indicates which atomics we are using, "atomic bu= iltins" indicates that we are NOT using APIs from stdatomic.h