From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <naoyuki.mori@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 79D5D558C
 for <dev@dpdk.org>; Thu, 10 Nov 2016 15:43:16 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga105.fm.intel.com with ESMTP; 10 Nov 2016 06:43:15 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,619,1473145200"; 
   d="scan'208";a="2377440"
Received: from kmsmsx151.gar.corp.intel.com ([172.21.73.86])
 by orsmga002.jf.intel.com with ESMTP; 10 Nov 2016 06:43:14 -0800
Received: from pgsmsx107.gar.corp.intel.com ([169.254.7.110]) by
 KMSMSX151.gar.corp.intel.com ([169.254.10.34]) with mapi id 14.03.0248.002;
 Thu, 10 Nov 2016 22:43:13 +0800
From: "Mori, Naoyuki" <naoyuki.mori@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "bjorn.topel@gmail.com"
 <bjorn.topel@gmail.com>, "Yao, Lei A" <lei.a.yao@intel.com>, "Topel, Bjorn"
 <bjorn.topel@intel.com>, "Zhang, Helin" <helin.zhang@intel.com>, "Ananyev,
 Konstantin" <konstantin.ananyev@intel.com>, "Xu, Qian Q"
 <qian.q.xu@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>
Thread-Topic: [PATCH] examples/l3fwd: force CRC stripping for i40evf
Thread-Index: AQHSO1lgjJAAoTEDM0qc6H7cRDp2S6DRwamAgACHUYA=
Date: Thu, 10 Nov 2016 14:43:13 +0000
Message-ID: <DBB1BBAA76A0CF46AFFD855C5296B7EE48B2089E@PGSMSX107.gar.corp.intel.com>
References: <5952EEAD-ED55-4C0B-86EB-945B87637CD2@intel.com>
 <50996464.o08F9XFMCf@xps13>
In-Reply-To: <50996464.o08F9XFMCf@xps13>
Accept-Language: ja-JP, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzY1ZTNmZjEtYTNhNS00NGI4LWIxMmMtNTY5YjVhNzY1OWEzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik9JUEF4b011K05pUnQyMENUdkVxeFlnR1RDXC82XC94WHI1eHFkeVhIYm5OMD0ifQ==
x-ctpclassification: CTP_IC
x-originating-ip: [172.30.20.205]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: force CRC stripping for
	i40evf
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Nov 2016 14:43:16 -0000

Hi Thomas,

> 2016-11-10 13:50, Mori, Naoyuki:
> > >    Thomas wrote:
> > >     > Just to make it sure, you mean returning an error in the driver=
 when
> > >     > a configuration cannot be applied, right?
> > >
> > >    Yes, as in 1bbcc5d21129 ("i40evf: report error for unsupported CRC
> > >    stripping config"), where -EINVAL is returned.
> > >
> > >    Bj?rn
> >
> > On my experience, OvS+DPDK has same issue.
> > You cannot run OvS on i40evf due to this CRC config mismatch, while OvS=
 on
> ixgbevf works fine.
> > So, changing on i40evf PMD side would have more benefit, I believe.
>=20
> No I think OVS should handle the configuration error.
> We could also add a function to query this capability before configuring.

That would be fine, as long as it became a well-known standard.
But at least, hope i40evf and ixgbevf to be consistent in this CRC handling=
.


Thanks,
Mori