Re: [dpdk-dev] [PATCH v3 3/9] ring: introduce RTS ring mode

[Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>]

<snip>

> > > > >
> > > > > diff --git a/devtools/libabigail.abignore
> > > > > b/devtools/libabigail.abignore index a59df8f13..cd86d89ca 100644
> > > > > --- a/devtools/libabigail.abignore
> > > > > +++ b/devtools/libabigail.abignore
> > > > > @@ -11,3 +11,10 @@
> > > > >          type_kind = enum
> > > > >          name = rte_crypto_asym_xform_type
> > > > >          changed_enumerators =
> > > RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END
> > > > > +; Ignore updates of ring prod/cons [suppress_type]
> > > > > +        type_kind = struct
> > > > > +        name = rte_ring
> > > > > +[suppress_type]
> > > > > +        type_kind = struct
> > > > > +        name = rte_event_ring
> > > > Does this block the reporting of these structures forever?
> > >
> > > Till we'll have a fix in libabigail, then we can remove these lines.
> > > I don't know any better alternative.
> > David, does this block all issues in the future for rte_ring library?
> 
> These two "suppression rules" make libabigail consider as harmless any
> change on the structures rte_ring and rte_event_ring.
> With those suppression rules, you won't get any complaint from libabigail (if
> this is what you call issues :-)).
> 
> Reviews on those structures must be extra careful, as we are blind with those
> rules in place.
Yes, this is my concern. Why not remove these fixes and ignore the errors manually (i.e. merge the patches knowing that they are false errors) from libabigail? Do you know if libabigail will fix these in the future?

> 
> 
> --
> David Marchand