From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2EA30A0577; Sun, 5 Apr 2020 23:35:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7989B2B83; Sun, 5 Apr 2020 23:35:37 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20080.outbound.protection.outlook.com [40.107.2.80]) by dpdk.org (Postfix) with ESMTP id 0D826276C; Sun, 5 Apr 2020 23:35:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SztJyAiCfDqHO39t+XxbehbYw/G0zz1o++azXlbGwss=; b=J+YIfR5JkpFHjmdTa/7HrfUHpa2SIPwq/i/PaXsu7AoUhOH5S/Bh+Z4kHEvB7yxVfUiWNu8er5QTC41hoTu0Bsdbc98u0lgxdKdKN5b2PosHG9PtZ1h6h5W6ngjfQQ0NRwtaSdjA/Vk0WDasw2g4e3FOA6eaMgMb4HnXdV6j66k= Received: from AM6P191CA0014.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::27) by AM6PR08MB3653.eurprd08.prod.outlook.com (2603:10a6:20b:4c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.20; Sun, 5 Apr 2020 21:35:33 +0000 Received: from VE1EUR03FT053.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8b:cafe::7c) by AM6P191CA0014.outlook.office365.com (2603:10a6:209:8b::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.17 via Frontend Transport; Sun, 5 Apr 2020 21:35:33 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT053.mail.protection.outlook.com (10.152.19.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.17 via Frontend Transport; Sun, 5 Apr 2020 21:35:33 +0000 Received: ("Tessian outbound e2c88df8bbbe:v50"); Sun, 05 Apr 2020 21:35:33 +0000 X-CR-MTA-TID: 64aa7808 Received: from 9ddf7370bdf6.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5D6314C0-F17D-44F7-94E0-FA328AAC96B0.1; Sun, 05 Apr 2020 21:35:28 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9ddf7370bdf6.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 05 Apr 2020 21:35:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BaKZWy1jxRfbC8LIoljdQ7aLZJ0621Qp3jDI2nldJa+FV119JgUu02lVgVPAExZ6afmBxt4h/bBcJu2VX9VZW2k1uV+HQ3KTKmpbXofm41TThEZ5tOY1D4joHoz/pmeJUbxzjMdcNU5eRNbC0nKsGX14hM6IwiluQ1bN0seLt2zHfyPol2D+Z99Qv6RyfplfItqYFEFdY2bO1uEGpZ+HchpwkwKtikwK0ThfMNO3o4egsQEbSzs6gz62KZfWVOlhJYcLLWCWvCCDQyvyjB+F38T5tBGO1wzqdZXyFGyM2k1JIPXOZo42SHosB1XNs8EKwj2DHx63SvcB1GXHYynxNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SztJyAiCfDqHO39t+XxbehbYw/G0zz1o++azXlbGwss=; b=BRTFZTkl7B/3UGZraYzNHDtT7KWfSORA+I8BWhnZT3d1Fmv31P0AGhrCB3AKjCfl2z9mVlNBmM97DDVG/O1wyO5f8eX2ROvJBUmSGoeifMAUKDjnsziCymNVo1VtJ/CUh2NIfnwv8bmEHOhl58BW9TUcM2x1DNhoGuIDAKAlA4frZrW0YOcMpJhq1eTCrZh5BkBoVpa8zJi0tkr84PaX+Egn9xYIrhe90QA4rIpJ7jH15Yyt3HGouv2ueympEthWCeqmFnzWNiOmdmSd2TqT/sOxxONlw6hL/pFPryHhjotaLyEd/dj+vCSBECo6o5Zpt+jXGrwzC95b2PjlpI78+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SztJyAiCfDqHO39t+XxbehbYw/G0zz1o++azXlbGwss=; b=J+YIfR5JkpFHjmdTa/7HrfUHpa2SIPwq/i/PaXsu7AoUhOH5S/Bh+Z4kHEvB7yxVfUiWNu8er5QTC41hoTu0Bsdbc98u0lgxdKdKN5b2PosHG9PtZ1h6h5W6ngjfQQ0NRwtaSdjA/Vk0WDasw2g4e3FOA6eaMgMb4HnXdV6j66k= Received: from DBBPR08MB4646.eurprd08.prod.outlook.com (10.255.79.144) by DBBPR08MB4695.eurprd08.prod.outlook.com (20.179.47.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.20; Sun, 5 Apr 2020 21:35:23 +0000 Received: from DBBPR08MB4646.eurprd08.prod.outlook.com ([fe80::1870:afc4:b90f:609d]) by DBBPR08MB4646.eurprd08.prod.outlook.com ([fe80::1870:afc4:b90f:609d%5]) with mapi id 15.20.2878.021; Sun, 5 Apr 2020 21:35:23 +0000 From: Honnappa Nagarahalli To: Phil Yang , "thomas@monjalon.net" , "harry.van.haaren@intel.com" , "konstantin.ananyev@intel.com" , "stephen@networkplumber.org" , "maxime.coquelin@redhat.com" , "dev@dpdk.org" CC: "david.marchand@redhat.com" , "jerinj@marvell.com" , "hemant.agrawal@nxp.com" , Gavin Hu , Ruifeng Wang , Joyce Kong , nd , "stable@dpdk.org" , Honnappa Nagarahalli , nd Thread-Topic: [PATCH v3 07/12] service: remove rte prefix from static functions Thread-Index: AQHWC5IcB8D6z5UMTE6lbWKeLAHYrg== Date: Sun, 5 Apr 2020 21:35:22 +0000 Message-ID: References: <1583999071-22872-1-git-send-email-phil.yang@arm.com> <1584407863-774-1-git-send-email-phil.yang@arm.com> <1584407863-774-8-git-send-email-phil.yang@arm.com> In-Reply-To: <1584407863-774-8-git-send-email-phil.yang@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 88d544e6-7030-4dd7-a5be-5a02fc315b1c.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [70.113.25.165] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 318e0df3-d9f7-496b-9472-08d7d9a94597 x-ms-traffictypediagnostic: DBBPR08MB4695:|DBBPR08MB4695:|AM6PR08MB3653: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:392;OLM:392; x-forefront-prvs: 03648EFF89 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR08MB4646.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(39850400004)(366004)(396003)(346002)(376002)(136003)(54906003)(110136005)(4326008)(6506007)(7696005)(8676002)(86362001)(9686003)(71200400001)(55016002)(81156014)(81166006)(8936002)(33656002)(186003)(66476007)(66446008)(478600001)(316002)(2906002)(66556008)(52536014)(5660300002)(7416002)(76116006)(26005)(66946007)(64756008); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: V1QEUOqiEZlnnbbeH8bRpziBEq8QglcaJD3U7zQcMIxhZPpGWYNwdTf3h+pDhKpKOetVZ17FGF/YfC22wQ5omIa55E4QpGPx5+sOFEcbb8PLS4Rwh7XisXuWNmX3uNVtKPn1iCU3YoV5edfOLdCK70aJTnsbIITIlLFo82vcDWiZsImLd8l6VW/XAIsD/nbODQEnRCvDFBbB+objPcUGL7kAhS3reVZ+OCAcLgUbD28BeXPsYBWSZyI4LIyKPtVbZsDCB7Od5o/TlCkeIszSTbRp4UNO1Ifs03C5C84hUIQSj26IxRfhbAoQIzcizji3qTpWM6XQfvFQR6EHAfNEgh5q6PrFKTHsN3Pc8sqvYKT0OSjrXUzaT2KacuDuI/mIOHmVlhawUnwKEZZLUTmpOZn+zpS5KD91VgIHcDenQBnV4YUdtImUmMVPPrnYbX0h x-ms-exchange-antispam-messagedata: Ms7TuL+kqbHlm35og2DIDWZbRb4IVPJ1mh5As5Bez2X5py2nKVGTjEuJUK9QUus1OSOvGYP43XJqFdzeKFqX9LSJkXDmqCZR0wRAvkx/NUBPBccLV6VHzLvSXQIGVd3cvY8jZjuJ4AYfL7xJ5YvCpw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4695 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT053.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(396003)(376002)(136003)(346002)(39840400004)(46966005)(70586007)(70206006)(52536014)(478600001)(33656002)(26826003)(7696005)(186003)(26005)(2906002)(47076004)(336012)(4326008)(6506007)(450100002)(86362001)(110136005)(9686003)(54906003)(5660300002)(36906005)(81166006)(81156014)(8676002)(8936002)(55016002)(316002)(356004); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 9b0431a7-96e2-4b33-0340-08d7d9a93f4c X-Forefront-PRVS: 03648EFF89 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ze+2YEzS2IJ+0MFPS1+NWKa7zIyeAyDH4ga8Uu0rNQ69tTtwCj+Hi97O+frK1KzktQ72XewdGD+fcT90QF6hKxijE3KiB6iWy+vbE8bGf4LPoD1mXafYvEaH49PslwO/+lAEeokZ9pfWYi44xqWhBco7gSjL0hjGMH5+KhGT1dsb+bFqXiCgIb8NaVOUPfZQZGXlVFDBVaBUM1iIWERXYWdaLxbX807xPYRrB9SFp5Aoz0DMIH2XLC41f2pZOUXX2LGBU//3gaSfenEUoJsOJDyJ8xPTPjdsP4dSqGjqPQYqRL6Y1ognXDGIJkcv01f96PerOHXWpHMsGxqvliUGGRdYcmLLP4QiRf6Gs9KH5LjU5Qj8VkEs6nXDtMIpdMZQEpclhI3Q4Y3drCocoZmyHmbIpVPFxhPpcsKF01rLmtOpvWllTF12DYwm5ur01M9JUBtG8SUeCAMx84fgyVbFX4k4QJlYfOiLUjeNLY34E31ip+VD4KcVN8Ht9MkOyo1QIz7z3suYh68Ue6cYI9+zEg== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2020 21:35:33.4615 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 318e0df3-d9f7-496b-9472-08d7d9a94597 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3653 Subject: Re: [dpdk-dev] [PATCH v3 07/12] service: remove rte prefix from static functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: [PATCH v3 07/12] service: remove rte prefix from static function= s >=20 > Fixes: 3cf5eb1546ed ("service: fix and refactor atomic service accesses") > Fixes: 21698354c832 ("service: introduce service cores concept") > Cc: stable@dpdk.org >=20 > Signed-off-by: Phil Yang > Reviewed-by: Honnappa Nagarahalli > --- > lib/librte_eal/common/rte_service.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) >=20 > diff --git a/lib/librte_eal/common/rte_service.c > b/lib/librte_eal/common/rte_service.c > index b0b78ba..2117726 100644 > --- a/lib/librte_eal/common/rte_service.c > +++ b/lib/librte_eal/common/rte_service.c > @@ -336,7 +336,7 @@ rte_service_runstate_get(uint32_t id) } >=20 > static inline void > -rte_service_runner_do_callback(struct rte_service_spec_impl *s, > +service_runner_do_callback(struct rte_service_spec_impl *s, > struct core_state *cs, uint32_t service_idx) { > void *userdata =3D s->spec.callback_userdata; @@ -379,10 +379,10 > @@ service_run(uint32_t i, struct core_state *cs, uint64_t service_mask, > if (!rte_atomic32_cmpset((uint32_t *)&s->execute_lock, 0, 1)) > return -EBUSY; >=20 > - rte_service_runner_do_callback(s, cs, i); > + service_runner_do_callback(s, cs, i); > rte_atomic32_clear(&s->execute_lock); > } else > - rte_service_runner_do_callback(s, cs, i); > + service_runner_do_callback(s, cs, i); >=20 > return 0; > } > @@ -436,7 +436,7 @@ rte_service_run_iter_on_app_lcore(uint32_t id, > uint32_t serialize_mt_unsafe) } >=20 > static int32_t > -rte_service_runner_func(void *arg) > +service_runner_func(void *arg) > { > RTE_SET_USED(arg); > uint32_t i; This is a minor comment. Since you are touching 'service_runner_func', please consider doing the bel= ow improvement: struct core_state *cs =3D &lcore_states[lcore]; while (lcore_states[lcore].runstate =3D=3D RUNSTATE_RUNNING) { =20 The while above can be changed as follows to make it more readable while (cs->runstate =3D=3D RUNSTATE_RUNNING) { =20 > @@ -706,7 +706,7 @@ rte_service_lcore_start(uint32_t lcore) > */ > lcore_states[lcore].runstate =3D RUNSTATE_RUNNING; >=20 > - int ret =3D rte_eal_remote_launch(rte_service_runner_func, 0, lcore); > + int ret =3D rte_eal_remote_launch(service_runner_func, 0, lcore); > /* returns -EBUSY if the core is already launched, 0 on success */ > return ret; > } > @@ -785,7 +785,7 @@ rte_service_lcore_attr_get(uint32_t lcore, uint32_t > attr_id, } >=20