From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Ruifeng Wang <Ruifeng.Wang@arm.com>,
"Feifei Wang (Arm Technology China)" <Feifei.Wang@arm.com>,
nd <nd@arm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] rte_ring work
Date: Thu, 7 May 2020 16:58:51 +0000 [thread overview]
Message-ID: <DBBPR08MB4646A607E6ABBA3A127BD90298A50@DBBPR08MB4646.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <BYAPR11MB33016246334F307C44AFC0889AA50@BYAPR11MB3301.namprd11.prod.outlook.com>
<snip>
>
> Hi Honnappa,
>
> >
> > Hi Konstantin,
> > Just to make sure we are coordinating the work on rte_ring, I plan to
> > get the following things done for 20.08. Please let me know if you have any
> comments.
>
> Thanks for sharing your plans.
> In general, looks reasonable to me.
> Few comments/questions below.
> From my side - I have just few rte_ring related plans for 20.08:
> 1) Try to integrate hts/rts ring mode into mempool_ring (new flags for
> mempool_create or so).
> 2) Use peek API into crypto/scheduler PMD.
> 3) Plus few ideas how to improve ring performance in particular usage
> scenarios.
> Don't know yet would it boil to something real or not (might be new sync
> mode or so).
>
> > 1) Remove experimental tag on rte_ring_xxx_elem APIs - they have been
> around for 2 releases now.
> > 2) Make the legacy APIs use elem APIs
> > 3) Check the possibility to remove rte_ring_generic.h implementation.
> > This can be done if the legacy API performance between the generic and
> C11 implementations is not much.
> > 4) Peek APIs for RTS
>
> Due to nature of RTS I don't think it is possible to implement peek API for it.
> But might be I am missing something here.
I think we have talked about it, probably a patch will make it clear.
>
> BTW, do you guys plan to continue with WFE API adoption in rte_ring?
Yes, we plan to. I thought you might not be interested in it and removed it here. There are new requirements on the rte_wait_until_xxx API due to the new sync modes. We might have to revisit the API definition.
>
> > Some cleanup activity (assuming above things are successful)
> >
> > 1) Remove the detailed comments on top of the internal functions - it
> > is hard to maintain, the parameters are already self-explanatory
> > 3) Files need some re-org
> > a) rte_ring.h, rte_ring_hts.h, rte_ring_rts.h, rte_ring_peek.h - will
> > have legacy format APIs written as wrappers around xxx_elem APIs
> > b) rte_ring_elem.h, rte_ring_hts_elem.h, rte_ring_rts_elem.h,
> rte_ring_peek_elem.h - will have xxx_elem APIs
> > c) ring_elem_pvt.h, ring_hts_elem_pvt.h, ring_rts_elem_pvt.h,
> ring_peek_elem_pvt.h
> > - these will contain the internal functions including the c11
> functions to manipulate the head/tail pointers.
> > The files with xxx_c11_mem.h will disappear. Make sure
> private
> > functions have __rte prefix
>
> Basically you'd plan to:
> a) rename rte_ring_*_c11_mem.h to rte_ring_*_pvt.h
> b) get rid of rte_ring_generic.h
> Correct?
Yes
next prev parent reply other threads:[~2020-05-07 16:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 19:37 Honnappa Nagarahalli
2020-05-07 11:12 ` Ananyev, Konstantin
2020-05-07 16:58 ` Honnappa Nagarahalli [this message]
2020-05-07 17:38 ` Ananyev, Konstantin
2020-05-08 5:12 ` Honnappa Nagarahalli
2020-05-08 12:57 ` Ananyev, Konstantin
2020-05-08 17:54 ` Honnappa Nagarahalli
2020-05-08 18:04 ` Ananyev, Konstantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBBPR08MB4646A607E6ABBA3A127BD90298A50@DBBPR08MB4646.eurprd08.prod.outlook.com \
--to=honnappa.nagarahalli@arm.com \
--cc=Feifei.Wang@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).