From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD192A0093; Thu, 21 May 2020 06:17:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B89AE1C214; Thu, 21 May 2020 06:17:27 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30069.outbound.protection.outlook.com [40.107.3.69]) by dpdk.org (Postfix) with ESMTP id 206F71C211 for ; Thu, 21 May 2020 06:17:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jYiIvX6MrWmFxFX2EAFSb7X3uv9c83N5pHeWsPHlFS0=; b=3wNrSS7VyHExK8GR3EUf1Kw7Fnh/mtHBNjb+YTs2q3k1/07YHKe4WYJwR5OKaQON/fwsk+UlASNi4qP+8W+2nPaB9c1m89KlgJweFpG4DR6jSulSdYt4zyZUpp4JvOkxzptfdU23wbVxIc6r0bp1U8kOfgbaGJ2oXeouUm8/zao= Received: from AM6P194CA0095.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:8f::36) by DB6PR08MB2919.eurprd08.prod.outlook.com (2603:10a6:6:1e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.31; Thu, 21 May 2020 04:17:24 +0000 Received: from VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8f:cafe::a1) by AM6P194CA0095.outlook.office365.com (2603:10a6:209:8f::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.23 via Frontend Transport; Thu, 21 May 2020 04:17:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT042.mail.protection.outlook.com (10.152.19.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.23 via Frontend Transport; Thu, 21 May 2020 04:17:23 +0000 Received: ("Tessian outbound 14e212f6ce41:v57"); Thu, 21 May 2020 04:17:23 +0000 X-CR-MTA-TID: 64aa7808 Received: from 203dadf9e219.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8BB9DB71-7399-443F-9332-8E71D6325CD4.1; Thu, 21 May 2020 04:17:18 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 203dadf9e219.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 21 May 2020 04:17:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fX0HQffMR9act03Z61XzyTeOHGj88mfk0LF7rGwM9Wp8BGgPptzNHulr+9tkajb/SSEv97A2tPewzLaE8xQf6mzNhKPxk/GAWQn4eVYHgpANpjuGA0g4H9XkUzwRufDc69oeHTbm+J5PGyfGn1pjetO7BfjAInLK5FZBTK5n0AWeWqCz24kcUjcRjzvWn9PY94wkQS98KMBtE0fJuNtAvIE2zb5ehI1nDDkWMN8bR3qyoU3yQA/B9gf0Jz1D25r2YbS7dIE2X9zHMDWXFHRf9wME3lS2bV2DzxUMpq7zDbditQQEWG0tT6tMl0+4bd5WbMlf0TzIwq0nEFOU7GqBHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jYiIvX6MrWmFxFX2EAFSb7X3uv9c83N5pHeWsPHlFS0=; b=PkPp9VJ3Yeyee0REavfLzuyotojMlbAbPYTcFxBZhCIt5ceLLzrMMTUZIMrfehsDR+DUhm/uPeJNEY7CDpKRlxOSYcabT0I5KNzX/9vZNM3Ryr1sHtvPbap3a6TUBSWwIhiDP6GNSHqU7rICf/XO0xstjGUx7mHS7PY4Ij6GpNnFRZrSpDxXiwgVbLyELqSzpkCYlvaIEd/tlSqRKwtmXK1muhRRP9TlYLplpm1iGEe09M6aLGuJN6N6U4Nc89iF1OuFSvF3qv8smuTVnG1nAGBjfGShlYX3uDE8vSj+6mdpG4ls5U07kv51BWzG0VkP3Hh+skvKLKTuVzPAt0HNNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jYiIvX6MrWmFxFX2EAFSb7X3uv9c83N5pHeWsPHlFS0=; b=3wNrSS7VyHExK8GR3EUf1Kw7Fnh/mtHBNjb+YTs2q3k1/07YHKe4WYJwR5OKaQON/fwsk+UlASNi4qP+8W+2nPaB9c1m89KlgJweFpG4DR6jSulSdYt4zyZUpp4JvOkxzptfdU23wbVxIc6r0bp1U8kOfgbaGJ2oXeouUm8/zao= Received: from DBBPR08MB4646.eurprd08.prod.outlook.com (2603:10a6:10:f5::16) by DBBPR08MB4904.eurprd08.prod.outlook.com (2603:10a6:10:f2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.23; Thu, 21 May 2020 04:17:16 +0000 Received: from DBBPR08MB4646.eurprd08.prod.outlook.com ([fe80::1870:afc4:b90f:609d]) by DBBPR08MB4646.eurprd08.prod.outlook.com ([fe80::1870:afc4:b90f:609d%5]) with mapi id 15.20.3021.024; Thu, 21 May 2020 04:17:16 +0000 From: Honnappa Nagarahalli To: Fady Bader , "dev@dpdk.org" CC: "thomas@monjalon.net" , "talshn@mellanox.com" , "yohadt@mellanox.com" , "olivier.matz@6wind.com" , "harini.ramakrishnan@microsoft.com" , "ocardona@microsoft.com" , "anand.rawat@intel.com" , "ranjit.menon@intel.com" , "dmitry.kozliuk@gmail.com" , Honnappa Nagarahalli , nd , nd Thread-Topic: [dpdk-dev] [PATCH v2] ring: build on Windows Thread-Index: AQHWLpPJsnrfyfmf6UK8PvvO9w2yeqix7AvA Date: Thu, 21 May 2020 04:17:16 +0000 Message-ID: References: <20200520104445.9072-1-fady@mellanox.com> In-Reply-To: <20200520104445.9072-1-fady@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 816869a2-7db2-4a89-bd9a-47c348f9cf2d.0 x-checkrecipientchecked: true Authentication-Results-Original: mellanox.com; dkim=none (message not signed) header.d=none; mellanox.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [70.113.25.165] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 85654c04-77a8-42e0-953f-08d7fd3ddcea x-ms-traffictypediagnostic: DBBPR08MB4904:|DB6PR08MB2919: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:1091;OLM:1091; x-forefront-prvs: 041032FF37 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: qxXZRmvrp8sHWaYfSSOP7dUfJ3UBArJdgyASzDd8hNUXK76d91VH75+nUP5FZ1G1fX1EmFz8UtWGscH1gWw1Dnt53TU8Mc/pAF8Tqh+4UeAj2CISFr/CnuIec4FoSRIH4BBg2f1E+3bmFLeVQcePJ6OT1fOZKfOOI2OlS+q2XCE/dPS/M+fYztRPvoUa1EuYQBk4ZjWtrjcFhy6cBpOwV06URVyTwGFUN3WoMZ/RT2cLd3sEcISeQ9BH+y/tLEFGfdvVB8tuspq+vnvizGtG+T34BvSpphsmiIV4j4R6UHaDVJ8bsFQClqn5n5AyyNlzLtXJ1a6QIGXrMVznJ2vhuw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR08MB4646.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(39860400002)(376002)(366004)(346002)(396003)(52536014)(71200400001)(76116006)(66946007)(7416002)(4326008)(66446008)(316002)(2906002)(54906003)(5660300002)(110136005)(8936002)(9686003)(7696005)(55016002)(478600001)(186003)(66556008)(6506007)(26005)(33656002)(86362001)(8676002)(66476007)(64756008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: zX9kR+7Doby1YqQGPpiiY6MfIokyHAU/GgwPGDGF1a5rs5HgnRpQOn3v5F10NEdiT6T3rEhiHY0eGzchpZ2mUgUvnKMRrvAVPNIzKpzXGczq9uVwALR1sxJRQomEoQbLOAR1sEnPeQdDv8tKYQOlo3qi6R2oarGvIdhwgO2/cIMcrscvcfWr91wvkcewuksguVodyAo7pTpF2haiiUFtjdDeZHrzdoLhcOBIUAOwG710v29fpFot2XNSfZHRFHcB8nS68st1xvoQU4TAG9Ol/16tcpx64nU4KnR4rcKHZC998J/IulBJX552jv0ByvpHyDrWKHAwh1CVFYNzt47kitZbNSUmEszL+qCALKzj/FEdJnA0pwzEohNkaAknZtLPgmQmSEvsb56ioE29IvfRt4AeXluZB4mByp9Iz7VdUuh4Xff/6wWoYn63ooZWz9FW1wlaiq/P7eorhky2pcHyB08uwL8plgt44YSzJcMQvCyF+cEkyr6pVgfs9uIM22xF Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4904 Original-Authentication-Results: mellanox.com; dkim=none (message not signed) header.d=none; mellanox.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(136003)(396003)(39860400002)(346002)(376002)(46966005)(86362001)(7696005)(316002)(478600001)(8676002)(110136005)(2906002)(8936002)(82310400002)(336012)(55016002)(33656002)(5660300002)(47076004)(9686003)(52536014)(6506007)(82740400003)(70586007)(70206006)(186003)(356005)(26005)(36906005)(81166007)(4326008)(54906003); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: d307a62b-ab3e-4dea-bb33-08d7fd3dd883 X-Forefront-PRVS: 041032FF37 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uN/KI+S/XBleQFrScw5t+R/hMjyO/NzM3KaRYBm2wbM2dT69PRUAU4Qywj/IbD1OUeCHKU/YacrsskSnhD6yNOHeAZkaXcPjr4AEP473YFrULkQc3NbvhWNsZlx6FXWWSW9sTKPNW/s9p/+79MgXGQHt8q2wq0kG/EJoZyKQFLth+lSN1382apRdjeeY5nW/k2yTUTsckkHGO7RTm75juMOwL1sz/SFO0rDecQNjCLVHmeEwZMwIh6JWh9ovCwMkdqrrrayxv5scNyBZ2w4CaQBldrQpgAdcl3moAmmhuA8uEL6jA+166TgMORFqEF/RBNzYcAA/rBwfLffkoGnsoK+jzqWRXLtEemw3xN949On7B7JsA8Zh9Xjk1PZ2W0+7GQFrhPDLd4edsqhJDT2M5LeFEW/YgUA0LjML5Jhhb1tB4qyxnDuHQHkf4SO3aMgaUFpMnHjej1Djde2jfDNIYeFN8ZpcynbUdekRUbeoLotM59FzB25V1eJCv83qRrrr9ha0wl42fKObchC+nvxAEA== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2020 04:17:23.6386 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 85654c04-77a8-42e0-953f-08d7fd3ddcea X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2919 Subject: Re: [dpdk-dev] [PATCH v2] ring: build on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: [dpdk-dev] [PATCH v2] ring: build on Window ^^^^ change thi= s to 'eal'. Even though the compilation error points to rte_ring, this is not a issue i= n rte_ring library. Suggest changing the commit message to something like "= eal: add per_lcore__rte_errno to export list for Windows". >=20 > Exported per_lcore__rte_errno function to compile ring for windows. >=20 > compilation error logs: > librte_ring_rte_ring.c.obj : error LNK2019: unresolved external symbol > per_lcore__rte_errno referenced in function rte_ring_lookup >=20 > The cause was that per_lcore__rte_errno function wasn't included in the > export list. > To solve this per_lcore__rte_errno was added to the Windows export list. >=20 > Signed-off-by: Fady Bader > Depends-on: series-9374 ("Windows basic memory management") > --- > lib/librte_eal/rte_eal_exports.def | 1 + lib/librte_eal/rte_eal_version= .map | 3 > +++ > lib/meson.build | 5 ++++- > 3 files changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/lib/librte_eal/rte_eal_exports.def > b/lib/librte_eal/rte_eal_exports.def > index 854b83bcd..cbb6b8cfe 100644 > --- a/lib/librte_eal/rte_eal_exports.def > +++ b/lib/librte_eal/rte_eal_exports.def > @@ -1,5 +1,6 @@ > EXPORTS > __rte_panic > + per_lcore__rte_errno > rte_calloc > rte_calloc_socket > rte_eal_get_configuration > diff --git a/lib/librte_eal/rte_eal_version.map > b/lib/librte_eal/rte_eal_version.map > index bdd014638..0f1b983b8 100644 > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > @@ -390,4 +390,7 @@ EXPERIMENTAL { > rte_trace_point_lookup; > rte_trace_regexp; > rte_trace_save; > + > + # added in 20.08 > + __emutls_v.per_lcore__rte_errno; Not sure why this is required. per_lcore__rte_errno is present already in t= his file. > }; > diff --git a/lib/meson.build b/lib/meson.build index d190d84ef..98ee5ec57 > 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -36,7 +36,10 @@ libraries =3D [ > 'flow_classify', 'bpf', 'graph', 'node'] >=20 > if is_windows > - libraries =3D ['kvargs','eal'] # only supported libraries for windows > + libraries =3D [ > + 'kvargs', > + 'eal', > + 'ring'] # only supported libraries for windows > endif >=20 > default_cflags =3D machine_args > -- > 2.16.1.windows.4