From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C751CA0352; Fri, 8 May 2020 19:54:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 725C11DA49; Fri, 8 May 2020 19:54:18 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30047.outbound.protection.outlook.com [40.107.3.47]) by dpdk.org (Postfix) with ESMTP id C582C1DA36 for ; Fri, 8 May 2020 19:54:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SgEE2bj0ngYdBQXnD0frRHB1xcdkocdlwhxVH+AvPgk=; b=j5WOa6kBpO29RJd1UnRfcsp+ILjzFULXeAXGt9x4JNtF7Au5MldbijJh+IWZBx0EVjb9z1oy+mmxVagv7r6spUu0cbI6lh1DevkP3lRkc84SH4izvBVQsqmcl2+rCODuOC+L134HeTj5miivCqOENyX7EdMh2vmYxA/gAIrisVA= Received: from AM6P193CA0133.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:85::38) by AM6PR08MB5159.eurprd08.prod.outlook.com (2603:10a6:20b:e2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.27; Fri, 8 May 2020 17:54:16 +0000 Received: from AM5EUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:85:cafe::a1) by AM6P193CA0133.outlook.office365.com (2603:10a6:209:85::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28 via Frontend Transport; Fri, 8 May 2020 17:54:16 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT014.mail.protection.outlook.com (10.152.16.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.27 via Frontend Transport; Fri, 8 May 2020 17:54:16 +0000 Received: ("Tessian outbound b3a67fbfbb1f:v54"); Fri, 08 May 2020 17:54:15 +0000 X-CR-MTA-TID: 64aa7808 Received: from 0190209c7cc7.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B80C1162-2633-45A3-AEC2-B90FBCEDB996.1; Fri, 08 May 2020 17:54:10 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0190209c7cc7.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 08 May 2020 17:54:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jT2igQ+8nwXcMOUto0UGZifcMhjXAq+JdoFYyPml7i9LU8CbA1132eHgI4sNuLOlZk/KVVnKv3WZUJOaOWRThlbCYvgt8muwviGj9V1eDaTFJImcTwGXXYZrGuk4xXurW73YzI0jakxk42RHLynFjdZ5PzSuZR4ljekiLgSyZqtz8Bcva6aZOxcCGh/yfArmfqsaS3sgJbRkPUVlOgCr/MwVYvb+6TahJAlOaS2E9GYV42P0qdxKAyKg2HgkNyALfpTn9LS1M4W1mpsDyb2hABSeT6UmZYgfXdLx4mMSAiDMaxNVM++tMPHYUAQbqgAah9nY+O6M5LLO2LMm5f80Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SgEE2bj0ngYdBQXnD0frRHB1xcdkocdlwhxVH+AvPgk=; b=BmtInLjTm5/KE2h8dt2/x4TwLjpYzm35QDYKO1TylTJnZhWIfJeGZcoHU9AbLkbdJTZX4qjU8J57zb0CNXAISDRuQSgpA3khlnXrnaegGYaOPbKmK8SxQbSJkMTMMrjgLmHF4OghyZ4xKXAHO0BqVLiL8WzLP20LXQYDI7ytcqbMa8Wp+cgeFcIqdljpIUy3xndgjNJTNVtu103b2fSUuh/kCMw/Q6XCXeZoY7O5wf4LG39OmothEOXAYSa+wK+nLpk+tPqyvesWRPfUMX9BNXr0Zmvc6QyvtgmrM5QbBL7FH9pCdUZVMFF1rZLtf/dTTJYotfpbtyk0qFZJ53hPOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SgEE2bj0ngYdBQXnD0frRHB1xcdkocdlwhxVH+AvPgk=; b=j5WOa6kBpO29RJd1UnRfcsp+ILjzFULXeAXGt9x4JNtF7Au5MldbijJh+IWZBx0EVjb9z1oy+mmxVagv7r6spUu0cbI6lh1DevkP3lRkc84SH4izvBVQsqmcl2+rCODuOC+L134HeTj5miivCqOENyX7EdMh2vmYxA/gAIrisVA= Received: from DBBPR08MB4646.eurprd08.prod.outlook.com (2603:10a6:10:f5::16) by DBBPR08MB4283.eurprd08.prod.outlook.com (2603:10a6:10:c3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.27; Fri, 8 May 2020 17:54:09 +0000 Received: from DBBPR08MB4646.eurprd08.prod.outlook.com ([fe80::1870:afc4:b90f:609d]) by DBBPR08MB4646.eurprd08.prod.outlook.com ([fe80::1870:afc4:b90f:609d%5]) with mapi id 15.20.2979.027; Fri, 8 May 2020 17:54:09 +0000 From: Honnappa Nagarahalli To: "Ananyev, Konstantin" , "dev@dpdk.org" CC: Ruifeng Wang , "Feifei Wang (Arm Technology China)" , nd , Dharmik Thakkar , Honnappa Nagarahalli , nd Thread-Topic: rte_ring work Thread-Index: AdYj2/yEUDvXLCvbSjmLQfkOx8WHHgAfYkpwAA2yNXAAATxDAAAYeeugABA9S7AAClJ08A== Date: Fri, 8 May 2020 17:54:09 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: cf782fc0-275c-478f-a682-914ac1f1da1c.0 x-checkrecipientchecked: true Authentication-Results-Original: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [70.113.25.165] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 2d774b76-0ad1-4205-0e7d-08d7f378d342 x-ms-traffictypediagnostic: DBBPR08MB4283:|DBBPR08MB4283:|AM6PR08MB5159: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; x-forefront-prvs: 039735BC4E X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: abaze1Y16NSiL1G6tP/ptMVEFE8smllL45ZoW25TxIYymnHH79nlzUmIqiP1mPV0vR+fCozsK6Iaj98i68vCFpqOQs3MNTn5ESrxhDELnEpLI0UlHU9ecJAFKZ2X26JWRhb6l67MOHBlQS8sBT1+Z+eUHUaCImMfNKPnBSMrCQvP7IutpZsen9RDMUNlNjehc7VXco2OheeejKLFfIbLpUHIYrtc0NuYlEJWkSPprH2vyD72H7zJbPs4GfXKbi9IIoaUODLwRPqRYtjqUA3m/ojwhMtxt51IKYH2dIiDP4iOyxHzQ45cXPPO23b93xgWiY7mOvd6g99v+/aESfkRydBmEoIhjj67n2XN99FS9WnvfuOuTMUTCbV7+judstHf+uRkIxhFivaVNBfV8VHqLjksA8tDYPGk9oMuWthQFOPBrZAGsir9JaqhZcphJkK3n1BxP8cEqJ9GLUhnUhbZTN0v3v3h9GyjXB1PL8Gx+bQZVqykHnkPwr0Agj/Gystg96+kngphbZ5HX1RNG2g/eorzHH7Xcg7VuwS0IyjWWm70oa/pCpTcK1mRfEpAsnhrIOJXiDhRpHjwbhmsU4wIj2kfrSo0Ey3cuz7mJ8kWbpBT/UU6Nz8vvAhv29aKyHNA X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR08MB4646.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(376002)(346002)(39860400002)(366004)(136003)(33430700001)(55016002)(9686003)(966005)(5660300002)(83290400001)(64756008)(83320400001)(66556008)(66476007)(66446008)(186003)(83280400001)(7696005)(83310400001)(2906002)(83300400001)(52536014)(6506007)(33440700001)(478600001)(33656002)(86362001)(8936002)(110136005)(76116006)(4326008)(66946007)(316002)(71200400001)(7116003)(26005)(8676002)(54906003)(21314003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: M3Oj2M7d0SF2uCIVrDdJcVVwpKzQMLNkVsheWRVGOfgQDX3R3Wi9f8fpGVSiL3KTgoT2wla/MNUtr1rwcIrk4vrzkTjOAXM8b5VAWFNaO+0GEAXBZZ3uzyOI7vF0XRd7SG8ctA4rat8CbG+1RErbiB3IW9AjL/q5c2hS15AIlA23WhDLft+M3SAm//qL5umRe89FTX9wwlNpJBRJm7cwkd9Ze+vivUxpuuhK+cRCmspDg4OadxcOsFnoTGbzFzozLdKDo9NODl+VolGMnfdYoKPFq3lZHJa/UXoG1u2VBO0SUgXAz76SUqBsukoLJo6CPUZ+ETc3KmJCxvpzdwHRR76+9FSwELpgd40I2qZscVT7XC+UkrhkEXA7PBJFwAXXkW3yDDvPlpFN4v2H0Ej1uo5DudI2jcrIU4ZpOcf8FZrpbA/jsPGAeCu0zarQ58Y6k+baSKwtPVwUQjBlNjRuchXAMxY5fTKPQqCiVg+6vjeTt827ipVnU6xup/3XSPBo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4283 Original-Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT014.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(136003)(39860400002)(396003)(376002)(346002)(46966005)(33430700001)(110136005)(82310400002)(966005)(7116003)(2906002)(4326008)(8676002)(478600001)(33440700001)(70206006)(8936002)(33656002)(5660300002)(82740400003)(55016002)(47076004)(336012)(7696005)(9686003)(356005)(54906003)(52536014)(186003)(316002)(81166007)(6506007)(36906005)(26005)(70586007)(86362001)(21314003); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: de550a5d-2583-49f1-d8bb-08d7f378cf3e X-Forefront-PRVS: 039735BC4E X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IJcfGrvDYDd9DbxlArMdshQtQQdsPSN8whEt+7c8cXvrnZ7kGtqGIU14MM6TIB2pPoMj+JPPI3Nv14oXm8NysGyp7Fs4oix4jGxrqRMMJVncHPSBmP+QFIFcgC6Sf6nNuGI7QqEjucUzjCjKOw6PYfWORb2Zeli/GgNmMxEfQ9xyvjwSvMK/LVkl5A9xPgRJom31xNwIB0YvjaGGgEbSpaILg5cshWMY0TNbCSQ2xQWyL8l3p7k3mIRQo+EAkMX3ip1huLPyPYeu54AtAZ1FKrRfC2CH/np+c8SCD/kRkl3xFF7RDyShx/QLcuh1ZVHbZBT2eN8CXmdmCeNoBHGxkfQrdMIFOL8GgAuF9JcLxxceJViXM5RSzI+6gWLOaC0qOEfKhLx9nJZ7L6ERokj9BjCV5lB9gV4x8dWeRcN5dcmrti9W5QjUqmU+ZbnDeKD4Xho4Yw381Kk1Nb9MQXhzJjKdmwDKXRLOteJDbaC79pdPyo3ZxWHcZNEZrCdOCiKTC2gP4k+GMiaw+0Ikvpq+utIAkhfNiJv2INwJR/01+dQLLnECq3SU1jECswYRpwOfncZxeY+LAv0O4zDMvESQGTUxE5VkmdMVOJm3o87JBTLiGbHmhFnV1jTNLdcVlJ0cHebWY+hiSCdpUuEDsI8xF0CY6IjBXhVP+S/0hxgbYXQjQ9vOmnI0IfSz9RX4h+nV X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2020 17:54:16.1621 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2d774b76-0ad1-4205-0e7d-08d7f378d342 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5159 Subject: Re: [dpdk-dev] rte_ring work X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > > > Some cleanup activity (assuming above things are successful) > > > > > > > > > > > > 1) Remove the detailed comments on top of the internal > > > > > > functions - it is hard to maintain, the parameters are already > > > > > > self-explanatory > > > > > > 3) Files need some re-org > > > > > > a) rte_ring.h, rte_ring_hts.h, rte_ring_rts.h, > > > > > > rte_ring_peek.h - will have legacy format APIs written as wrapp= ers > around xxx_elem APIs > > > > > > b) rte_ring_elem.h, rte_ring_hts_elem.h, rte_ring_rts_elem.h, > > > > > rte_ring_peek_elem.h - will have xxx_elem APIs > > > > > > c) ring_elem_pvt.h, ring_hts_elem_pvt.h, ring_rts_elem_pvt.h, > > > > > ring_peek_elem_pvt.h > > > > > > - these will contain the internal functions including > the > > > > > > c11 > > > > > functions to manipulate the head/tail pointers. > > > > > > The files with xxx_c11_mem.h will disappear. Make > sure > > > > > private > > > > > > functions have __rte prefix > > > > > > > > > > Basically you'd plan to: > > > > > a) rename rte_ring_*_c11_mem.h to rte_ring_*_pvt.h > > > > > b) get rid of rte_ring_generic.h Correct? > > > > Yes > > > > > > If there would be no perf drops, I have no objections. > > Agree > > > Though recently there was a discussion is it ok to remove dpdk > > > installable headers (even ones marked as internal). > > Do you remember any conclusions? I tried to search, could not find the > discussion. >=20 > http://patches.dpdk.org/patch/69560/ Thank you. rte_ring library has called out clearly if a particular file sho= uld be included or not. If the users have included other files despite that= , may be DPDK should not be held accountable?