From: "Kavanagh, Mark B" <mark.b.kavanagh@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"Tan, Jianfeng" <jianfeng.tan@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix data segment buffer length
Date: Wed, 2 Aug 2017 10:54:03 +0000 [thread overview]
Message-ID: <DC5AD7FA266D86499789B1BCAEC715F8B7EDBDA7@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <20170802072209.15233-1-qi.z.zhang@intel.com>
>From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qi Zhang
>Sent: Wednesday, August 2, 2017 8:22 AM
>To: Wu, Jingjing <jingjing.wu@intel.com>
>Cc: dev@dpdk.org; jianfeng.tang@intel.com; Zhang, Qi Z <qi.z.zhang@intel.com>;
>stable@dpdk.org; Tan, Jianfeng <jianfeng.tan@intel.com>
>Subject: [dpdk-dev] [PATCH] net/i40e: fix data segment buffer length
>
>Buffer length be configured for each data segment should not exceed
>the requested value, or device may fill data that exceed the boundary
>of memory that be reserved.
>
>Fixes: 4861cde46116 ("i40e: new poll mode driver")
>Cc: stable@dpdk.org
>
>Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
>Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Thanks guys, this resolved an issue that I'd encountered (as discussed off-list).
Reviewed-by: Mark Kavanagh <mark.b.kavanagh@intel.com>
Tested-by: Mark Kavanagh <mark.b.kavanagh@intel.com>
>---
> drivers/net/i40e/i40e_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
>index ae64de6..d42c23c 100644
>--- a/drivers/net/i40e/i40e_rxtx.c
>+++ b/drivers/net/i40e/i40e_rxtx.c
>@@ -2474,7 +2474,7 @@ i40e_rx_queue_config(struct i40e_rx_queue *rxq)
> case I40E_FLAG_HEADER_SPLIT_DISABLED:
> default:
> rxq->rx_hdr_len = 0;
>- rxq->rx_buf_len = RTE_ALIGN(buf_size,
>+ rxq->rx_buf_len = RTE_ALIGN_FLOOR(buf_size,
> (1 << I40E_RXQ_CTX_DBUFF_SHIFT));
> rxq->hs_mode = i40e_header_split_none;
> break;
>--
>2.9.4
next prev parent reply other threads:[~2017-08-02 10:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 7:22 Qi Zhang
2017-08-02 10:54 ` Kavanagh, Mark B [this message]
2017-08-03 20:47 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DC5AD7FA266D86499789B1BCAEC715F8B7EDBDA7@irsmsx105.ger.corp.intel.com \
--to=mark.b.kavanagh@intel.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).