Re: [PATCH v3 1/2] devtools/mailmap_ctl: script to work with mailmap

["Robin Jarry" <rjarry@redhat.com>]

Bruce Richardson, Oct 17, 2025 at 15:38:
> Add a script to easily add entries to, check and sort the mailmap file.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Marat Khalili <marat.khalili@huawei.com>
> ---

Hey Bruce, I only have a couple of minor remarks:

$ isort --profile black --diff devtools/mailmap_ctl.py
--- devtools/mailmap_ctl.py:before	2025-10-17 15:42:59.507233
+++ devtools/mailmap_ctl.py:after	2025-10-17 15:43:03.351551
@@ -6,13 +6,13 @@
 A tool for manipulating the .mailmap file in DPDK repository.
 """

-import sys
-import re
 import argparse
 import itertools
+import re
+import sys
 import unicodedata
+from dataclasses import dataclass
 from pathlib import Path
-from dataclasses import dataclass


$ ruff check devtools/mailmap_ctl.py
devtools/mailmap_ctl.py:171:5: F841 Local variable `operations` is assigned to but never used
    |
169 |     """Main function."""
170 |     # ops and functions implementing them
171 |     operations = {"add": add_entry, "check": check_mailmap, "sort": sort_mailmap}
    |     ^^^^^^^^^^ F841
172 |
173 |     parser = argparse.ArgumentParser(
    |
    = help: Remove assignment to unused variable `operations`

Found 1 error.
No fixes available (1 hidden fix can be enabled with the `--unsafe-fixes` option).


With these fixed:

Reviewed-by: Robin Jarry <rjarry@redhat.com>

Thanks!

-- 
Robin

> 98% lean.