From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id D57CDADA1 for ; Fri, 13 Feb 2015 03:59:40 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 12 Feb 2015 18:52:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,568,1418112000"; d="scan'208";a="665766861" Received: from kmsmsx153.gar.corp.intel.com ([172.21.73.88]) by fmsmga001.fm.intel.com with ESMTP; 12 Feb 2015 18:59:39 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.110.15) by KMSMSX153.gar.corp.intel.com (172.21.73.88) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 13 Feb 2015 10:59:36 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.192]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.161]) with mapi id 14.03.0195.001; Fri, 13 Feb 2015 10:59:31 +0800 From: "Xu, HuilongX" To: "Wu, Jingjing" , "dev@dpdk.org" Thread-Topic: [PATCH v3 0/6] new ntuple filter replaces 2tuple and 5tuple filters Thread-Index: AQHQROzXFo0yqywqb0it5uG5RvI3Cpzt4Dtg Date: Fri, 13 Feb 2015 02:59:30 +0000 Message-ID: References: <1421912305-2022-1-git-send-email-jingjing.wu@intel.com> <1423543713-21624-1-git-send-email-jingjing.wu@intel.com> In-Reply-To: <1423543713-21624-1-git-send-email-jingjing.wu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 0/6] new ntuple filter replaces 2tuple and 5tuple filters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Feb 2015 02:59:41 -0000 Tested-by:huilong xu - Tested Commit: 2250cc5a191906c914221ff4f0da7b5d699b4175 - OS: Fedora20 3.11.10-301.fc20.x86_64 - GCC: gcc version 4.8.3 20140911 (Red Hat 4.8.3-7) (GCC) - CPU: Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz - NIC: Intel Corporation 82599EB 10-Gigabit Network Connection [8086:10fb] Intel Corporation I350 Gigabit Network Connection [8086:1521] Intel Corporation 82580 Gigabit Network Connection [8086:150e] - Default x86_64-native-linuxapp-gcc configuration - Total 2 cases, 2 passed, 0 failed =20 - Case: five_tuple_filter Description: Check specified tcp package receive by specified queue. Tes= t NIC 82599EB Command / instruction: Start testpmd=20 testpmd -c ffff -n 4 -- -i --disable-rss --rxq=3D4 --txq=3D4 --portmask= =3D0x3 --nb-cores=3D8 --nb-ports=3D2 =20 set queue map: set stat_qmap rx 0 0 0 set stat_qmap rx 1 0 0 set stat_qmap rx 0 1 1 set stat_qmap rx 1 1 1 set stat_qmap rx 0 2 2 set stat_qmap rx 1 2 2 set stat_qmap rx 0 3 3 set stat_qmap rx 1 3 3 set vlan offload: vlan set strip off 0 vlan set strip off 1 vlan set filter off 0 vlan set filter off 1 set flush rx on: set flush_rx on start testpmd: start add five tuple filter: 5tuple_filter 0 add dst_ip 2.2.2.5 src_ip 2.2.2.4 dst_port 1 s= rc_port 1 protocol 0x06 mask 0x1f tcp_flags 0x0 priority 3 queue 3=20 Send packets with tcp inner L4 data,dstip 2.2.2.5, scrip 2.2.2.4,dstport = 1, srcport 1, protocol 0x06 test result: testpmd can receive the package by port 0 queue 3 remove five tuple filter: 5tuple _filter 0 del dst_ip 2.2.2.5 src_ip 2.2.2.4 dst_port 1= src_port 1 protocol 0x06 mask 0x1f tcp_flags 0x0 priority 3 queue 3=20 Send packets with tcp inner L4 data,dstip 2.2.2.5, scrip 2.2.2.4,dstp= ort 1, srcport 1, protocol 0x06 test result: testpmd can receive the package by port 0 queue 0=20 - Case: twotuple_filter Description: Check specified udp package receive by specified queue. Tes= t NIC i350 and 82580 Command / instruction: Start testpmd=20 testpmd -c ffff -n 4 -- -i --disable-rss --rxq=3D4 --txq=3D4 --portmask= =3D0x3 --nb-cores=3D8 --nb-ports=3D2 =20 set queue map: set stat_qmap rx 0 0 0 set stat_qmap rx 1 0 0 set stat_qmap rx 0 1 1 set stat_qmap rx 1 1 1 set stat_qmap rx 0 2 2 set stat_qmap rx 1 2 2 set stat_qmap rx 0 3 3 set stat_qmap rx 1 3 3 set vlan offload: vlan set strip off 0 vlan set strip off 1 vlan set filter off 0 vlan set filter off 1 set flush rx on: set flush_rx on start testpmd: start add two tuple filter: 2tuple_filter 0 add dst_port 64 protocol 0x11 mask 1 tcp_flags= 0 priority 3 queue 1=20 Send packets with udp inner L4 data,dstport 64, protocol 0x11 test result: testpmd can receive the package by port 0 queue 1 remove five tuple filter: 5tuple 2tuple_filter 0 del dst_port 64 protocol 0x11 mask 1 t= cp_flags 0 priority 3 queue 1 =20 Send packets with tcp inner L4 data, dstport 64 ,protocol 0x11 test result: testpmd can receive the package by port 0 queue 0 -----Original Message----- From: Wu, Jingjing=20 Sent: Tuesday, February 10, 2015 12:48 PM To: dev@dpdk.org Cc: Wu, Jingjing; De Lara Guarch, Pablo; Cao, Min; Xu, HuilongX Subject: [PATCH v3 0/6] new ntuple filter replaces 2tuple and 5tuple filter= s v2 changes: - remove the code which is already applied in patch "Integrate ethertype filter in igb/ixgbe driver to new API". - modify commands' description in doc testpmd_funcs.rst. v3 change: - remove the UINT32_BIT definition in ixgbe driver The patch set uses new filter_ctrl API to replace old 2tuple and 5tuple fil= ter APIs. It defines ntuple filter to combine 2tuple and 5tuple types.=20 It uses new functions and structure to replace old ones in igb/ixgbe driver= , new commands to replace old ones in testpmd, and removes the old APIs. It removes the filter's index parameters from user interface, only the filter's key and assigned queue are visible to user. Jingjing Wu (6): ethdev: define ntuple filter type and its structure ixgbe: ntuple filter functions replace old ones for 5tuple filter e1000: ntuple filter functions replace old ones for 2tuple and 5tuple filter testpmd: new commands for ntuple filter ethdev: remove old APIs and structures of 5tuple and 2tuple filters doc: commands changed in testpmd_funcs for 2tuple amd 5tuple filter app/test-pmd/cmdline.c | 406 ++++++------- app/test-pmd/config.c | 65 --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 99 +--- lib/librte_ether/rte_eth_ctrl.h | 57 ++ lib/librte_ether/rte_ethdev.c | 116 ---- lib/librte_ether/rte_ethdev.h | 192 ------ lib/librte_pmd_e1000/e1000_ethdev.h | 69 ++- lib/librte_pmd_e1000/igb_ethdev.c | 869 +++++++++++++++++++-----= ---- lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 468 +++++++++++---- lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 52 +- 10 files changed, 1300 insertions(+), 1093 deletions(-) --=20 1.9.3