RE: [PATCH v1 1/3] net/ice: restrict testpmd to scalar path for TxPP

["Loftus, Ciara" <ciara.loftus@intel.com>]

> 
> ICE PMD supports TxPP feature only in scalar path. Hence restricted
> testpmd to scalar path when the feature is enabled.
> 
> Fixes: 0b6ff09a1f19 ("net/intel: support Tx packet pacing for E830")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Soumyadeep Hore <soumyadeep.hore@intel.com>
> ---
>  drivers/net/intel/ice/ice_rxtx.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/intel/ice/ice_rxtx.c b/drivers/net/intel/ice/ice_rxtx.c
> index fd0b3a7532..33d82cd46d 100644
> --- a/drivers/net/intel/ice/ice_rxtx.c
> +++ b/drivers/net/intel/ice/ice_rxtx.c
> @@ -4103,8 +4103,11 @@ ice_set_tx_function(struct rte_eth_dev *dev)
>  	struct ci_tx_queue *txq;
>  	int i;
>  	int tx_check_ret = -1;
> +	uint64_t offloads;
> 
> -	if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
> +	offloads = dev->data->dev_conf.txmode.offloads;
> +	if ((offloads & RTE_ETH_TX_OFFLOAD_SEND_ON_TIMESTAMP) == 0
> &&
> +		rte_eal_process_type() == RTE_PROC_PRIMARY) {
>  		ad->tx_simd_width = RTE_VECT_SIMD_DISABLED;
>  		tx_check_ret = ice_tx_vec_dev_check(dev);
>  		ad->tx_simd_width = ice_get_max_simd_bitwidth();
> --
> 2.47.1

I think you can achieve the desired behaviour by adding
RTE_ETH_TX_OFFLOAD_SEND_ON_TIMESTAMP to
ICE_TX_NO_VECTOR_FLAGS. Also you should remove the reference
to testpmd in the commit message. The patch is just a change
to the ice driver so should not reference any specific
application.