DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Loftus, Ciara" <ciara.loftus@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH] net/ice: make link state configurable on device stop
Date: Fri, 29 Aug 2025 09:46:44 +0000	[thread overview]
Message-ID: <DM3PPF7D18F34A158305FAB4D8BECCD2DE38E3AA@DM3PPF7D18F34A1.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20250828075547.1fe99122@hermes.local>

> 
> On Thu, 28 Aug 2025 10:23:05 +0000
> Ciara Loftus <ciara.loftus@intel.com> wrote:
> 
> > Introduce the boolean restore_link_state devarg for the ice driver. When
> > set, when the ice port is stopped, the physical link will be restored to
> > the state it was in when the device was started.
> >
> > Prior to this patch the default behaviour was to always restore the link
> > to its original state. The new default behaiour is to always bring the
> > link down, which is in keeping with most other drivers.
> >
> > Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
> > ---
> 
> Device specific devargs should be discouraged. Seems like the same
> issue occurs across multiple drivers.

I had considered creating a generic ethdev API for this rather than a
device specific devarg. However when I looked into it I wasn't sure
there would be much appetite for it, as most drivers bring the link
down on close as standard behaviour.
I'll submit that patch as RFC and if it gets traction and acceptance
we can drop this devarg.

  reply	other threads:[~2025-08-29  9:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-28 10:23 Ciara Loftus
2025-08-28 10:35 ` Bruce Richardson
2025-08-28 14:55 ` Stephen Hemminger
2025-08-29  9:46   ` Loftus, Ciara [this message]
2025-08-29  9:45 ` [PATCH v2] net/ice: make link state configurable on device close Ciara Loftus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM3PPF7D18F34A158305FAB4D8BECCD2DE38E3AA@DM3PPF7D18F34A1.namprd11.prod.outlook.com \
    --to=ciara.loftus@intel.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).