From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D41FA0C4D; Tue, 2 Nov 2021 02:22:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B31324069F; Tue, 2 Nov 2021 02:22:28 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id D52F64068F for ; Tue, 2 Nov 2021 02:22:26 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10155"; a="211919691" X-IronPort-AV: E=Sophos;i="5.87,201,1631602800"; d="scan'208";a="211919691" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2021 18:22:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,201,1631602800"; d="scan'208";a="727615355" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP; 01 Nov 2021 18:22:24 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 1 Nov 2021 18:22:23 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 1 Nov 2021 18:22:23 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 1 Nov 2021 18:22:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H+mM+rntJg+kzLg881Kd8Od7sfGFrM+N05JgRod1wMzbNgXFXcrexBn/eoJ0Xql8QwjhdP5uX4HeeZnM91wINGRsWMCKhUjyEg6f3/zK46DXz9r5xmfvVOqcD6woE+4f5DW4fr3UIgGdmnQVB6hDplZr9FyS4+RuaZfEYhTaeZhCS6rk526PTXwILRnQa0UGqC7UWkpFPE3wpcwSPcl2zXEa820hVc+557Y/N3dTY40atxbgDQeDRGsMI39xWx+byaAnLhPHJgNMBNWuKO4/QIHEfXwaSHKjRghoX53+fpQMCD5cKE5nAfpeIrtaj5i9KihKhmZVlHjowXzvRJIcew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fvcPv+/y9V8itZ/0fhAF8N5KrAYa7ql+wsM2aIZcvMc=; b=K/eA8TPJURCl7Kz0PmiIW8clfOZETqRm4E77my8gfh+Ucrum/65j3puqL0ypyoq7o8LFcX7Q2TdxrqQRLewIwXtlZzPKOQUujLHm8JeVynP7wnubWLLS+v1yIhqW3pRPqU88bwpUxxwx70ahbWOD98fjNdm7F+11JlaJAIVgA1EdJ/8JFikFyd13J3lMrIzUt2v5AmFkhehGY5MQyb8fEUnwNeRL0snGu8zJNS0bTh3UpOUlL6kZdEDAZ+oaYUvC0hSr6ygrosRL31cNGha89nj69VSoCMhrieiqOIEwbLb0bHamasEhDfqb+LYxsSvgBh92D6eA7891INgALxSmDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fvcPv+/y9V8itZ/0fhAF8N5KrAYa7ql+wsM2aIZcvMc=; b=UG9bWgsDwCPPEAQLSBgfMZ/MDcAb3G/apdmlnFHeybJjQYiGHRD/nWDYY4JpSbHs/20RgRhwhkIN3E/UOiYbBsV9Y5O44Fj6/+zZFWUb0b5ahVF0yPbb5jqlG2jLqyXffJvMNDmmds/f5jnrz15zXqSL387/jrg6TU94u272tYc= Received: from DM4PR11MB5518.namprd11.prod.outlook.com (2603:10b6:5:39f::18) by DM6PR11MB2588.namprd11.prod.outlook.com (2603:10b6:5:c6::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.18; Tue, 2 Nov 2021 01:22:21 +0000 Received: from DM4PR11MB5518.namprd11.prod.outlook.com ([fe80::e03e:d9f2:f8df:43a8]) by DM4PR11MB5518.namprd11.prod.outlook.com ([fe80::e03e:d9f2:f8df:43a8%5]) with mapi id 15.20.4649.019; Tue, 2 Nov 2021 01:22:21 +0000 From: "Wang, Haiyue" To: Harman Kalra , "dev@dpdk.org" CC: "david.marchand@redhat.com" , "Mcnamara, John" Thread-Topic: [PATCH 3/6] drivers: fix bad bit shift operation Thread-Index: AQHXz1INoBH0zST/CU2Kf2025BGpqqvvcQIA Date: Tue, 2 Nov 2021 01:22:20 +0000 Message-ID: References: <20211101175337.83358-1-hkalra@marvell.com> <20211101175337.83358-3-hkalra@marvell.com> In-Reply-To: <20211101175337.83358-3-hkalra@marvell.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1af86796-692b-4713-340e-08d99d9f37fa x-ms-traffictypediagnostic: DM6PR11MB2588: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1850; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0471NgONbhngMTlEigg1UHCsuzSdqcapl2lOyoFsx/ZtLTJqR2CwZhZU7COYoo/Eq4BdQxIopHgUlt9UwhLIA0CJqpPl/A+2dr08GAT9w5/WR2CZnma5hmp4HKREue7j16qre5k5Q5hey5sET5ij9Jai8p+7dZXDfE6oL/gHP8XmTlajVfneK5H6n+ib5pYCu8g3KXvR/aLNiXNsgIhxjivapWE1HPqk33stFPWlZWO65t+ShTz1sP7cQk3AG9K84r5ugnKTV2d8hUzg+KKTHpdHOgyjSZ17zsV0g2zoXmtTRbIbo57H4zb5A9NUfAnmInZpsC+O0AbnAnvrYmC0MHVTyb8u/FZ3iqoVOq/6xR0sLywywQUx7NvesWkUU+rLw5GvhUxQmzQWhoysTM1Krwj2NBs812yOPMgsIdSSTF8lJhDuRzRptPclbFMuKRWE7ugMj+gN3Ooqj678mO57fLbSWl2J6fGY+Vgz3tQZhMoHYf4fdCMJGpFeJD743yB3OY9Pz3DSG/J882CpJ1WsK/4aeIgUxh9Dy8w3VxuYtOJxK9QPV5m4R/GeUg9tlz5Z/zU4sSyZasmgaRAHmZoI7Y1XhI5COLJiGPUCqp4OB6fMZmPQcf6z83MNDeB86Y7m45iIv78mAWxJwgQPCuWuBqpKxzRv8mSs7hsZZAvu+J307D6YJGnvbo3Dj+oZ15eSnxEoQ5oMPP8NxiI4hW1pIA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5518.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(71200400001)(110136005)(316002)(83380400001)(55016002)(54906003)(9686003)(53546011)(86362001)(6506007)(7696005)(26005)(2906002)(122000001)(38070700005)(186003)(33656002)(4744005)(5660300002)(52536014)(8676002)(8936002)(82960400001)(76116006)(66446008)(64756008)(66556008)(66476007)(4326008)(66946007)(107886003)(38100700002)(508600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?A0Uf9pkOdgICf5Ion/7yY+FVtLjWPGJOKFZ7AAba3jgxp76ZxsZcX79rVBLS?= =?us-ascii?Q?44jhKgWFPE5Ltem3fqBpa6R4GGmZE1V7SRAWGHVmWy6I8skDgUSLTi7jasV4?= =?us-ascii?Q?wMKcLOclbzQboYC/qr/W9b0qneVWyjdbOENh87MyrKhcdygFFt7jlS6vP4RC?= =?us-ascii?Q?IFEPlPVh/72jpbV5aix3lPR3QDpBnVqaICWPuxXOcSQKR8ey/cHf4x1q78D4?= =?us-ascii?Q?TcmOdkYWOs18vbJRuvDNIsTyeXub3N8z7VIqylGbMzwZ5bYIDaohCiUfsC9c?= =?us-ascii?Q?cd/Hr6usT0GxBAohKfnNirbo65LWHUy5YtGjBF8/gAy5jVwOJr77Ie462cU0?= =?us-ascii?Q?hmamQ1e6MvhGhtM5xlZ7m3qchwXdbKaiNbIaxjHQavQGLlaZnVj0qambzXUs?= =?us-ascii?Q?whxhDMqLWlvD/xIMhmyAGrQXq7BUHvjFJmfuerKMiQFrVgYkNXNZ5Ia2rE0N?= =?us-ascii?Q?ywvVrVwC2Um6u9Dvn42WipgOCVCqIWBfUMivMSYK0B5F/2PINhsC2aPP82yo?= =?us-ascii?Q?3dKzpwpejfiRy0eqjCzfOj4hhqOGge4t6p7sJbE5fe/21bKegTd4L4A40zal?= =?us-ascii?Q?0rcND7xA8GLO0+D7zw63Ndt1ku6UnJr+ToiKV2ISDO9S4a/x3uk/TaV2SwII?= =?us-ascii?Q?3Tn5ymd1yfNz4TFBOFqR2aUTKgY1bTfIa/K7W/xHBEGiFdpKaUHuzoHzqCiC?= =?us-ascii?Q?6iPtPuR+c4chUDBPYO1epSw4IsCdAw69zJTX4/cWBUWvZtdshCW6XrKyjLyv?= =?us-ascii?Q?PraNcRgM/PpF3/PdJbo6bhIlH+sNX8y23PBDhMPXwoHZOiBTFChB0uPbP6FU?= =?us-ascii?Q?kgD4TVLr4O4f/aEAeAkmfuMOVGWkQGe2USCGWBBz4CoiaQFsqGLVSgkF1w66?= =?us-ascii?Q?p6ZghOMX2CBDJWbtX69e3ULPvr21u7UJQ8sS0JK41W1rowufCv/ZkZx9DCtT?= =?us-ascii?Q?qm23jHUXaZobMQgH77JaBp0qsLajCG20qMv6V2I3g20QFx3kZRDzU8Y2LVEC?= =?us-ascii?Q?5DSxZxO9m1IBSLM4dkSAFRXqEJub/CVUMpF/+EnIaAT8It61lDACAdBQKXXP?= =?us-ascii?Q?mdGtKeWDlbB18gROt6ljreDP+Xi4er/8QU/50GWyoIBVL2tEFnMRvHEYNsXh?= =?us-ascii?Q?/kjXzSs2dFLImzVOI2jSvnIc2ExJeNKpsJazuiTE47duDMaNZdH1ozptrZzP?= =?us-ascii?Q?cF05Z4oW+9E/6XEobRcGwckGCphzrWMWK2WIOj3XSU/1A8x6pMDBWYhZP6QF?= =?us-ascii?Q?GAfKn5XrbHwZSXf+7ZjDUi8GTaMHZCtxTUL+vmeJUktk4SHxBSob8DN95XG6?= =?us-ascii?Q?C22a3uJ64wAPrEwiZ/Dm7tBwfkfv8YP5hOVdyguiNWcV0orYag8/yU/vTkac?= =?us-ascii?Q?2j2YALABGXwewKnJeFUp+2Ge2nDex+QcLbvch9qJ900Z7Khb2OmUT83qDLWX?= =?us-ascii?Q?Q4BDOIZ6hZ5fTfg28Vwg0SmoYkDm1UjAOK5NdRki0gHV19M9s0bg4axVLNxZ?= =?us-ascii?Q?n2PT468a0A6ZYI3/a6Mi4W3HGw6iZYWQctUxXAf/NBAE3ptn5s+oEl8qsMZy?= =?us-ascii?Q?hz78dRzLsn0Hd3gBfmHCuTbPa894j8Xfz3dD0MNROEw0+9OBShEIFmzDBwg9?= =?us-ascii?Q?wA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5518.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1af86796-692b-4713-340e-08d99d9f37fa X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2021 01:22:21.2478 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EBnQjnztaEhRuExCRovOZ70lqfmw+s5inDLq6nHLAUps0ZyEth/scz5Tl46qJlqM7pouTc7s3v7NelC9yfkpyQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2588 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 3/6] drivers: fix bad bit shift operation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Harman Kalra > Sent: Tuesday, November 2, 2021 01:54 > To: dev@dpdk.org; Wang, Haiyue > Cc: david.marchand@redhat.com; Mcnamara, John ; = Harman Kalra > > Subject: [PATCH 3/6] drivers: fix bad bit shift operation >=20 > This patch fixes coverity issue by adding a check for > negative value to avoid bad bit shift operation. >=20 > Coverity issue: 373717,373697,373685 > Fixes: d61138d4f0e2 ("drivers: remove direct access to interrupt handle") >=20 > Signed-off-by: Harman Kalra > --- > drivers/net/e1000/igb_ethdev.c | 17 +++++++++++------ > drivers/net/igc/igc_ethdev.c | 18 +++++++++++++----- Acked-by: Haiyue Wang > -- > 2.18.0