From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D545A0C43; Thu, 21 Oct 2021 03:14:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 134FF410E2; Thu, 21 Oct 2021 03:14:14 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 9816840150 for ; Thu, 21 Oct 2021 03:14:12 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10143"; a="226379168" X-IronPort-AV: E=Sophos;i="5.87,168,1631602800"; d="scan'208";a="226379168" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2021 18:14:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,168,1631602800"; d="scan'208";a="719321911" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga006.fm.intel.com with ESMTP; 20 Oct 2021 18:14:10 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 20 Oct 2021 18:14:10 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 20 Oct 2021 18:14:10 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 20 Oct 2021 18:14:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hWBjB2NpyC2e/i8x6RI/BEo/W+WcfpmmLqJ1sA5neKfj3bRg+azBk335AA6R52XxGboSel6fT/nobqGisyyzDwxg4wWgCXEyMdr0ri2Nbv5+ZOnTg9/h+GZA5Ie6nbJ5JloVCdTycCVvfIuZpp5rKhOssKje84mGWH956JCnkcRcMT7alxNqhR/aCLDj3ntqHwtoFlIxF0hhtwTZcPIo6IecKoK8zxBSnCRlYVSOe9T+P/JUmJloaKPcov3VoegygO6+/9Y76ho5pQAJCvm6Baph5aliKMfGflcntvDJoutj+4nCfKC1o8VOYZYWtO6l5ylr2QxCexhJmwS0blvbwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cdOdIwKZsxTfkTXgM2hyCxMg2HNZ0VddyTHLdlWC7iI=; b=VuOI2WdS8EtxZiKHO666egeatPZ5DAH4/ZZZ71y8+hxUTSwV9kLU+08kMiNOhSXXe3D7yKHI+CCeYpW3WqQxLDs9ntzBweOBgKOuLMMwxg6yxY1s4MRQx9P3rlCn/W9TYoxKQ2hOCizb7REAH3LyxV+OsJQ3VLZ0Z9+sSZgTvK9lMUvOrOHSoN2R6SK0DcaE6JNUX5fGNDOxrVJzY79EWDDlpwpFnqvpQEH0lAqG3dwyt+A46wUMPCtnjgge7mOlKKOEtUeBZbEs5iXY8jhqSHvtI9MakDRgZeGT+2UPzOmFWNX5sj6A3tkgfB5lpyt05IwYM1kwig5KyTdajapTlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cdOdIwKZsxTfkTXgM2hyCxMg2HNZ0VddyTHLdlWC7iI=; b=mS2X+LrVzoafJa2+K1dC+2b4x8bukpB6aqjR0TP7TzuiKCH6Mk5/nH2jUR+wSwwLvfIuhRgzesTKv5jH0S8f8wvlO8kjiAMgCP53HTiwMrYfK7D/AwxVUChVd6UMkzkRlK3qgn9CU45t5DwLqYE/sJv6gW0wcVr1EOw1pDBxkpc= Received: from DM4PR11MB5518.namprd11.prod.outlook.com (2603:10b6:5:39f::18) by DM5PR11MB1881.namprd11.prod.outlook.com (2603:10b6:3:113::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Thu, 21 Oct 2021 01:14:06 +0000 Received: from DM4PR11MB5518.namprd11.prod.outlook.com ([fe80::a1a3:f5ec:2121:415c]) by DM4PR11MB5518.namprd11.prod.outlook.com ([fe80::a1a3:f5ec:2121:415c%7]) with mapi id 15.20.4608.018; Thu, 21 Oct 2021 01:14:05 +0000 From: "Wang, Haiyue" To: Tudor Cornea , "Zhang, Qi Z" CC: "Zhang, AlvinX" , "Yigit, Ferruh" , "dev@dpdk.org" Thread-Topic: [PATCH v2] net/ixgbe: initialize port even if mtu config fails Thread-Index: AQHXxd5NKTqJgi2qAUmOxlSCQ/44aavcpa3g Date: Thu, 21 Oct 2021 01:14:05 +0000 Message-ID: References: <1634306769-20123-1-git-send-email-tudor.cornea@gmail.com> <1634753626-84056-1-git-send-email-tudor.cornea@gmail.com> In-Reply-To: <1634753626-84056-1-git-send-email-tudor.cornea@gmail.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f27681d6-92da-40b3-82e4-08d9943013b7 x-ms-traffictypediagnostic: DM5PR11MB1881: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:51; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: G74qFx+YdBNyahrXdbhP9BMPH0itS26ckWQbicORJsk+kxc3xR6Sa3YoXfbjTPRzL3R/U+3iQCdM6ykDaSXGxXF84OwcDv5lvgGihm8IRQhJWJbhn+KftJXtsHK1NKok3/GrzVoczPxNkSeE8s7DiP6J/R+CiW89odqTlul6wn6Nj2bVRR0DNHkFvNaC9x/lF1lLFrRoAG4vWXnZV0FJd/6uo+9OCrBGlKI3CGAxB64rXLggBSdpFFw7tjbXIOBZpeANnL5lUkahC/7F6vAUyUdBFRY5dPJYyr5ziV8mwySftWXGnPkMykucseecMWg5HgbLhObFF62YnxA/VWJOk0/tfiqCoXTlSc70u4JKYTXomh+eJtUmFCv85ey31GC1Sq1bCWFlUXC2p3kWDuXAmTfv/B40Al6nqaJh+yhe2u5yYHi1JrCzc5YqayQNOoADJh0qVVHg0eQnEpUQ+FX5vvEiK1y+QeLEdsuaXM+4v1W7n5QGMGxFnKrGP+g4eTJBvt0k2Un5KYI7BHg+LRE+4PkJZXmTEI7iBXrVszXbzF/3AdkdVEfeZ4bK0pUVvTru3VTc06p+c4Mz/iEhLPzocdN6RycQSjhwdlIURXKsyauQn2AE8Xr2AOk9sQ0JONanNyITJLs2c8sM/bYDNL5jG4uygAuHpE/f9DVgg+4oBWAjG0etrOKxCLtGFAAXdlVwNhXx+LNgrvXyylYLzl7dVCbfqggpAEt2Wwf8uV/NO6PdLYZaZlUL2zmtnK93kunyJup3aBJMZlP9hW9IYLZhvxuFmbRxZApnHuFGgt0meWw= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5518.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(71200400001)(9686003)(76116006)(7696005)(38070700005)(53546011)(6506007)(186003)(38100700002)(8936002)(8676002)(966005)(33656002)(4326008)(316002)(83380400001)(6636002)(86362001)(2906002)(66946007)(122000001)(66476007)(5660300002)(66556008)(55016002)(52536014)(64756008)(66446008)(110136005)(26005)(82960400001)(508600001)(54906003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LUrAQ4kt3ip45lX6pz3iro9KS5rX12va1bn10pGQDGjUZZjTL9ot/IX9trTx?= =?us-ascii?Q?WPlhcYonDDctJ/Bk2qdBsSMc2mKSWeeX9Z2YF2jRooR/30eXtC/Seq6+GPWP?= =?us-ascii?Q?Ie7a5PEIhxW8BtsjW1DYZ1GM2XejuS02trRZyL6hSIkrBU0S+oCmKcYe86fF?= =?us-ascii?Q?csGEv7aI8LiY+1Ac6tpyeRRwTpsj93imE7l8C2wMbssMk/Z017Rg6dcYqzpq?= =?us-ascii?Q?loZBlGjmQLPJi4xE1j63T2kzqbe/u+dkQrHXtmuKrda+4OGETixfhP3PjkHY?= =?us-ascii?Q?KPLeDpIdjoYpDUgy/dGzzHaXVx/RSjeAlBjfEYM5t/6ARtLqfZyxL+NCX5pD?= =?us-ascii?Q?gygd17f7W1gzPy/S8dyG5rBwM2nHTvdz/geSmoKZaklN/x3sbEEznsEI3Eq+?= =?us-ascii?Q?pE6f/7DTYkzMu3yktCvzGnUxKRoj7kgs29EoOAV7fuv8+WKY3cMP8GIwHvqF?= =?us-ascii?Q?6Ncv24PdcSQz19gEKTy4A3VGe5+bqsEfNn88ofDWho3X5nTl2nFkfhiZlDmP?= =?us-ascii?Q?27IQ4p9bmWUKqkLGlMIOJozLIMrTpiep2Fa3XmI3DuTFen1JTEGuxkWNKf0L?= =?us-ascii?Q?x+nFEEu9SSnnqON6oP19c6M1Fbhpcnlq8MvxjSq5xpGjS3Uo2SrKwUvLA1c5?= =?us-ascii?Q?akCVR7Z5/tg1hZsnehJqLzeKai/Zq0/uvCtM8dEMh0d1d0u0PXjttUKTevUG?= =?us-ascii?Q?ykS+JmI257FJ5Hm0y1+Yoykzo4sAPKsweyTBMYqZ1JweJb9v2xDSDmlNCAtZ?= =?us-ascii?Q?Wtgb9a0u+yJ1c1hKpIwDUYlXn6XlErZjNXbLvbi4oHF1LifySAXMOvxBSgxp?= =?us-ascii?Q?BFkH9NnAw9gW0qWHs7SOgd7CP+6kAon1/6rlRQkdc+9ZhSmwzcmBjalnaTu3?= =?us-ascii?Q?wzaFuzbCRCfjBDoCsZssUjnPDcpL89p3KIYuTwVAiDlxS6wm43UZC4+bs8dQ?= =?us-ascii?Q?qTgH1r67pD1UKNOv2MvNPeTGqN8/ib57L9Nh6D3nSKeUsK7krgIOACfah2n6?= =?us-ascii?Q?jpGn3bp8PwqlCvzMBDzBC22jvkrRx3sU4ouuU5zoinaNqxeozHoWbDtrq4lK?= =?us-ascii?Q?7i8OPp0BeMeYnQH4Teo1KfupJlpajnzytAMKFx2I5mbpkue+QBME1saunwM0?= =?us-ascii?Q?V4sYbyZdZN4Q8laaerWktPKy602BU6M2H8fBCwfrxhFT3peJGkgLBp0QwbEz?= =?us-ascii?Q?wWi+dNsCtk0PWMqkXCeTOrYkROKrh04HgFAKKGmAAn5z0aqRS9es8UuhEeBW?= =?us-ascii?Q?mB292My3TYN6XSClX4thI+Ud3NAst7EusSMz0ZqgE+j7SOZLQFtRek/idijM?= =?us-ascii?Q?+/Tl3Xv+JGoD6asP0kHs8eX8?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5518.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f27681d6-92da-40b3-82e4-08d9943013b7 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2021 01:14:05.8685 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pba61MaTDIKaMS61vovAtcBvrPun95MvFZp4QPdVRBpFL6iFjYkTlAqy4nC9/0MTS67tdggUnNMXevNYKzeCZg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1881 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: initialize port even if mtu config fails X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Tudor Cornea > Sent: Thursday, October 21, 2021 02:14 > To: Zhang, Qi Z > Cc: Wang, Haiyue ; Zhang, AlvinX ; Yigit, Ferruh > ; dev@dpdk.org; Tudor Cornea > Subject: [PATCH v2] net/ixgbe: initialize port even if mtu config fails >=20 > On a VMware ESXi 6.0 setup with an Intel 82599 NIC the ports don't > seem to initialize anymore, while running testpmd. >=20 > Configuring Port 0 (socket 0) > ixgbevf_dev_rx_init(): Set max packet length to 1518 failed. > ixgbevf_dev_start(): Unable to initialize RX hardware (-22) > Fail to start port 0: Invalid argument > Configuring Port 1 (socket 0) > ixgbevf_dev_rx_init(): Set max packet length to 1518 failed. > ixgbevf_dev_start(): Unable to initialize RX hardware (-22) > Fail to start port 1: Invalid argument > Please stop the ports first >=20 > If the call to ixgbevf_rlpml_set_vf fails and we return prematurely, > we will not be able to initialize the ports correctly. >=20 > The behavior seems to have changed since the following commit: >=20 > commit c77866a16904 ("net/ixgbe: detect failed VF MTU set") >=20 > We can make this particular use case work correctly if we don't > return an error, which seems to be consistent with the overall > kernel ixgbevf implementation. >=20 > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/d= rivers/net/ethernet/intel/ixg > bevf/ixgbevf_main.c#n2015 >=20 > Signed-off-by: Tudor Cornea >=20 > --- > v2: > * Change title > * Remove max_rx_pkt_len fix in ixgbe_ethdev.c > It's already fixed as part of Ferruh's changes in next-net branch, > so this part should be redundant, now > --- > drivers/net/ixgbe/ixgbe_rxtx.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 Thanks! Acked-by: Haiyue Wang > -- > 2.7.4