From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C7DFA0562; Fri, 19 Mar 2021 09:59:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4CA8140F44; Fri, 19 Mar 2021 09:59:10 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id ED35C140F42 for ; Fri, 19 Mar 2021 09:59:08 +0100 (CET) IronPort-SDR: Go+araATieArcBJUkvLB2AHnIDz2HSnbvZmyAnZGNiaQEhfmYfsG1WqPpZBei2iWCq/QAClD6t gz9KpA5apGcw== X-IronPort-AV: E=McAfee;i="6000,8403,9927"; a="169782883" X-IronPort-AV: E=Sophos;i="5.81,261,1610438400"; d="scan'208";a="169782883" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2021 01:59:08 -0700 IronPort-SDR: Kv2bwghNO+mecos3tzpWD6KA/DTWavnJIfJrDDXQBnGVd6h+GlhdnyXKE7v7oBKIjx5KgI6XpF hmKHG3G8NBJw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,261,1610438400"; d="scan'208";a="603076396" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga006.fm.intel.com with ESMTP; 19 Mar 2021 01:59:07 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 19 Mar 2021 01:59:07 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Fri, 19 Mar 2021 01:59:07 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Fri, 19 Mar 2021 01:59:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fN4lwVlrfgbuVIBEh9cOF0+m1O+MBANfSdVGG9k2U57f8KHW8yoatKHJQeezOUUdp7s0JaE+qPykCO0NXitvQtjb7AiggrIfJUsAATv4ICvwosxdTiHtfSl4che5FQsigJWl04Eiw3JSP1TFp39IjfAtK6by9Byfam+Z59mOLI5XZrxnrk+mNpBIse8rs1VGSQdNARIX1JnQLQYOGFoop9HRMbSE29deaQt+Jf+H9EFb5aF5+ReA/BDimaQE6u/8pCpMDrKqmk2tQ5rikMR5PRmndVOoXrsiCLj8QCdeiSSOdZK4BViJIN2uwXG/ZMfIeAxaTjIN0T8kO8Oe/XDgaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Las9VFb86oZ84ALyjSB18XVrzt2FwP0tzv9shOSruIc=; b=cLFb0szOvH17Ut8J0beEK7sovUKogZWts33mUrBPSNH19ohfCxtCS9ei3RL8TgZOLiXsCjaME4h6El6ImyTbzNVRJI+Vb9IEjBoR0rbE8v2Lmh3TBWYnGlLAkUiZdaPRN+ARKQu6bpFDGN4Ay9McNCyJzlrLqT+1h6KGT0gIUgzMaDiYTOZKYmswmwaMsvzgEEq0Qf+L4yCtwrb0thMhyOmj9zrlP/XTw+v4d+MaQVq0CdEXNfAiGO91EJZkX1f9o2/bNy3LELYZwQZZylixlis4z/h7OcbBIX5rxZ4+k/y2HUCam2doLSsN/qg0IYkT5XCJBsQtJ4f/QJuUk4Pj5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Las9VFb86oZ84ALyjSB18XVrzt2FwP0tzv9shOSruIc=; b=w0Z28IgbcrDAMfxQlOzoAULxJOfx5NDqoUhwg1J9pt1TOO9qN4mmo66KRlwXK5T3yDs2WCrBKKVpXRR3CMX8YO1CG5t06D4tbnmXaJiN4woArqTVDSJ6ArdGwhdocvX86hSQ79J+5XOtApQiZiiIPu2h/qmeEpTJjsSa1NswCJE= Received: from DM4PR11MB5534.namprd11.prod.outlook.com (2603:10b6:5:391::22) by DM6PR11MB4105.namprd11.prod.outlook.com (2603:10b6:5:5::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Fri, 19 Mar 2021 08:59:04 +0000 Received: from DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::79a3:3404:b907:d49c]) by DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::79a3:3404:b907:d49c%6]) with mapi id 15.20.3955.018; Fri, 19 Mar 2021 08:59:04 +0000 From: "Li, Xiaoyun" To: Thomas Monjalon , "dev@dpdk.org" CC: "david.marchand@redhat.com" , "Richardson, Bruce" , "mb@smartsharesystems.com" Thread-Topic: [PATCH v3 11/11] app/testpmd: fix usage text Thread-Index: AQHXF2wK2IyWUswZHkOyTj1Q9Z1JF6qLBllA Date: Fri, 19 Mar 2021 08:59:04 +0000 Message-ID: References: <20210309233116.1934666-1-thomas@monjalon.net> <20210312181720.242252-1-thomas@monjalon.net> <20210312181720.242252-12-thomas@monjalon.net> In-Reply-To: <20210312181720.242252-12-thomas@monjalon.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.54] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d27ef02d-87d6-4362-a37a-08d8eab53f1e x-ms-traffictypediagnostic: DM6PR11MB4105: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1051; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iIv73TkXFgwD5aP7FF1KVo6+XW3p/DzC1LH4a2DUTb7afG3bRtnJJoysWgKjsQL3lzDfd5+Xt9EAnzwZK9rkkMwdBPCkyCSRPa3l0mufRTjBmn0ct/ZUueQzq3dmVh0yGGWiMNjpIPqkoemP8h0nZDoD8ByvbUwe7/sHKVyoSpAuiMjeHQzzyi3ciJss1xL4fMIL3PTgnApZZF90WFjENhbXjYlngepPgeKEqU8Yhr8YQqAjvv1UC059Ct7OgEXFRSQithscILAvwZ7pquUbreqqMFRGV5avIubPvARw4+otnjeMHWBic56ljq7Or4LptI50iLs0Txg7tcaiE2luu3gVgSx2HLOfaGVbjKTCxe6lv1XrTX1x8cahGwB9SAMNfk2pqg0C564JuNINUGVJyWbaQpPb3iVm/Avyssuj6S4KigwPc5bzx92qvVTVC8HLs8fRzFp3BztDDiCuD2TH857Mj79aQdcYT7yt4KIUDIwoELB2E8yrXy4uhT+0Fiq2emFVgd0i7ZPq8t/AfM+lGvqxuDB/YLchDdBU925od04e/pc9esZ+Z4+NnufyWuOA6CofZkeW1J2yGyq13nAs0HLJxR44FTdZqWOwUO7u9qLKEbXNcOKZxKAM8U9PKTmz1QCbLeumWeiKvz50OST1doHHcEgHGpl9cCWSXRrJXr0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5534.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(366004)(136003)(346002)(39860400002)(396003)(66556008)(66476007)(76116006)(66446008)(64756008)(26005)(4326008)(478600001)(53546011)(316002)(8676002)(8936002)(54906003)(66946007)(5660300002)(110136005)(6506007)(7696005)(86362001)(52536014)(83380400001)(9686003)(71200400001)(38100700001)(33656002)(186003)(55016002)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?6gLU5xZk8DuFXXt6GydXf8k/si1n16zSurxLR1PCD2f+N7jfy+szSr5WAL/g?= =?us-ascii?Q?Hnvh0S4lP9BKOlJehNsiVTIwrtxBaJq8GZz6irs7/z/D5hSk2O8y+qTaer64?= =?us-ascii?Q?njZHhCskZaMEPUh8ulonEM91UokM5q5xZVEnsPqc4Hy0lHhGAMopq8KJ1NL7?= =?us-ascii?Q?9o4f+bD6mr93GW92fV499fqSPeFlWoDLxpSA77gMhoDWLwrEh0byg/1DQrZr?= =?us-ascii?Q?HwIldZTqg0KvUqp9oV4cRGBnb4jLZ3Qe3o/EMFxPoNsQdC8hACTDhgAz+is3?= =?us-ascii?Q?HnqzJt34oYxQWwX4xCNXFuGHYqYsM9VxDyVHA8xRyxwesf1GS+3TX8ckBrw5?= =?us-ascii?Q?KTKzMc2Sy0TMcsM427mdROxNoqxw/e2cysURTiKYuBMRR+GDaVZRy50nq5qd?= =?us-ascii?Q?Re+mHiXS6jC1vB4fF7+2K6BsZmCNrKXwyJHjyMCr5TkFjX9jy5vaxK/bcqwq?= =?us-ascii?Q?VnUktiYkaqRUm9JLCZjSZNhNKn/wOTkSEK+MI5tNl2pQymcVkcNEze8x2Ml4?= =?us-ascii?Q?0yc3hMNO9G4w8wSUDpbyL/AW043K+/omsjoMrVETBvemxxarh0nefYA3AU+A?= =?us-ascii?Q?soAUZjgOdoyY21KDDqnMYFQoI8HnbRzTIrJeNl2CKozh/Rj1+LNMpRuxM3sj?= =?us-ascii?Q?ngdV87f6XpMnDE6dYxMrp+zyGhosOaqlqryaRPp8WXXQJzNXylrA4FEQKZNH?= =?us-ascii?Q?pS+wfCc4M6Mny+dLsEa3dCsJBei7hntwngZynBaSLpYPYJG3SY1LA/rFlyhS?= =?us-ascii?Q?tqSJmPaEKlMNCXeFsf0cCkPoiE1DqSU0jvBcg2NIF1eTzoiwlSak4Kj9gRfn?= =?us-ascii?Q?2RVtKig/G6BRsvtU5hg0PHHIrnDMHeGET72dVEjzRcfpDw6ZI0Ionz90soaX?= =?us-ascii?Q?0DgyMDJodoiBDnGmec0VM9AWgOSrUw5Zv+QLNURSUlADnBdMM2dXIjJUIO4W?= =?us-ascii?Q?sh6clu3nSo48HPIS/Wn/FZqqMleqP8nPix3RMHrbYHG8+fcy4W4/cPZRVYGi?= =?us-ascii?Q?IAs1JwwR+HfOIe7Mx8uP13cbynuFsV8SJZjrJMecssOpbue6B5DRC5AcNsYP?= =?us-ascii?Q?js7WwtOgC2ihE+YJqiGXpqwNQtpdVnAWm/angRG4x1hVQrpps9v5VHp4ruar?= =?us-ascii?Q?beAzbuJf6efsKwPqDtXobKSplAiNztwzv6HG1D/dlAKZyHtFTNSlkf4q4Zj+?= =?us-ascii?Q?vS7pSfqlfDTdX0yRuICF+TjFXlLmypokKtcljaiVyVuY6+Ncjf8kQyI2bf5E?= =?us-ascii?Q?+/oE8MJ/0u0CFfMkTOLfB+U5kARi11ZrgyQc4jLBTEh5IihDeHIj+ykY1q/P?= =?us-ascii?Q?Wiw=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5534.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d27ef02d-87d6-4362-a37a-08d8eab53f1e X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Mar 2021 08:59:04.1409 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RSpno+ZfIN8U+jB2l9tHjaZ7D9wx2sP/sXKsOLfEmIdDJugvaJhRNdRNSX2KqlOFl1a+2C2EYKOU3uhQvACZew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4105 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 11/11] app/testpmd: fix usage text X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi > -----Original Message----- > From: Thomas Monjalon > Sent: Saturday, March 13, 2021 02:17 > To: dev@dpdk.org > Cc: david.marchand@redhat.com; Richardson, Bruce > ; mb@smartsharesystems.com; Li, Xiaoyun > > Subject: [PATCH v3 11/11] app/testpmd: fix usage text >=20 > The options help text was including an incomplete and redundant summary o= f > the options before explaining each. The summary is dropped. >=20 > The details of the option --hairpin-mode had an extra space, breaking the > alignment with the next line. >=20 > Signed-off-by: Thomas Monjalon > --- > app/test-pmd/parameters.c | 26 ++------------------------ > 1 file changed, 2 insertions(+), 24 deletions(-) >=20 > diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index > 7f41021d4d..efcbf1e845 100644 > --- a/app/test-pmd/parameters.c > +++ b/app/test-pmd/parameters.c > @@ -49,29 +49,7 @@ > void > usage(const char *progname) > { > - printf("usage: %s [EAL options] -- " > -#ifdef RTE_LIB_CMDLINE > - "[--interactive|-i] " > - "[--cmdline-file=3DFILENAME] " > -#endif > - "[--help|-h] | [--auto-start|-a] | [" > - "--tx-first | --stats-period=3DPERIOD | " > - "--coremask=3DCOREMASK --portmask=3DPORTMASK --numa " > - "--portlist=3DPORTLIST " > - "--mbuf-size=3D | --total-num-mbufs=3D | " > - "--nb-cores=3D | --nb-ports=3D | " > -#ifdef RTE_LIB_CMDLINE > - "--eth-peers-configfile=3D | " > - "--eth-peer=3DX,M:M:M:M:M:M | " > - "--tx-ip=3DSRC,DST | --tx-udp=3DPORT | " The patch looks good to me. But I found one issue. "--tx-ip=3DSRC,DST | --tx-udp=3DPORT " These 2 parameters are missing in th= e detailed usage text below. And out of curiosity, I compared the detailed usage items and lgopts in lau= nch_args_parse() There are several missing items in the usage text. "--ports" (I didn't find this in the parse actually, should this be removed= from lgopts?) "--noisy-lkup-num-reads-writes" (This one is misspelled in the usage text a= s the 2nd " noisy-lkup-num- writes ") "--no-numa" "--mp-anon" "--enable-scatter" There 3 parameters are missing i= n usage text. BRs Xiaoyun > -#endif > - "--pkt-filter-mode=3D |" > - "--rss-ip | --rss-udp | --rss-level-inner | --rss-level-outer |" > - "--rxpt=3D | --rxht=3D | --rxwt=3D |" > - " --rxfreet=3D | --txpt=3D | --txht=3D | --txwt=3D | --txfreet= =3D | " > - "--txrst=3D | --tx-offloads=3D | | --rx-offloads=3D | " > - "--vxlan-gpe-port=3D | --geneve-parsed-port=3D | " > - "--record-core-cycles | --record-burst-stats]\n", > + printf("\nUsage: %s [EAL options] -- [testpmd options]\n\n", > progname); > #ifdef RTE_LIB_CMDLINE > printf(" --interactive: run in interactive mode.\n"); @@ -221,7 +199,7 > @@ usage(const char *progname) > "enabled\n"); > printf(" --record-core-cycles: enable measurement of CPU cycles.\n"); > printf(" --record-burst-stats: enable display of RX and TX bursts.\n")= ; > - printf(" --hairpin-mode=3D0xXX: bitmask set the hairpin port mode.\n " > + printf(" --hairpin-mode=3D0xXX: bitmask set the hairpin port mode.\n" > " 0x10 - explicit Tx rule, 0x02 - hairpin ports paired\n" > " 0x01 - hairpin ports loop, 0x00 - hairpin port self\n"); > } > -- > 2.30.1