From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C3E4A0548; Mon, 26 Apr 2021 13:23:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45BA841104; Mon, 26 Apr 2021 13:23:56 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id DF6DE40140; Mon, 26 Apr 2021 13:23:54 +0200 (CEST) IronPort-SDR: KThNAhrTIdCijXaSDRwbAgv8Rq0Wa1lnI9S3b7XgI0j6cIIDUwH9XCZwZegekeERh+W+L938iS 4NR8u2VbqnZg== X-IronPort-AV: E=McAfee;i="6200,9189,9965"; a="176436057" X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="176436057" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2021 04:23:53 -0700 IronPort-SDR: K5wSDTsdu7oEARJYrUq96aFzqVzdosc3adIU3y/nNPIKqpLlJARQLZMN7XBH2wJlEO1d3rFP8/ /EhwBAG4AW8g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="424879517" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 26 Apr 2021 04:23:53 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 26 Apr 2021 04:23:52 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 26 Apr 2021 04:23:52 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 26 Apr 2021 04:23:52 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 26 Apr 2021 04:23:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UouGFtLYxMum15r2C5Uf84pl0I32Vzl+4R8+9MmHkYBrXIFeqjTfkV2qcX5FN2cfvw5j8emQlSjzPb79H2ZiN65IS66SLFdj63u7bi7AaaWX5drg+0gpsZyXZi+HSJje/SePx++23t7ApQ1Yo51yrq7uCsfVIkINOtRYlRWUVOrem6OlSUTjXMSOn11qO2twkeZ5M/j1xQ+lrWvO6ChH8WdQOZU9silIqgr7rA/S05aXcUXVXLi1KRF7Uq+X3ssCBCbDWGs8aAAc3s9ghufQa0I0eWkTRi7XFaaNk1XLgGwCFiIFtO904jtAdouU48SspLirfi60idOReQgHJEZ5yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hHU8Ck71cU6KYkzu4PtloKeoqm1wAhp2x3DP7aQipYg=; b=Aiu+w99CRESfRH0wVDvOssntfFHdRHYVLK1N37u1Bsfm9CzO5qQMEtMjnTqK9880jbgdt4mGbsxFXB3YK7LGkj2TNtsa1X5TaT7z6jI1HhCoVUQd+2KpKtGTLl7OsnFzkWEA7zu0bzlG8r7nqRJlqnVQuKQYo9l1eM7q0KLrapzhZt0MG7XSPeYJBFONKKM9epFkYH+WxPBpOKcv8m7UYSOZqGLBPS59D+wMd8k0AWF3Yg+pUribnPS0MDfSAn7VbZ30xYKzAJZu9Po8QbXMG7KasisrXqXneZHIG5KH3YNehSBcjUUz8ezws+nEDdWPxoh3W8UTkVUJS6+mX6n5dw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hHU8Ck71cU6KYkzu4PtloKeoqm1wAhp2x3DP7aQipYg=; b=MyiWDogSsYOMUJWVwhJhWpgzLeQOMbd2/g/+wxftTdXUtEgNks6OzSADLelpTN6oAOJnjxPWhsNRT4obtpH3bq420uAdxmL4jo46fZtehmslEFBN/2guPfTuVt0RdS426EbKcBl0fpW0COfNHE1NyVorY5chKi0muLZLyFzk8DU= Received: from DM4PR11MB5534.namprd11.prod.outlook.com (2603:10b6:5:391::22) by DM6PR11MB3577.namprd11.prod.outlook.com (2603:10b6:5:137::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.20; Mon, 26 Apr 2021 11:23:50 +0000 Received: from DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::9034:15e:7cf3:4b78]) by DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::9034:15e:7cf3:4b78%4]) with mapi id 15.20.4065.027; Mon, 26 Apr 2021 11:23:50 +0000 From: "Li, Xiaoyun" To: "Yigit, Ferruh" , Viacheslav Ovsiienko , "Wei Hu (Xavier)" , Chengchang Tang CC: "dev@dpdk.org" , "stable@dpdk.org" , "Andrew Boyer" Thread-Topic: [PATCH v2] app/testpmd: fix segment number check Thread-Index: AQHXOFtOdzaTBGa2TkC1Okc6O4+1nqrGqwVQ Date: Mon, 26 Apr 2021 11:23:50 +0000 Message-ID: References: <1607699265-5238-1-git-send-email-viacheslavo@nvidia.com> <20210423160952.336272-1-ferruh.yigit@intel.com> In-Reply-To: <20210423160952.336272-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.54] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 08ab833e-b145-49a5-70d2-08d908a5c43a x-ms-traffictypediagnostic: DM6PR11MB3577: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +8flP2JpiPJ4cpHGY3cYSbFBhFJmmMmgD29bCS5fycXh/EoKNaXwacAa9wKDAVnCPNoBx060crvcXDwQyYdkmdozu+k7P3kFonb0/3NYbLIIW78KSwtHqZXwXOytRK3O0ty2fuBmcYez17s0VEhXU1ooBT4q2yCiOXHUTDLafmwPZNlpSKAmsolQnh5UOJobHiIt1SpMJUgO+qUZjws1F70hyiH3W2oomYq1VDhDl9n+lyFZ+r421N4x1oAXqXXWchv+At9jx/1QOMzS1r9NQ//v9/4k4GSm5VaZLm3QmSBm7lighGJ3q+3uEputV60c7Ld5+gq9oFRR+O8uW/cclItw6SIrkxJlQaCpSQl8Ku9OQyL46R6TP57yPHzJQeXGTT/50EhaXE3Wfl30xJYKyKuDfxl0s5I0cPyJw+pJoHKUFKClEDtVOVtZ+QJGO0pouYCMmkcKMghHOcvvz1hJhnDp/tFxxuCDD6JktQlySebL77k6xPP6Zm872Xb7r7VWt92jDG7Z+OBPTMAGWAvo8HZ3lV2167xzVyX4DCSsbUUSpJG/oY5aiNuFAoEO5eOT0MsAgsy4OGnbs8TpRDfWfJpXPQ2yEO4Fb0MRd4QUOG8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5534.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(136003)(376002)(366004)(346002)(396003)(83380400001)(52536014)(71200400001)(86362001)(5660300002)(38100700002)(53546011)(9686003)(8676002)(2906002)(122000001)(6506007)(66476007)(66556008)(66446008)(64756008)(186003)(55016002)(33656002)(66946007)(7696005)(76116006)(316002)(26005)(54906003)(8936002)(4326008)(478600001)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?ynGEUlkQjDxy6N/ct1H2BArJoeMCImrjPUSEq1DKc/yd4NIoa2NgibQNcbUE?= =?us-ascii?Q?8eLQkFDmVFpIRT3cCTpwjXT38I4P/myyfT8cGUyGGvVOPrGyUp1WqjG45YF2?= =?us-ascii?Q?I+89OzOjNFvxysRnGpoVBC9OUfNOr1zpmzcT6jvRn8bvpHOBQsB2cA9qHi3W?= =?us-ascii?Q?chmvVvejQ9kqJnJndYk4tphcC9IQWu6oYLNeCgQHHkZafqWbxKacFZq5itkD?= =?us-ascii?Q?HaFPkDeUjtsR38s4+/+zxkB2u9+66O0aVA9fkyr5pXYeehTb5qbEPirXanOj?= =?us-ascii?Q?osIl/vIXWhSDETfqG5Hkxy0d/XIqPk9c6ykwsuHPWGQSNwlYwUiJJK4ek0sK?= =?us-ascii?Q?iDgoiweGUuCBaPnJUuuBo2/z0dSsFBCWL0tkuoQhe2Q/ymacc4gv2y4kjDyT?= =?us-ascii?Q?WL0vtEUrBy0/48Pxp+ByV0my42N7GaZ4FqKethFM6C2xqoUMQAc44fNAgxj4?= =?us-ascii?Q?kDwWPlMuDgo2G/bFzO5a7xEPju7qJ6jEp+DSpE5m4sPsoSYSt0CFzFTKocTS?= =?us-ascii?Q?C2Oks1BiZf2/7YtPRO1LVqcVwj+JDI2s3ec+A2qnr48XMCkEfKJTRyBOMjZF?= =?us-ascii?Q?u+dpcnJoJbIvOugO0+Dv3WqPNFLeqeoKs6KWz+Msxylsa1J2oFWPOB0FHHRQ?= =?us-ascii?Q?jLXX3OgjA5CTdBt0wRPsytzW1ygrbXxCm9dLZLU1IP9HhGbcaX9rMd0fXkNe?= =?us-ascii?Q?S8DvMzHsZEc0QPKWjvpCkhkifHyi2jae3wLfWW087nSWxrLmRZAm5OGiIQ5c?= =?us-ascii?Q?EwM9WTBKT6eHogOLqjHHTXCJnyYxdSRLhhxjV0NqGeZtjKUarENjWGOacW7t?= =?us-ascii?Q?YKxYQ+1fAiqAZ5R0sHAhIcgr3T4HsQKGy7YKVJT+sZndoWDpLUxzg9Pve6Jn?= =?us-ascii?Q?JjWLF2FZyxZPCJWmCWtSj2XUSGBuxs2j4Ni4ZNJRNjizXSIqkrinXqMOTfk4?= =?us-ascii?Q?Je61xryLwXaRFpv5b1TpZ554fVDeTGnXbNXb7k5/rraXIpkAVL65xOpBpMw4?= =?us-ascii?Q?C78JP+zKPFIpjQHKyC9n97jbRDcyhNR9VUvVVFKsxUeN8JyXNN8/wxAcMOeQ?= =?us-ascii?Q?84URX8yHnqLxbEkDh1YFAYX9A9NK4ZkU2x0Hqx91maLXCsVBsclXRUe5/C8G?= =?us-ascii?Q?csSTi8MratD/70GrEvf6299gX/QDqVQTihIWibdcDpF50bEP6rmEXvFjALlr?= =?us-ascii?Q?9pfFf5cHNakbDvIMzeCcYJazcYB6YeY2OONb4joy1tJmu3cHaaiVQm9HX7iZ?= =?us-ascii?Q?ivE3+ZkMhoeZZ5oHJz3wA6hqV75Npc9+AAVJq4BgGzPN7VGa+KA1yCFLM9X3?= =?us-ascii?Q?ARM=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5534.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08ab833e-b145-49a5-70d2-08d908a5c43a X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2021 11:23:50.4037 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GEnDAaEwa+hemKtMeEY7Tc/e3HYCUKxSRn/4f4VVc18xued7jiag3/sZtjL5s/sJODpc7s60Dpbiivz9krnMyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3577 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix segment number check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi > -----Original Message----- > From: Yigit, Ferruh > Sent: Saturday, April 24, 2021 00:10 > To: Viacheslav Ovsiienko ; Li, Xiaoyun > ; Wei Hu (Xavier) ; > Chengchang Tang > Cc: Yigit, Ferruh ; dev@dpdk.org; stable@dpdk.org= ; > Andrew Boyer > Subject: [PATCH v2] app/testpmd: fix segment number check >=20 > From: Viacheslav Ovsiienko >=20 > The --txpkts command line parameter was silently ignored due to applicati= on > was unable to check the Tx queue ring sizes for non configured ports [1]. Remove this [1] or mark the following items as [1] [2] [3]. >=20 > The "set txpkts " was also rejected if there was some stopp= ed or > /unconfigured port. >=20 > This provides the following: >=20 > - If fails to get ring size from the port, this can be because port is > not initialized yet, ignore the check and just be sure segment size > won't cause an out of bound access. The port descriptor check will > be done during Tx setup. >=20 > - The capability to send single packet is supposed to be very basic > and always supported, the setting segment number to 1 is always > allowed, no check performed >=20 > - At the moment of Tx queue setup the descriptor number is checked > against configured segment number >=20 > Bugzilla ID: 584 > Fixes: 8dae835d88b7 ("app/testpmd: remove restriction on Tx segments set"= ) > Cc: stable@dpdk.org >=20 > Signed-off-by: Viacheslav Ovsiienko > Signed-off-by: Ferruh Yigit > --- > Cc: Andrew Boyer >=20 > v2: > * Become more flexible for the '--txpkts' command line, if not able to > get the descriptor size from port, ignore the check. >=20 > ('nb_txd' check was proposed before, this will require '--txd' > parameter, but also enforces a specific order on the parameters, > instead going with the option to flex the checks for parameter.) > --- > app/test-pmd/cmdline.c | 4 ++++ > app/test-pmd/config.c | 32 ++++++++++++++++++++++++-------- > 2 files changed, 28 insertions(+), 8 deletions(-) Except the one comment above for commit log, Acked-by: Xiaoyun Li