From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F22EBA0C4B; Thu, 17 Jun 2021 05:29:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 749024067A; Thu, 17 Jun 2021 05:29:53 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id D9F6C40150 for ; Thu, 17 Jun 2021 05:29:51 +0200 (CEST) IronPort-SDR: wy9Dhemt21S4TBGN/gIdcpnrVsK8RySrRJz/wbkzERbikj4N0I/fkEj0CcaeenbdWhlSRonabf vQloPlcyR98w== X-IronPort-AV: E=McAfee;i="6200,9189,10017"; a="185987696" X-IronPort-AV: E=Sophos;i="5.83,278,1616482800"; d="scan'208";a="185987696" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2021 20:29:50 -0700 IronPort-SDR: 8wtlLv9fsD48HE+Z8g0H+IS5jshTtaEJ6wSORX5S5Frj7QU6U4MwBjeCYyI6OQOiQ4pR3gIW7P jcFUoLHhf7qw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,278,1616482800"; d="scan'208";a="554265430" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga004.jf.intel.com with ESMTP; 16 Jun 2021 20:29:50 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Wed, 16 Jun 2021 20:29:50 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Wed, 16 Jun 2021 20:29:49 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Wed, 16 Jun 2021 20:29:49 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Wed, 16 Jun 2021 20:29:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ub6RDQvksHGOKsmWRpIGyX551jHX7zTWsOr19UU3IljabnI/dCwbRiQozsUL8jLUvGkS3KRSbjTiNGzBV/fDas8G5vm0j34DwTtv0CMDw1xlt9iBqFltVi1YORAYOcEeN55rqBAyPbSsLlOcItzkANO+XOnJHp7yEyYCcdRRQNNekrcjusQJ1Za/Qt2p3f7tH3tTmAfobHjd1CbHUqzER50iZYYAi8mL1CtxIUP0Xm+KxKdVO1RLNzcuc/pgnXKwNtc/RGOTrcZUYbccmUM5hw7v9EbEJfmUr7OWWaw2Ry1peI0oVQ8DgmtuBxnoRL4gyJ8uiH+dgaf/oT1Q5FFeHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+zhPlbhUJxrxviV6y+fDCK18VNPxrBVOmOAz4N2rYUw=; b=PgjIoYSP+3AuZGFx4dylwDm16qdtxek6RfvsrL7HSWV5mOijSHQhCDHtNa4Ra46v8gmHROO3cZXm/Gl/7Yi8S6eBiB727hhohoK1kAT7usw86Ripa/5S7H8DjRpZsR2PMf9SxuNnahPWgvNzCO9v3rG+jvN8RvZwhtKNB4hra4IvOwo3sWxut9+vGHNi02OX0vOjOxXSOmCZZLD40fnIRhZAOMYJw8amx83hTHqJIF1+O6U/KYuiN6JxUhagq2t/ZGYiuHP7oMp1fI7YkBBQ98G8vxXAP9+snGNXNxxAzKe6Way3C4VVExGMhek8FmrPY4xoJnAN50WX0CXLzCOI+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+zhPlbhUJxrxviV6y+fDCK18VNPxrBVOmOAz4N2rYUw=; b=QThXU3e3h3vgbj2YbGoNKky9fexBEYZM89n9Of/dQA/dDxI7KdW8OBBEX8uatpvlEmEnk56GTlKBERP30OVqJYPuA3ZC8cALp8kcE9oRPriJZIibv1H4gcnhc5zXJtnE9PPW/xc4vnWHOpJUp/xOmlZ6qfKzLtI+Ywy3QEsW/pM= Received: from DM4PR11MB5534.namprd11.prod.outlook.com (2603:10b6:5:391::22) by DM6PR11MB2730.namprd11.prod.outlook.com (2603:10b6:5:c7::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.24; Thu, 17 Jun 2021 03:29:42 +0000 Received: from DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::645f:ca6d:7947:12c9]) by DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::645f:ca6d:7947:12c9%9]) with mapi id 15.20.4219.026; Thu, 17 Jun 2021 03:29:42 +0000 From: "Li, Xiaoyun" To: Andrew Rybchenko , Ori Kam CC: "dev@dpdk.org" , "Richardson, Bruce" , "Yigit, Ferruh" , "Singh, Aman Deep" Thread-Topic: [PATCH v2] app/testpmd: send failure logs to stderr Thread-Index: AQHXYs1ItOxpQJLSzE+L+xvlrNqa/KsXiPEQ Date: Thu, 17 Jun 2021 03:29:42 +0000 Message-ID: References: <20210527162452.1568351-1-andrew.rybchenko@oktetlabs.ru> <20210616163209.823918-1-andrew.rybchenko@oktetlabs.ru> In-Reply-To: <20210616163209.823918-1-andrew.rybchenko@oktetlabs.ru> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.52] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3a5e6a6d-f35a-4c3d-5e51-08d931402565 x-ms-traffictypediagnostic: DM6PR11MB2730: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: i1P1wV0E06RKWyb6RQ1vXq3sCqUNdsnKZ9MAChAtFMVa1y0TFlxkUUPgWfOj0r3GtpCn72h/QaBEsc7CsRliIlIrmIByq3iW3+xKYzda30eYSBRkLpD/ZtjVoEgLQ5AO231vNWMYbta7l75k3q0T2+wKH2QWyQUE+sc5QrK/Jvk0Y92YWJwbti7z3gx814vbkJqH7evdQPTWHMreqWtmxkmXD8mXSKzqNtCGRPcEdS++Kd+PofNrcwV9Lp9Zylvhn/kz5uE3fBkLYR5N3YoT/D4IBt74ZYbMm2jED1T21JHnaFVvt4xd+KdJbxjEnwnU++UmtBGu/0vKucqW/1UPJ6US5pXD0yQGfrpBL8U5rrBvvzI70Xw+5xiuXoJ/53f+8fKpWovcrCKhjBwSTMe20/24zQVdo7+2X0lpMTr+YdHwRQbldBrfiI7a/IbWb0VWWuvXEOsdnsKiY1XxY/r90pY39gdyfjMvCB4HmidhlCTRXVukxLT17shmOQGmHr4gekZolppbVFXGNCwYf2G+Bk2w4ZBphM9zKhjhojTX62sOSAaGbe5fr+qL9u5O97qCli60ob8WQgeqVSRc6zH+XuegSLFHuP2B3QKrx1JYJ7JWT145S8vbKdVSBAVIQ6lqM3yHf2KC+sVr2t0V79jihUXPFx8AqvGqe3XYP1l+9OBC2v4ee3a/qeTX8te970ylyKScRcKsez0NJMFQhQiYHPA7ThWeIe1wi3sg80Py0Ro= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5534.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(366004)(39860400002)(376002)(346002)(396003)(76116006)(26005)(52536014)(4326008)(6506007)(186003)(7696005)(8676002)(5660300002)(66446008)(54906003)(53546011)(110136005)(83380400001)(316002)(8936002)(66946007)(55016002)(478600001)(2906002)(38100700002)(33656002)(71200400001)(122000001)(86362001)(66476007)(64756008)(9686003)(66556008)(107886003)(966005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7Wz0F00V2zytqGMeBaLZSOhN8bGzgPenkhACI+YDGCMsYisyyNWxuoKEEG92?= =?us-ascii?Q?43zAWLUbA+auiINd9GBcqFG0iBXAQN6GLq5a7tvYIY1YhcARxhpoxXdAuO0K?= =?us-ascii?Q?bGpPJza17KqZZHVa6NPSOxhXbf1RcyZSepbO0/ozvyJrvzaygtqWHssFIANE?= =?us-ascii?Q?mqDwrXyBAzYvGNlx1EXJ0gvEo4UOVBwk3f63fAPfx+B7V3+OeZUCM+UWWNap?= =?us-ascii?Q?ZlTMwQdaUGjcLIMhR15ZP09m7Pr9aixlv1BdssoXBbD6n3sMPA36hL4uhmks?= =?us-ascii?Q?gFJuY8QhkrW7mchjRwoyW+2Qy/JjKeiT7ScCkZOqCdB6hQg1DBHCMERsQ/yD?= =?us-ascii?Q?NA33L4PMNZGLypyfZ4g+o5r/SLPYocDptaip0UTw9Xd5kMtlIBojyjnJ5JsF?= =?us-ascii?Q?Q6O0krnBRx06Fa5LyVIIoNZtvsGTO2UqcPvP6s3gRlo33DKZg11ZEVKgCeSO?= =?us-ascii?Q?MTirVJ4NmbYqpxd+lXQBqJhtIeOUx44616++P6l+Uwimh//PMkhBVHTbs2Id?= =?us-ascii?Q?wqBpbl5GyZbimYbRYZQQQ58gs4GT27v5rbCuRERap84kLAERYd3NzQpCreH/?= =?us-ascii?Q?9KBUQ9GyOTqzqPU0PEHDpWWP+BRkJe90jKiz4LMH2UJ/7S8ftjzV7FEoMKgM?= =?us-ascii?Q?zAGazapDE64fTjeiasb9JdHcN969oHIWxbvFwnE9/PVOBebyNioOVrSSZupX?= =?us-ascii?Q?QXfp/wt9dfKkxEw+OwGDqBrB9yWqcyoK5oJXyGCWaoSvGDC3fPO3nDoB6TGg?= =?us-ascii?Q?tMLUc2KM3/0QOUcX/CHoW7bQgcf+nRI7FpPmGKSEekj18QqHtd+NAlkHgV+B?= =?us-ascii?Q?Y71hu+LP1nv4aig4BgbHq8DJJccD3bQ3eT7Kyx5GY29A0VoEsBojMEa0gnu1?= =?us-ascii?Q?Zaai8o4RNvgZr+1nOpE4sg1GCfcoEEcnljnl9LSd+llLitR+xIa2Ma4DEUPK?= =?us-ascii?Q?yTDSxGyPnbl6tVP8brX3XvygmaBwZjg2HePA4+jDQ3A11vVh4s7UzqJz5Kt3?= =?us-ascii?Q?OM+UaBE2Fht7rynWJRiKTrpYptOe0okLRLEb/V8uG+ddkUCG4ANqOqW7Bhml?= =?us-ascii?Q?PzzdGyqX/yBR1oWxTOa1CZLWBFy4B0jetc1N2h9RX2YlILXhR5KuvSFbPzzV?= =?us-ascii?Q?AmclE3WGC3LlINUzdYFqaRUnaacxDtfX/qZewUS6gNf0hjH5/jPq2+xF/wLk?= =?us-ascii?Q?PXkuy0dXirKH5Qmi6wr2McoJC+WQoumAnp+GtAzhHFJL1RTBEt8FBhiMD7bl?= =?us-ascii?Q?3n0Kq8KPDJTTH/1H3nhtOFm5LcicuNKDs4pgFYpIqjLbiyKGKuj9id8prTAO?= =?us-ascii?Q?fsw=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5534.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3a5e6a6d-f35a-4c3d-5e51-08d931402565 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2021 03:29:42.3967 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1ruihmr2JXjSglz214b2MX37/kNSqjKGL4qU6McrulKeZvdqMBehpNReXqnM7S7vGRwzmd0IedKAqoJEh48+SA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2730 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: send failure logs to stderr X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi > -----Original Message----- > From: Andrew Rybchenko > Sent: Thursday, June 17, 2021 00:32 > To: Li, Xiaoyun ; Ori Kam > Cc: dev@dpdk.org; Richardson, Bruce ; Yigit, > Ferruh ; Singh, Aman Deep > > Subject: [PATCH v2] app/testpmd: send failure logs to stderr >=20 > Running with stdout suppressed or redirected for further processing > is very confusing in the case of errors. Fix it by logging errors and > warnings to stderr. >=20 > Since lines with log messages are touched anyway concatanate split Typo: "concatenate" And it's really good to have those split strings combined. Thanks. > format string to make it easier to search using grep. >=20 > Fix indent of format string arguments. >=20 > Signed-off-by: Andrew Rybchenko > --- > v2: > - switch from printf() to fpritnf(stderr, ...) in more cases > - do not inherit acks from the previous version since the patch is > much bigger > - fix style in few cases (TAB vs spaces, missing space separtor etc) > - still don't use TESTPMD_LOG() since the patch does not add new logs. > Also switching to TESTPMD_LOG() will add "testpmd: " prefix to log > messages and it is a real change and could be a pain for automation. >=20 > app/test-pmd/bpf_cmd.c | 6 +- > app/test-pmd/cmdline.c | 957 ++++++++++++++----------- > app/test-pmd/cmdline_flow.c | 20 +- > app/test-pmd/cmdline_mtr.c | 8 +- > app/test-pmd/cmdline_tm.c | 33 +- > app/test-pmd/config.c | 452 ++++++------ > app/test-pmd/csumonly.c | 5 +- > app/test-pmd/parameters.c | 21 +- > app/test-pmd/testpmd.c | 298 ++++---- > app/test-pmd/util.c | 19 +- > doc/guides/rel_notes/release_21_08.rst | 5 + > 11 files changed, 1002 insertions(+), 822 deletions(-) > 2.30.2 This patch overall looks good to me. But there're some warnings about coding styles reported. http://mails.dpdk.= org/archives/test-report/2021-June/199047.html Not all of them makes sense. But can you check ones with QUOTED_WHITESPACE_BEFORE_NEWLINE, UNSPECIFIED_I= NT, EMBEDDED_FUNCTION_NAME? The latter two type of warnings are legacy issues but it'll be good to have= them fixed. BRs Xiaoyun