From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9372A0C43; Thu, 21 Oct 2021 05:24:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BBE3D40DF5; Thu, 21 Oct 2021 05:24:38 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 8216C40142 for ; Thu, 21 Oct 2021 05:24:37 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10143"; a="226393261" X-IronPort-AV: E=Sophos;i="5.87,168,1631602800"; d="scan'208";a="226393261" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2021 20:24:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,168,1631602800"; d="scan'208";a="444614747" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga006.jf.intel.com with ESMTP; 20 Oct 2021 20:24:36 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 20 Oct 2021 20:24:35 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 20 Oct 2021 20:24:35 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 20 Oct 2021 20:24:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WPbACrg4+TjfUlVKhZWtnfqYWNB9y+qTEy76aDcIyiWCzg+1jgBmXAtiqHz4e0iXE55a/Mep4LxmeJb6mqM2yzkHyWVwwTz9+OvXqjhQ4lmV8bzxB3rYFtKKhhAwJlNoJM+A8rCTdVdjnhdtI2b+FQ2JfKAT5x4m9KfU9x76N+0luDuT43aPahn1jRd0AKyj8xoLBzID80n8K8gWT1JB77H08So1q4hgipphBQQ0MfjHXpT3RqFccbn2xFM5GSuQY3R5RgrMLlG0kU0HKnkJD9inJV2TMfYR6Y2FMmaEvH/NSTu8aKQUSe9d01gNFX/sbEtWrdRwoi2GUKZwJghJiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QagfChLD7X/Z0eRNQqJ3WzxStgIh9x8LHd81HrMYBWE=; b=dbub+jlDtaf5dVMb36zyWfr3w3oVIK49kbvCkBcBeJHl2CJgNIeNSY4urs+0odFPNtdfOLuorD3T7otSJfXh5JtvWPU6cOiSWNYT74h2EH1S3EEs1aZTQG4DzpSMzy+hTYgnRE/p2pguqREbyTWlfifBgesvHLVuDZtJbiDpxJG5WDH7CBYOuXelZiXAYl+Z8gibsliAm9Pmrz1bPT9gvP/SllHb1XJ2fJ2qX+SYPB3vgix1S+lx2Ni+fYv062OKqU8ikA07sYvDkrzakWdHSnTWz5fY2eAHDVPfk2Co8q2F7562cl8/a1Id5gOr5iol3LsWWgerEIBFX1+h7F8B/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QagfChLD7X/Z0eRNQqJ3WzxStgIh9x8LHd81HrMYBWE=; b=yB8RCCeKyjtknvfxaMKJSnXryZTiaw6YkqqUkvOzvR75t+BS52gHxe0WOfLhXt4CF9pkJWO2UvpuX5tFqvMQhkRZ2YIrfyRSgG6guz5XPyc3hs0zbuQ7asoBsay1tN/M5SjHyqbsPadqaAcRxocqA6WsmQwgGyJOH1S/FjuLkJo= Received: from DM4PR11MB5534.namprd11.prod.outlook.com (2603:10b6:5:391::22) by DM6PR11MB2762.namprd11.prod.outlook.com (2603:10b6:5:c8::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Thu, 21 Oct 2021 03:24:27 +0000 Received: from DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::3d9b:76d7:e274:bad3]) by DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::3d9b:76d7:e274:bad3%4]) with mapi id 15.20.4608.018; Thu, 21 Oct 2021 03:24:27 +0000 From: "Li, Xiaoyun" To: Xueming Li , "dev@dpdk.org" , "Zhang, Yuying" CC: Jerin Jacob , "Yigit, Ferruh" , Andrew Rybchenko , Viacheslav Ovsiienko , Thomas Monjalon , Lior Margalit , "Ananyev, Konstantin" , Ajit Khaparde Thread-Topic: [PATCH v11 4/7] app/testpmd: new parameter to enable shared Rx queue Thread-Index: AQHXxYe7W346D66n4UmHtltJBZAdmKvcujlA Date: Thu, 21 Oct 2021 03:24:27 +0000 Message-ID: References: <20210727034204.20649-1-xuemingl@nvidia.com> <20211020075319.2397551-1-xuemingl@nvidia.com> <20211020075319.2397551-5-xuemingl@nvidia.com> In-Reply-To: <20211020075319.2397551-5-xuemingl@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 91d5e05d-e83f-4427-06b4-08d9944249c7 x-ms-traffictypediagnostic: DM6PR11MB2762: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HlzhODg/Ba1iitOgMW7R0o0cTl3W9kFM5/OejBJ8x63BXZ9nZUkkDb06EpFTf6nuo3fnBsrJju9/tYdwzUZ6CdPaWjUTCtcgSBSQdKiNUBMpnQNPEtH3PWqen4S0/9BEjBK4DAZMpoRBbMF4i2NRxge3eArlkFJL9fKysadXUamzWU4PKHyZG6yrywtRF6h1EvMnyRTfgdbe3KcLk1jWpRJ0Z9eZ00hW+y652kueUa17mP/WzvRLObtHyzEn+tGJgpzVG8vVaofQnYQPaiiacAowI84IPDzGH+7fh88FSTZIkMiMJg+vnTlzO7OlhKhKvHSWr2z29GNEHSsiZXATJ4vse1ZAe4G82BIRjWX8gWUoA/+QBJT/j3iFASKcbIXzgIDlYkGou/d4MD2xL4hJ4SRYmi5OOt6tJU5n9OcAqpXyEbhVSFQel1zd7t5c7aJn7qB42uTyIlZshJzVTayTYkSuTrPHjL+qanaMYzlCpfnlE/U9Rxy2h1SwubAxmsEjDGrWo88cSll6hu67os/MZQgHRjjV3xzu/pWxCBfiBJ/awHb3J3cEh7jnXYGeX1mImsg4lOXBtEV1CinRMUZb7ZN0vf+BCkxXiDg1jAEq/8J9n6agNcvpEOaHC2J0CXYcujOWreIbcAwWpf10u69NO45TQx2W7oJx3H04/8L2yg1xmn3nYDRuYTHQe5/GNLK05D1MdglsgWjE3jUq9Z0zVg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5534.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(53546011)(9686003)(122000001)(110136005)(66946007)(38100700002)(6506007)(71200400001)(2906002)(8936002)(52536014)(76116006)(54906003)(66476007)(33656002)(86362001)(26005)(5660300002)(186003)(66556008)(64756008)(66446008)(83380400001)(4326008)(8676002)(6636002)(7696005)(316002)(38070700005)(508600001)(82960400001)(55016002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?G6xDYspsbT5L5NK8p1I0Aat+UNwjIWYEo1q6WvOCf7Njn3VFxJDIExFvmCFU?= =?us-ascii?Q?Lp5KUNA5b9Ph/5VgIwnAnjFiqdPWIOAZcxLcHtG0W7XssbeWqSkHuZsIcyKJ?= =?us-ascii?Q?Suh77Cgiwh+n3xQsNHcvQ6T9WgV5IwwuqTu/kBrTro6zxEa68Dg4Izg+QNot?= =?us-ascii?Q?JMP2YK0AfMYE6+okzmHOf1Ylx5gA5oAa55aUJuEepp51WUy8hnrqbZSl1FyT?= =?us-ascii?Q?u01o7knAuE/qHsCWcFpsZJrQLrPtPCcPLKNubD8rTs+Slc+8DMxu90qcVfxr?= =?us-ascii?Q?OCH5aTrMbdyAb+ApVlffLbOwM73FI/8WN/S/4NjJCCJqDwT7zIm8zukuzcnQ?= =?us-ascii?Q?DBYS/pwjGgTzqlt9n2cCHr1k5D78daw9Qn47XXrEEnwL+eoz9sgtRPHqKYbF?= =?us-ascii?Q?HgPFrqzfLBZalkvyZsn08/QOTK5c0Ze2j7ajEi8HaPQ5dZ+tKjp4MmZqAJB6?= =?us-ascii?Q?rD4tRoPvYkkaGiW3hHF9SyrhuA31VEw8TUEePPw5rLQipmja7dgqZfxGKjhO?= =?us-ascii?Q?8EX6VGjLys6pm1A33t7eHc5x40BxnssUSOmBjG8YXDKz0d51lcjA2czaTSqC?= =?us-ascii?Q?FFo93kY2pTv7rtNAXzCE1xvv7jrH2idYBXGFn1LhOrG3kf0HbG7G3GUdwwss?= =?us-ascii?Q?nbF4a1ZIwyarR6iK4y0y4hTsvZMu2YGFdocV1CZ1UL8rD3YGl7RpuaOIx6y7?= =?us-ascii?Q?Nz0bL8jotZHo3zySmz03DmebHBWoFmXXm0zsdH9CI8i627Tl+lM8sAQ4xCJi?= =?us-ascii?Q?omejmVIYZm+L6efAoB71BhMOnCdNznlwD+/QwT7uaV6x2iE98T0eWIOqUY7v?= =?us-ascii?Q?Pdd1KLvDfaw0fUV1LMDoIAALDuGqsR3MH5UyjGUG9zjxJBladIB0EmAKtQKD?= =?us-ascii?Q?j8uidp1pXw9ZnYV5nKpUWhmYaZUGj3aWO79OO1vPlpeWG3l0OWw+v76RYMBT?= =?us-ascii?Q?xpNPBsdBKy78+tkgWNYCcdU3L2WHRleWfUEplr8R4ws8jrK4Htoj8NSwvNSd?= =?us-ascii?Q?a1OkNRLMA9yRx+RbN+vIt/cib5c16DX3lgkq6JGgdGU3D4uxN9mgGtAgS0ve?= =?us-ascii?Q?ZYP0KWdXAQJ7bWeAK6mtEhCuDWl8Pk/H5/pb1w/agHPIRvCcPlCmjlTZXFG6?= =?us-ascii?Q?kIZgVZ6WKR2OFrlX2sjXDqZFf1ClgnfyZHSvB7AA14DPuSJQ2uoLmc2E0WW5?= =?us-ascii?Q?1pYq3gMSve1MO6ySxUT0Q87bE+1ArebHewe2pL+1XUTPDHCWdjC4o+drpvDq?= =?us-ascii?Q?I+RhNpw6gNVxr2IScl8ZYWAHV07wsysfVv1CzzugEuHgAVzVBX6SvoMz6rG5?= =?us-ascii?Q?Lxg=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5534.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91d5e05d-e83f-4427-06b4-08d9944249c7 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2021 03:24:27.5202 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xiaoyun.li@intel.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2762 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v11 4/7] app/testpmd: new parameter to enable shared Rx queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi > -----Original Message----- > From: Xueming Li > Sent: Wednesday, October 20, 2021 15:53 > To: dev@dpdk.org; Zhang, Yuying > Cc: xuemingl@nvidia.com; Jerin Jacob ; Yigit, Ferr= uh > ; Andrew Rybchenko > ; Viacheslav Ovsiienko > ; Thomas Monjalon ; Lior > Margalit ; Ananyev, Konstantin > ; Ajit Khaparde > ; Li, Xiaoyun > Subject: [PATCH v11 4/7] app/testpmd: new parameter to enable shared Rx > queue >=20 > Adds "--rxq-share=3DX" parameter to enable shared RxQ, share if device su= pports, > otherwise fallback to standard RxQ. >=20 > Share group number grows per X ports. X defaults to MAX, implies all port= s join X defaults to number of probed ports. > share group 1. Queue ID is mapped equally with shared Rx queue ID. >=20 > Forwarding engine "shared-rxq" should be used which Rx only and update > stream statistics correctly. >=20 > Signed-off-by: Xueming Li > --- > app/test-pmd/config.c | 7 ++++++- > app/test-pmd/parameters.c | 13 +++++++++++++ > app/test-pmd/testpmd.c | 20 +++++++++++++++++--- > app/test-pmd/testpmd.h | 2 ++ > doc/guides/testpmd_app_ug/run_app.rst | 7 +++++++ > 5 files changed, 45 insertions(+), 4 deletions(-) >=20 > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index > 2c1b06c544d..fa951a86704 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -1271,6 +1273,17 @@ launch_args_parse(int argc, char** argv) > } > if (!strcmp(lgopts[opt_idx].name, "txonly-multi-flow")) > txonly_multi_flow =3D 1; > + if (!strcmp(lgopts[opt_idx].name, "rxq-share")) { > + if (optarg =3D=3D NULL) { > + rxq_share =3D UINT32_MAX; Why not use "nb_ports" here? nb_ports is the number of probed ports. > + } else { > + n =3D atoi(optarg); > + if (n >=3D 0) > + rxq_share =3D (uint32_t)n; > + else > + rte_exit(EXIT_FAILURE, "rxq- > share must be >=3D 0\n"); > + } > + } > if (!strcmp(lgopts[opt_idx].name, "no-flush-rx")) > no_flush_rx =3D 1; > if (!strcmp(lgopts[opt_idx].name, "eth-link-speed")) >=20 > +* ``--rxq-share=3D[X]`` > + > + Create queues in shared Rx queue mode if device supports. > + Group number grows per X ports. X defaults to MAX, implies all ports X defaults to number of probed ports. I suppose this is what you mean? Also, I agree with other comments with the= wording part. > + join share group 1. Forwarding engine "shared-rxq" should be used > + which Rx only and update stream statistics correctly. > + > * ``--eth-link-speed`` >=20 > Set a forced link speed to the ethernet port:: > -- > 2.33.0