Re: [dpdk-dev] [dpdk-stable] [PATCH v3] app/testpmd: fix offloads for the newly attached port

["Li, Xiaoyun" <xiaoyun.li@intel.com>]

> -----Original Message-----
> From: stable <stable-bounces@dpdk.org> On Behalf Of Viacheslav Ovsiienko
> Sent: Monday, July 12, 2021 20:41
> To: dev@dpdk.org
> Cc: Singh, Aman Deep <aman.deep.singh@intel.com>;
> arybchenko@solarflare.com; stable@dpdk.org
> Subject: [dpdk-stable] [PATCH v3] app/testpmd: fix offloads for the newly
> attached port
> 
> For the newly attached ports (with "port attach" command) the default offloads
> settings, configured from application command line, were not applied, causing
> port start failure following the attach.
> 
> For example, if scattering offload was configured in command line and rxpkts
> was configured for multiple segments, the newly attached port start was failed
> due to missing scattering offload enable in the new port settings. The missing
> code to apply the offloads to the new device and its queues is added.
> 
> The new local routine init_config_port_offloads() is introduced, embracing the
> shared part of port offloads initialization code.
> 
> Cc: stable@dpdk.org
> Fixes: c9cce42876f5 ("ethdev: remove deprecated attach/detach functions")
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
> v1: http://patches.dpdk.org/project/dpdk/patch/20210619154012.27295-1-
> viacheslavo@nvidia.com/
> v2: http://patches.dpdk.org/project/dpdk/patch/20210712102440.12491-1-
> viacheslavo@nvidia.com/
>     - comments addressed - common code is presented as dedicated routine
> v3: - uninitialized socket_id issue (reported by CI)
>     - removed dead code for port_per_socket from init_config()
> 
>  app/test-pmd/testpmd.c | 151 +++++++++++++++++++----------------------
>  1 file changed, 68 insertions(+), 83 deletions(-)
> 
Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>