From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F5DEA034F; Mon, 22 Mar 2021 02:45:16 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D45C3140DBB; Mon, 22 Mar 2021 02:45:15 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 426244069C; Mon, 22 Mar 2021 02:45:13 +0100 (CET) IronPort-SDR: YpADC3so1gbtYgUmddfcDagosNmROlFqOF99pqGEAHUbCfR2GIxGTPzdBUMekQpmwh3Ul2+p4k aiya7FJuvpjA== X-IronPort-AV: E=McAfee;i="6000,8403,9930"; a="254182782" X-IronPort-AV: E=Sophos;i="5.81,266,1610438400"; d="scan'208";a="254182782" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2021 18:45:12 -0700 IronPort-SDR: GQOJKDUg9f1vVGGKhnPlOflsEsEU5FiTwH+2Tl6IMsohw2QQRNa9m4P2WrN53w9LwgA/XCgp7P SvYo02WbKxHA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,266,1610438400"; d="scan'208";a="603736400" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga006.fm.intel.com with ESMTP; 21 Mar 2021 18:45:12 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sun, 21 Mar 2021 18:45:11 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sun, 21 Mar 2021 18:45:11 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Sun, 21 Mar 2021 18:45:11 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Sun, 21 Mar 2021 18:45:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QpKKOi21NoKCJEsJ7WDlCPI+vqD/GryVDjD/PXHQgYv8P4/AgsIggGjGmDcInUryGKHBD1xQDwY34wSNkQUi6HETEvLLoycjyx2zFOEYya6C7agSEFmOQxhSwN3QCai0QnZIZhU/KEoFhSHjvYfrmC+RjteuhElTANpuEEWP9+2sFDNf0sicPGiLHM2kMG4vCpN2K7INthj7LS6ZKDsmcxMxRvEwf7XM6VEMR9EO8lljjY8ZDVmLsndg5E52p+bZule/i3znK3jGYCN55cC/Q5Og2kx/F8rxY3Hxr8RVODpXF4m6sU1fW2yNOpjZCbkns9koPzrHxJrATuu72WU+6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8BzkwEFcnUzm1PpsuCwxFVW76vd4teAO4INU2ODwa98=; b=QVW+uCZ8OCkt3NLEaV+GuKuG6beBcWuyokvQuyGM0lxSX8A04Pd6n7rlQeGAIzoOUAza4k4OAgOaIpH2OW6/yOeQfXhuxeUgjqrzNzJhXq88SYz91MnZyQpPNmK0YxfGPnz1DQoFcs3QB/SLxCLm2pEASfAZ0aHT2fNtZe2XZIug6Octee3JxDaF0HuIyBEvC5ohzNAdpZjhKMvzfdXoqRb0+M9yb8Mm9oXvgLXWTTSrtCxXnU/5qriIVjLrjDIb8z3/MV7aUOy+GOLeEdBvfLlWqnOlTi4ny6IsKXsBhozZV+KS/fObfW4CuLKc1405D1W163j8gD7ANXmNadzGyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8BzkwEFcnUzm1PpsuCwxFVW76vd4teAO4INU2ODwa98=; b=K9FARjDtxFKxubmERyek5nJqqel7ixsAWJyDM08UrHO21YO/LwY0vghDYDZuBOgaDBXFbEpQNZsrbZFKH/xwnU50ZKuD2J1PwAD40YQdOaxs48/wkPLQ40adr4d4jwMXGiuogokJksIj/mr/ZBiS7ZmuGozJLLcCP5qn6J0JBGU= Received: from DM4PR11MB5534.namprd11.prod.outlook.com (2603:10b6:5:391::22) by DM6PR11MB4105.namprd11.prod.outlook.com (2603:10b6:5:5::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Mon, 22 Mar 2021 01:45:08 +0000 Received: from DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::79a3:3404:b907:d49c]) by DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::79a3:3404:b907:d49c%6]) with mapi id 15.20.3955.025; Mon, 22 Mar 2021 01:45:08 +0000 From: "Li, Xiaoyun" To: Thomas Monjalon , "dev@dpdk.org" CC: "david.marchand@redhat.com" , "stable@dpdk.org" , Ajit Khaparde , "Richardson, Bruce" , Andrew Rybchenko , Ori Kam , Bing Zhao , "Iremonger, Bernard" , "Jens Freimann" , Kevin Traynor , Stephen Hemminger , Maciej Czekaj , "De Lara Guarch, Pablo" Thread-Topic: [PATCH v4 11/11] app/testpmd: fix usage text Thread-Index: AQHXHqIbTJd4Cd9+Cky5xkiLACZrLaqPPG4A Date: Mon, 22 Mar 2021 01:45:08 +0000 Message-ID: References: <20210309233116.1934666-1-thomas@monjalon.net> <20210321223116.1340974-1-thomas@monjalon.net> <20210321223116.1340974-12-thomas@monjalon.net> In-Reply-To: <20210321223116.1340974-12-thomas@monjalon.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.54] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ebf4cf53-8c7f-405e-ab62-08d8ecd41fd0 x-ms-traffictypediagnostic: DM6PR11MB4105: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BF9n9/M09HOeH9iRs23c17fNiEA2UsYgPOke1ivDv8oL4Sm79VzqA1yt0eILToiyv70wp7Eeel1aKDhKDJ/7xj6uprbMRDuGpir0rQ16fQ74Z4iE1/CHmkGTjmOWIN8Ga0iEoVZ2KOapjOXYUa/fTXgC0G/urIHMak7QS4rJ8r5uweu6yOJoIE4rWnGd+7DAmejw0dAbglLU33QKrbu+TwsFxDk3t9Ivh3LIy75lpXKrGaERGXMwRBWgPmt5n5a5OBjfqLTWAMDdZWOFLs5rC68XGYAkX4vfYivzVEaYLZIbN9dPTSt71ysoLsijINaFajzTb73bOo1P9hzKIo/0F2y6X4zwotHkoGOWRXjbE6H0BHaNH1A1OAmJQL/XwJLo2R00whbKY2YFIUZh6t9s3YZ7pweDJI/eRGSktcH2zR1Jfoi+Z7dJNS+8uFAu6EvoDE9eyIqkCYRaJz1aXWEpNkBL9sfQdt0nsM6Ek2Y0pvYPbxmTnA1peF9khXOkxUStuIr7YqLURKDIMiBxCwiVGjhkUo78tskkc413TDDQI9QK0WCtNPqADrsU7IvoK5Le+P+pkEM22xPaUuvzhWmIMI3HhtKO0L8mm+dU5c7mlEoJ05fIGWselV+rnEqb6IfwXBkgGX2F3+9VJOqH2OYQ/3v5SJVpUQvcwf2FiGFr+68= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5534.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(396003)(376002)(39860400002)(136003)(366004)(66946007)(66556008)(64756008)(66476007)(66446008)(110136005)(478600001)(76116006)(38100700001)(86362001)(316002)(54906003)(7416002)(8936002)(5660300002)(186003)(4326008)(52536014)(8676002)(26005)(9686003)(55016002)(107886003)(33656002)(53546011)(6506007)(71200400001)(83380400001)(2906002)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?iuYM+RObOOzJ7uX4O6fPZEr+r96BluIzyCQqUyBP0PrB3PmqaQGo/lE0BpxC?= =?us-ascii?Q?r3jVpkbhUvkxC1DyddGHdaawh4/5t43TBbJJ4P38DrbkPdWnfj8gpDybEdPe?= =?us-ascii?Q?ICbkZZ5Sl4TSuGDUUqqLIDd6Zn70u2ioObzcTHo/TbYsZZU8GoxIgycj+OEZ?= =?us-ascii?Q?n08PzOJH4neTl+WYmtxZmdGF0/5B55aB0KqlveBUykoh0mhvdb2zUxM5glit?= =?us-ascii?Q?WHLSfHFA52Ep2jYvaqFowpZAjM1pKrPeHCxsbs3NcYDTJ8hLL/WFS95SjQa8?= =?us-ascii?Q?ypg6mY83CgxT19R+yypTQjXH26GH/gfU3kE8wZtsCm5isALhfIhf5w/p1qR/?= =?us-ascii?Q?nO+pKPwYzJspOdqd3/8iSwl/2cKDvYmTW6C9Qvqi/K0GKEvrGWklDdMAZuXz?= =?us-ascii?Q?C9BKhPB8eggGE36TngdLhEjqa9ObQOFPaZOqYjzE/njKhBJSmX7xJ8tJQ3qY?= =?us-ascii?Q?pT1lvl6OohiXZj3so9PluAQSE2cYZBpQNZ1//MwsxkMjzcYr6x8jfSDh4F93?= =?us-ascii?Q?0DTM95+eXkbNj+phikqd1lCmPGsCXB0yxc0+Vq1BFNc4do4Vm77uu/hGbbnz?= =?us-ascii?Q?hnDu6gCBklxGbRqX387yWO31cdgx96yiS5FjS+ebrDkn8bkD67XZX1m53Rig?= =?us-ascii?Q?/Rvz0x0mOwSOA0Zd/F2i12yl/4F68ufwNsWAGX1DLcwJPlKUwCXAavgBDS7i?= =?us-ascii?Q?KB1FEd64EZZs+A4Jc+fJ4180/4N4MBrUwtf6Py40avBZOx7Iq1OgQlrtORuI?= =?us-ascii?Q?eDaGYEyq58BO8ubDEa3E+GK2w7RmxqLFr5ETRumaEbS8icJZpaMHXVFPTaNZ?= =?us-ascii?Q?ozOdD5zNLKhoaU0VlUJbyiFIv7qaRPFHY1sJam8VhKRC4T9qy+7AcjyGATYk?= =?us-ascii?Q?/N2u6D6Fm4RG8s3bHR09vJgrMSMs9rWre2JXpiPCzbex1z9vMJJTMmh4MxZS?= =?us-ascii?Q?fF+rOUB8xy8Wf5yKTuM6Tyr/sDpsEoE8CISHvPAkUiGHeh0BP+9JwsERVE6y?= =?us-ascii?Q?YvCgkoSZxMPhrVbdLBTL4KTyeE4WboXtq9Fi6pEo/OpUTkePvOTayr4Ig4WF?= =?us-ascii?Q?F9qXixAFmZVh+vWfclADbNM7N/BaJR/WqNwfUSm0lIStwABcro0STWhTOXoX?= =?us-ascii?Q?c1ASqrCAIk/Zh235i8eNNVYnfPpGH3Q/NBiWvqEaxUcaAtVZolTcVKfFsgj8?= =?us-ascii?Q?g2+fsVrRGSZmaDYc9Xi2YwLIGMX6NpJ1jRaZYaUbFaBJ4HW1jsK+AW4Y3ljC?= =?us-ascii?Q?TIa+YVOO20shrUxmk6ELMpQQ0oVZZIphxeNmiDONMqDQhRF5oympX4ATXlvO?= =?us-ascii?Q?YEs=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5534.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ebf4cf53-8c7f-405e-ab62-08d8ecd41fd0 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2021 01:45:08.2362 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +jQs0K9DuQ7W3AKcy9DKRA4dAiM36VGKJL7pS/qukiBx/HUWKBbhOfwSSYqGicKJw5NV95QwTRLRmRtSX8yvVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4105 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4 11/11] app/testpmd: fix usage text X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, March 22, 2021 06:31 > To: dev@dpdk.org > Cc: david.marchand@redhat.com; stable@dpdk.org; Ajit Khaparde > ; Richardson, Bruce > ; Andrew Rybchenko > ; Li, Xiaoyun ; Ori > Kam ; Bing Zhao ; Iremonger, Bernard > ; Jens Freimann ; > Kevin Traynor ; Stephen Hemminger > ; Maciej Czekaj > ; De Lara Guarch, Pablo > > Subject: [PATCH v4 11/11] app/testpmd: fix usage text >=20 > The options help text was including an incomplete and redundant summary o= f > the options before explaining each. The summary is dropped. >=20 > The details of the option --hairpin-mode had an extra space, breaking the > alignment with the next line. >=20 > There were some mismatches between options in the usage text > sed -rn 's/.*\(" *--([a-z-]*)[=3D: ].*/\1/p' app/test-pmd/parameters.c a= nd > the options declared in lgopts array > sed -rn 's/.*\{.*"(.*)",.*,.*,.*},.*/\1/p' app/test-pmd/parameters.c The > misses were: > --no-numa > --enable-scatter > --tx-ip > --tx-udp > --noisy-lkup-num-reads-writes > The option --ports was not implemented. >=20 > Fixes: 01817b10d27c ("app/testpmd: change hairpin queues setup") > Fixes: 3c156061b938 ("app/testpmd: add noisy neighbour forwarding mode") > Fixes: bf5b2126bf44 ("app/testpmd: add ability to set Tx IP and UDP param= eters") > Fixes: 0499793854f5 ("app/testpmd: add scatter enabling option") > Fixes: 999b2ee0fe45 ("app/testpmd: enable NUMA support by default") > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org >=20 > Signed-off-by: Thomas Monjalon > Acked-by: Ajit Khaparde > Acked-by: Bruce Richardson > Acked-by: Andrew Rybchenko > --- Acked-by: Xiaoyun Li