From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F69CA0C50; Fri, 16 Jul 2021 10:30:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 394CE40151; Fri, 16 Jul 2021 10:30:50 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 5DCBA4014D; Fri, 16 Jul 2021 10:30:48 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10046"; a="274523570" X-IronPort-AV: E=Sophos;i="5.84,244,1620716400"; d="scan'208";a="274523570" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jul 2021 01:30:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,244,1620716400"; d="scan'208";a="413919121" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga003.jf.intel.com with ESMTP; 16 Jul 2021 01:30:46 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Fri, 16 Jul 2021 01:30:46 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Fri, 16 Jul 2021 01:30:46 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Fri, 16 Jul 2021 01:30:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hF/wxVnLI04TiGptxhGql9MblSjFuUCXou3HE+S7HT2JRUalienNSCdIw5cgUUkSEjm//LUKl2m/tXcL+ZUpHAwxQv25RKdiag10sj/Z4Z8dQNOcFaEwqzZG+DbCHEWhye8OvL/HaDDRiwvzbbImTTCx9PV85oZ0sMcMDRFcf84EC43S5N1XA4jLqOsHFb5ywP9xZUoHEgrF/OcwDGpSekVb1y828kzZDVzZxQw7AyoBlLDa+ZDAp1osCGpDUDoDbJlhirO7pL4RQt3qqdR4iPz7Vof3xsBxnmnACCdCsq69BFRNkBldMfYO+fKVYVYoQoQpJIuHGYj2Iomrn5/qCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TZrCEDFN+I2jOjg31phooX9YdohGm3Dw3hQbSD2MIjg=; b=OjpQkk8O3RneNJ2+jbFNcKtv10fjYdZ7ApnK1I83VaC8NTDuLnJS9dgXGGFCSsvYRuCTPrg4Q7fMSvwu8+q2tOhuaoTynDHk7vnnC2kBniGcd6iuN3QSg0XfKHWH/J/qnYnQHXbdJmT0szph5K6P+iOk7AUK96Z19tNRlB3m4PazTfD7MqQa75YyTFTxGOXoTRhJo8HPSRyOJ2ObyIKLieRxKQimU407NrEovrxI1ORQoYLJ/SknSPEnZ0ptaudwpUspLEfxscneSU2wZA5NVsoRjyNf0ZDn2SUmierDmCDbJ5Wo5HCG/DY2M7u+aFeDxv78f1Fv+K3S7/frUqUAgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TZrCEDFN+I2jOjg31phooX9YdohGm3Dw3hQbSD2MIjg=; b=I0jWfTq5NmpQDX+3A6VB4idOjkH68P56/is/wo+pr/UNgwnF9sM9jG4Phlc+gRyEHf1hNTADi+yLz+Kt9d2rCRhqtaImrNwofr7N9Iby7pneaXpmntV8eLtUi6cE+OqSGbDtk7y5YPK+hpfzAiHIVt6Ps2w/Z9YyKAVgKLwTstU= Received: from DM4PR11MB5534.namprd11.prod.outlook.com (2603:10b6:5:391::22) by DM6PR11MB4107.namprd11.prod.outlook.com (2603:10b6:5:198::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.24; Fri, 16 Jul 2021 08:30:40 +0000 Received: from DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::87d:1217:a7cc:dd72]) by DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::87d:1217:a7cc:dd72%9]) with mapi id 15.20.4308.027; Fri, 16 Jul 2021 08:30:40 +0000 From: "Li, Xiaoyun" To: "Li, Xiaoyun" , "Wang, Jie1X" , "dev@dpdk.org" CC: "andrew.rybchenko@oktetlabs.ru" , "stable@dpdk.org" Thread-Topic: [PATCH v4] app/testpmd: fix testpmd doesn't show RSS hash offload Thread-Index: AQHXeS7puSPND5vqtU+bJkR2YAbtX6tDd2KwgAFm0YA= Date: Fri, 16 Jul 2021 08:30:40 +0000 Message-ID: References: <20210715113314.8837-1-jie1x.wang@intel.com> <20210715115720.9981-1-jie1x.wang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ac3d4be0-eec7-466e-4f19-08d94833ff12 x-ms-traffictypediagnostic: DM6PR11MB4107: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:628; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iUxocDkPjObfmzg7oxkp1FSKcZPf1OzycWX0c1S1Qfk5S6NGyay4RRAiLTWqCRl9raE7E+MhwCEVBFfSSbVCgxGofoiTqJ+zFdzrppOGC+iG+aaJblvaeTqqS7bl0+UCgJ2g7AOMr8MoZAxCXDsBb6JvvyYXqwlnBoDIwqdKMQJcUWoF1VFzU+6EOE7EeacwtvNQbSwJ1rd0tT1sY90fMq3hU+ofnfRdg6pF0dC6aBGprGUX2AkTta8se0EHflSIrAg8KnuaG3ez6AgkQ7SWdH+o29UE78T31tugeEAHHWmIS84t1XHxw5shKpbw4mJIMSbImSWLssXmBAOLcHJqmTWFRsf+ahAttnvH5XHfOVCtKdPwgbCCCd9bVklPcctNlWxg39XdNdyWdqc4G0BqCsTnssmc6teiTHZVhc/ZP7Ne0DGv39N5f0xqYHhs5nplDPpjFWHgY3Ne65ftQV9O5F6xjojTNP7nt5l5KsNyOivnyh0CyMF0vD1hlYp1t4nwxfIFeWix4wrP2lJbU23ReiI43MiSk0bL/3RRN38G4aqTXX6L3ozDJO7DgGwLKFKLPonQI8KgFaDVLaVeRK9uO8r6YbSh7wUi4VkFuRvkNHRHRSNJkA87zYmkmCKeR0gqgo7qr6AvTtgNoY9VpB0tGbXB0UQTBzYIQrELbwaPTeNEpizzcWiP8rMPGndi0a2U0XCggUJ4nJ5WgW07yiDBBQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5534.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(366004)(346002)(39860400002)(136003)(376002)(83380400001)(2906002)(122000001)(33656002)(316002)(110136005)(76116006)(66946007)(54906003)(86362001)(66556008)(71200400001)(64756008)(66476007)(66446008)(478600001)(8936002)(55016002)(9686003)(186003)(7696005)(38100700002)(26005)(4326008)(8676002)(52536014)(5660300002)(6506007)(53546011)(38070700004); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?p/qXKTqQBGBZyxYPNVFzW+xN/fULCW0/e8x46N0j82Q5CntsRDZJgOVJFAaA?= =?us-ascii?Q?KlgnrahHWYQJdSpTpH55ChNd9oWHLaRnSWT4N467dC2JyyMnD0101c+Vbnu5?= =?us-ascii?Q?KuNGeV1TOjxTXxyIQkpBymQYK1TALvezfSrXyuRvfMq8gEw+dtVV63MvVEap?= =?us-ascii?Q?9NrL9b2cyo7PQCYy6yPBbi9SZol351GhppYeg1wx4UVsjTBSjl0jX/PbxB4+?= =?us-ascii?Q?pGbUgzMauoHKAoLfV3vdeNYpoe9JwBJsjMGQjsB+b3Mpbw6zQTDuqvKwm2dJ?= =?us-ascii?Q?1rPIlRq7k39sKMo+P29z5WlsyrAtct4cFzFhife4jH3VM0AV0lqWA8cKqhnK?= =?us-ascii?Q?ePEU4wF/suBMcmKVgYQVi72RE+uY0SNwzLgYaDSSuw2F3LjsBVj5HabDOXU1?= =?us-ascii?Q?WuOMPT8NDflQDUUX6SBZSXuNBmuFwzeMqqwNGe/K4Zu29XXAqaZcR51iskH+?= =?us-ascii?Q?57DhDC2cSsfM3T9K3tW8ztNr6Vd0sG1NJ0WhrPtSd50BFrZQLofiUzWhoIYt?= =?us-ascii?Q?1hNEIXrTZ+SbIiNMvWtEGiOofba84N5eODzgag7F6ILxerHOmdu4a3x2Igs0?= =?us-ascii?Q?4rquG5RUkGhgONEQntOXWrj73x1rdaant1J6bHBxgwP3DZNLWbmSMNRALCMm?= =?us-ascii?Q?WjPBsVYl0XzbFoYOCgiq9mPlC0H5YmFS6lD9X6/E3A/FBfzReLySWAEs+sdd?= =?us-ascii?Q?w/2oB4bjwVEtAXqAgsyRSs81Fr13YIyVBq2aUePDHcGGnHaVCYTT+SOE0sfl?= =?us-ascii?Q?9IjGWErc/dtCfRPZP2ihgcQT7W5eqaip5TzOYpdusLAzP4/N524DNZGNrGjv?= =?us-ascii?Q?fYSkkXBh9DOvZcf3WhsQsyNy0mB8/cAWCJ5rjlJQNwXgYxYKSx4oADtuaQdT?= =?us-ascii?Q?tvEzekGJeyjfZkU+RPpNrVmwxDR2BEZ1xrap7u34gWreAdig9z9RHSio9JoH?= =?us-ascii?Q?W+xe4Z5WCD3JyG31/ZDAUMvYUTSWvktA72LgZmIsBTiQaCkP1hyXEXMwy5I3?= =?us-ascii?Q?nSSUgfTUNaQ/H3paEOJUsZxIDUi/bTE33EJMtd3zb/uvYhLB6HBND1kqO4e3?= =?us-ascii?Q?856WU4KMfwzQgqDQQ0ACR4uDnkmNvpGR5l8y5ZKRARYGDSO30P/2Fr3D8YRN?= =?us-ascii?Q?OmpLk5W2viVkz8/1rdSnpzzc+j3Z/52TfnlTpSUApX88+11N14A2BdzCOmZC?= =?us-ascii?Q?uT/etyLCP/F/SpXEIoTIMjrqAOa7m6V224QSoeHCmXhB+qibH4X8OzUZxkdX?= =?us-ascii?Q?Q6jvoAGPGBk8EiivpdUqrQkLdDmQr8AXdkaklxfZrC/FzshNSuYI9lWEQVM1?= =?us-ascii?Q?mowp45ZMYLWm4GzRt7nS/NYc?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5534.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac3d4be0-eec7-466e-4f19-08d94833ff12 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jul 2021 08:30:40.8547 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6FaCEbm7O3oqDwIWH6yikl3Uc5SdO58AwoAqGE3FPu9eyHpA31OWsKCIT0plR4OkTeZK2GQjZxj4jG1YjXetJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4107 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4] app/testpmd: fix testpmd doesn't show RSS hash offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: stable On Behalf Of Li, Xiaoyun > Sent: Thursday, July 15, 2021 12:54 > To: Wang, Jie1X ; dev@dpdk.org > Cc: andrew.rybchenko@oktetlabs.ru; stable@dpdk.org > Subject: Re: [dpdk-stable] [PATCH v4] app/testpmd: fix testpmd doesn't sh= ow > RSS hash offload >=20 > > -----Original Message----- > > From: Wang, Jie1X > > Sent: Thursday, July 15, 2021 19:57 > > To: dev@dpdk.org > > Cc: Li, Xiaoyun ; andrew.rybchenko@oktetlabs.ru; > > Wang, Jie1X ; stable@dpdk.org > > Subject: [PATCH v4] app/testpmd: fix testpmd doesn't show RSS hash > > offload > > > > The driver may change offloads info into dev->data->dev_conf in > > dev_configure which may cause port->dev_conf and port->rx_conf contain > outdated values. > > > > This patch updates the offloads info if it changes to fix this issue. > > > > Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") > > Cc: stable@dpdk.org > > > > Signed-off-by: Jie Wang > > --- > > v4: delete the whitespace at the end of the line. > > v3: > > - check and update the "offloads" of "port->dev_conf.rx/txmode". > > - update the commit log. > > v2: copy "rx/txmode.offloads", instead of copying the entire struct > > "dev->data- > > >dev_conf.rx/txmode". > > --- > > app/test-pmd/testpmd.c | 27 +++++++++++++++++++++++++++ > > 1 file changed, 27 insertions(+) >=20 > Acked-by: Xiaoyun Li Although I gave my ack, app shouldn't touch rte_eth_devices which this patc= h does. Usually, testpmd should only call function like eth_dev_info_get_pr= int_err(). But dev_info doesn't contain the info dev->data->dev_conf which the driver = modifies. Probably we need a better fix.