From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C6E4CA0C46; Fri, 18 Jun 2021 10:32:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 50BAC40150; Fri, 18 Jun 2021 10:32:47 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 41D6740142 for ; Fri, 18 Jun 2021 10:32:45 +0200 (CEST) IronPort-SDR: yNJe4IzYwetKFt3upqMRHmz/QrtFlSXqPXSUmO9FpQF4hWoSNucvqtFZ6DpGEqHEkpaXp91L/l 93K7GSW//iwg== X-IronPort-AV: E=McAfee;i="6200,9189,10018"; a="267663913" X-IronPort-AV: E=Sophos;i="5.83,283,1616482800"; d="scan'208";a="267663913" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2021 01:32:43 -0700 IronPort-SDR: 5GrV4ZbYHiNVYd50oe6SayTMi/4VQEUCWieR5CilfiM7gUIGH8KIcrxfoDciDdfOsNbtBdtigY 0Xki9v62rd6g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,283,1616482800"; d="scan'208";a="422156624" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga002.jf.intel.com with ESMTP; 18 Jun 2021 01:32:43 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Fri, 18 Jun 2021 01:32:43 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Fri, 18 Jun 2021 01:32:43 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Fri, 18 Jun 2021 01:32:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HA3wp4UHXWFvtxTiMSRrMsHrdequJVibs9JWKRDG/cNaq7H3qVP6eo6IBQxEL7lvWuwcP1J3kReaZYyqSHELucitclDQ9+LGTDqKoIBrkCiZad/mnX6bErNtdtk1omJFGEJjrsPwgdhO+Yaqy1rsSp33sYp9oUU3IBkGKR5RskVYtDsLzCkhWHT9lCmzbWpt+Xij/6PgcbmfOGql+G0Etu2pQXWIN+m053IIVPrPsPkJliykIm7GmPsc0GTAWaUcFU6gtXTw6XOPRCltigRbQiBFncceHEGCwzPmnuQwG0ueOACdTFfk/ByuoE4iBiuOv0fJ3jYWL0a/KS3aItarBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xy/BWYwfj0mAPMx5QqL5H9jnugN3RD7J0xnP6OcK6jA=; b=l04llzrycOh8a28b6xTynKsC0eoFc+QW9Ur4eypX1RpVb6UDpNxkkzdvTI5nT4g/RoV3yE4i5rQh5L9tDmFe0bJVKLyRAFn/vCYNdKzi+MgBgfVnHIwZ29JKTPVJodiFttGRq58cbwMwRVwmQ0RjNeIoAGZF3uWAyUwOl7aA9jmKBpJIAR50fOiqOSIilFbswZChrr6ertoLAkRWxynJcjT42ODwdRImtWcknGPAG+13ZIas5eqF0jXzt0gRQA2CeuGWyiYDLoHirXXsNxxi86fqSWfeoP1XjpsBXeL/bP+w4TTjxFIp/ScX7bliIdxMIHXAoeIZUjWBA1LX6uLtGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xy/BWYwfj0mAPMx5QqL5H9jnugN3RD7J0xnP6OcK6jA=; b=F8NDooAq3RAkex/nivO35UbKYq7e87pk3am1CdrSRZsWWL5oO1P+kGujzBHfir56hHzc/GaUgqSFB3QUvgN4VN7AgX8PdkN6KJ1GX8lx9tIDm13G8RLQ++o0mImaJPUNoIEgumjRrbj+QjPZKlfKH76DJnYCsPbkPUtFFdKw/Ss= Received: from DM4PR11MB5534.namprd11.prod.outlook.com (2603:10b6:5:391::22) by DM6PR11MB2730.namprd11.prod.outlook.com (2603:10b6:5:c7::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.24; Fri, 18 Jun 2021 08:32:39 +0000 Received: from DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::645f:ca6d:7947:12c9]) by DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::645f:ca6d:7947:12c9%9]) with mapi id 15.20.4242.021; Fri, 18 Jun 2021 08:32:39 +0000 From: "Li, Xiaoyun" To: Andrew Rybchenko , Ori Kam CC: "dev@dpdk.org" , "Richardson, Bruce" , "Yigit, Ferruh" , "Singh, Aman Deep" Thread-Topic: [PATCH v3] app/testpmd: send failure logs to stderr Thread-Index: AQHXY4QJebPh2sf7mUGnzGWnkje2T6sZcVjA Date: Fri, 18 Jun 2021 08:32:39 +0000 Message-ID: References: <20210527162452.1568351-1-andrew.rybchenko@oktetlabs.ru> <20210617142026.1133460-1-andrew.rybchenko@oktetlabs.ru> In-Reply-To: <20210617142026.1133460-1-andrew.rybchenko@oktetlabs.ru> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.52] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9a719a54-35d5-4c76-488b-08d93233a250 x-ms-traffictypediagnostic: DM6PR11MB2730: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WodTgVS0FLY2G5bBTsTEvju3bEY9F1wqYTIyQ+C86OjW3OSrxOdpOC1xFhnsL5OlTwMf56OdfMpgvfnU2cGzFx2sr/KDaw8+VpDl69p/1YsyZTh7TsURShsUYzBo1jkc3H1BMJdL/7uZt5z33PvKm73UJCH6hTtf31L8OU3HURDflF4wGzGqwOYBechZaJno2xuYemg8b4AkbnjYHhK7P025VTroEWxQSz6gi28CryCUhYGZAsWJgqQucGJHiFbiJ634zaMuOt9CMJM6/t1FfBdt/meTrIswIAfo3hOFNhBgLnRS2VL5FOGVvj3ua9LTymL1awcj6QUHiPYor9luUlOxdaKhxPPmRZ0xHHgHqWso6+BtMVGMWlTJ86nmUcQiaZH+YS/B+aV8tdvrKCc0XQJYgkJ8beGpfTUfAhvDmrcY7z/ubsSKF62Xdu+oydR8qrYrZ3lKntPaJ3e1C8WWB4TJAH1VjqoWSP8ojjcPNCWCI8P29watQcDFGkvGsDQoRpYyel30BwrbuHLe9oYZbY0twtKbRE6BgvnZYgjliB7O7Zk7+UpHA8FIFPFcnzdZklcuzH8TmDivNwwRfcTmpW2RqnuwJwkp3UWk8QS2l2A= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5534.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(376002)(39860400002)(136003)(366004)(396003)(66946007)(6506007)(8936002)(55016002)(478600001)(86362001)(38100700002)(107886003)(33656002)(26005)(64756008)(66556008)(66476007)(54906003)(66446008)(122000001)(2906002)(71200400001)(83380400001)(316002)(110136005)(53546011)(4326008)(186003)(5660300002)(8676002)(7696005)(76116006)(9686003)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CqeKjQ1b9lHD1dXq4U3ZOuDzkAOwrboN5eLkUadrfNf+wTN2bomvWxkv5Kvl?= =?us-ascii?Q?yzZ7fhF/pQgcQFVovnm0hnO0fliMj58C5SNe1qr7kDA/gJdrBBt0CrF8uMms?= =?us-ascii?Q?OpWHkoCDHibL5R/nsOPtaBX8fcFmiB6DAfkBmO+brpdLw7cKR1Tq0owROMIb?= =?us-ascii?Q?0/Grk+ALKIH91E0IeHTnwfO0bt8O4G5U3isoAbiCtbYRfVNpgytpOaLLUDOG?= =?us-ascii?Q?2absCQL9BA1c4zZnaW1mFQRMdCx+UBEc4cd07L9awSMCF7+o6nehOCfzGz0P?= =?us-ascii?Q?/j5ezYoWkxSSCKFqmlA5z5WM60uWFcOOgJOlok1jDUTaDbdnVmcv2QnmJxIw?= =?us-ascii?Q?D6dYmcOFgAONmLjCrcwZT3VVEkyyRe8yhz2LfUTk4+uubeFmdDfgSrnsH9os?= =?us-ascii?Q?bnJOuJk7rtOPb8SuLc0Bsu1CFViM/9FUPJKTHfucGkent1Iz1oIp2WDYqP50?= =?us-ascii?Q?8XAXP52shL1vDBqe46oeSGmlX5YDs6DpzLdupMwZ7SDuTMsqGCrZ5ZjgK+Am?= =?us-ascii?Q?q0kovjh+Ng7r94p/tqQDeJjtHslSJ10ldD5G89yATzTedjNWsoCJCieeFIBQ?= =?us-ascii?Q?6SUo0D2kgvYZcFVSTviWi3uTM5sBf230DqjMDAY783B2ENJXHKQdUwgtu9ez?= =?us-ascii?Q?nfmV5wCNG7GHrwZrROH/NJdklJSNu8cul0v+pOZAZU7nvK74CVqYFnBfjKkT?= =?us-ascii?Q?b2DIx5xhJsGqQ+21x5FuHCTbOqFunHHGjwPmceFlp1e+k+Zkc2VhOKPm4Ue1?= =?us-ascii?Q?KwCkZE5j35DMCUQvQoMGn0IPx3UuBojVaWWzKl0kRT1+E+FBj96+P13mRFRs?= =?us-ascii?Q?EjIHK0Im1hXwRXgW92dwS9SFQffW8wRRnZxRfSzFDoIWBMBVlVLammi9M7WA?= =?us-ascii?Q?vM0kHCFoYBCARN1FGnw1GN1S7HIs2mNf7qqWTh/Et81Cnp7we/MmaNbciDd+?= =?us-ascii?Q?hHhNv8RgOtkw7YN+WdSpVWRCs3IgeWyctUupAtusroTe9de03m8tzltKeMv9?= =?us-ascii?Q?L5kTGpTZcCUJ4ihS+WNHer49xl4/r3bLcbjSgu50IS8u0t7UZPkZf8j6kFiR?= =?us-ascii?Q?B4pMcDcvHLM+05VhywlkYt0y0n/c5PQuAWA16uBYJ3AtNHjqWJEUlGfmvo2v?= =?us-ascii?Q?7/tHTvp2isKcIqTWggaULMs6oxGjts61aD+I6NUWpao6/IrFdr3ZFwqWQCA/?= =?us-ascii?Q?qZZMjtu0V1ruRrfiRhm3wo8umO8gQp3NYtsF58aZh9QpndfaCrEhcGw97QjA?= =?us-ascii?Q?xg2kXf7C50WQuOC4VN7XSf5/jKiUafqwNPH5kUJuAD+qw4YGWSZaDkPmH/lH?= =?us-ascii?Q?nj4=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5534.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a719a54-35d5-4c76-488b-08d93233a250 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jun 2021 08:32:39.6103 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XVNIOvpcXxHq1NHmsZtGTFsI08+2zxklTtL4sc/q5f+HL5AnkMLT/kYz/PDhPmSgaZawqfomu1A9TDuuKlSWQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2730 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3] app/testpmd: send failure logs to stderr X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Andrew Rybchenko > Sent: Thursday, June 17, 2021 22:20 > To: Li, Xiaoyun ; Ori Kam > Cc: dev@dpdk.org; Richardson, Bruce ; Yigit, > Ferruh ; Singh, Aman Deep > > Subject: [PATCH v3] app/testpmd: send failure logs to stderr >=20 > Running with stdout suppressed or redirected for further processing > is very confusing in the case of errors. Fix it by logging errors and > warnings to stderr. >=20 > Since lines with log messages are touched anyway concatenate split > format strings to make it easier to search using grep. >=20 > Fix indent of format string arguments. >=20 > Signed-off-by: Andrew Rybchenko > --- > v3: > - fix typo in the patch description > - fix applicable coding style issues reported by patchwork >=20 > v2: > - switch from printf() to fpritnf(stderr, ...) in more cases > - do not inherit acks from the previous version since the patch is > much bigger > - fix style in few cases (TAB vs spaces, missing space separtor etc) > - still don't use TESTPMD_LOG() since the patch does not add new logs. > Also switching to TESTPMD_LOG() will add "testpmd: " prefix to log > messages and it is a real change and could be a pain for automation. >=20 > app/test-pmd/bpf_cmd.c | 6 +- > app/test-pmd/cmdline.c | 957 ++++++++++++++----------- > app/test-pmd/cmdline_flow.c | 20 +- > app/test-pmd/cmdline_mtr.c | 8 +- > app/test-pmd/cmdline_tm.c | 33 +- > app/test-pmd/config.c | 455 ++++++------ > app/test-pmd/csumonly.c | 5 +- > app/test-pmd/parameters.c | 21 +- > app/test-pmd/testpmd.c | 298 ++++---- > app/test-pmd/util.c | 19 +- > doc/guides/rel_notes/release_21_08.rst | 5 + > 11 files changed, 1004 insertions(+), 823 deletions(-) Acked-by: Xiaoyun Li