From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79855A034F; Mon, 29 Mar 2021 07:50:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 57DFE140DB2; Mon, 29 Mar 2021 07:50:02 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 5740D40042 for ; Mon, 29 Mar 2021 07:50:00 +0200 (CEST) IronPort-SDR: IYmoDDC/qABGU8tsorneODuivE50DOc86iEblfvM+NZCn0uj3Y1RzkC9PIoUVW8HBd3wvcQBo+ 58vFfF6ZwwzA== X-IronPort-AV: E=McAfee;i="6000,8403,9937"; a="252830368" X-IronPort-AV: E=Sophos;i="5.81,285,1610438400"; d="scan'208";a="252830368" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Mar 2021 22:49:59 -0700 IronPort-SDR: dPdbFReXzc5rjVjQ4T6umWoUBBOYVoB4Su3Hewh1QfP7DAolW902sN7hv3lOjcSmZBCdyLhV7X 14k9QkExI44w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,285,1610438400"; d="scan'208";a="454412261" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga001.jf.intel.com with ESMTP; 28 Mar 2021 22:49:59 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sun, 28 Mar 2021 22:49:58 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Sun, 28 Mar 2021 22:49:58 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Sun, 28 Mar 2021 22:49:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QkC+DIcqd/hhmtAWUX8vepeDPRTvoWDgJMv71YTkDvIKW0ccK0Yqej9tt0/+MnEsrjTrOEDQSEKkrPfi4K46Ls7sA9rVBk0jmC3ZOe7aqeyZcnL4rRskrV1y+sX4UOJhoe3nJ/IcO4rZozMIpJrhbiLWWeCkQ2b85OcRIaB5ZAYb1BxaehUBfQgi+XmA8tONYpccC1USIP52zuL7qzxGwYf7BcudmiMYqj1vZeJ13Acj1qUy3d1qA6UQ1i1I6F7Dl1nzhVICKSnTf2Y5AnZvaFlU2FO5eESgjOeluPhLuo9DD6ROBQ9I4QdL4o8vgSx551BTGmtPqLY+UjK/GlmW4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DECDyo+CNHwbNHmml/ZFIUI8h8hnVnpVgCDsMUhx51U=; b=dKB5F9LDmVaOETqf7e3IvhV3MkQR4v4NJ6K9hgoW8Hesrkof22DVwQHXPhMBG0Eg4OBjwqVgC9FHOLY+0WX6b04o3EBZkAa98d6Oru2KZgQKSGfys/WN5eJJEa8Nc/Thd0t8i3As8QW2uUO36EonD9VRXjdeqXiOZZQNlFDbGj7E9V6C5trfz6c+S2yU8JDUXrsBXI2lcoIbuhIf6hhoL4YtAGtynFIg4B/Dh3frZd1p6PuPlqsQlSTANUC5kP1e6ryibZ7cc7PKwpheHrCKcojCSUFxQNbAj7ZYwVgva8N49cDDARiMnGOCilagJXOd2FPQlez+u3ZQLEJD2DqlWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DECDyo+CNHwbNHmml/ZFIUI8h8hnVnpVgCDsMUhx51U=; b=u8BoIl092DANAs12wlC1n9rDcsI2G2deDkf2RRBs28dkn+0tQOBKTvZxVZXUnAOnrek5ozpph+sJ/iWNBQiQ7EAAJW3WtczXX48LGn3pIgpLPr77AdKSo4i7RkSGhItqgHPWdtOljOMsCjqME+GvtZfEUQe4u3zkEZrqkfIVzC0= Received: from DM4PR11MB5534.namprd11.prod.outlook.com (2603:10b6:5:391::22) by DM6PR11MB4379.namprd11.prod.outlook.com (2603:10b6:5:1db::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.24; Mon, 29 Mar 2021 05:49:55 +0000 Received: from DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::79a3:3404:b907:d49c]) by DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::79a3:3404:b907:d49c%6]) with mapi id 15.20.3977.033; Mon, 29 Mar 2021 05:49:55 +0000 From: "Li, Xiaoyun" To: "Min Hu (Connor)" , "dev@dpdk.org" CC: "Yigit, Ferruh" Thread-Topic: [PATCH] app/testpmd: fix Tx/Rx descriptor query error log Thread-Index: AQHXIturXLbBBfVO20CTzgCLbU0iZaqab+sw Date: Mon, 29 Mar 2021 05:49:55 +0000 Message-ID: References: <1616830494-46559-1-git-send-email-humin29@huawei.com> In-Reply-To: <1616830494-46559-1-git-send-email-humin29@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.51] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 283772f7-2b1b-408a-2f2f-08d8f2767ae8 x-ms-traffictypediagnostic: DM6PR11MB4379: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:785; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: h/7dgJnyl0MsGjLjLomoQw7a9EQwwBz+DvJyjHF5hdrSmh8RRziWNzqmq+WHjEJr4zansoYwrMRo2N6UoKJ+qYVVHF4Yt0SMu1E0o/Pt9x8YdpJx3yMG4XBLhBWxLOXZGUVmlSHlo9QINpnP8Gv+B+nW/73YmWaOaV3j5Rjb4I5UuP1ETf025BDZQGNtgb1psQWiJokRdeJFd0kcXBk1xUql/8du6pb5D1o2SzCEIVyFnrBKcVfy/HcrvBdE84LIiyxm7aXSkO+yKk6bo/67udaOXQscZ+a6RSh1Yf8h+Bk9Epy1YWqZi0YMofWy1vx/Vs/QnBhHP+PE5cW1dVWVLE/5Y/2JrOKUyggOrhKgeMEAqp4f7sF9KZ1PY0xrfgZlWSHoUlceEN3DumWyhI9ngCHvWKgdNmniPkMkPwqAVt+Zmxu2X6EsS13kufr6ZWwbbaqDhTmykghJpNv951vj7sSLx3HAsd17mY1Mn7MSgN0wMwC7SPBFDGGqCf+3Fq2Papl0zSOrsWoAh7/Sgby0ZTnIj3vR31z2p7doEd+unjzmRiLrwIU/XdMgDaFZ6A9YICOBTRA8SjQilZHtR09uEmK0U71oR2Ppc2tbb9VgrnCj81F+FcPpoUN9gZEHM8R/0fhBZ+Jc+vnDHXJG2LWYgk7AyoDNX5s3qwx0MhvQGzg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5534.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(396003)(346002)(39860400002)(376002)(366004)(38100700001)(83380400001)(26005)(110136005)(33656002)(52536014)(5660300002)(9686003)(71200400001)(186003)(55016002)(478600001)(76116006)(316002)(7696005)(8676002)(4326008)(8936002)(66946007)(64756008)(86362001)(66476007)(66556008)(66446008)(6506007)(2906002)(53546011)(107886003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?hFhXdlgXdVdgglsRth5sEGQ3pi831hmI43PQTPbl8KWGv2AtFO35EUeSqNL9?= =?us-ascii?Q?x4fm6Nl1LiqwHEIpjEMQseedgX9MK7m5Pqa0HncvkjbDzo1U66Uwj/bA86SQ?= =?us-ascii?Q?8DOMhInPqz6fYzjgvjo6wASwl/2zczDr7uwnYWimvR4BBckqX22VicyvzoQt?= =?us-ascii?Q?bLPwEGujcHEdRPL2880V2SpSAnRsZpak6/Ysa331cYGPmJW5eh3+AkaYVGPw?= =?us-ascii?Q?Kr6vMF9AJFADW8rOPdApm/1Jnj4ic+DWtm7FDkn8eQfjX8K2s422sKrT9tu9?= =?us-ascii?Q?GKmgwdI9sjpCvnu5O9AxtS2aGa+D3xQWMG8svX+LPL/qZ+gaiWo2q/Lmp6co?= =?us-ascii?Q?ODNrHuoOZLCKe2TritbweyMlzefMnoD5RAuPKnxD5/CsGcJeybLjm4t2EgQ+?= =?us-ascii?Q?acdG3veqClOBPIS6utDgDe6XZTldvxuJ1JOivAl72Yh6wg7PaL+OiGklbcsa?= =?us-ascii?Q?3p8/xGCSRppHyOzLf+ZGMxdMXeu6Nj18rYZJxyNKPG+4ttRxuLkLbJxc1XL/?= =?us-ascii?Q?LlL7eOM4Xkz9m1e2h4cEHD2NCR8BO/XASmE90mL0lI8eezr6fb4n6X+EhqN/?= =?us-ascii?Q?w5X2ikVZkLK1ReCCKky7cYnY9PVngXm3iSOxPqzO7I4tl3r4XHc13tL39Gdi?= =?us-ascii?Q?FAvqTwvDcrPIrxPGfrzYIEn++cjW9Wxv13d4F911NA6+oj4CaJsW9J4z6ypg?= =?us-ascii?Q?TAyUlgD1NJjzAzOtKiAhBrgh2Gu1Y2d3j3dBwrbvyPVDvpcHYGFZFiJrwE/u?= =?us-ascii?Q?wgNRwxPZWr9kBoph6EMumSfqa8MiNTQvsM0l+iYxYQUENg3kjzg0we2YTeWT?= =?us-ascii?Q?X5U2fmc1C22jaNSr5Y1DHVedcwgrXPYgRq0pZr2qgU2zaEmIJwLDv49MK+GX?= =?us-ascii?Q?fVtk3C1jB3/f7Zc+6ki+4DPcogbz6VtgEkGD3Al1JsL1VrSQcwlWIZ7zc/nh?= =?us-ascii?Q?E+ZEnIb2lG6IPHImqRMJ0Ihjm9A7R4afdJKbwvv8Gn7mGabaXP+LUMSmYV/g?= =?us-ascii?Q?aeaYRnCUnaoTZJ+60nDjbTlAVvwUk3YxxHeOs1YOFIC4jlu2eRNVDK3LZnRN?= =?us-ascii?Q?bWasiaeC2Gwbu14SKiVoUtIFi0a1pm2DGFfXHzTfgnpYyJPwRSHxXBvM1Ydw?= =?us-ascii?Q?2V07QQFUhAt7GNQOGt5qt5rOd3vbRfaH/rD8QXrIBrjL5u8SccbKUJuQI43x?= =?us-ascii?Q?FITGXBkaJf6WI+ItokDWziSSe8nb+rLYRnNCEcOnKQXWeqs8XVeOiUMcP8/1?= =?us-ascii?Q?e/OwyVlBF34nPF85dssSzw2j7mk2S/MydhguaXTt/Pviv+/EV63BGEVyv5oS?= =?us-ascii?Q?BDqW55LSgQ83pXklh+rHKa3o?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5534.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 283772f7-2b1b-408a-2f2f-08d8f2767ae8 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2021 05:49:55.3262 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1dG/5i46DrHTIcYoh6EuCDEuB4/+VXYQE+sMnsfMZGuZom+tjLe3Ik9o0vANLs2GKEhs6+kkGH3QZNks9cCWFw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4379 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix Tx/Rx descriptor query error log X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi > -----Original Message----- > From: Min Hu (Connor) > Sent: Saturday, March 27, 2021 15:35 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Li, Xiaoyun > Subject: [PATCH] app/testpmd: fix Tx/Rx descriptor query error log >=20 > From: Hongbo Zheng >=20 > Currently in testpmd, if we input "show port 0 rxq 0 desc 9999 status" > and if rte_eth_rx_descriptor_status return a negative value, testpmd will= print returns > "Invalid queueid =3D 0", seems user input an invalid queueid, while the a= ctual Users input/ user inputs > situation may be that 9999 is out of bounds, current information is misle= ading to > users. >=20 > This patch modify the Tx/Rx descriptor query error information in testpmd= by modifies > add offset information, now if we fail to query Tx/Rx descriptor, testpmd= will adding > print "Invalid queueid =3D 0, offset =3D 9999", then we can check our inp= ut. The commit log has grammar mistakes. And I think you can simply explain wha= t the patch does like: This patch adds more err info for Tx/Rx descriptor query command. And the print should be "Invalid input: queue id =3D 0, desc id =3D 9999" b= ecause you still don't tell users if it's queue id err or desc id err. BRs Xiaoyun >=20 > Fixes: fae9aa717d6c ("app/testpmd: support checking descriptor status") > Cc: stable@dpdk.org >=20 > Signed-off-by: Hongbo Zheng > Signed-off-by: Min Hu (Connor) > --- > app/test-pmd/cmdline.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > 287d7a0..1a74a61 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -16633,7 +16633,8 @@ cmd_show_rx_tx_desc_status_parsed(void > *parsed_result, > rc =3D rte_eth_rx_descriptor_status(res->cmd_pid, res->cmd_qid, > res->cmd_did); > if (rc < 0) { > - printf("Invalid queueid =3D %d\n", res->cmd_qid); > + printf("Invalid queueid =3D %d, offset =3D %d\n", > + res->cmd_qid, res->cmd_did); > return; > } > if (rc =3D=3D RTE_ETH_RX_DESC_AVAIL) > @@ -16646,7 +16647,8 @@ cmd_show_rx_tx_desc_status_parsed(void > *parsed_result, > rc =3D rte_eth_tx_descriptor_status(res->cmd_pid, res->cmd_qid, > res->cmd_did); > if (rc < 0) { > - printf("Invalid queueid =3D %d\n", res->cmd_qid); > + printf("Invalid queueid =3D %d, offset =3D %d\n", > + res->cmd_qid, res->cmd_did); > return; > } > if (rc =3D=3D RTE_ETH_TX_DESC_FULL) > -- > 2.7.4